)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"005bcba95185a83e481d0ad0bcbebb984f6d8f7f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Change-Id: I34a3f8d4a496217eb01790e2d124111625bf5f85"},{"line_number":29,"context_line":"Closes-Bug: #1825583"},{"line_number":30,"context_line":"(cherry picked from commit 13278be9f265e237fc68ee60acfacaa1df68522e)"},{"line_number":31,"context_line":"(cherry picked from commit e6ca3838d940dea417cdeffe22c656d222737a7e)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffb9cba7_22e7d7ae","line":31,"updated":"2019-04-30 21:09:05.000000000","message":"This doesn\u0027t look correct - did you forget the -x option with the git cherry-pick command?","commit_id":"9477c761cced10ff947b424809f31fd79580289d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"462ec76f2c16de1be52cdd309e3cb5d571f80b07","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Change-Id: I34a3f8d4a496217eb01790e2d124111625bf5f85"},{"line_number":29,"context_line":"Closes-Bug: #1825583"},{"line_number":30,"context_line":"(cherry picked from commit 13278be9f265e237fc68ee60acfacaa1df68522e)"},{"line_number":31,"context_line":"(cherry picked from commit e6ca3838d940dea417cdeffe22c656d222737a7e)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffb9cba7_c2011b08","line":31,"in_reply_to":"ffb9cba7_22e7d7ae","updated":"2019-04-30 21:20:05.000000000","message":"Yes I did. I always do when I do it manually. So I added it by hand. And did it wrong. Fixed (I think).","commit_id":"9477c761cced10ff947b424809f31fd79580289d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3adfec3da8332c434c4fde8c8f76fe7662858854","unresolved":false,"context_lines":[{"line_number":15,"context_line":"(Microversion negotiation is done within ironicclient itself.)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Also, this bug went latent for several releases because a) it only seems"},{"line_number":18,"context_line":"to be triggered when region_name is given in the conf; but also b)"},{"line_number":19,"context_line":"ironicclient has code to discover a reasonable endpoint if passed None."},{"line_number":20,"context_line":"So this change also adds a warning log if we try and fail to discover"},{"line_number":21,"context_line":"the endpoint via ksa."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Conflicts:"},{"line_number":24,"context_line":"\tnova/tests/unit/virt/ironic/test_client_wrapper.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_ce0a6a88","line":21,"range":{"start_line":18,"start_character":64,"end_line":21,"end_character":21},"updated":"2019-07-01 15:21:32.000000000","message":"Maybe it doesn\u0027t matter, but I wonder if this is true for the min and max versions of ironicclient in queens (min being what we have in requirements.txt and max being what\u0027s in queens upper-constraints).\n\n(later)\n\nNow I remember that the queens thing I was worried about was actually for another change that went on top of this one:\n\nhttps://review.opendev.org/#/c/654692/2/nova/virt/ironic/client_wrapper.py\n\nAnd has not been proposed for stable/queens.","commit_id":"ba3ad2d65af20332e768a6df0e2c2d64292f9e2c"}]}