)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"db23366468d5ed9b63815b945e315891f729525b","unresolved":false,"context_lines":[{"line_number":5706,"context_line":"            with self.virtapi.wait_for_instance_event("},{"line_number":5707,"context_line":"                    instance, events, deadline\u003dtimeout,"},{"line_number":5708,"context_line":"                    error_callback\u003dself._neutron_failed_callback):"},{"line_number":5709,"context_line":"                LOG.debug(\u0027Initiating plug of VIF %(vif_info)\u0027,"},{"line_number":5710,"context_line":"                          {\u0027vif_info\u0027: network_info},"},{"line_number":5711,"context_line":"                          instance\u003dinstance)"},{"line_number":5712,"context_line":"                self.plug_vifs(instance, network_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_98863313","line":5709,"range":{"start_line":5709,"start_character":50,"end_line":5709,"end_character":61},"updated":"2019-05-01 07:52:30.000000000","message":"%(vif_info)s","commit_id":"b49b131f263e3232791cf6e3047ffdc2a9cd4f79"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"add84e1bb3ba2ce2fe19bd00542eb86c64be1d98","unresolved":false,"context_lines":[{"line_number":5706,"context_line":"            with self.virtapi.wait_for_instance_event("},{"line_number":5707,"context_line":"                    instance, events, deadline\u003dtimeout,"},{"line_number":5708,"context_line":"                    error_callback\u003dself._neutron_failed_callback):"},{"line_number":5709,"context_line":"                LOG.debug(\u0027Initiating plug of VIF %(vif_info)\u0027,"},{"line_number":5710,"context_line":"                          {\u0027vif_info\u0027: network_info},"},{"line_number":5711,"context_line":"                          instance\u003dinstance)"},{"line_number":5712,"context_line":"                self.plug_vifs(instance, network_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_93485487","line":5709,"range":{"start_line":5709,"start_character":50,"end_line":5709,"end_character":61},"in_reply_to":"ffb9cba7_98863313","updated":"2019-05-01 13:17:56.000000000","message":"Done","commit_id":"b49b131f263e3232791cf6e3047ffdc2a9cd4f79"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"db23366468d5ed9b63815b945e315891f729525b","unresolved":false,"context_lines":[{"line_number":8188,"context_line":"        max_retry \u003d CONF.live_migration_retry_count"},{"line_number":8189,"context_line":"        for cnt in range(max_retry):"},{"line_number":8190,"context_line":"            try:"},{"line_number":8191,"context_line":"                LOG.debug(\u0027Attempting plug of VIF %(vif_info), \u0027"},{"line_number":8192,"context_line":"                          \u0027attempt %(count)\u0027,"},{"line_number":8193,"context_line":"                          {\u0027vif_info\u0027: network_info,"},{"line_number":8194,"context_line":"                           \u0027count\u0027: cnt},"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_387f0716","line":8191,"range":{"start_line":8191,"start_character":50,"end_line":8191,"end_character":61},"updated":"2019-05-01 07:52:30.000000000","message":"ditto","commit_id":"b49b131f263e3232791cf6e3047ffdc2a9cd4f79"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"add84e1bb3ba2ce2fe19bd00542eb86c64be1d98","unresolved":false,"context_lines":[{"line_number":8188,"context_line":"        max_retry \u003d CONF.live_migration_retry_count"},{"line_number":8189,"context_line":"        for cnt in range(max_retry):"},{"line_number":8190,"context_line":"            try:"},{"line_number":8191,"context_line":"                LOG.debug(\u0027Attempting plug of VIF %(vif_info), \u0027"},{"line_number":8192,"context_line":"                          \u0027attempt %(count)\u0027,"},{"line_number":8193,"context_line":"                          {\u0027vif_info\u0027: network_info,"},{"line_number":8194,"context_line":"                           \u0027count\u0027: cnt},"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_33616806","line":8191,"range":{"start_line":8191,"start_character":50,"end_line":8191,"end_character":61},"in_reply_to":"ffb9cba7_387f0716","updated":"2019-05-01 13:17:56.000000000","message":"Done","commit_id":"b49b131f263e3232791cf6e3047ffdc2a9cd4f79"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"db23366468d5ed9b63815b945e315891f729525b","unresolved":false,"context_lines":[{"line_number":8189,"context_line":"        for cnt in range(max_retry):"},{"line_number":8190,"context_line":"            try:"},{"line_number":8191,"context_line":"                LOG.debug(\u0027Attempting plug of VIF %(vif_info), \u0027"},{"line_number":8192,"context_line":"                          \u0027attempt %(count)\u0027,"},{"line_number":8193,"context_line":"                          {\u0027vif_info\u0027: network_info,"},{"line_number":8194,"context_line":"                           \u0027count\u0027: cnt},"},{"line_number":8195,"context_line":"                          instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_f8740f38","line":8192,"range":{"start_line":8192,"start_character":35,"end_line":8192,"end_character":43},"updated":"2019-05-01 07:52:30.000000000","message":"%(count)d","commit_id":"b49b131f263e3232791cf6e3047ffdc2a9cd4f79"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"add84e1bb3ba2ce2fe19bd00542eb86c64be1d98","unresolved":false,"context_lines":[{"line_number":8189,"context_line":"        for cnt in range(max_retry):"},{"line_number":8190,"context_line":"            try:"},{"line_number":8191,"context_line":"                LOG.debug(\u0027Attempting plug of VIF %(vif_info), \u0027"},{"line_number":8192,"context_line":"                          \u0027attempt %(count)\u0027,"},{"line_number":8193,"context_line":"                          {\u0027vif_info\u0027: network_info,"},{"line_number":8194,"context_line":"                           \u0027count\u0027: cnt},"},{"line_number":8195,"context_line":"                          instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_535e5c44","line":8192,"range":{"start_line":8192,"start_character":35,"end_line":8192,"end_character":43},"in_reply_to":"ffb9cba7_f8740f38","updated":"2019-05-01 13:17:56.000000000","message":"Done","commit_id":"b49b131f263e3232791cf6e3047ffdc2a9cd4f79"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"665b33351e501c2917a3bfc72269a7ce3e06023c","unresolved":false,"context_lines":[{"line_number":5706,"context_line":"            with self.virtapi.wait_for_instance_event("},{"line_number":5707,"context_line":"                    instance, events, deadline\u003dtimeout,"},{"line_number":5708,"context_line":"                    error_callback\u003dself._neutron_failed_callback):"},{"line_number":5709,"context_line":"                LOG.debug(\u0027Initiating plug of VIF %(vif_info)s\u0027,"},{"line_number":5710,"context_line":"                          {\u0027vif_info\u0027: network_info},"},{"line_number":5711,"context_line":"                          instance\u003dinstance)"},{"line_number":5712,"context_line":"                self.plug_vifs(instance, network_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_4bad40e7","line":5709,"range":{"start_line":5709,"start_character":46,"end_line":5709,"end_character":49},"updated":"2019-05-01 15:53:27.000000000","message":"network_info can contain multiple VIFs, right? So should this be plural?","commit_id":"b9d15b9a814b1faf73597ec9f4cb92375b31a70f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5175b69296d02c015875cc5de0d95152a215ac32","unresolved":false,"context_lines":[{"line_number":5706,"context_line":"            with self.virtapi.wait_for_instance_event("},{"line_number":5707,"context_line":"                    instance, events, deadline\u003dtimeout,"},{"line_number":5708,"context_line":"                    error_callback\u003dself._neutron_failed_callback):"},{"line_number":5709,"context_line":"                LOG.debug(\u0027Initiating plug of VIF %(vif_info)s\u0027,"},{"line_number":5710,"context_line":"                          {\u0027vif_info\u0027: network_info},"},{"line_number":5711,"context_line":"                          instance\u003dinstance)"},{"line_number":5712,"context_line":"                self.plug_vifs(instance, network_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_a46189ab","line":5709,"range":{"start_line":5709,"start_character":46,"end_line":5709,"end_character":49},"in_reply_to":"ffb9cba7_4bad40e7","updated":"2019-05-01 19:18:39.000000000","message":"network info is a list of nova.network.model.vif objects\n\nim not sure how useful this is however given the existing logging we have when we invoke plug on os-vif.","commit_id":"b9d15b9a814b1faf73597ec9f4cb92375b31a70f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"665b33351e501c2917a3bfc72269a7ce3e06023c","unresolved":false,"context_lines":[{"line_number":8191,"context_line":"                LOG.debug(\u0027Attempting plug of VIF %(vif_info)s, \u0027"},{"line_number":8192,"context_line":"                          \u0027attempt %(count)d\u0027,"},{"line_number":8193,"context_line":"                          {\u0027vif_info\u0027: network_info,"},{"line_number":8194,"context_line":"                           \u0027count\u0027: cnt},"},{"line_number":8195,"context_line":"                          instance\u003dinstance)"},{"line_number":8196,"context_line":"                self.plug_vifs(instance, vif_plug_nw_info)"},{"line_number":8197,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_8b59f835","line":8194,"range":{"start_line":8194,"start_character":36,"end_line":8194,"end_character":39},"updated":"2019-05-01 15:53:27.000000000","message":"This will show up zero-based. Is that what you want?","commit_id":"b9d15b9a814b1faf73597ec9f4cb92375b31a70f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6bf21a9357dd9c6a84d39cba7c2d032007f78bd6","unresolved":false,"context_lines":[{"line_number":8191,"context_line":"                LOG.debug(\u0027Attempting plug of VIF %(vif_info)s, \u0027"},{"line_number":8192,"context_line":"                          \u0027attempt %(count)d\u0027,"},{"line_number":8193,"context_line":"                          {\u0027vif_info\u0027: network_info,"},{"line_number":8194,"context_line":"                           \u0027count\u0027: cnt},"},{"line_number":8195,"context_line":"                          instance\u003dinstance)"},{"line_number":8196,"context_line":"                self.plug_vifs(instance, vif_plug_nw_info)"},{"line_number":8197,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b7ce1f2a","line":8194,"range":{"start_line":8194,"start_character":36,"end_line":8194,"end_character":39},"in_reply_to":"ffb9cba7_640cf1eb","updated":"2020-08-26 18:32:36.000000000","message":"Bad UX though. I\u0027d much rather we simply add","commit_id":"b9d15b9a814b1faf73597ec9f4cb92375b31a70f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5175b69296d02c015875cc5de0d95152a215ac32","unresolved":false,"context_lines":[{"line_number":8191,"context_line":"                LOG.debug(\u0027Attempting plug of VIF %(vif_info)s, \u0027"},{"line_number":8192,"context_line":"                          \u0027attempt %(count)d\u0027,"},{"line_number":8193,"context_line":"                          {\u0027vif_info\u0027: network_info,"},{"line_number":8194,"context_line":"                           \u0027count\u0027: cnt},"},{"line_number":8195,"context_line":"                          instance\u003dinstance)"},{"line_number":8196,"context_line":"                self.plug_vifs(instance, vif_plug_nw_info)"},{"line_number":8197,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_640cf1eb","line":8194,"range":{"start_line":8194,"start_character":36,"end_line":8194,"end_character":39},"in_reply_to":"ffb9cba7_8b59f835","updated":"2019-05-01 19:18:39.000000000","message":"i think that is ok personaly.","commit_id":"b9d15b9a814b1faf73597ec9f4cb92375b31a70f"}]}