)]}'
{"etc/nova/nova.conf.sample":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"a622b5c77129021e0f18d2e2d1710045a9f422c7","unresolved":false,"context_lines":[{"line_number":660,"context_line":"# running_deleted_instance_poll_interval\u003d30"},{"line_number":661,"context_line":"###### (IntOpt) Number of seconds after being deleted when a running instance should be considered eligible for cleanup."},{"line_number":662,"context_line":"# running_deleted_instance_timeout\u003d0"},{"line_number":663,"context_line":"###### (BoolOpt) Whether to allow dhcp iptable filter rull in network traffic."},{"line_number":664,"context_line":"# allow_dhcp\u003dtrue"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"######### defined in nova.virt.baremetal.nodes #########"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAHH%2F%2F%2FGk%3D","line":663,"updated":"2012-04-26 19:55:47.000000000","message":"Minor spelling issue:\n\nShould say \u0027rule\u0027 instead of \u0027rull\u0027.","commit_id":"e805e21afd3d33e6387d18e9c9ced88076d28d37"}],"nova/compute/utils.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"e07d8f930e2900685ce3347e45581607959359fb","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                                        False)"},{"line_number":179,"context_line":"        should_create_vlan \u003d get_meta(network, \u0027should_create_vlan\u0027, False)"},{"line_number":180,"context_line":"        gateway \u003d get_ip(subnet_v4[\u0027gateway\u0027])"},{"line_number":181,"context_line":"        dhcp_server \u003d get_meta(subnet_v4, \u0027dhcp_server\u0027, \u0027\u0027)"},{"line_number":182,"context_line":"        network_dict \u003d dict(bridge\u003dnetwork[\u0027bridge\u0027],"},{"line_number":183,"context_line":"                            id\u003dnetwork[\u0027id\u0027],"},{"line_number":184,"context_line":"                            cidr\u003dsubnet_v4[\u0027cidr\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAHX%2F%2F8uk%3D","line":181,"updated":"2012-05-11 19:45:19.000000000","message":"can we use None here instead of \u0027\u0027?","commit_id":"767b6eef3aa4f89832340692d8429529aab4bdcc"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"51791500b19c2946b195a4185e887c7f3d7f7d34","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                                        False)"},{"line_number":179,"context_line":"        should_create_vlan \u003d get_meta(network, \u0027should_create_vlan\u0027, False)"},{"line_number":180,"context_line":"        gateway \u003d get_ip(subnet_v4[\u0027gateway\u0027])"},{"line_number":181,"context_line":"        dhcp_server \u003d get_meta(subnet_v4, \u0027dhcp_server\u0027, \u0027\u0027)"},{"line_number":182,"context_line":"        network_dict \u003d dict(bridge\u003dnetwork[\u0027bridge\u0027],"},{"line_number":183,"context_line":"                            id\u003dnetwork[\u0027id\u0027],"},{"line_number":184,"context_line":"                            cidr\u003dsubnet_v4[\u0027cidr\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAHX%2F%2F8sE%3D","line":181,"in_reply_to":"AAAAHX%2F%2F8uk%3D","updated":"2012-05-11 21:29:30.000000000","message":"Right, and None is the default so just:\n\n  dhcp_server \u003d get_meta(subnet_v4, \u0027dhcp_server\u0027)\n\nshould do it","commit_id":"767b6eef3aa4f89832340692d8429529aab4bdcc"}],"nova/tests/network/test_manager.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"e07d8f930e2900685ce3347e45581607959359fb","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            self.assertDictMatch(nw, check)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"            check \u003d {\u0027broadcast\u0027: \u0027192.168.%d.255\u0027 % nid,"},{"line_number":169,"context_line":"                     \u0027dhcp_server\u0027: \u0027\u0027,"},{"line_number":170,"context_line":"                     \u0027dns\u0027: [\u0027192.168.%d.3\u0027 % nid, \u0027192.168.%d.4\u0027 % nid],"},{"line_number":171,"context_line":"                     \u0027gateway\u0027: \u0027192.168.%d.1\u0027 % nid,"},{"line_number":172,"context_line":"                     \u0027gateway_v6\u0027: \u0027fe80::def\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAHX%2F%2F8ug%3D","line":169,"updated":"2012-05-11 19:45:19.000000000","message":"None","commit_id":"767b6eef3aa4f89832340692d8429529aab4bdcc"}],"nova/tests/test_libvirt.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"e07d8f930e2900685ce3347e45581607959359fb","unresolved":false,"context_lines":[{"line_number":897,"context_line":"        self.assertEquals(parameters[0].get(\u0027name\u0027), \u0027IP\u0027)"},{"line_number":898,"context_line":"        self.assertTrue(_ipv4_like(parameters[0].get(\u0027value\u0027), \u0027192.168\u0027))"},{"line_number":899,"context_line":"        self.assertEquals(parameters[1].get(\u0027name\u0027), \u0027DHCPSERVER\u0027)"},{"line_number":900,"context_line":"        self.assertTrue(_ipv4_like(parameters[1].get(\u0027value\u0027), \u0027\u0027))"},{"line_number":901,"context_line":""},{"line_number":902,"context_line":"    def _check_xml_and_container(self, instance):"},{"line_number":903,"context_line":"        user_context \u003d context.RequestContext(self.user_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAHX%2F%2F8uc%3D","line":900,"updated":"2012-05-11 19:45:19.000000000","message":"This line isn\u0027t really doing anything anymore, so maybe it should be asserting that the value is None","commit_id":"767b6eef3aa4f89832340692d8429529aab4bdcc"}],"nova/virt/libvirt/firewall.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"60928484dde88a3d3cb7b1e152b06b24f1d2efc7","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"import nova.virt.firewall as base_firewall"},{"line_number":30,"context_line":"from nova.virt import netutils"},{"line_number":31,"context_line":"from nova.openstack.common import cfg"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAHH%2F%2F9i8%3D","line":31,"updated":"2012-05-02 10:38:56.000000000","message":"from nova.openstack.common should not be put here","commit_id":"e805e21afd3d33e6387d18e9c9ced88076d28d37"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"60928484dde88a3d3cb7b1e152b06b24f1d2efc7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":"allow_dhcp_opt \u003d cfg.BoolOpt(\u0027allow_dhcp\u0027,"},{"line_number":36,"context_line":"        default\u003dTrue,"},{"line_number":37,"context_line":"        help\u003d\u0027Whether to allow dhcp iptable filter rull in network traffic.\u0027)"},{"line_number":38,"context_line":"FLAGS \u003d flags.FLAGS"},{"line_number":39,"context_line":"FLAGS.register_opt(allow_dhcp_opt)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAHH%2F%2F9io%3D","line":37,"updated":"2012-05-02 10:38:56.000000000","message":"default\u003dTrue should align with \u0027allow_dhcp\u0027","commit_id":"e805e21afd3d33e6387d18e9c9ced88076d28d37"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"60928484dde88a3d3cb7b1e152b06b24f1d2efc7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        help\u003d\u0027Whether to allow dhcp iptable filter rull in network traffic.\u0027)"},{"line_number":38,"context_line":"FLAGS \u003d flags.FLAGS"},{"line_number":39,"context_line":"FLAGS.register_opt(allow_dhcp_opt)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# The default Firewall driver must be listed at position 0"},{"line_number":42,"context_line":"drivers \u003d [\u0027nova.virt.libvirt.firewall.IptablesFirewallDriver\u0027, ]"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAHH%2F%2F9i0%3D","line":40,"updated":"2012-05-02 10:38:56.000000000","message":"I tend to put FLAGS just behind the LOG since they are  constants or global variables.","commit_id":"e805e21afd3d33e6387d18e9c9ced88076d28d37"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"661632bf14c1db0d0bde709979de89a067a20acd","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            base_filter \u003d \u0027nova-base\u0027"},{"line_number":113,"context_line":"        else:"},{"line_number":114,"context_line":"            base_filter \u003d \u0027nova-nodhcp\u0027"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        for (network, mapping) in network_info:"},{"line_number":117,"context_line":"            nic_id \u003d mapping[\u0027mac\u0027].replace(\u0027:\u0027, \u0027\u0027)"},{"line_number":118,"context_line":"            instance_filter_name \u003d self._instance_filter_name(instance, nic_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAHX%2F%2F%2BK0%3D","line":115,"updated":"2012-05-09 14:29:02.000000000","message":"I don\u0027t think this is good enough - you add the DHCP rules to a filter which is never used?\n\nWe should just avoid adding the DHCP rules to the nova-base filter at all","commit_id":"cd48e61931daa282acf54ff715939826f0b569f7"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"51791500b19c2946b195a4185e887c7f3d7f7d34","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            base_filter \u003d \u0027nova-base\u0027"},{"line_number":113,"context_line":"        else:"},{"line_number":114,"context_line":"            base_filter \u003d \u0027nova-nodhcp\u0027"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        for (network, mapping) in network_info:"},{"line_number":117,"context_line":"            nic_id \u003d mapping[\u0027mac\u0027].replace(\u0027:\u0027, \u0027\u0027)"},{"line_number":118,"context_line":"            instance_filter_name \u003d self._instance_filter_name(instance, nic_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAHX%2F%2F8sA%3D","line":115,"updated":"2012-05-11 21:29:30.000000000","message":"Unless I\u0027m missing something, this means we\u0027re adding the DHCP rules to a filter called \u0027nova-nodhcp\u0027 and then just not using that filter\n\nWe should just avoid adding the DHCP rules at all rather than adding an unused filter","commit_id":"767b6eef3aa4f89832340692d8429529aab4bdcc"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"03c4ae5862f8aa3cd7ba57ac461583fc362f36e3","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            base_filter \u003d \u0027nova-base\u0027"},{"line_number":113,"context_line":"        else:"},{"line_number":114,"context_line":"            base_filter \u003d \u0027nova-nodhcp\u0027"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        for (network, mapping) in network_info:"},{"line_number":117,"context_line":"            nic_id \u003d mapping[\u0027mac\u0027].replace(\u0027:\u0027, \u0027\u0027)"},{"line_number":118,"context_line":"            instance_filter_name \u003d self._instance_filter_name(instance, nic_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAHX%2F%2F8r0%3D","line":115,"in_reply_to":"AAAAHX%2F%2F8sA%3D","updated":"2012-05-11 21:33:27.000000000","message":"Actually, I\u0027m sorry - I misunderstood. I see now how \u0027nova-nodhcp\u0027 is used.","commit_id":"767b6eef3aa4f89832340692d8429529aab4bdcc"}]}