)]}'
{"nova/objects/instance.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0c6f7c3f317de3c5c33875bcfabe3e344f1a837a","unresolved":false,"context_lines":[{"line_number":1390,"context_line":"        :param node: Filter instances on this node."},{"line_number":1391,"context_line":"        :returns: list of non-deleted instance UUIDs on the given host and node"},{"line_number":1392,"context_line":"        \"\"\""},{"line_number":1393,"context_line":"        return cls._get_uuids_by_host_and_node(context, host, node)"},{"line_number":1394,"context_line":""},{"line_number":1395,"context_line":"    @base.remotable_classmethod"},{"line_number":1396,"context_line":"    def get_by_host_and_not_type(cls, context, host, type_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_b03c3093","line":1393,"updated":"2019-06-14 16:28:44.000000000","message":"Curious why we need two methods here. Something to do with the decorators I guess?","commit_id":"4adface8b9c1cdb04f9401d4bbd1c2dc795f94a5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"61b4562ee350abfa07a13df3ebc5d6ed34b887c9","unresolved":false,"context_lines":[{"line_number":1390,"context_line":"        :param node: Filter instances on this node."},{"line_number":1391,"context_line":"        :returns: list of non-deleted instance UUIDs on the given host and node"},{"line_number":1392,"context_line":"        \"\"\""},{"line_number":1393,"context_line":"        return cls._get_uuids_by_host_and_node(context, host, node)"},{"line_number":1394,"context_line":""},{"line_number":1395,"context_line":"    @base.remotable_classmethod"},{"line_number":1396,"context_line":"    def get_by_host_and_not_type(cls, context, host, type_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_61b7873c","line":1393,"in_reply_to":"9fb8cfa7_b03c3093","updated":"2019-06-19 14:42:36.000000000","message":"Yeah it\u0027s the pattern used through b/c of the decorators.","commit_id":"4adface8b9c1cdb04f9401d4bbd1c2dc795f94a5"}],"nova/scheduler/client/report.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5b7390097c5a9523a418df214b4e6bffdbec4da8","unresolved":false,"context_lines":[{"line_number":2169,"context_line":"            # Delete any allocations for this resource provider."},{"line_number":2170,"context_line":"            # Since allocations are by consumer, we get the consumers on this"},{"line_number":2171,"context_line":"            # host, which are its instances."},{"line_number":2172,"context_line":"            # NOTE(mriedem): This assumes the only allocations on this node"},{"line_number":2173,"context_line":"            # are instances, but couldn\u0027t there be migration consumers if the"},{"line_number":2174,"context_line":"            # node is deleted during a migration? Obviously an admin shouldn\u0027t"},{"line_number":2175,"context_line":"            # do that but...you know. I guess the provider deletion should fail"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_dd987e1c","line":2172,"updated":"2019-06-05 20:57:51.000000000","message":"As seen from bug 1829479 there could not only be unconfirmed migrations but also evacuated instances - so the consumer for those allocations are instances but their host is set to another compute so they don\u0027t show up in this list and we delete the provider anyway, but because ResourceProviderInUse is ignored below, we still delete the compute service...","commit_id":"42b5ce2987fd8432ca710d31c50396743d8d9486"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0c6f7c3f317de3c5c33875bcfabe3e344f1a837a","unresolved":false,"context_lines":[{"line_number":2173,"context_line":"            # are instances, but there could be migration consumers if the"},{"line_number":2174,"context_line":"            # node is deleted during a migration or allocations from an"},{"line_number":2175,"context_line":"            # evacuated host (bug 1829479). Obviously an admin shouldn\u0027t"},{"line_number":2176,"context_line":"            # do that but...you know. I guess the provider deletion should fail"},{"line_number":2177,"context_line":"            # in that case which is what we\u0027d want to happen."},{"line_number":2178,"context_line":"            instance_uuids \u003d objects.InstanceList.get_uuids_by_host_and_node("},{"line_number":2179,"context_line":"                context, host, nodename)"},{"line_number":2180,"context_line":"            for instance_uuid in instance_uuids:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_b00af0ce","line":2177,"range":{"start_line":2176,"start_character":38,"end_line":2177,"end_character":60},"updated":"2019-06-14 16:28:44.000000000","message":"This makes it sound like said failure would percolate up, which it won\u0027t as currently written. Suggest reword, with a TODO.","commit_id":"4adface8b9c1cdb04f9401d4bbd1c2dc795f94a5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"61b4562ee350abfa07a13df3ebc5d6ed34b887c9","unresolved":false,"context_lines":[{"line_number":2173,"context_line":"            # are instances, but there could be migration consumers if the"},{"line_number":2174,"context_line":"            # node is deleted during a migration or allocations from an"},{"line_number":2175,"context_line":"            # evacuated host (bug 1829479). Obviously an admin shouldn\u0027t"},{"line_number":2176,"context_line":"            # do that but...you know. I guess the provider deletion should fail"},{"line_number":2177,"context_line":"            # in that case which is what we\u0027d want to happen."},{"line_number":2178,"context_line":"            instance_uuids \u003d objects.InstanceList.get_uuids_by_host_and_node("},{"line_number":2179,"context_line":"                context, host, nodename)"},{"line_number":2180,"context_line":"            for instance_uuid in instance_uuids:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_e17cd773","line":2177,"range":{"start_line":2176,"start_character":38,"end_line":2177,"end_character":60},"in_reply_to":"9fb8cfa7_b00af0ce","updated":"2019-06-19 14:42:36.000000000","message":"There is a TODO below from you to raise on those errors.","commit_id":"4adface8b9c1cdb04f9401d4bbd1c2dc795f94a5"}]}