)]}'
{"nova/scheduler/request_filter.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d428b237d93940175d8e503fd478e45839831911","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import os_traits"},{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":"from oslo_utils import excutils"},{"line_number":18,"context_line":"from oslo_utils import timeutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import nova.conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_c5d51245","line":17,"updated":"2019-05-07 15:53:31.000000000","message":"not used","commit_id":"7314c12620c5c4d09bab23935748a897f196fd21"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c2edc044d88bd4f5540aacf2a0893894b41ae81e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            try:"},{"line_number":38,"context_line":"                ran \u003d fn(ctxt, request_spec)"},{"line_number":39,"context_line":"            finally:"},{"line_number":40,"context_line":"                if ran:"},{"line_number":41,"context_line":"                    # Only log info if the filter was enabled and not"},{"line_number":42,"context_line":"                    # excluded for some reason"},{"line_number":43,"context_line":"                    LOG.debug(\u0027Request filter %r took %.1f seconds\u0027 % ("}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_05b48a34","line":40,"range":{"start_line":40,"start_character":16,"end_line":40,"end_character":23},"updated":"2019-05-07 15:53:09.000000000","message":"require_image_type_support will return None in the case that it actually did something, which would be Falsey here and you wouldn\u0027t log anything.","commit_id":"7314c12620c5c4d09bab23935748a897f196fd21"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c2edc044d88bd4f5540aacf2a0893894b41ae81e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    enabled \u003d CONF.scheduler.limit_tenants_to_placement_aggregate"},{"line_number":61,"context_line":"    agg_required \u003d CONF.scheduler.placement_aggregate_required_for_tenants"},{"line_number":62,"context_line":"    if not enabled:"},{"line_number":63,"context_line":"        return False"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    aggregates \u003d objects.AggregateList.get_by_metadata("},{"line_number":66,"context_line":"        ctxt, value\u003drequest_spec.project_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_058d6a7a","line":63,"updated":"2019-05-07 15:53:09.000000000","message":"As noted above, \"if ran\" will evaluate to False for None so you don\u0027t really need to change these filter methods to return False since None will do, but you do need them to return True if they did something and you want to log it.","commit_id":"7314c12620c5c4d09bab23935748a897f196fd21"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b0fc481dd19c87a6805f4a384676a6b8b96cf8b7","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    enabled \u003d CONF.scheduler.limit_tenants_to_placement_aggregate"},{"line_number":61,"context_line":"    agg_required \u003d CONF.scheduler.placement_aggregate_required_for_tenants"},{"line_number":62,"context_line":"    if not enabled:"},{"line_number":63,"context_line":"        return False"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    aggregates \u003d objects.AggregateList.get_by_metadata("},{"line_number":66,"context_line":"        ctxt, value\u003drequest_spec.project_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_25f98ec7","line":63,"in_reply_to":"dfbec78f_058d6a7a","updated":"2019-05-07 15:58:24.000000000","message":"I know, just wanted to be explicit.","commit_id":"7314c12620c5c4d09bab23935748a897f196fd21"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"4122ffee1a0a3ffa9b8303ed39677d32c45019c9","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    matches the desired AZ of the user\u0027s request."},{"line_number":98,"context_line":"    \"\"\""},{"line_number":99,"context_line":"    if not CONF.scheduler.query_placement_for_availability_zone:"},{"line_number":100,"context_line":"        return"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    az_hint \u003d request_spec.availability_zone"},{"line_number":103,"context_line":"    if not az_hint:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_aa3c42c8","line":100,"updated":"2019-05-09 16:35:50.000000000","message":"You\u0027ve been explicit about False and True in the other returns. It looks like this should be for consistency, even though it will still work.","commit_id":"ab68a7eceaccb4bc213de888869dd25bf25c1785"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f5012af5ed69e6a9be2e8f9ec105699ed5824fab","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    matches the desired AZ of the user\u0027s request."},{"line_number":98,"context_line":"    \"\"\""},{"line_number":99,"context_line":"    if not CONF.scheduler.query_placement_for_availability_zone:"},{"line_number":100,"context_line":"        return"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    az_hint \u003d request_spec.availability_zone"},{"line_number":103,"context_line":"    if not az_hint:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_2a8b721f","line":100,"in_reply_to":"dfbec78f_aa3c42c8","updated":"2019-05-09 16:56:53.000000000","message":"Indeed, thanks.","commit_id":"ab68a7eceaccb4bc213de888869dd25bf25c1785"}]}