)]}'
{"nova/context.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a383e08d86ce7f837cefd1d4390fa9d40c418750","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def to_policy_values(self):"},{"line_number":260,"context_line":"        policy \u003d super(RequestContext, self).to_policy_values()"},{"line_number":261,"context_line":"        # TODO(johngarbutt) can we remove this soon?"},{"line_number":262,"context_line":"        policy[\u0027is_admin\u0027] \u003d self.is_admin"},{"line_number":263,"context_line":"        return policy"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_8fed07f1","line":261,"updated":"2019-06-04 19:26:32.000000000","message":"Probably once all of these are deprecated and removed\n\nhttps://opendev.org/openstack/nova/src/branch/master/nova/policies/servers.py#L181\n\nBut that also means operators aren\u0027t going to be able to rely on that custom policy check_str in their overrides. Even if they have been in the past. They\u0027d have to fully adopt the new model (with different scope types) and not rely on this at all.","commit_id":"f1f0ff799f9a9e044d28765190e3a91341ff1aa5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a0a9a3e96462bed888bfc1063858ba63d5695575","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def to_policy_values(self):"},{"line_number":260,"context_line":"        policy \u003d super(RequestContext, self).to_policy_values()"},{"line_number":261,"context_line":"        # TODO(johngarbutt) can we remove this soon?"},{"line_number":262,"context_line":"        policy[\u0027is_admin\u0027] \u003d self.is_admin"},{"line_number":263,"context_line":"        return policy"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_1825d1c2","line":261,"in_reply_to":"9fb8cfa7_8fed07f1","updated":"2019-06-05 11:39:49.000000000","message":"Yeah... I was thinking the same.","commit_id":"f1f0ff799f9a9e044d28765190e3a91341ff1aa5"}],"nova/policy.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c2401a63b9c00234bccf833c0a73150ffe781330","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        target \u003d default_target(context)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    try:"},{"line_number":165,"context_line":"        result \u003d _ENFORCER.authorize(action, target, context,"},{"line_number":166,"context_line":"                                     do_raise\u003ddo_raise, exc\u003dexc, action\u003daction)"},{"line_number":167,"context_line":"    except policy.PolicyNotRegistered:"},{"line_number":168,"context_line":"        with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_107426fd","line":165,"updated":"2019-07-01 09:08:38.000000000","message":"TODO: split this into a separate chance with a description of the issues.","commit_id":"ceb8e1faca99b774b5fc07fcd92a03b922dceddf"}],"nova/tests/unit/policies/test_admin_actions.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d6c23effa3654d08456664fd19800d91cf7c0e17","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                                     self.req, self.instance.uuid, body\u003d{})"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"class AdminActionsTypePolicyTest(AdminActionsPolicyTest):"},{"line_number":94,"context_line":"    \"\"\"Test Admin Actions APIs policies with system scope enabled."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    This class set the nova.conf [oslo_policy] enforce_scope to True"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_db1b3ec8","line":93,"updated":"2019-11-21 00:31:29.000000000","message":"Lets add this in the previous patch please.","commit_id":"a38dd8e36128436304a9953d09648d72051e32c8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c377bef705388b94910e8ba223e3efeb37ea796b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                                     self.req, self.instance.uuid, body\u003d{})"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"class AdminActionsTypePolicyTest(AdminActionsPolicyTest):"},{"line_number":94,"context_line":"    \"\"\"Test Admin Actions APIs policies with system scope enabled."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    This class set the nova.conf [oslo_policy] enforce_scope to True"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_8504dc19","line":93,"in_reply_to":"3fa7e38b_db1b3ec8","updated":"2019-12-04 19:21:59.000000000","message":"done","commit_id":"a38dd8e36128436304a9953d09648d72051e32c8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d6c23effa3654d08456664fd19800d91cf7c0e17","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.reset_state_success_contexts \u003d [self.system_admin_context]"},{"line_number":111,"context_line":"        # Check that non-system scopped token (project scopped and legacy"},{"line_number":112,"context_line":"        # admin) is not able to reset state"},{"line_number":113,"context_line":"        self.reset_state_fail_contexts \u003d [self.legacy_admin_context,"},{"line_number":114,"context_line":"                                          self.project_member_context]"},{"line_number":115,"context_line":"        # Check that System admin (token with system scope) is able"},{"line_number":116,"context_line":"        # to inject the network info"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_1b26b617","line":113,"updated":"2019-11-21 00:31:29.000000000","message":"as pre earlier patch, I think we need more coverage of the different context types here, we should ensure all tests test all possible context types.","commit_id":"a38dd8e36128436304a9953d09648d72051e32c8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c377bef705388b94910e8ba223e3efeb37ea796b","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self.reset_state_success_contexts \u003d [self.system_admin_context]"},{"line_number":111,"context_line":"        # Check that non-system scopped token (project scopped and legacy"},{"line_number":112,"context_line":"        # admin) is not able to reset state"},{"line_number":113,"context_line":"        self.reset_state_fail_contexts \u003d [self.legacy_admin_context,"},{"line_number":114,"context_line":"                                          self.project_member_context]"},{"line_number":115,"context_line":"        # Check that System admin (token with system scope) is able"},{"line_number":116,"context_line":"        # to inject the network info"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_a5ff9800","line":113,"in_reply_to":"3fa7e38b_1b26b617","updated":"2019-12-04 19:21:59.000000000","message":"done","commit_id":"a38dd8e36128436304a9953d09648d72051e32c8"}]}