)]}'
{"nova/tests/functional/test_servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"56a29a0aeabfa426061f6c361a0e75548c6da101","unresolved":false,"context_lines":[{"line_number":2498,"context_line":"            dest_rp_uuid\u003ddest_rp_uuid)"},{"line_number":2499,"context_line":""},{"line_number":2500,"context_line":"    def test_migration_confirm_resize_error(self):"},{"line_number":2501,"context_line":"        self.failed_hostname \u003d None"},{"line_number":2502,"context_line":"        source_hostname \u003d self.compute1.host"},{"line_number":2503,"context_line":"        dest_hostname \u003d self.compute2.host"},{"line_number":2504,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_be8bec65","line":2501,"range":{"start_line":2501,"start_character":8,"end_line":2501,"end_character":35},"updated":"2019-05-13 21:32:56.000000000","message":"We can remove this.","commit_id":"495a9a8ef72c05ab7246d014eacb79ec0e9a7321"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d77f9900e91b3ecc537d998746f566bed14c1bba","unresolved":false,"context_lines":[{"line_number":2498,"context_line":"            dest_rp_uuid\u003ddest_rp_uuid)"},{"line_number":2499,"context_line":""},{"line_number":2500,"context_line":"    def test_migration_confirm_resize_error(self):"},{"line_number":2501,"context_line":"        self.failed_hostname \u003d None"},{"line_number":2502,"context_line":"        source_hostname \u003d self.compute1.host"},{"line_number":2503,"context_line":"        dest_hostname \u003d self.compute2.host"},{"line_number":2504,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_fec3a487","line":2501,"range":{"start_line":2501,"start_character":8,"end_line":2501,"end_character":35},"in_reply_to":"dfbec78f_be8bec65","updated":"2019-05-13 21:37:18.000000000","message":"Done","commit_id":"495a9a8ef72c05ab7246d014eacb79ec0e9a7321"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"56a29a0aeabfa426061f6c361a0e75548c6da101","unresolved":false,"context_lines":[{"line_number":2515,"context_line":""},{"line_number":2516,"context_line":"        # Mock failure"},{"line_number":2517,"context_line":"        def fake_confirm_migration(context, migration, instance, network_info):"},{"line_number":2518,"context_line":"            self.failed_hostname \u003d source_hostname"},{"line_number":2519,"context_line":"            raise exception.MigrationPreCheckError("},{"line_number":2520,"context_line":"                reason\u003d\u0027test_migration_confirm_resize_error\u0027)"},{"line_number":2521,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_5eeaf00e","line":2518,"range":{"start_line":2518,"start_character":12,"end_line":2518,"end_character":50},"updated":"2019-05-13 21:32:56.000000000","message":"And this right?","commit_id":"495a9a8ef72c05ab7246d014eacb79ec0e9a7321"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d77f9900e91b3ecc537d998746f566bed14c1bba","unresolved":false,"context_lines":[{"line_number":2515,"context_line":""},{"line_number":2516,"context_line":"        # Mock failure"},{"line_number":2517,"context_line":"        def fake_confirm_migration(context, migration, instance, network_info):"},{"line_number":2518,"context_line":"            self.failed_hostname \u003d source_hostname"},{"line_number":2519,"context_line":"            raise exception.MigrationPreCheckError("},{"line_number":2520,"context_line":"                reason\u003d\u0027test_migration_confirm_resize_error\u0027)"},{"line_number":2521,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_9ebce806","line":2518,"range":{"start_line":2518,"start_character":12,"end_line":2518,"end_character":50},"in_reply_to":"dfbec78f_5eeaf00e","updated":"2019-05-13 21:37:18.000000000","message":"Done","commit_id":"495a9a8ef72c05ab7246d014eacb79ec0e9a7321"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"95fd00c6d0792452a8110bf55e3baf08ba50cbeb","unresolved":false,"context_lines":[{"line_number":5321,"context_line":""},{"line_number":5322,"context_line":"        self._delete_and_check_allocations(server)"},{"line_number":5323,"context_line":""},{"line_number":5324,"context_line":"    def test_confirm_migrate_delete_alloc_on_source_fails(self):"},{"line_number":5325,"context_line":"        source_hostname \u003d self.compute1.host"},{"line_number":5326,"context_line":"        dest_hostname \u003d self.compute2.host"},{"line_number":5327,"context_line":"        source_rp_uuid \u003d self._get_provider_uuid_by_host(source_hostname)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_573ea1da","line":5324,"range":{"start_line":5324,"start_character":8,"end_line":5324,"end_character":57},"updated":"2019-05-09 00:15:27.000000000","message":"Doesn\u0027t this test already do the same thing? I assume you\u0027re trying to follow up on the queens backport:\n\nhttps://review.opendev.org/#/c/652153/\n\nAnd this test is not in queens (or rocky) since it was added in Stein:\n\nhttps://review.opendev.org/#/c/591811/\n\nMaybe we can just include this test in stable/rocky directly then backport it to stable/queens and rebase the series for https://review.opendev.org/#/c/652153/ on top of it.","commit_id":"495a9a8ef72c05ab7246d014eacb79ec0e9a7321"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f69aea9d93510799cd4f17020acebe715b86da4c","unresolved":false,"context_lines":[{"line_number":5321,"context_line":""},{"line_number":5322,"context_line":"        self._delete_and_check_allocations(server)"},{"line_number":5323,"context_line":""},{"line_number":5324,"context_line":"    def test_confirm_migrate_delete_alloc_on_source_fails(self):"},{"line_number":5325,"context_line":"        source_hostname \u003d self.compute1.host"},{"line_number":5326,"context_line":"        dest_hostname \u003d self.compute2.host"},{"line_number":5327,"context_line":"        source_rp_uuid \u003d self._get_provider_uuid_by_host(source_hostname)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_fe6724e8","line":5324,"range":{"start_line":5324,"start_character":8,"end_line":5324,"end_character":57},"in_reply_to":"dfbec78f_0771cea9","updated":"2019-05-13 21:25:36.000000000","message":"Yeah you\u0027re right, the allocation cleanup call to placement in this test 409s so it\u0027s different.","commit_id":"495a9a8ef72c05ab7246d014eacb79ec0e9a7321"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"02721325943139edefd8e13779c3940026ee5d81","unresolved":false,"context_lines":[{"line_number":5321,"context_line":""},{"line_number":5322,"context_line":"        self._delete_and_check_allocations(server)"},{"line_number":5323,"context_line":""},{"line_number":5324,"context_line":"    def test_confirm_migrate_delete_alloc_on_source_fails(self):"},{"line_number":5325,"context_line":"        source_hostname \u003d self.compute1.host"},{"line_number":5326,"context_line":"        dest_hostname \u003d self.compute2.host"},{"line_number":5327,"context_line":"        source_rp_uuid \u003d self._get_provider_uuid_by_host(source_hostname)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_0771cea9","line":5324,"range":{"start_line":5324,"start_character":8,"end_line":5324,"end_character":57},"in_reply_to":"dfbec78f_573ea1da","updated":"2019-05-09 12:37:22.000000000","message":"hey Matt. Yes, this is for that queens backport \u003d)\n\nHmm I did not see this test before. Yea it looks very similar, except that looks like it causes the allocation deletion to fail and get leaked (I could be reading this wrong, please chime in). See:\n\n        self.assertIn(\u0027Failed to delete allocations\u0027,\n                      server[\u0027fault\u0027][\u0027message\u0027])\n\n        # NOTE(gibi): Nova leaks the allocation held by the migration_uuid even\n        # after the instance is deleted. At least nova logs a fat ERROR.\n        self.assertIn(\u0027Deleting allocation in placement for migration %s \u0027\n                      \u0027failed. The instance %s will be put to ERROR state but \u0027\n                      \u0027the allocation held by the migration is leaked.\u0027 %\n                      (migrations[0][\u0027uuid\u0027], server[\u0027id\u0027]),\n                      self.stdlog.logger.output)\n\nWe can try backporting this and see if it catches any problems in Rocky and Queens, but I wonder if it is exactly the same scenario and coverage as the one I wrote.","commit_id":"495a9a8ef72c05ab7246d014eacb79ec0e9a7321"}]}