)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e64a4cbf5065c503cf917b54b34fa67302c1022f","unresolved":false,"context_lines":[{"line_number":1367,"context_line":"                # ran InstanceList.get_by_host_and_node(), added those"},{"line_number":1368,"context_line":"                # instances to RT.tracked_instances and the above"},{"line_number":1369,"context_line":"                # Instance.get_by_uuid() call. We SHOULD attempt to remove any"},{"line_number":1370,"context_line":"                # allocations that reference this compute host if the VM is in"},{"line_number":1371,"context_line":"                # a stable terminal state (i.e. it isn\u0027t in a state of waiting"},{"line_number":1372,"context_line":"                # for resize to confirm/revert), however if the destination"},{"line_number":1373,"context_line":"                # host is an Ocata compute host, it will delete the allocation"},{"line_number":1374,"context_line":"                # that contains this source compute host information anyway and"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_461e310d","line":1371,"range":{"start_line":1370,"start_character":63,"end_line":1371,"end_character":41},"updated":"2019-05-19 19:56:35.000000000","message":"This might be the key. If we want to downgrade the warning, we could consider just doing that if the instance.task_state is not None.","commit_id":"fbf3dccab92e4252f8816540c32d2b54b900a6be"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"423280ea57a97e7f372f2f7cd1101ea5eee14f21","unresolved":false,"context_lines":[{"line_number":1367,"context_line":"                # ran InstanceList.get_by_host_and_node(), added those"},{"line_number":1368,"context_line":"                # instances to RT.tracked_instances and the above"},{"line_number":1369,"context_line":"                # Instance.get_by_uuid() call. We SHOULD attempt to remove any"},{"line_number":1370,"context_line":"                # allocations that reference this compute host if the VM is in"},{"line_number":1371,"context_line":"                # a stable terminal state (i.e. it isn\u0027t in a state of waiting"},{"line_number":1372,"context_line":"                # for resize to confirm/revert), however if the destination"},{"line_number":1373,"context_line":"                # host is an Ocata compute host, it will delete the allocation"},{"line_number":1374,"context_line":"                # that contains this source compute host information anyway and"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_bee0ca27","line":1371,"range":{"start_line":1370,"start_character":63,"end_line":1371,"end_character":41},"in_reply_to":"bfb3d3c7_461e310d","updated":"2019-05-28 08:59:19.000000000","message":"Yup, this is the key. However, the instance.task_state is not necessarily able to determine whether the final result of the instance operation (evacuate, shelve offload, cold or live migrate) conforms to the scenario. That whole block does need to be re-worked.","commit_id":"fbf3dccab92e4252f8816540c32d2b54b900a6be"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e64a4cbf5065c503cf917b54b34fa67302c1022f","unresolved":false,"context_lines":[{"line_number":1369,"context_line":"                # Instance.get_by_uuid() call. We SHOULD attempt to remove any"},{"line_number":1370,"context_line":"                # allocations that reference this compute host if the VM is in"},{"line_number":1371,"context_line":"                # a stable terminal state (i.e. it isn\u0027t in a state of waiting"},{"line_number":1372,"context_line":"                # for resize to confirm/revert), however if the destination"},{"line_number":1373,"context_line":"                # host is an Ocata compute host, it will delete the allocation"},{"line_number":1374,"context_line":"                # that contains this source compute host information anyway and"},{"line_number":1375,"context_line":"                # recreate an allocation that only refers to itself. So we"},{"line_number":1376,"context_line":"                # don\u0027t need to do anything in that case. Just log the"},{"line_number":1377,"context_line":"                # situation here for information but don\u0027t attempt to delete or"},{"line_number":1378,"context_line":"                # change the allocation."}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_6627b566","line":1375,"range":{"start_line":1372,"start_character":49,"end_line":1375,"end_character":68},"updated":"2019-05-19 19:56:35.000000000","message":"The code referenced here is all long gone and doesn\u0027t apply anymore.","commit_id":"fbf3dccab92e4252f8816540c32d2b54b900a6be"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"423280ea57a97e7f372f2f7cd1101ea5eee14f21","unresolved":false,"context_lines":[{"line_number":1369,"context_line":"                # Instance.get_by_uuid() call. We SHOULD attempt to remove any"},{"line_number":1370,"context_line":"                # allocations that reference this compute host if the VM is in"},{"line_number":1371,"context_line":"                # a stable terminal state (i.e. it isn\u0027t in a state of waiting"},{"line_number":1372,"context_line":"                # for resize to confirm/revert), however if the destination"},{"line_number":1373,"context_line":"                # host is an Ocata compute host, it will delete the allocation"},{"line_number":1374,"context_line":"                # that contains this source compute host information anyway and"},{"line_number":1375,"context_line":"                # recreate an allocation that only refers to itself. So we"},{"line_number":1376,"context_line":"                # don\u0027t need to do anything in that case. Just log the"},{"line_number":1377,"context_line":"                # situation here for information but don\u0027t attempt to delete or"},{"line_number":1378,"context_line":"                # change the allocation."}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_3e729aae","line":1375,"range":{"start_line":1372,"start_character":49,"end_line":1375,"end_character":68},"in_reply_to":"bfb3d3c7_6627b566","updated":"2019-05-28 08:59:19.000000000","message":"Yeah, these desc are not means, should be removed.","commit_id":"fbf3dccab92e4252f8816540c32d2b54b900a6be"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"d1392ac9bd1d750f93abcc6686287144b635d238","unresolved":false,"context_lines":[{"line_number":1376,"context_line":"                # don\u0027t need to do anything in that case. Just log the"},{"line_number":1377,"context_line":"                # situation here for information but don\u0027t attempt to delete or"},{"line_number":1378,"context_line":"                # change the allocation."},{"line_number":1379,"context_line":"                LOG.warning(\"Instance %s has been temporarily moved to \""},{"line_number":1380,"context_line":"                            \"another host %s(%s). There are allocations \""},{"line_number":1381,"context_line":"                            \"remaining against the source host that might \""},{"line_number":1382,"context_line":"                            \"need to be removed: %s.\","}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_10826e50","line":1379,"range":{"start_line":1379,"start_character":50,"end_line":1379,"end_character":61},"updated":"2019-05-09 07:40:12.000000000","message":"Hmm, I think we should probably keep the original statement as this is not only used for live migration, in other cases, the instance did moved to other host permanently","commit_id":"fbf3dccab92e4252f8816540c32d2b54b900a6be"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e64a4cbf5065c503cf917b54b34fa67302c1022f","unresolved":false,"context_lines":[{"line_number":1376,"context_line":"                # don\u0027t need to do anything in that case. Just log the"},{"line_number":1377,"context_line":"                # situation here for information but don\u0027t attempt to delete or"},{"line_number":1378,"context_line":"                # change the allocation."},{"line_number":1379,"context_line":"                LOG.warning(\"Instance %s has been temporarily moved to \""},{"line_number":1380,"context_line":"                            \"another host %s(%s). There are allocations \""},{"line_number":1381,"context_line":"                            \"remaining against the source host that might \""},{"line_number":1382,"context_line":"                            \"need to be removed: %s.\","}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_c63221a8","line":1379,"range":{"start_line":1379,"start_character":50,"end_line":1379,"end_character":61},"in_reply_to":"dfbec78f_10826e50","updated":"2019-05-19 19:56:35.000000000","message":"Agree that this isn\u0027t really a temporary thing if we\u0027re in the middle of a migration.","commit_id":"fbf3dccab92e4252f8816540c32d2b54b900a6be"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e64a4cbf5065c503cf917b54b34fa67302c1022f","unresolved":false,"context_lines":[{"line_number":1377,"context_line":"                # situation here for information but don\u0027t attempt to delete or"},{"line_number":1378,"context_line":"                # change the allocation."},{"line_number":1379,"context_line":"                LOG.warning(\"Instance %s has been temporarily moved to \""},{"line_number":1380,"context_line":"                            \"another host %s(%s). There are allocations \""},{"line_number":1381,"context_line":"                            \"remaining against the source host that might \""},{"line_number":1382,"context_line":"                            \"need to be removed: %s.\","},{"line_number":1383,"context_line":"                            instance_uuid, instance.host, instance.node, alloc)"},{"line_number":1384,"context_line":""},{"line_number":1385,"context_line":"    def delete_allocation_for_evacuated_instance(self, context, instance, node,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_0618391b","line":1382,"range":{"start_line":1380,"start_character":50,"end_line":1382,"end_character":52},"updated":"2019-05-19 19:56:35.000000000","message":"The original warning was likely because this was worried about leaking allocations if the source compute didn\u0027t clean them up, but really that\u0027s the job of the migration code to do the allocation cleanup properly on whatever host, for whatever move operation (evacuate, shelve offload, cold or live migrate).\n\nAs such the warning shouldn\u0027t really apply anymore, especially if the instance task_state is not None. If the task_state is None and we have allocations against this host but that\u0027s not where the instance is, then the warning is probably OK.","commit_id":"fbf3dccab92e4252f8816540c32d2b54b900a6be"}]}