)]}'
{"nova/api/openstack/views/images.py":[{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"26e989b6db7a4abb90bd206bd4a0b539d74bb31b","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"            if \u0027min_disk\u0027 in image_obj:"},{"line_number":210,"context_line":"                try:"},{"line_number":211,"context_line":"                    min_disk \u003d int(image_obj.get(\"min_disk\") or 0)"},{"line_number":212,"context_line":"                except Exception:"},{"line_number":213,"context_line":"                    min_disk \u003d 0"},{"line_number":214,"context_line":"                finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F%2BvQ%3D","line":211,"updated":"2011-09-26 18:04:04.000000000","message":"Can you use less logic in the try/except?\n\nmin_disk \u003d image_obj.get(\"min_disk\") or 0\ntry:\n    min_disk \u003d int(min_disk)\nexcept ValueError:\n    min_disk \u003d 0\nimage[\u0027minDisk\u0027] \u003d min_disk\n\nNo need for the finally in my opinion, as you\u0027d never encounter an error in the statement \"min_disk \u003d 0\". Maybe it\u0027s over-thinking, but I\u0027d rather not have \u0027except Exception\u0027.","commit_id":"04f31ce1931867a4fcc960e13f9ba6e2680b9674"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"fc8361b791eae3496364e49b33dceb917c3f1cf9","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"            if \u0027min_disk\u0027 in image_obj:"},{"line_number":210,"context_line":"                try:"},{"line_number":211,"context_line":"                    min_disk \u003d int(image_obj.get(\"min_disk\") or 0)"},{"line_number":212,"context_line":"                except Exception:"},{"line_number":213,"context_line":"                    min_disk \u003d 0"},{"line_number":214,"context_line":"                finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F%2Bu0%3D","line":211,"in_reply_to":"AAAACX%2F%2F%2BvQ%3D","updated":"2011-09-26 18:09:25.000000000","message":"That\u0027s definitely a clearer approach. Check out patchset 2","commit_id":"04f31ce1931867a4fcc960e13f9ba6e2680b9674"}]}