)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f9c0ad955186cf7eecdcfe31023a7137a284186","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hamdy Khader \u003chamdyk@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-05-16 00:31:34 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] OVS DPDK port representors support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This POC code adds support for OVS DPDK port representors[1], a direct"},{"line_number":10,"context_line":"port on a netdev datapath is considered a DPDK representor port."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bfb3d3c7_435cee4a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2019-05-17 17:50:41.000000000","message":"-1 because we still need a release note\nand a blueprint or bug for this.\n\nbut overall i think the patch looks correct\n\ni would be happy with a single bug that was tagged against\nnova neutron and os-vif as bluprint can be spread across multiple projects in launchpad but ill leave that up to the nova core team to decide.\n\ni think anything more then a specless blueprint is too heavy weight given this is the only nova change required.\n\nthe only other question i have was can we get the melonox ci to start testing this feature against the nova gate going forward?\n\nit would be nice to see it vote on this change but i will not block on that point either.","commit_id":"b05e453904cc3d26650982d6e9d81789f6eb190d"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"f2071ca5e5eecff15ac471b765dc909050a62348","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hamdy Khader \u003chamdyk@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-05-16 00:31:34 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] OVS DPDK port representors support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This POC code adds support for OVS DPDK port representors[1], a direct"},{"line_number":10,"context_line":"port on a netdev datapath is considered a DPDK representor port."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bfb3d3c7_f3fefe03","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"in_reply_to":"bfb3d3c7_0e737d82","updated":"2019-05-20 09:36:43.000000000","message":"Done","commit_id":"b05e453904cc3d26650982d6e9d81789f6eb190d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b711e5a1c8549842824e3dbba1a61fcb841ab841","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hamdy Khader \u003chamdyk@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-05-16 00:31:34 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] OVS DPDK port representors support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This POC code adds support for OVS DPDK port representors[1], a direct"},{"line_number":10,"context_line":"port on a netdev datapath is considered a DPDK representor port."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bfb3d3c7_0e737d82","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"in_reply_to":"bfb3d3c7_435cee4a","updated":"2019-05-17 18:06:46.000000000","message":"Agree this should have something to track its feature-ness. Sean and I talked about an rfe bug opened in neutron and tagged against nova as well. That\u0027s fine with me. It should describe the user impact and any necessary doc changes.","commit_id":"b05e453904cc3d26650982d6e9d81789f6eb190d"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"f2071ca5e5eecff15ac471b765dc909050a62348","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hamdy Khader \u003chamdyk@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-05-16 00:31:34 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] OVS DPDK port representors support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This POC code adds support for OVS DPDK port representors[1], a direct"},{"line_number":10,"context_line":"port on a netdev datapath is considered a DPDK representor port."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bfb3d3c7_5804c917","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"in_reply_to":"bfb3d3c7_435cee4a","updated":"2019-05-20 09:36:43.000000000","message":"Done","commit_id":"b05e453904cc3d26650982d6e9d81789f6eb190d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ebe7d1399097c97e3733c602622f13691b472475","unresolved":false,"context_lines":[{"line_number":13,"context_line":"must have the databath info to be passed to os-vif."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] http://docs.openvswitch.org/en/latest/topics/dpdk/phy/#representors"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1829734"},{"line_number":18,"context_line":"Change-Id: I416e121ebdc5f5dfbddda809af7379658d9c1fd6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bfb3d3c7_bb96a64b","line":16,"updated":"2019-05-30 12:10:51.000000000","message":"this should have \nDepends-On: https://review.opendev.org/#/c/658786/10\nand we will need to do a relase of os-vif before this can merge with the corresponding min version bump in nova.\nalternitivly you could put a min version check in the nova code and raise an exception if the os-vif version is not new enough in which case we dont need to wait for the next os-vif release.\n\ncurrently im planning to do that in 2-3 weeks, i.e. before m2","commit_id":"919a2da541c95f2ffade1d35dc1606255c800bcb"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"0ec1bbd433f106c540533f91138e024d5efbf5ab","unresolved":false,"context_lines":[{"line_number":13,"context_line":"must have the databath info to be passed to os-vif."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] http://docs.openvswitch.org/en/latest/topics/dpdk/phy/#representors"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1829734"},{"line_number":18,"context_line":"Change-Id: I416e121ebdc5f5dfbddda809af7379658d9c1fd6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9fb8cfa7_5cee198c","line":16,"in_reply_to":"bfb3d3c7_bb96a64b","updated":"2019-06-18 08:21:46.000000000","message":"No need for \nDepends-On: https://review.opendev.org/#/c/658786/\nbecause it got merged, will wait till the next os-vif release so I can bump the version.","commit_id":"919a2da541c95f2ffade1d35dc1606255c800bcb"}],"nova/network/model.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4f8cd95fbb0351fd658f2ed02c8bfd266a8ff2c2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"VIF_TYPE_AGILIO_OVS \u003d \u0027agilio_ovs\u0027"},{"line_number":46,"context_line":"VIF_TYPE_BINDING_FAILED \u003d \u0027binding_failed\u0027"},{"line_number":47,"context_line":"VIF_TYPE_VIF \u003d \u0027vif\u0027"},{"line_number":48,"context_line":"VIF_TYPE_UNBOUND \u003d \u0027unbound\u0027"},{"line_number":49,"context_line":"VIF_TYPE_OVS_DPDK \u003d \u0027ovs_dpdk\u0027"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Constants for dictionary keys in the \u0027vif_details\u0027 field in the VIF"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_78257b5b","line":48,"range":{"start_line":48,"start_character":28,"end_line":48,"end_character":28},"updated":"2019-05-14 16:07:42.000000000","message":"we shoudl not have a new vif type for this.\nthe vif_type shoudl be ovs and the vnic type shoudl be direct or virtio forwarder depending on if we are exposing the vf to the guest or using vhost-vfio to expose a vhost-user like connection.","commit_id":"2e62c933d1ed6118d65501065967146a872dda22"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"464ed572c549e5d010919214d8614d076dbccacd","unresolved":false,"context_lines":[{"line_number":45,"context_line":"VIF_TYPE_AGILIO_OVS \u003d \u0027agilio_ovs\u0027"},{"line_number":46,"context_line":"VIF_TYPE_BINDING_FAILED \u003d \u0027binding_failed\u0027"},{"line_number":47,"context_line":"VIF_TYPE_VIF \u003d \u0027vif\u0027"},{"line_number":48,"context_line":"VIF_TYPE_UNBOUND \u003d \u0027unbound\u0027"},{"line_number":49,"context_line":"VIF_TYPE_OVS_DPDK \u003d \u0027ovs_dpdk\u0027"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Constants for dictionary keys in the \u0027vif_details\u0027 field in the VIF"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_f512c861","line":48,"range":{"start_line":48,"start_character":28,"end_line":48,"end_character":28},"in_reply_to":"dfbec78f_78257b5b","updated":"2019-05-15 10:31:53.000000000","message":"Done","commit_id":"2e62c933d1ed6118d65501065967146a872dda22"}],"nova/network/os_vif_util.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f9c0ad955186cf7eecdcfe31023a7137a284186","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    # during Train."},{"line_number":319,"context_line":"    return objects.vif.VIFPortProfileOVSRepresentor("},{"line_number":320,"context_line":"        interface_id\u003dvif.get(\u0027ovs_interfaceid\u0027) or vif[\u0027id\u0027],"},{"line_number":321,"context_line":"        datapath_type\u003dvif[\u0027details\u0027].get("},{"line_number":322,"context_line":"            model.VIF_DETAILS_OVS_DATAPATH_TYPE),"},{"line_number":323,"context_line":"        representor_name\u003d_get_vif_name(vif),"},{"line_number":324,"context_line":"        representor_address\u003dvif[\"profile\"][\u0027pci_slot\u0027])"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_aeecc3f3","line":322,"range":{"start_line":321,"start_character":6,"end_line":322,"end_character":49},"updated":"2019-05-17 17:50:41.000000000","message":"note: the VIFPortProfileOVSRepresentor \n\nhttps://github.com/openstack/os-vif/blob/983bfdee5024afc9fb3e7979b1219a58669bd401/os_vif/objects/vif.py#L399-L447\n\ninherits the datapath_type field form the VIFPortProfileOpenVSwitch\n\nhttps://github.com/openstack/os-vif/blob/983bfdee5024afc9fb3e7979b1219a58669bd401/os_vif/objects/vif.py#L318-L358\n\nso when we pivort to using the new \ndatapath_offload filed in the base port prifile this will need to be updated to the standard VIFPortProfileOpenVSwitch\n\nthis is not an issue just calling this out","commit_id":"b05e453904cc3d26650982d6e9d81789f6eb190d"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"535cc506d14b60e3f788939bffc5cb8856e4fff8","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        if (isinstance(vif, os_vif.objects.vif.VIFHostDevice) and"},{"line_number":551,"context_line":"                vif.dev_type \u003d\u003d osv_fields.VIFHostDeviceDevType.GENERIC):"},{"line_number":552,"context_line":"            conf \u003d vconfig.LibvirtConfigGuestHostdevPCI()"},{"line_number":553,"context_line":"            pci_slot \u003d vif.port_profile.representor_address"},{"line_number":554,"context_line":"            designer.set_vif_host_backend_hostdev_pci_config(conf, pci_slot)"},{"line_number":555,"context_line":"        else:"},{"line_number":556,"context_line":"            # Do the config that\u0027s common to all vif types"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fb8cfa7_8690a850","line":553,"range":{"start_line":553,"start_character":12,"end_line":553,"end_character":59},"updated":"2019-06-18 13:41:36.000000000","message":"This is not going to work. It should be pci_slot \u003d vif.dev_address","commit_id":"350778eaec74919fa5a4115e52bb9cf81796f4f8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"747593bc0cce8068c5f8b84894413e80a6143dc4","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        if (isinstance(vif, os_vif.objects.vif.VIFHostDevice) and"},{"line_number":551,"context_line":"                vif.dev_type \u003d\u003d osv_fields.VIFHostDeviceDevType.GENERIC):"},{"line_number":552,"context_line":"            conf \u003d vconfig.LibvirtConfigGuestHostdevPCI()"},{"line_number":553,"context_line":"            pci_slot \u003d vif.port_profile.representor_address"},{"line_number":554,"context_line":"            designer.set_vif_host_backend_hostdev_pci_config(conf, pci_slot)"},{"line_number":555,"context_line":"        else:"},{"line_number":556,"context_line":"            # Do the config that\u0027s common to all vif types"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fb8cfa7_c638e03e","line":553,"range":{"start_line":553,"start_character":12,"end_line":553,"end_character":59},"in_reply_to":"9fb8cfa7_8690a850","updated":"2019-06-18 13:50:06.000000000","message":"vif.dev_address is the address of the VF that is added to the  vm and vif.port_profile.representor_address should be the pci address of the VF represtor port so i think you are correct.\ni also have not done a full review of this but ill try and get to it later in the week.","commit_id":"350778eaec74919fa5a4115e52bb9cf81796f4f8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bdc2728c7f0eca87df3d100725b48d6c63e98d3f","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        if (isinstance(vif, os_vif.objects.vif.VIFHostDevice) and"},{"line_number":551,"context_line":"                vif.dev_type \u003d\u003d osv_fields.VIFHostDeviceDevType.GENERIC):"},{"line_number":552,"context_line":"            conf \u003d vconfig.LibvirtConfigGuestHostdevPCI()"},{"line_number":553,"context_line":"            pci_slot \u003d vif.port_profile.representor_address"},{"line_number":554,"context_line":"            designer.set_vif_host_backend_hostdev_pci_config(conf, pci_slot)"},{"line_number":555,"context_line":"        else:"},{"line_number":556,"context_line":"            # Do the config that\u0027s common to all vif types"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fb8cfa7_4672b013","line":553,"range":{"start_line":553,"start_character":12,"end_line":553,"end_character":59},"in_reply_to":"9fb8cfa7_c638e03e","updated":"2019-06-18 13:54:04.000000000","message":"actully nlooking at https://review.opendev.org/#/c/658785/9/nova/network/os_vif_util.py they have the same value.\n\ni belive we are ment to prefer the adress in teh port profile but i will need to load up more context to review this properly i have not looked at this in almost a year so i need to read the related code too.","commit_id":"350778eaec74919fa5a4115e52bb9cf81796f4f8"}],"releasenotes/notes/ovs-dpdk-port-7c139573afaaec2f.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ebe7d1399097c97e3733c602622f13691b472475","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bfb3d3c7_ef7f4063","line":9,"updated":"2019-05-30 12:10:51.000000000","message":"can you add the minium version of ovs-dpdk required to make this work and mention the defualt limit of 32 ethdevs for dpdk type ports.","commit_id":"919a2da541c95f2ffade1d35dc1606255c800bcb"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"0ec1bbd433f106c540533f91138e024d5efbf5ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9fb8cfa7_3cd485bd","line":9,"in_reply_to":"bfb3d3c7_ef7f4063","updated":"2019-06-18 08:21:46.000000000","message":"Done","commit_id":"919a2da541c95f2ffade1d35dc1606255c800bcb"}]}