)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"49c34817ab835e7e415487c310700f636ee2c45f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"deeper layer."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This is manually backported from the placement repository:"},{"line_number":27,"context_line":"commit 727fb88dccfe8461cc40ae53ca2d4e40fd2a9c3c"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: I4efdc65395e69a6d33fba927018d003cce26fa68"},{"line_number":30,"context_line":"Closes-Bug: #1828937"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bfb3d3c7_8f9447ea","line":27,"range":{"start_line":27,"start_character":7,"end_line":27,"end_character":47},"updated":"2019-05-17 21:52:03.000000000","message":"Guess I would have expected 28a341acfd77fe34dc8948ddb663439f67dea7d6 for the placement stable/stein cherry pick.","commit_id":"8330ab4e61187c6bca5f38bac0afb2bb16280d06"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1691c70bdaa797604430bd2b2ee516b6eacaafb4","unresolved":false,"context_lines":[{"line_number":24,"context_line":"deeper layer."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This is manually backported from the placement repository:"},{"line_number":27,"context_line":"commit 727fb88dccfe8461cc40ae53ca2d4e40fd2a9c3c"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: I4efdc65395e69a6d33fba927018d003cce26fa68"},{"line_number":30,"context_line":"Closes-Bug: #1828937"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bfb3d3c7_2f851bae","line":27,"range":{"start_line":27,"start_character":7,"end_line":27,"end_character":47},"in_reply_to":"bfb3d3c7_8f9447ea","updated":"2019-05-17 21:52:57.000000000","message":"They\u0027re the same, and since it was manual...","commit_id":"8330ab4e61187c6bca5f38bac0afb2bb16280d06"}],"nova/api/openstack/placement/handlers/allocation_candidate.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"59a34d894523d35acef11e2a4abe2d2a646e9f9d","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    nested_aware \u003d want_version.matches((1, 29))"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    try:"},{"line_number":280,"context_line":"        cands \u003d rp_obj.AllocationCandidates.get_by_requests("},{"line_number":281,"context_line":"            context, requests, limit\u003dlimit, group_policy\u003dgroup_policy,"},{"line_number":282,"context_line":"            nested_aware\u003dnested_aware)"},{"line_number":283,"context_line":"    except exception.ResourceClassNotFound as exc:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_3328dd32","line":280,"range":{"start_line":280,"start_character":16,"end_line":280,"end_character":22},"updated":"2019-05-22 17:16:44.000000000","message":"My guess is there was a little conflict here because this was ac_obj in placement master but not noted in the commit message. Anyway, tests are passing.","commit_id":"8330ab4e61187c6bca5f38bac0afb2bb16280d06"}],"nova/api/openstack/placement/objects/resource_provider.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"efe1986daacb86723e30483b96976d25ff57828a","unresolved":false,"context_lines":[{"line_number":3983,"context_line":"    return areqs, psums"},{"line_number":3984,"context_line":""},{"line_number":3985,"context_line":""},{"line_number":3986,"context_line":"def _exclude_nested_providers(alloc_cands):"},{"line_number":3987,"context_line":"    \"\"\"Exclude allocation requests and provider summaries for old microversions"},{"line_number":3988,"context_line":"    if they involve more than one provider from the same tree."},{"line_number":3989,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_80aa2316","line":3986,"range":{"start_line":3986,"start_character":30,"end_line":3986,"end_character":41},"updated":"2019-05-15 16:04:50.000000000","message":"one arg","commit_id":"7e8d65a6ba91805a5e0b3df3a60d51ca573cf8c9"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"efe1986daacb86723e30483b96976d25ff57828a","unresolved":false,"context_lines":[{"line_number":4197,"context_line":""},{"line_number":4198,"context_line":"        if not nested_aware and has_trees:"},{"line_number":4199,"context_line":"            alloc_request_objs, summary_objs \u003d _exclude_nested_providers("},{"line_number":4200,"context_line":"                alloc_request_objs, summary_objs)"},{"line_number":4201,"context_line":""},{"line_number":4202,"context_line":"        # Limit the number of allocation request objects. We do this after"},{"line_number":4203,"context_line":"        # creating all of them so that we can do a random slice without"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_c0b49b82","line":4200,"range":{"start_line":4200,"start_character":16,"end_line":4200,"end_character":48},"updated":"2019-05-15 16:04:50.000000000","message":"two args\n\nHow is this not failing tests?\n\nIt is in rocky: http://logs.openstack.org/07/659207/1/check/nova-tox-functional/6cd1985/testr_results.html.gz","commit_id":"7e8d65a6ba91805a5e0b3df3a60d51ca573cf8c9"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"9bbd1c5d5666079ef9047e0f9d2947acbae586a4","unresolved":false,"context_lines":[{"line_number":4197,"context_line":""},{"line_number":4198,"context_line":"        if not nested_aware and has_trees:"},{"line_number":4199,"context_line":"            alloc_request_objs, summary_objs \u003d _exclude_nested_providers("},{"line_number":4200,"context_line":"                alloc_request_objs, summary_objs)"},{"line_number":4201,"context_line":""},{"line_number":4202,"context_line":"        # Limit the number of allocation request objects. We do this after"},{"line_number":4203,"context_line":"        # creating all of them so that we can do a random slice without"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_f233b012","line":4200,"range":{"start_line":4200,"start_character":16,"end_line":4200,"end_character":48},"in_reply_to":"dfbec78f_c0b49b82","updated":"2019-05-16 04:41:15.000000000","message":"Done.\n\n\u003e How is this not failing tests? It is in rocky\n\nI think this change in stein cycle is related. https://review.opendev.org/#/c/617941/","commit_id":"7e8d65a6ba91805a5e0b3df3a60d51ca573cf8c9"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"39497fa98f54d9f877e099e3187ab9b3568c30d4","unresolved":false,"context_lines":[{"line_number":4197,"context_line":""},{"line_number":4198,"context_line":"        if not nested_aware and has_trees:"},{"line_number":4199,"context_line":"            alloc_request_objs, summary_objs \u003d _exclude_nested_providers("},{"line_number":4200,"context_line":"                alloc_request_objs, summary_objs)"},{"line_number":4201,"context_line":""},{"line_number":4202,"context_line":"        # Limit the number of allocation request objects. We do this after"},{"line_number":4203,"context_line":"        # creating all of them so that we can do a random slice without"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_3ce1e9ff","line":4200,"range":{"start_line":4200,"start_character":16,"end_line":4200,"end_character":48},"in_reply_to":"dfbec78f_f233b012","updated":"2019-05-16 22:44:51.000000000","message":"Wow, that\u0027s kind of crazy. So how do we validate that this cherry-pick works?","commit_id":"7e8d65a6ba91805a5e0b3df3a60d51ca573cf8c9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"59a34d894523d35acef11e2a4abe2d2a646e9f9d","unresolved":false,"context_lines":[{"line_number":4072,"context_line":"            context, requests, limit\u003dlimit, group_policy\u003dgroup_policy,"},{"line_number":4073,"context_line":"            nested_aware\u003dnested_aware)"},{"line_number":4074,"context_line":"        return cls("},{"line_number":4075,"context_line":"            context,"},{"line_number":4076,"context_line":"            allocation_requests\u003dalloc_reqs,"},{"line_number":4077,"context_line":"            provider_summaries\u003dprovider_summaries,"},{"line_number":4078,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfb3d3c7_73bc15dc","line":4075,"range":{"start_line":4075,"start_character":12,"end_line":4075,"end_character":19},"updated":"2019-05-22 17:16:44.000000000","message":"There was likely also a conflict on this.","commit_id":"8330ab4e61187c6bca5f38bac0afb2bb16280d06"}]}