)]}'
{"nova/scheduler/host_manager.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8b27228ca5caaae256c9b39bd6d0275407bc4be2","unresolved":false,"context_lines":[{"line_number":538,"context_line":"                LOG.info(\"No nodes matched due to not matching \""},{"line_number":539,"context_line":"                         \"\u0027force_nodes\u0027 value of \u0027%s\u0027\", forced_nodes_str)"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"        def _get_hosts_matching_request(hosts, requested_destination):"},{"line_number":542,"context_line":"            (host, node) \u003d (requested_destination.host,"},{"line_number":543,"context_line":"                            requested_destination.node)"},{"line_number":544,"context_line":"            requested_nodes \u003d [x for x in hosts"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_e339a9d6","side":"PARENT","line":541,"updated":"2019-05-15 16:11:38.000000000","message":"Don\u0027t we still need to do this for the force-hosts case for ironic (when there are multiple nodes possible)?\n\nhttps://review.opendev.org/#/c/650878/7/nova/scheduler/utils.py@530","commit_id":"daa2ac2287df12dfdee532d66ef97a03350ca6af"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"5b9a79e1f38aff4bb049e2d0daf637f39fd370b5","unresolved":false,"context_lines":[{"line_number":538,"context_line":"                LOG.info(\"No nodes matched due to not matching \""},{"line_number":539,"context_line":"                         \"\u0027force_nodes\u0027 value of \u0027%s\u0027\", forced_nodes_str)"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"        def _get_hosts_matching_request(hosts, requested_destination):"},{"line_number":542,"context_line":"            (host, node) \u003d (requested_destination.host,"},{"line_number":543,"context_line":"                            requested_destination.node)"},{"line_number":544,"context_line":"            requested_nodes \u003d [x for x in hosts"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_785d5a13","side":"PARENT","line":541,"in_reply_to":"dfbec78f_b83992d7","updated":"2019-05-16 09:02:38.000000000","message":"wait, no. The ironic still report each node as RP to the Placement. So we needn\u0027t this for ironic also.","commit_id":"daa2ac2287df12dfdee532d66ef97a03350ca6af"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"79119333a345a162e1e1c4981288c92b21a208ca","unresolved":false,"context_lines":[{"line_number":538,"context_line":"                LOG.info(\"No nodes matched due to not matching \""},{"line_number":539,"context_line":"                         \"\u0027force_nodes\u0027 value of \u0027%s\u0027\", forced_nodes_str)"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"        def _get_hosts_matching_request(hosts, requested_destination):"},{"line_number":542,"context_line":"            (host, node) \u003d (requested_destination.host,"},{"line_number":543,"context_line":"                            requested_destination.node)"},{"line_number":544,"context_line":"            requested_nodes \u003d [x for x in hosts"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_b83992d7","side":"PARENT","line":541,"in_reply_to":"dfbec78f_e339a9d6","updated":"2019-05-16 08:57:35.000000000","message":"right...we still need this for ironic. But for the ironic case, if we specified the node, then https://review.opendev.org/#/c/650878/7/nova/scheduler/utils.py@526 will be wrong, since there is no ironic node in the placement.","commit_id":"daa2ac2287df12dfdee532d66ef97a03350ca6af"}]}
