)]}'
{"id":"openstack%2Fnova~659317","triplet_id":"openstack%2Fnova~stable%2Fstein~I01c63e685113bf30e687ccb14a4d18e344b306f6","project":"openstack/nova","branch":"stable/stein","topic":"bug1821373","hashtags":[],"change_id":"I01c63e685113bf30e687ccb14a4d18e344b306f6","subject":"Fix retry of instance_update_and_get_original","status":"MERGED","created":"2019-05-15 15:30:46.000000000","updated":"2019-05-21 19:31:59.000000000","submitted":"2019-05-21 19:31:59.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"659317-1558467119164-d1a6a7d1","meta_rev_id":"b42e0826d4a6dfb5175dbbd8a1431b93b7ed5c25","_number":659317,"virtual_id_number":659317,"owner":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-05-15 16:43:23.000000000","_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-05-15 17:43:50.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-05-15 17:04:29.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":2,"date":"2019-05-21 19:31:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2019-05-20 10:49:01.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2019-05-21 16:55:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"all":[{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":1,"date":"2019-05-21 16:55:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-05-20 10:59:13.000000000","_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-15 16:43:23.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-05-15 17:04:29.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-05-15 17:43:50.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-05-20 10:49:01.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-05-20 10:59:13.000000000","updated_by":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"reviewer":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"state":"REVIEWER"},{"updated":"2019-05-21 16:55:09.000000000","updated_by":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"reviewer":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"state":"REVIEWER"},{"updated":"2019-05-21 19:31:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4dbe9353277c613a065788b1d7e48152f246b8d7","author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"date":"2019-05-15 15:30:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d0c3b4910a6992591a3d4542135127c5a0199210","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2019-05-15 16:43:23.000000000","message":"Patch Set 1:\n\nTesting failed ubuntu-xenial-s390x. For rechecking only on the ubuntu-xenial-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/659317/1/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/54eb7ac : FAILURE in 1h 04m 53s","accounts_in_message":[],"_revision_number":1},{"id":"44ee382d7f1e3d17140f75f828323c6d17d5a6bf","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-05-15 17:04:29.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/17/659317/1/check/tempest-dsvm-full-xenial/8f75fbd/ : SUCCESS in 1h 22m 15s\n- tempest-dsvm-full-xenial-py3 https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/17/659317/1/check/tempest-dsvm-full-xenial-py3/e6a2ac3/ : SUCCESS in 1h 32m 59s (non-voting)\n- grenade-dsvm-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/17/659317/1/check/grenade-dsvm-xenial/cf71382/ : SUCCESS in 1h 09m 01s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"51775986929044df1c58919eeeccd132d4d05da2","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-05-15 17:43:50.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/659317/1 : FAILURE in 2h 12m 19s","accounts_in_message":[],"_revision_number":1},{"id":"14072300f7c9c03ff8c79ecef27411fea4edd7b8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-15 18:09:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/17/659317/1/check/grenade-py3/32bf704/ : SUCCESS in 58m 11s\n- tempest-full-py3 http://logs.openstack.org/17/659317/1/check/tempest-full-py3/d456e5f/ : SUCCESS in 1h 34m 30s\n- openstack-tox-cover http://logs.openstack.org/17/659317/1/check/openstack-tox-cover/1aae5ed/cover/ : SUCCESS in 13m 37s\n- openstack-tox-lower-constraints http://logs.openstack.org/17/659317/1/check/openstack-tox-lower-constraints/68b85e2/ : SUCCESS in 11m 32s\n- openstack-tox-pep8 http://logs.openstack.org/17/659317/1/check/openstack-tox-pep8/36f3958/ : SUCCESS in 10m 11s\n- openstack-tox-py27 http://logs.openstack.org/17/659317/1/check/openstack-tox-py27/9fc6d4c/ : SUCCESS in 11m 10s\n- openstack-tox-py35 http://logs.openstack.org/17/659317/1/check/openstack-tox-py35/dcc0d69/ : SUCCESS in 15m 02s\n- openstack-tox-py36 http://logs.openstack.org/17/659317/1/check/openstack-tox-py36/8f0fb2f/ : SUCCESS in 12m 03s\n- openstack-tox-py37 http://logs.openstack.org/17/659317/1/check/openstack-tox-py37/2bf3dec/ : SUCCESS in 12m 08s\n- openstack-tox-docs http://logs.openstack.org/17/659317/1/check/openstack-tox-docs/59d69b8/html/ : SUCCESS in 5m 33s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/17/659317/1/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/d7f01ba/ : FAILURE in 40m 17s (non-voting)\n- devstack-plugin-ceph-tempest http://logs.openstack.org/17/659317/1/check/devstack-plugin-ceph-tempest/a01bc7c/ : SUCCESS in 1h 27m 02s (non-voting)\n- neutron-grenade-multinode http://logs.openstack.org/17/659317/1/check/neutron-grenade-multinode/9ffb87a/ : SUCCESS in 1h 07m 44s\n- nova-grenade-live-migration http://logs.openstack.org/17/659317/1/check/nova-grenade-live-migration/46e372f/ : SUCCESS in 57m 56s\n- nova-live-migration http://logs.openstack.org/17/659317/1/check/nova-live-migration/753fad0/ : SUCCESS in 45m 58s\n- nova-next http://logs.openstack.org/17/659317/1/check/nova-next/bb1a737/ : SUCCESS in 1h 25m 35s\n- nova-tox-functional http://logs.openstack.org/17/659317/1/check/nova-tox-functional/73c4bdd/ : SUCCESS in 18m 30s\n- nova-tox-functional-py35 http://logs.openstack.org/17/659317/1/check/nova-tox-functional-py35/6cb8181/ : SUCCESS in 19m 16s\n- tempest-multinode-full http://logs.openstack.org/17/659317/1/check/tempest-multinode-full/d7e2636/ : SUCCESS in 1h 49m 28s (non-voting)\n- tempest-slow-py3 http://logs.openstack.org/17/659317/1/check/tempest-slow-py3/33f9319/ : SUCCESS in 2h 18m 26s","accounts_in_message":[],"_revision_number":1},{"id":"f2e76fe481217f92d02770fb969ea783630b9de5","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-05-20 10:49:01.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM, clean and useful.","accounts_in_message":[],"_revision_number":1},{"id":"66196ed6d641a101390871c4f59ea58f64c7b214","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2019-05-21 16:55:09.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"6cfa944dbfd00864c760b6e14f8d7b67d2aa2a8b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-21 16:56:02.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"6f06dc04447fd587389a39fae4666d432ecd71dd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-21 19:31:58.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 http://logs.openstack.org/17/659317/1/gate/grenade-py3/a52ecb5/ : SUCCESS in 1h 23m 46s\n- tempest-full-py3 http://logs.openstack.org/17/659317/1/gate/tempest-full-py3/79e3fdd/ : SUCCESS in 1h 26m 27s\n- openstack-tox-lower-constraints http://logs.openstack.org/17/659317/1/gate/openstack-tox-lower-constraints/30fb43d/ : SUCCESS in 14m 35s\n- openstack-tox-pep8 http://logs.openstack.org/17/659317/1/gate/openstack-tox-pep8/6b4bbc1/ : SUCCESS in 10m 28s\n- openstack-tox-py27 http://logs.openstack.org/17/659317/1/gate/openstack-tox-py27/30141da/ : SUCCESS in 14m 08s\n- openstack-tox-py35 http://logs.openstack.org/17/659317/1/gate/openstack-tox-py35/de0c6bd/ : SUCCESS in 13m 39s\n- openstack-tox-py36 http://logs.openstack.org/17/659317/1/gate/openstack-tox-py36/0262e3a/ : SUCCESS in 12m 47s\n- openstack-tox-py37 http://logs.openstack.org/17/659317/1/gate/openstack-tox-py37/f583583/ : SUCCESS in 11m 47s\n- openstack-tox-docs http://logs.openstack.org/17/659317/1/gate/openstack-tox-docs/5a4f365/html/ : SUCCESS in 6m 23s\n- nova-grenade-live-migration http://logs.openstack.org/17/659317/1/gate/nova-grenade-live-migration/cc6f75e/ : SUCCESS in 1h 08m 39s\n- nova-live-migration http://logs.openstack.org/17/659317/1/gate/nova-live-migration/35d8ce9/ : SUCCESS in 50m 18s\n- nova-tox-functional http://logs.openstack.org/17/659317/1/gate/nova-tox-functional/8892778/ : SUCCESS in 17m 19s\n- nova-tox-functional-py35 http://logs.openstack.org/17/659317/1/gate/nova-tox-functional-py35/d32e2f8/ : SUCCESS in 22m 46s\n- nova-next http://logs.openstack.org/17/659317/1/gate/nova-next/a1cbdb5/ : SUCCESS in 1h 19m 47s\n- tempest-slow-py3 http://logs.openstack.org/17/659317/1/gate/tempest-slow-py3/42ce50f/ : SUCCESS in 2h 19m 46s","accounts_in_message":[],"_revision_number":1},{"id":"a0c2c3911705b7db556a0e12c51c8c00e552393f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-21 19:31:59.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"61fef49b1555c6509398fc47c21319c1b5e50505","revisions":{"61fef49b1555c6509398fc47c21319c1b5e50505":{"kind":"REWORK","_number":1,"created":"2019-05-15 15:30:46.000000000","uploader":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"ref":"refs/changes/17/659317/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/17/659317/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/659317/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/659317/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/659317/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/17/659317/1"}}},"commit":{"parents":[{"commit":"d7d7f115430c7ffeb88ec9dcd155ac69b29d7513","subject":"Add functional confirm_migration_error test","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d7d7f115430c7ffeb88ec9dcd155ac69b29d7513"}]}],"author":{"name":"Matthew Booth","email":"mbooth@redhat.com","date":"2019-05-13 15:04:39.000000000","tz":60},"committer":{"name":"Matthew Booth","email":"mbooth@redhat.com","date":"2019-05-15 15:29:53.000000000","tz":60},"subject":"Fix retry of instance_update_and_get_original","message":"Fix retry of instance_update_and_get_original\n\n_instance_update modifies its \u0027values\u0027 argument. Consequently if it is\nretried due to an update conflict, the second invocation has the wrong\narguments.\n\nA specific issue this causes is that if we called it with\nexpected_task_state a concurrent modification to task_state will cause\nus to fail and retry. However, expected_task_state will have been popped\nfrom values on the first invocation and will not be present for the\nsecond. Consequently the second invocation will fail to perform the\ntask_state check and therefore succeed, resulting in a race.\n\nWe rewrite the old race unit test which wasn\u0027t testing the correct\nthing for 2 reasons:\n\n1. Due to the bug fixed in this patch, although we were calling\n   update_on_match() twice, the second call didn\u0027t check the task state.\n2. side_effect\u003diterable returns function items without executing them,\n   but we weren\u0027t hitting this due to the bug fixed in this patch.\n\nCloses-Bug: #1821373\nChange-Id: I01c63e685113bf30e687ccb14a4d18e344b306f6\n(cherry picked from commit aae5c7aa3819ad9161fd2effed3872d540099230)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/61fef49b1555c6509398fc47c21319c1b5e50505"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/61fef49b1555c6509398fc47c21319c1b5e50505"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}