)]}'
{"id":"openstack%2Fnova~659320","triplet_id":"openstack%2Fnova~stable%2Fqueens~I01c63e685113bf30e687ccb14a4d18e344b306f6","project":"openstack/nova","branch":"stable/queens","topic":"bug1821373","hashtags":[],"change_id":"I01c63e685113bf30e687ccb14a4d18e344b306f6","subject":"Fix retry of instance_update_and_get_original","status":"MERGED","created":"2019-05-15 15:33:01.000000000","updated":"2019-07-01 20:34:09.000000000","submitted":"2019-07-01 20:34:08.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"659320-1562013249422-daa3b747","meta_rev_id":"102726557891a2e84852b447236125a365cdae0a","_number":659320,"virtual_id_number":659320,"owner":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-05-20 10:58:52.000000000","_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-05-24 05:56:42.000000000","_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"date":"2019-05-24 10:06:31.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-05-22 06:12:35.000000000","_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"date":"2019-05-24 10:50:31.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-07-01 20:34:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2019-05-30 08:49:19.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2019-07-01 15:25:14.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-05-24 09:22:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":1,"date":"2019-07-01 15:25:14.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-15 17:52:09.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-05-20 10:58:52.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-05-22 06:12:35.000000000","updated_by":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-05-24 05:56:42.000000000","updated_by":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"reviewer":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"state":"REVIEWER"},{"updated":"2019-05-24 09:22:45.000000000","updated_by":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"reviewer":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"state":"REVIEWER"},{"updated":"2019-05-24 10:06:31.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-05-24 10:50:31.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-05-30 08:49:19.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-07-01 15:25:14.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-07-01 20:34:08.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8231681f2ba09bdfdb958ede12be454f45a53cd0","author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"date":"2019-05-15 15:33:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"85dbd26150d6ef8d49498f667e459171a4a6016e","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-05-15 15:33:57.000000000","message":"Patch Set 1:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/20/659320/1/check/nova-out-of-tree-pvm/c02812c : FAILURE in 6s\n- nova-in-tree-pvm http://184.172.12.213/20/659320/1/check/nova-in-tree-pvm/f03b243 : FAILURE in 7s","accounts_in_message":[],"_revision_number":1},{"id":"be01a8fc55377d45f9b5fed970ec1017f9baca60","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-05-15 16:18:22.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/659320/1 : FAILURE in 44m 25s","accounts_in_message":[],"_revision_number":1},{"id":"aa330ca975bb6453fed666b60cb57be34d058d0b","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-05-15 16:49:30.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/20/659320/1/check/tempest-dsvm-full-xenial/16ed76a/ : SUCCESS in 1h 12m 36s\n- tempest-dsvm-full-xenial-py3 https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/20/659320/1/check/tempest-dsvm-full-xenial-py3/c957fa1/ : FAILURE in 1h 05m 24s (non-voting)\n- grenade-dsvm-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/20/659320/1/check/grenade-dsvm-xenial/a301001/ : FAILURE in 1h 15m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e3a7c8468efe20de412ff2b720e5e2f5cefdea02","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2019-05-15 17:52:09.000000000","message":"Patch Set 1:\n\nTesting failed ubuntu-xenial-s390x. For rechecking only on the ubuntu-xenial-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/659320/1/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/30b1f35 : FAILURE in 1h 03m 59s","accounts_in_message":[],"_revision_number":1},{"id":"cea7f896db785b473963164ff23756b2c303f80f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-15 18:42:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/20/659320/1/check/openstack-tox-pep8/2b51d95/ : SUCCESS in 9m 15s\n- openstack-tox-py27 http://logs.openstack.org/20/659320/1/check/openstack-tox-py27/fcd4fe9/ : SUCCESS in 16m 22s\n- openstack-tox-py35 http://logs.openstack.org/20/659320/1/check/openstack-tox-py35/75ecce2/ : SUCCESS in 12m 59s\n- build-openstack-sphinx-docs http://logs.openstack.org/20/659320/1/check/build-openstack-sphinx-docs/9fc057a/html/ : SUCCESS in 6m 13s\n- tempest-full http://logs.openstack.org/20/659320/1/check/tempest-full/d7972ad/ : SUCCESS in 1h 26m 44s\n- neutron-grenade http://logs.openstack.org/20/659320/1/check/neutron-grenade/0e30797/ : SUCCESS in 1h 00m 49s\n- tempest-full-py3 http://logs.openstack.org/20/659320/1/check/tempest-full-py3/a055a38/ : SUCCESS in 1h 26m 47s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/20/659320/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/5a5efca/ : SUCCESS in 48m 58s (non-voting)\n- nova-cells-v1 http://logs.openstack.org/20/659320/1/check/nova-cells-v1/a3cc13b/ : SUCCESS in 46m 27s\n- nova-grenade-live-migration http://logs.openstack.org/20/659320/1/check/nova-grenade-live-migration/a926770/ : FAILURE in 3m 57s (non-voting)\n- nova-live-migration http://logs.openstack.org/20/659320/1/check/nova-live-migration/e0c4e9a/ : SUCCESS in 50m 58s\n- nova-multiattach http://logs.openstack.org/20/659320/1/check/nova-multiattach/6015477/ : SUCCESS in 1h 01m 05s\n- nova-next http://logs.openstack.org/20/659320/1/check/nova-next/60cb95e/ : SUCCESS in 1h 24m 49s\n- tempest-slow http://logs.openstack.org/20/659320/1/check/tempest-slow/00316bd/ : SUCCESS in 1h 56m 23s\n- nova-tox-functional http://logs.openstack.org/20/659320/1/check/nova-tox-functional/f81c613/ : SUCCESS in 18m 34s\n- nova-tox-functional-py35 http://logs.openstack.org/20/659320/1/check/nova-tox-functional-py35/179a487/ : SUCCESS in 19m 01s\n- neutron-grenade-multinode http://logs.openstack.org/20/659320/1/check/neutron-grenade-multinode/bd79ace/ : SUCCESS in 1h 08m 43s\n- devstack-plugin-ceph-tempest http://logs.openstack.org/20/659320/1/check/devstack-plugin-ceph-tempest/3a399e7/ : SUCCESS in 1h 21m 01s (non-voting)\n- tempest-multinode-full http://logs.openstack.org/20/659320/1/check/tempest-multinode-full/ab490fc/ : SUCCESS in 1h 40m 01s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8747f5fe787a8482c668803f6ee43c8879e8b96b","author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"date":"2019-05-20 10:58:04.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"9ba499408682675a9b3d2558ed71ac7a9dece0d3","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-05-20 10:58:52.000000000","message":"Patch Set 2:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/20/659320/2/check/nova-out-of-tree-pvm/ca24fa6 : FAILURE in 6s\n- nova-in-tree-pvm http://184.172.12.213/20/659320/2/check/nova-in-tree-pvm/5cf6f95 : FAILURE in 7s","accounts_in_message":[],"_revision_number":2},{"id":"e93dd19b567f31d0cbe835ef66b428300797052a","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-05-20 12:12:17.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/20/659320/2/check/tempest-dsvm-full-xenial/9a83bb1/ : SUCCESS in 1h 13m 17s\n- tempest-dsvm-full-xenial-py3 https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/20/659320/2/check/tempest-dsvm-full-xenial-py3/b7dc678/ : FAILURE in 1h 09m 52s (non-voting)\n- grenade-dsvm-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/20/659320/2/check/grenade-dsvm-xenial/5cf1f46/ : SUCCESS in 53m 24s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"36b615f9e06d3d20c422dcbb0f31094c6134e8d5","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-05-20 13:06:21.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/659320/2 : FAILURE in 46m 43s","accounts_in_message":[],"_revision_number":2},{"id":"20aa383454c5551745894997e130215ae5aa118a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-20 17:33:29.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/20/659320/2/check/openstack-tox-pep8/88416b1/ : SUCCESS in 10m 10s\n- openstack-tox-py27 http://logs.openstack.org/20/659320/2/check/openstack-tox-py27/20f59bd/ : SUCCESS in 12m 17s\n- openstack-tox-py35 http://logs.openstack.org/20/659320/2/check/openstack-tox-py35/b2dd712/ : SUCCESS in 14m 34s\n- build-openstack-sphinx-docs http://logs.openstack.org/20/659320/2/check/build-openstack-sphinx-docs/4dcc765/html/ : SUCCESS in 6m 25s\n- tempest-full http://logs.openstack.org/20/659320/2/check/tempest-full/62859d0/ : SUCCESS in 1h 48m 11s\n- neutron-grenade http://logs.openstack.org/20/659320/2/check/neutron-grenade/9299b8c/ : SUCCESS in 54m 38s\n- tempest-full-py3 http://logs.openstack.org/20/659320/2/check/tempest-full-py3/9853865/ : SUCCESS in 1h 20m 28s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/20/659320/2/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/4f99d1c/ : SUCCESS in 47m 31s (non-voting)\n- nova-cells-v1 http://logs.openstack.org/20/659320/2/check/nova-cells-v1/3012811/ : SUCCESS in 46m 06s\n- nova-grenade-live-migration http://logs.openstack.org/20/659320/2/check/nova-grenade-live-migration/f0eb26a/ : SUCCESS in 1h 02m 31s (non-voting)\n- nova-live-migration http://logs.openstack.org/20/659320/2/check/nova-live-migration/a8ee0a0/ : SUCCESS in 55m 03s\n- nova-multiattach http://logs.openstack.org/20/659320/2/check/nova-multiattach/37920e0/ : SUCCESS in 57m 04s\n- nova-next http://logs.openstack.org/20/659320/2/check/nova-next/75d7be3/ : SUCCESS in 1h 18m 54s\n- tempest-slow http://logs.openstack.org/20/659320/2/check/tempest-slow/a80df21/ : SUCCESS in 1h 48m 14s\n- nova-tox-functional http://logs.openstack.org/20/659320/2/check/nova-tox-functional/ef858a8/ : SUCCESS in 24m 51s\n- nova-tox-functional-py35 http://logs.openstack.org/20/659320/2/check/nova-tox-functional-py35/7ad1971/ : SUCCESS in 21m 48s\n- neutron-grenade-multinode http://logs.openstack.org/20/659320/2/check/neutron-grenade-multinode/7d368bc/ : FAILURE in 44m 59s\n- devstack-plugin-ceph-tempest http://logs.openstack.org/20/659320/2/check/devstack-plugin-ceph-tempest/f50d097/ : FAILURE in 1h 19m 51s (non-voting)\n- tempest-multinode-full http://logs.openstack.org/20/659320/2/check/tempest-multinode-full/6eb258f/ : SUCCESS in 1h 35m 11s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"79ad5e0379b6745cc6414a5b02c02589057aae88","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2019-05-22 06:12:35.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- Nova-ML2-Sriov http://13.74.249.42/20/659320/2/check-nova/Nova-ML2-Sriov/2d3d814 : FAILURE in 31m 11s (non-voting)\n- Nova-MACVTAP-ML2-Sriov http://13.74.249.42/20/659320/2/check-nova/Nova-MACVTAP-ML2-Sriov/ae906a5 : FAILURE in 1h 08m 31s (non-voting)\n\nTo re-run the job post \u0027recheck nova-mlnx\u0027 comment. For more information visit https://wiki.openstack.org/wiki/ThirdPartySystems/Mellanox_CI","accounts_in_message":[],"_revision_number":2},{"id":"bfa93abbedd34006056db7f5059851cd710b8c25","author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"date":"2019-05-24 05:56:42.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"ff55dd8b4b00fb9e87aceafa7c839423d71324fb","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-05-24 06:41:42.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/659320/2 : FAILURE in 44m 23s","accounts_in_message":[],"_revision_number":2},{"id":"997592d50b728a57a15d7a621ba1dc2923c8ae07","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-05-24 07:02:37.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/20/659320/2/check/tempest-dsvm-full-xenial/c1b27ca/ : SUCCESS in 59m 50s\n- tempest-dsvm-full-xenial-py3 https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/20/659320/2/check/tempest-dsvm-full-xenial-py3/040f8ca/ : FAILURE in 1h 05m 12s (non-voting)\n- grenade-dsvm-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/20/659320/2/check/grenade-dsvm-xenial/414a099/ : SUCCESS in 1h 01m 35s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"7400104dcf3cfe6320a81379c14046d7149ba48c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-24 08:19:21.000000000","message":"Patch Set 2:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/20/659320/2/check/openstack-tox-pep8/bac962f/ : SUCCESS in 10m 14s\n- openstack-tox-py27 http://logs.openstack.org/20/659320/2/check/openstack-tox-py27/684666f/ : SUCCESS in 14m 53s\n- openstack-tox-py35 http://logs.openstack.org/20/659320/2/check/openstack-tox-py35/ba90980/ : SUCCESS in 16m 09s\n- build-openstack-sphinx-docs http://logs.openstack.org/20/659320/2/check/build-openstack-sphinx-docs/4db8916/html/ : SUCCESS in 6m 47s\n- tempest-full http://logs.openstack.org/20/659320/2/check/tempest-full/67c371e/ : SUCCESS in 2h 04m 27s\n- neutron-grenade http://logs.openstack.org/20/659320/2/check/neutron-grenade/4738776/ : SUCCESS in 1h 28m 49s\n- tempest-full-py3 http://logs.openstack.org/20/659320/2/check/tempest-full-py3/9265319/ : SUCCESS in 1h 57m 01s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/20/659320/2/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/48976db/ : SUCCESS in 1h 12m 15s (non-voting)\n- nova-cells-v1 http://logs.openstack.org/20/659320/2/check/nova-cells-v1/cf78659/ : SUCCESS in 49m 43s\n- nova-grenade-live-migration http://logs.openstack.org/20/659320/2/check/nova-grenade-live-migration/3d9d3df/ : SUCCESS in 1h 33m 07s (non-voting)\n- nova-live-migration http://logs.openstack.org/20/659320/2/check/nova-live-migration/f0568dd/ : SUCCESS in 52m 27s\n- nova-multiattach http://logs.openstack.org/20/659320/2/check/nova-multiattach/91f5c89/ : FAILURE in 1h 02m 37s\n- nova-next http://logs.openstack.org/20/659320/2/check/nova-next/d9a2a90/ : SUCCESS in 1h 56m 01s\n- tempest-slow http://logs.openstack.org/20/659320/2/check/tempest-slow/7a7855f/ : SUCCESS in 1h 48m 22s\n- nova-tox-functional http://logs.openstack.org/20/659320/2/check/nova-tox-functional/adede5f/ : SUCCESS in 19m 02s\n- nova-tox-functional-py35 http://logs.openstack.org/20/659320/2/check/nova-tox-functional-py35/f0a1331/ : SUCCESS in 23m 59s\n- neutron-grenade-multinode http://logs.openstack.org/20/659320/2/check/neutron-grenade-multinode/47583f6/ : SUCCESS in 1h 02m 30s\n- devstack-plugin-ceph-tempest http://logs.openstack.org/20/659320/2/check/devstack-plugin-ceph-tempest/f949f16/ : SUCCESS in 1h 46m 00s (non-voting)\n- tempest-multinode-full http://logs.openstack.org/20/659320/2/check/tempest-multinode-full/cfbd6b7/ : SUCCESS in 1h 55m 35s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"b3dd00210f4dec2ee060751098ff3421a7b14a29","author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"date":"2019-05-24 09:22:45.000000000","message":"Patch Set 2: Code-Review+1\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"709447da25e410700a123b17a23841eb6624f563","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-05-24 10:06:31.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/659320/2 : FAILURE in 43m 10s","accounts_in_message":[],"_revision_number":2},{"id":"a40e7affa60b8df40fd028fbfe8efbf164031139","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-05-24 10:50:31.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/20/659320/2/check/tempest-dsvm-full-xenial/a33794a/ : SUCCESS in 1h 13m 31s\n- tempest-dsvm-full-xenial-py3 https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/20/659320/2/check/tempest-dsvm-full-xenial-py3/657dd38/ : FAILURE in 1h 27m 05s (non-voting)\n- grenade-dsvm-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/20/659320/2/check/grenade-dsvm-xenial/cd3fb21/ : SUCCESS in 1h 08m 15s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"a8486c7a867a26b422f55dde07785dcd6cd5f0b0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-24 11:16:27.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/20/659320/2/check/openstack-tox-pep8/11899b3/ : SUCCESS in 8m 57s\n- openstack-tox-py27 http://logs.openstack.org/20/659320/2/check/openstack-tox-py27/a9bea47/ : SUCCESS in 19m 04s\n- openstack-tox-py35 http://logs.openstack.org/20/659320/2/check/openstack-tox-py35/23455d8/ : SUCCESS in 14m 49s\n- build-openstack-sphinx-docs http://logs.openstack.org/20/659320/2/check/build-openstack-sphinx-docs/cb35641/html/ : SUCCESS in 6m 34s\n- tempest-full http://logs.openstack.org/20/659320/2/check/tempest-full/2924628/ : SUCCESS in 1h 37m 26s\n- neutron-grenade http://logs.openstack.org/20/659320/2/check/neutron-grenade/7fbba68/ : SUCCESS in 59m 30s\n- tempest-full-py3 http://logs.openstack.org/20/659320/2/check/tempest-full-py3/855e857/ : SUCCESS in 1h 16m 51s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/20/659320/2/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/bfd798c/ : SUCCESS in 50m 21s (non-voting)\n- nova-cells-v1 http://logs.openstack.org/20/659320/2/check/nova-cells-v1/4639847/ : SUCCESS in 48m 52s\n- nova-grenade-live-migration http://logs.openstack.org/20/659320/2/check/nova-grenade-live-migration/72a09dd/ : SUCCESS in 57m 56s (non-voting)\n- nova-live-migration http://logs.openstack.org/20/659320/2/check/nova-live-migration/1e6a7be/ : SUCCESS in 40m 56s\n- nova-multiattach http://logs.openstack.org/20/659320/2/check/nova-multiattach/ba65a63/ : SUCCESS in 58m 49s\n- nova-next http://logs.openstack.org/20/659320/2/check/nova-next/70f57d7/ : SUCCESS in 1h 17m 04s\n- tempest-slow http://logs.openstack.org/20/659320/2/check/tempest-slow/835f91f/ : SUCCESS in 1h 47m 30s\n- nova-tox-functional http://logs.openstack.org/20/659320/2/check/nova-tox-functional/673463e/ : SUCCESS in 19m 59s\n- nova-tox-functional-py35 http://logs.openstack.org/20/659320/2/check/nova-tox-functional-py35/d79a010/ : SUCCESS in 25m 42s\n- neutron-grenade-multinode http://logs.openstack.org/20/659320/2/check/neutron-grenade-multinode/983151d/ : SUCCESS in 1h 05m 40s\n- devstack-plugin-ceph-tempest http://logs.openstack.org/20/659320/2/check/devstack-plugin-ceph-tempest/74a86fe/ : SUCCESS in 1h 18m 38s (non-voting)\n- tempest-multinode-full http://logs.openstack.org/20/659320/2/check/tempest-multinode-full/de681f7/ : SUCCESS in 1h 38m 02s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"ba516c984cd59c09863cc6646f0fdcc00a8ab237","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-05-30 08:49:19.000000000","message":"Patch Set 2: Code-Review+2\n\nLGTM, in the stable/rocky gate now.","accounts_in_message":[],"_revision_number":2},{"id":"1bce3fbed2989741286503b459e9c4661907c8e4","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-01 15:25:14.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nClean backport and the rocky version is released so lgtm.","accounts_in_message":[],"_revision_number":2},{"id":"7a5d3a55b425ce75183d25ef80c06eca2c8702ae","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-01 15:26:59.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"75d2a6c2d3cb0a2100870731b6018981bf41a1b9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-01 20:34:08.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/20/659320/2/gate/openstack-tox-pep8/d0a2d9a/ : SUCCESS in 9m 49s\n- openstack-tox-py27 http://logs.openstack.org/20/659320/2/gate/openstack-tox-py27/70e37a8/ : SUCCESS in 13m 38s\n- openstack-tox-py35 http://logs.openstack.org/20/659320/2/gate/openstack-tox-py35/70d5a9c/ : SUCCESS in 15m 27s\n- build-openstack-sphinx-docs http://logs.openstack.org/20/659320/2/gate/build-openstack-sphinx-docs/370aaa7/html/ : SUCCESS in 7m 45s\n- tempest-full http://logs.openstack.org/20/659320/2/gate/tempest-full/22e8629/ : SUCCESS in 1h 23m 34s\n- neutron-grenade http://logs.openstack.org/20/659320/2/gate/neutron-grenade/28d2619/ : SUCCESS in 54m 03s\n- tempest-full-py3 http://logs.openstack.org/20/659320/2/gate/tempest-full-py3/3f5555d/ : SUCCESS in 1h 23m 13s\n- nova-cells-v1 http://logs.openstack.org/20/659320/2/gate/nova-cells-v1/d639865/ : SUCCESS in 47m 02s\n- nova-live-migration http://logs.openstack.org/20/659320/2/gate/nova-live-migration/88f6fda/ : SUCCESS in 46m 26s\n- nova-multiattach http://logs.openstack.org/20/659320/2/gate/nova-multiattach/7d7b9d6/ : SUCCESS in 58m 01s\n- nova-next http://logs.openstack.org/20/659320/2/gate/nova-next/e3820d6/ : SUCCESS in 1h 14m 45s\n- tempest-slow http://logs.openstack.org/20/659320/2/gate/tempest-slow/693a374/ : SUCCESS in 1h 52m 28s\n- nova-tox-functional http://logs.openstack.org/20/659320/2/gate/nova-tox-functional/6e2d5e7/ : SUCCESS in 20m 26s\n- nova-tox-functional-py35 http://logs.openstack.org/20/659320/2/gate/nova-tox-functional-py35/267df8f/ : SUCCESS in 18m 53s","accounts_in_message":[],"_revision_number":2},{"id":"98339f5176cfa8ebaff05d2ec04edd952d37cc41","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-01 20:34:09.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f9c2503609bfad0b871d9e87227aa2bb5c137467","revisions":{"24eebc26078607ad9765e1487ccd832d19037754":{"kind":"REWORK","_number":1,"created":"2019-05-15 15:33:01.000000000","uploader":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"ref":"refs/changes/20/659320/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/20/659320/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/659320/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/659320/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/659320/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/20/659320/1"}}},"commit":{"parents":[{"commit":"01141392db549728e78865b6a56468d17102bee0","subject":"Use migration_status during volume migrating and retyping","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/01141392db549728e78865b6a56468d17102bee0"}]}],"author":{"name":"Matthew Booth","email":"mbooth@redhat.com","date":"2019-05-13 15:04:39.000000000","tz":60},"committer":{"name":"Matthew Booth","email":"mbooth@redhat.com","date":"2019-05-15 15:32:45.000000000","tz":60},"subject":"Fix retry of instance_update_and_get_original","message":"Fix retry of instance_update_and_get_original\n\n_instance_update modifies its \u0027values\u0027 argument. Consequently if it is\nretried due to an update conflict, the second invocation has the wrong\narguments.\n\nA specific issue this causes is that if we called it with\nexpected_task_state a concurrent modification to task_state will cause\nus to fail and retry. However, expected_task_state will have been popped\nfrom values on the first invocation and will not be present for the\nsecond. Consequently the second invocation will fail to perform the\ntask_state check and therefore succeed, resulting in a race.\n\nWe rewrite the old race unit test which wasn\u0027t testing the correct\nthing for 2 reasons:\n\n1. Due to the bug fixed in this patch, although we were calling\n   update_on_match() twice, the second call didn\u0027t check the task state.\n2. side_effect\u003diterable returns function items without executing them,\n   but we weren\u0027t hitting this due to the bug fixed in this patch.\n\nCloses-Bug: #1821373\nChange-Id: I01c63e685113bf30e687ccb14a4d18e344b306f6\n(cherry picked from commit aae5c7aa3819ad9161fd2effed3872d540099230)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/24eebc26078607ad9765e1487ccd832d19037754"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/24eebc26078607ad9765e1487ccd832d19037754"}]},"branch":"refs/heads/stable/queens"},"f9c2503609bfad0b871d9e87227aa2bb5c137467":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-05-20 10:58:04.000000000","uploader":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"ref":"refs/changes/20/659320/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/20/659320/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/659320/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/659320/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/659320/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/20/659320/2"}}},"commit":{"parents":[{"commit":"01141392db549728e78865b6a56468d17102bee0","subject":"Use migration_status during volume migrating and retyping","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/01141392db549728e78865b6a56468d17102bee0"}]}],"author":{"name":"Matthew Booth","email":"mbooth@redhat.com","date":"2019-05-13 15:04:39.000000000","tz":60},"committer":{"name":"Matthew Booth","email":"mbooth@redhat.com","date":"2019-05-20 10:57:50.000000000","tz":60},"subject":"Fix retry of instance_update_and_get_original","message":"Fix retry of instance_update_and_get_original\n\n_instance_update modifies its \u0027values\u0027 argument. Consequently if it is\nretried due to an update conflict, the second invocation has the wrong\narguments.\n\nA specific issue this causes is that if we called it with\nexpected_task_state a concurrent modification to task_state will cause\nus to fail and retry. However, expected_task_state will have been popped\nfrom values on the first invocation and will not be present for the\nsecond. Consequently the second invocation will fail to perform the\ntask_state check and therefore succeed, resulting in a race.\n\nWe rewrite the old race unit test which wasn\u0027t testing the correct\nthing for 2 reasons:\n\n1. Due to the bug fixed in this patch, although we were calling\n   update_on_match() twice, the second call didn\u0027t check the task state.\n2. side_effect\u003diterable returns function items without executing them,\n   but we weren\u0027t hitting this due to the bug fixed in this patch.\n\nCloses-Bug: #1821373\nChange-Id: I01c63e685113bf30e687ccb14a4d18e344b306f6\n(cherry picked from commit aae5c7aa3819ad9161fd2effed3872d540099230)\n(cherry picked from commit 61fef49b1555c6509398fc47c21319c1b5e50505)\n(cherry picked from commit 4540cd6ef9731837cf4ed1e56850bcfa3512ae1c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f9c2503609bfad0b871d9e87227aa2bb5c137467"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f9c2503609bfad0b871d9e87227aa2bb5c137467"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}