)]}'
{".zuul.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8b84f69cb3c778f0c3e0f32f1278d477149460a4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      - openstack/devstack-gate"},{"line_number":12,"context_line":"      - openstack/nova"},{"line_number":13,"context_line":"      - openstack/tempest"},{"line_number":14,"context_line":"      - openstack/os-traits"},{"line_number":15,"context_line":"    irrelevant-files: \u0026dsvm-irrelevant-files"},{"line_number":16,"context_line":"      - ^api-.*$"},{"line_number":17,"context_line":"      - ^(test-|)requirements.txt$"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_0956d45d","line":14,"range":{"start_line":14,"start_character":5,"end_line":14,"end_character":27},"updated":"2019-05-22 13:55:43.000000000","message":"note to other reviews these changes are just temporary so Eric and ensure its working coorrectly \nlater version of the pacth will go back to using the released version","commit_id":"6cc7c1568ab2d66fae95f8052c6c4563313bc2d0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8b84f69cb3c778f0c3e0f32f1278d477149460a4","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    description: |"},{"line_number":146,"context_line":"      Run tempest compute API tests using LVM image backend. This only runs"},{"line_number":147,"context_line":"      against nova/virt/libvirt/* changes."},{"line_number":148,"context_line":"    required-projects:"},{"line_number":149,"context_line":"      - openstack/os-traits"},{"line_number":150,"context_line":"    run: playbooks/legacy/nova-lvm/run.yaml"},{"line_number":151,"context_line":"    post-run: playbooks/legacy/nova-lvm/post.yaml"},{"line_number":152,"context_line":"    # Copy irrelevant-files from nova-dsvm-base and then exclude anything"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_691190ac","line":149,"range":{"start_line":148,"start_character":4,"end_line":149,"end_character":27},"updated":"2019-05-22 13:55:43.000000000","message":"this is not needed because you added it to nova-dsvm-base\n\nrequired poeject is additive so you inherit required project form your parents.","commit_id":"6cc7c1568ab2d66fae95f8052c6c4563313bc2d0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8b84f69cb3c778f0c3e0f32f1278d477149460a4","unresolved":false,"context_lines":[{"line_number":186,"context_line":"      Starting in Stein, the job was changed to run with python 3 and enabled"},{"line_number":187,"context_line":"      volume multi-attach testing."},{"line_number":188,"context_line":"      Runs all tempest compute API and most scenario tests concurrently."},{"line_number":189,"context_line":"    required-projects:"},{"line_number":190,"context_line":"      - openstack/os-traits"},{"line_number":191,"context_line":"    run: playbooks/legacy/nova-next/run.yaml"},{"line_number":192,"context_line":"    post-run: playbooks/legacy/nova-next/post.yaml"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_29239807","line":190,"range":{"start_line":189,"start_character":4,"end_line":190,"end_character":27},"updated":"2019-05-22 13:55:43.000000000","message":"also inherited form parent","commit_id":"6cc7c1568ab2d66fae95f8052c6c4563313bc2d0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8b84f69cb3c778f0c3e0f32f1278d477149460a4","unresolved":false,"context_lines":[{"line_number":234,"context_line":"      - openstack/grenade"},{"line_number":235,"context_line":"      - openstack/devstack-gate"},{"line_number":236,"context_line":"      - openstack/nova"},{"line_number":237,"context_line":"      - openstack/os-traits"},{"line_number":238,"context_line":"    irrelevant-files: *live-migration-irrelevant-files"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_49836ccd","line":237,"range":{"start_line":237,"start_character":6,"end_line":237,"end_character":27},"updated":"2019-05-22 13:55:43.000000000","message":"again not neeed because its set in nova-dvsm-multinode-bases","commit_id":"6cc7c1568ab2d66fae95f8052c6c4563313bc2d0"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"42029b4fcf61dddc236e4d95ce1786df5d479986","unresolved":false,"context_lines":[{"line_number":234,"context_line":"      - openstack/grenade"},{"line_number":235,"context_line":"      - openstack/devstack-gate"},{"line_number":236,"context_line":"      - openstack/nova"},{"line_number":237,"context_line":"      - openstack/os-traits"},{"line_number":238,"context_line":"    irrelevant-files: *live-migration-irrelevant-files"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_df4aaaaa","line":237,"range":{"start_line":237,"start_character":6,"end_line":237,"end_character":27},"in_reply_to":"bfb3d3c7_49836ccd","updated":"2019-05-22 14:58:37.000000000","message":"cool, thanks for the close inspection. I just unthinkingly blatted it anywhere it was absent, knowing it was temporary.","commit_id":"6cc7c1568ab2d66fae95f8052c6c4563313bc2d0"}],"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8b84f69cb3c778f0c3e0f32f1278d477149460a4","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[1] https://review.opendev.org/#/c/660168"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Depends-On: I127ed21d249675a1a876379bfcdb436749bf108b"},{"line_number":28,"context_line":"Change-Id: Ib29c975d3d4e1adf14e215b1a28d30681ee16a77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bfb3d3c7_898ac418","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":53},"updated":"2019-05-22 13:55:43.000000000","message":"nit: technically this should  use the new url way but this should still work\n\nso it should be \nDepends-on: https://review.opendev.org/#/c/660168\n\nyou will also want to add a patch to depend on the change to the release repo and bump the min version in a later revision.","commit_id":"6cc7c1568ab2d66fae95f8052c6c4563313bc2d0"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"42029b4fcf61dddc236e4d95ce1786df5d479986","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[1] https://review.opendev.org/#/c/660168"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Depends-On: I127ed21d249675a1a876379bfcdb436749bf108b"},{"line_number":28,"context_line":"Change-Id: Ib29c975d3d4e1adf14e215b1a28d30681ee16a77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bfb3d3c7_df714a0e","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":53},"in_reply_to":"bfb3d3c7_898ac418","updated":"2019-05-22 14:58:37.000000000","message":"\u003e nit: technically this should  use the new url way but this should\n \u003e still work\n \u003e \n \u003e so it should be\n \u003e Depends-on: https://review.opendev.org/#/c/660168\n\nYeah, that\u0027s what I had originally, but the dep didn\u0027t work, so I thought it might be because of the URL, and I know the change-id method still worked, so I thought I\u0027d try it. Then I found out about the required-projects business.\n\n \u003e you will also want to add a patch to depend on the change to the\n \u003e release repo and bump the min version in a later revision.\n\nYup, once those exist.","commit_id":"6cc7c1568ab2d66fae95f8052c6c4563313bc2d0"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"a431b8637ca8dcb0786299115781bedd5a9da84c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eric Fried \u003copenstack@fried.cc\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-05-22 18:08:24 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Support old \u0026 new versions of svm and vmx traits"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Patch [1] added new Intel- and AMD-specific trait namespaces for certain"},{"line_number":10,"context_line":"X86 CPU features, including a couple that had already been defined in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bfb3d3c7_b79b1671","line":7,"range":{"start_line":7,"start_character":35,"end_line":7,"end_character":46},"updated":"2019-05-27 15:53:42.000000000","message":"OCD nit: \"SVM and VMX\"\n\n(Or \u0027svm\u0027 and \u0027vmx\u0027, as in the commit message body; whichever you use consistently :-))","commit_id":"8b514f0fda18b64cba5f9dab64182da503d5fa79"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"a431b8637ca8dcb0786299115781bedd5a9da84c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"WIP: Remove .zuul.yaml delta, update os-traits requirements once [1] is"},{"line_number":23,"context_line":"released."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[1] https://review.opendev.org/#/c/660168"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Depends-On: I127ed21d249675a1a876379bfcdb436749bf108b"},{"line_number":28,"context_line":"Change-Id: Ib29c975d3d4e1adf14e215b1a28d30681ee16a77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bfb3d3c7_b7c6b667","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":41},"updated":"2019-05-27 15:53:42.000000000","message":"Please update this to: https://review.opendev.org/#/c/655193/\n\n(As discussed, I incorporated the changes from https://review.opendev.org/#/c/660168 into https://review.opendev.org/#/c/655193/, to preserve the history.)","commit_id":"8b514f0fda18b64cba5f9dab64182da503d5fa79"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"05d37dbd7f8c5fa0d3cadee8eff272e7ab77e164","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003cstephenfin@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-10 16:59:49 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Support old \u0026 new versions of svm and vmx traits"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Patch [1] added new Intel- and AMD-specific trait namespaces for certain"},{"line_number":10,"context_line":"X86 CPU features, including a couple that had already been defined in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f560f44_baa44908","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2020-09-11 10:52:08.000000000","message":"nit - WIP?","commit_id":"b3fd7ff0d86430230f63286f58969e150722e943"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"05d37dbd7f8c5fa0d3cadee8eff272e7ab77e164","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Support old \u0026 new versions of svm and vmx traits"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Patch [1] added new Intel- and AMD-specific trait namespaces for certain"},{"line_number":10,"context_line":"X86 CPU features, including a couple that had already been defined in"},{"line_number":11,"context_line":"the generic X86 namespace (the Intel-specific \u0027vmx\u0027 feature and the"},{"line_number":12,"context_line":"AMD-specific \u0027svm\u0027 feature). Unfortunately, the libvirt driver was"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f560f44_7a9e31b8","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":9},"updated":"2020-09-11 10:52:08.000000000","message":"nit - missing reference","commit_id":"b3fd7ff0d86430230f63286f58969e150722e943"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8b84f69cb3c778f0c3e0f32f1278d477149460a4","unresolved":false,"context_lines":[{"line_number":9654,"context_line":"                    LOG.info(\u0027URI %(uri)s does not support full set\u0027"},{"line_number":9655,"context_line":"                             \u0027 of host capabilities: %(error)s\u0027,"},{"line_number":9656,"context_line":"                             {\u0027uri\u0027: self._host._uri, \u0027error\u0027: ex})"},{"line_number":9657,"context_line":"                    return libvirt_utils.cpu_features_to_traits({})"},{"line_number":9658,"context_line":""},{"line_number":9659,"context_line":"        cpu.parse_str(features)"},{"line_number":9660,"context_line":"        return libvirt_utils.cpu_features_to_traits("}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_29d638c5","line":9657,"range":{"start_line":9657,"start_character":64,"end_line":9657,"end_character":66},"updated":"2019-05-22 13:55:43.000000000","message":"you should use set() here\n\n{} is always a dict if its empty\n\n{1} is a set contining 1\n\n\u003e\u003e\u003e type({})\n\u003cclass \u0027dict\u0027\u003e\n\u003e\u003e\u003e type({1})\n\u003cclass \u0027set\u0027\u003e\n\u003e\u003e\u003e\n\n-1 is for this the rest are just nits/comments","commit_id":"6cc7c1568ab2d66fae95f8052c6c4563313bc2d0"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"42029b4fcf61dddc236e4d95ce1786df5d479986","unresolved":false,"context_lines":[{"line_number":9654,"context_line":"                    LOG.info(\u0027URI %(uri)s does not support full set\u0027"},{"line_number":9655,"context_line":"                             \u0027 of host capabilities: %(error)s\u0027,"},{"line_number":9656,"context_line":"                             {\u0027uri\u0027: self._host._uri, \u0027error\u0027: ex})"},{"line_number":9657,"context_line":"                    return libvirt_utils.cpu_features_to_traits({})"},{"line_number":9658,"context_line":""},{"line_number":9659,"context_line":"        cpu.parse_str(features)"},{"line_number":9660,"context_line":"        return libvirt_utils.cpu_features_to_traits("}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_dfdf0ad4","line":9657,"range":{"start_line":9657,"start_character":64,"end_line":9657,"end_character":66},"in_reply_to":"bfb3d3c7_29d638c5","updated":"2019-05-22 14:58:37.000000000","message":"Sigh, I thought jaypipes was the only one who cared about this. Will fix.","commit_id":"6cc7c1568ab2d66fae95f8052c6c4563313bc2d0"}],"nova/virt/libvirt/utils.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8b84f69cb3c778f0c3e0f32f1278d477149460a4","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    # AMD-specific svm feature."},{"line_number":80,"context_line":"    \u0027svm\u0027: (os_traits.HW_CPU_X86_SVM, os_traits.HW_CPU_X86_AMD_SVM),"},{"line_number":81,"context_line":"    \u0027tbm\u0027: os_traits.HW_CPU_X86_TBM,"},{"line_number":82,"context_line":"    # We have to continue to support the old (generic) trait for the"},{"line_number":83,"context_line":"    # Intel-specific vmx feature."},{"line_number":84,"context_line":"    \u0027vmx\u0027: (os_traits.HW_CPU_X86_VMX, os_traits.HW_CPU_X86_INTEL_VMX),"},{"line_number":85,"context_line":"    \u0027xop\u0027: os_traits.HW_CPU_X86_XOP"},{"line_number":86,"context_line":"}"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_4914cc4e","line":84,"range":{"start_line":82,"start_character":3,"end_line":84,"end_character":70},"updated":"2019-05-22 13:55:43.000000000","message":"we originally should have defined a common traits for hardware viruilisation that\n\ne.g.\nHW_CPU_HW_VIRT\n\nthat could have been used by all hyperviors on all architetures.\n\nanyway yes these are vendor specific extensions so i guess\nthat makes sense","commit_id":"6cc7c1568ab2d66fae95f8052c6c4563313bc2d0"}]}