)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f47d8b0ff6228da8e6619bbb81f97871b4bf097e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"(see bug referenced below for details)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Furthermore the systemd detection is fixed and"},{"line_number":18,"context_line":"all mount and umount commands are moved to libvirt privsep."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #1756823"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfb3d3c7_f8f8e4c4","line":18,"range":{"start_line":18,"start_character":30,"end_line":18,"end_character":59},"updated":"2019-05-22 16:35:45.000000000","message":"It\u0027s unfortunate that you mixed this into the bug fix, I would have preferred that this is just something that would have been done separately on master so we don\u0027t have to worry about it in a backport. Too late now I guess.","commit_id":"feff5a21aa5eda9a076397acbfd8d986eddd1a9f"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"71a9f405bbd32c0c3a9fbc46782d5d7f5763cfb7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"(see bug referenced below for details)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Furthermore the systemd detection is fixed and"},{"line_number":18,"context_line":"all mount and umount commands are moved to libvirt privsep."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #1756823"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfb3d3c7_de636541","line":18,"range":{"start_line":18,"start_character":30,"end_line":18,"end_character":59},"in_reply_to":"bfb3d3c7_f8f8e4c4","updated":"2019-05-24 08:42:51.000000000","message":"Mmh, i was asked to add the privsep step in here and probably should\u0027ve resisted, didn\u0027t think far enough ahead.\nHowever the fix does not require the privsep addition so i\u0027ll update this.","commit_id":"feff5a21aa5eda9a076397acbfd8d986eddd1a9f"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ff70454379328af55926080156730f23ca336538","unresolved":false,"context_lines":[{"line_number":15,"context_line":"(see bug referenced below for details)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Furthermore the systemd detection is fixed."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #1756823"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I53f3a062ce419d1142d7dd3103fab565bb105e05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_d4f78f59","line":18,"updated":"2019-09-04 02:46:26.000000000","message":"Deleting the privsep stuff should be noted.","commit_id":"ed4e39853ace96296bcda89b69f2c66d0d8f5ab8"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"29bbc5707a218ca029b3e000adb30fef6fdbd612","unresolved":false,"context_lines":[{"line_number":15,"context_line":"(see bug referenced below for details)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Furthermore the systemd detection is fixed."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #1756823"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I53f3a062ce419d1142d7dd3103fab565bb105e05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_73feeaaf","line":18,"in_reply_to":"7faddb67_d4f78f59","updated":"2019-09-04 11:55:22.000000000","message":"Done","commit_id":"ed4e39853ace96296bcda89b69f2c66d0d8f5ab8"}],"nova/tests/unit/virt/libvirt/volume/test_quobyte.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ff70454379328af55926080156730f23ca336538","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import six"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from nova import exception as nova_exception"},{"line_number":28,"context_line":"from nova.privsep import libvirt"},{"line_number":29,"context_line":"from nova import test"},{"line_number":30,"context_line":"from nova.tests.unit.virt.libvirt.volume import test_volume"},{"line_number":31,"context_line":"from nova import utils"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_b4f3f372","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":32},"updated":"2019-09-04 02:46:26.000000000","message":"This line should also be removed.","commit_id":"ed4e39853ace96296bcda89b69f2c66d0d8f5ab8"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"29bbc5707a218ca029b3e000adb30fef6fdbd612","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import six"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from nova import exception as nova_exception"},{"line_number":28,"context_line":"from nova.privsep import libvirt"},{"line_number":29,"context_line":"from nova import test"},{"line_number":30,"context_line":"from nova.tests.unit.virt.libvirt.volume import test_volume"},{"line_number":31,"context_line":"from nova import utils"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_332e3243","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":32},"in_reply_to":"7faddb67_b4f3f372","updated":"2019-09-04 11:55:22.000000000","message":"*ick*, forgot to run pep8 tests. Done.","commit_id":"ed4e39853ace96296bcda89b69f2c66d0d8f5ab8"}],"nova/virt/libvirt/volume/quobyte.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e0cb9a63f4bf33941c1540e24e382342deaa00f4","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    fileutils.ensure_tree(mnt_base)"},{"line_number":60,"context_line":"    req_root \u003d False"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # NOTE(kaisers): disable xattrs to speed up io as this omits"},{"line_number":63,"context_line":"    # additional metadata requests in the backend. xattrs can be"},{"line_number":64,"context_line":"    # enabled without issues but will reduce performance."},{"line_number":65,"context_line":"    command \u003d [\u0027mount.quobyte\u0027, \u0027--disable-xattrs\u0027, volume, mnt_base]"},{"line_number":66,"context_line":"    if is_systemd():"},{"line_number":67,"context_line":"        # Note(kaisers): with systemd this requires a separate CGROUP to"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_cb1b1771","line":64,"range":{"start_line":62,"start_character":4,"end_line":64,"end_character":57},"updated":"2019-09-17 15:19:08.000000000","message":"This was updated in the original change:\n\nhttps://review.opendev.org/#/c/554195/28/nova/virt/libvirt/volume/quobyte.py@62\n\nThere was also logging involved in the change that isn\u0027t here.","commit_id":"584de531ac9991b9f1b7545b0d8a74f8c7d4566a"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"22850654e00502ad6d0853cd87291700bdc8bba6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    fileutils.ensure_tree(mnt_base)"},{"line_number":60,"context_line":"    req_root \u003d False"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # NOTE(kaisers): disable xattrs to speed up io as this omits"},{"line_number":63,"context_line":"    # additional metadata requests in the backend. xattrs can be"},{"line_number":64,"context_line":"    # enabled without issues but will reduce performance."},{"line_number":65,"context_line":"    command \u003d [\u0027mount.quobyte\u0027, \u0027--disable-xattrs\u0027, volume, mnt_base]"},{"line_number":66,"context_line":"    if is_systemd():"},{"line_number":67,"context_line":"        # Note(kaisers): with systemd this requires a separate CGROUP to"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_a8ff6532","line":64,"range":{"start_line":62,"start_character":4,"end_line":64,"end_character":57},"in_reply_to":"3fa7e38b_cb1b1771","updated":"2019-09-23 09:10:54.000000000","message":"I removed the comment as by the original change and changed the log output to follow the new structure.","commit_id":"584de531ac9991b9f1b7545b0d8a74f8c7d4566a"}]}