)]}'
{"nova/api/openstack/compute/aggregates.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"834b804141d021bc304a5ef62c98e871280cf467","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class AggregateController(wsgi.Controller):"},{"line_number":38,"context_line":"    \"\"\"The Host Aggregates API controller for the OpenStack API.\"\"\""},{"line_number":39,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":40,"context_line":"        super(AggregateController, self).__init__(*args, **kwargs)"},{"line_number":41,"context_line":"        self.api \u003d compute.AggregateAPI()"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_c9116354","line":39,"range":{"start_line":39,"start_character":21,"end_line":39,"end_character":38},"updated":"2019-06-10 14:23:41.000000000","message":"Why are you adding these throughout? It\u0027s clearly not doing anything. This constructor isn\u0027t being called with any args/kwargs (or it would have blown up before), so none are being passed to the super\u0027s __init__. I.e. if that guy had required args, it would be blowing up anyway.","commit_id":"256678b0024e22c20de49304500916d5cc88b082"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1c203bd81f9fc90d0b92600fb7f2b0aa42121042","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class AggregateController(wsgi.Controller):"},{"line_number":38,"context_line":"    \"\"\"The Host Aggregates API controller for the OpenStack API.\"\"\""},{"line_number":39,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":40,"context_line":"        super(AggregateController, self).__init__(*args, **kwargs)"},{"line_number":41,"context_line":"        self.api \u003d compute.AggregateAPI()"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_a940afa6","line":39,"range":{"start_line":39,"start_character":21,"end_line":39,"end_character":38},"in_reply_to":"9fb8cfa7_c9116354","updated":"2019-06-10 14:37:21.000000000","message":"Good point. The only reason for this was so one could override the \u0027view_builder\u0027 argument of the base class, but nothing was doing that so I just removed the argument entirely","commit_id":"256678b0024e22c20de49304500916d5cc88b082"}],"nova/api/openstack/compute/console_auth_tokens.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"834b804141d021bc304a5ef62c98e871280cf467","unresolved":false,"context_lines":[{"line_number":29,"context_line":"class ConsoleAuthTokensController(wsgi.Controller):"},{"line_number":30,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":31,"context_line":"        super(ConsoleAuthTokensController, self).__init__(*args, **kwargs)"},{"line_number":32,"context_line":"        self.consoleauth_rpcapi \u003d consoleauth_rpcapi.ConsoleAuthAPI()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _show(self, req, id, rdp_only):"},{"line_number":35,"context_line":"        \"\"\"Checks a console auth token and returns the related connect info.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_c93ac3ca","line":32,"range":{"start_line":32,"start_character":13,"end_line":32,"end_character":31},"updated":"2019-06-10 14:23:41.000000000","message":"Why did you publicize this? Seems unrelated (and unnecessary).","commit_id":"256678b0024e22c20de49304500916d5cc88b082"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1c203bd81f9fc90d0b92600fb7f2b0aa42121042","unresolved":false,"context_lines":[{"line_number":29,"context_line":"class ConsoleAuthTokensController(wsgi.Controller):"},{"line_number":30,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":31,"context_line":"        super(ConsoleAuthTokensController, self).__init__(*args, **kwargs)"},{"line_number":32,"context_line":"        self.consoleauth_rpcapi \u003d consoleauth_rpcapi.ConsoleAuthAPI()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _show(self, req, id, rdp_only):"},{"line_number":35,"context_line":"        \"\"\"Checks a console auth token and returns the related connect info.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_89ee0bb2","line":32,"range":{"start_line":32,"start_character":13,"end_line":32,"end_character":31},"in_reply_to":"9fb8cfa7_c93ac3ca","updated":"2019-06-10 14:37:21.000000000","message":"It was mostly done because none of the others were private and it seemed weird. Dropped now though","commit_id":"256678b0024e22c20de49304500916d5cc88b082"}],"nova/api/openstack/compute/images.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"834b804141d021bc304a5ef62c98e871280cf467","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":46,"context_line":"        super(ImagesController, self).__init__(*args, **kwargs)"},{"line_number":47,"context_line":"        self.image_api \u003d nova.image.API()"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def _get_filters(self, req):"},{"line_number":50,"context_line":"        \"\"\"Return a dictionary of query param filters from the request."}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_a942ef3c","line":47,"range":{"start_line":47,"start_character":13,"end_line":47,"end_character":22},"updated":"2019-06-10 14:23:41.000000000","message":"ditto","commit_id":"256678b0024e22c20de49304500916d5cc88b082"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1c203bd81f9fc90d0b92600fb7f2b0aa42121042","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":46,"context_line":"        super(ImagesController, self).__init__(*args, **kwargs)"},{"line_number":47,"context_line":"        self.image_api \u003d nova.image.API()"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def _get_filters(self, req):"},{"line_number":50,"context_line":"        \"\"\"Return a dictionary of query param filters from the request."}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_0903fb74","line":47,"range":{"start_line":47,"start_character":13,"end_line":47,"end_character":22},"in_reply_to":"9fb8cfa7_a942ef3c","updated":"2019-06-10 14:37:21.000000000","message":"Done","commit_id":"256678b0024e22c20de49304500916d5cc88b082"}],"nova/api/openstack/compute/networks.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"834b804141d021bc304a5ef62c98e871280cf467","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class NetworkController(wsgi.Controller):"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def __init__(self, network_api\u003dNone, *args, **kwargs):"},{"line_number":82,"context_line":"        super(NetworkController, self).__init__(*args, **kwargs)"},{"line_number":83,"context_line":"        # TODO(stephenfin): \u0027network_api\u0027 is only being passed for use by tests"},{"line_number":84,"context_line":"        self.network_api \u003d network_api or network.API()"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_e56fadf9","line":81,"range":{"start_line":81,"start_character":39,"end_line":81,"end_character":56},"updated":"2019-06-10 14:23:41.000000000","message":"I\u0027m kind of shocked this even compiles.\n\n[Later] Okay, the interpreter doesn\u0027t mind unless you actually try to call it with anything in *args:\n\n In [2]: class Foo(object):\n    ...:     def __init__(self, foo\u003d\u0027bar\u0027, *args, **kwargs):\n    ...:         print(\"foo: %s\\nargs: %s\\nkwargs: %s\" % (foo, args, kwargs))\n    ...:         \n \n In [3]: \n\n In [3]: Foo()\n foo: bar\n args: ()\n kwargs: {}\n Out[3]: \u003c__main__.Foo at 0x7f0d67c1a350\u003e\n \n In [4]: Foo(foo\u003d\u0027baz\u0027, 1, two\u003d3)\n   File \"\u003cipython-input-4-ca07bde15cdf\u003e\", line 1\n     Foo(foo\u003d\u0027baz\u0027, 1, two\u003d3)\n SyntaxError: non-keyword arg after keyword arg\n\nSo I think *args should be removed from this.","commit_id":"256678b0024e22c20de49304500916d5cc88b082"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1c203bd81f9fc90d0b92600fb7f2b0aa42121042","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class NetworkController(wsgi.Controller):"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def __init__(self, network_api\u003dNone, *args, **kwargs):"},{"line_number":82,"context_line":"        super(NetworkController, self).__init__(*args, **kwargs)"},{"line_number":83,"context_line":"        # TODO(stephenfin): \u0027network_api\u0027 is only being passed for use by tests"},{"line_number":84,"context_line":"        self.network_api \u003d network_api or network.API()"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_490d739f","line":81,"range":{"start_line":81,"start_character":39,"end_line":81,"end_character":56},"in_reply_to":"9fb8cfa7_e56fadf9","updated":"2019-06-10 14:37:21.000000000","message":"Done","commit_id":"256678b0024e22c20de49304500916d5cc88b082"}],"nova/api/openstack/compute/networks_associate.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"834b804141d021bc304a5ef62c98e871280cf467","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class NetworkAssociateActionController(wsgi.Controller):"},{"line_number":28,"context_line":"    \"\"\"Network Association API Controller.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, network_api\u003dNone, *args, **kwargs):"},{"line_number":31,"context_line":"        super(NetworkAssociateActionController, self).__init__(*args, **kwargs)"},{"line_number":32,"context_line":"        # TODO(stephenfin): \u0027network_api\u0027 is only being passed for use by tests"},{"line_number":33,"context_line":"        self.network_api \u003d network_api or network.API()"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_a57535cd","line":30,"range":{"start_line":30,"start_character":41,"end_line":30,"end_character":47},"updated":"2019-06-10 14:23:41.000000000","message":"ditto","commit_id":"256678b0024e22c20de49304500916d5cc88b082"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1c203bd81f9fc90d0b92600fb7f2b0aa42121042","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class NetworkAssociateActionController(wsgi.Controller):"},{"line_number":28,"context_line":"    \"\"\"Network Association API Controller.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, network_api\u003dNone, *args, **kwargs):"},{"line_number":31,"context_line":"        super(NetworkAssociateActionController, self).__init__(*args, **kwargs)"},{"line_number":32,"context_line":"        # TODO(stephenfin): \u0027network_api\u0027 is only being passed for use by tests"},{"line_number":33,"context_line":"        self.network_api \u003d network_api or network.API()"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_29083f90","line":30,"range":{"start_line":30,"start_character":41,"end_line":30,"end_character":47},"in_reply_to":"9fb8cfa7_a57535cd","updated":"2019-06-10 14:37:21.000000000","message":"Done","commit_id":"256678b0024e22c20de49304500916d5cc88b082"}],"nova/api/openstack/compute/server_password.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1062ab607f3103d9e1db82ce18e01d2046669883","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class ServerPasswordController(wsgi.Controller):"},{"line_number":26,"context_line":"    \"\"\"The Server Password API controller for the OpenStack API.\"\"\""},{"line_number":27,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":28,"context_line":"        self.compute_api \u003d compute.API(*args, **kwargs)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @wsgi.expected_errors(404)"},{"line_number":31,"context_line":"    def index(self, req, server_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_04c8e01f","line":28,"updated":"2019-05-23 14:34:05.000000000","message":"Missed one","commit_id":"13bce6595d0f399f6ea07526566578f4e189bf96"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"03f06c08541af09b6b8009cda0f1de84d1cc4477","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class ServerPasswordController(wsgi.Controller):"},{"line_number":26,"context_line":"    \"\"\"The Server Password API controller for the OpenStack API.\"\"\""},{"line_number":27,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":28,"context_line":"        self.compute_api \u003d compute.API(*args, **kwargs)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @wsgi.expected_errors(404)"},{"line_number":31,"context_line":"    def index(self, req, server_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_690077ac","line":28,"updated":"2019-06-10 14:23:50.000000000","message":"Oh, this is wrong","commit_id":"256678b0024e22c20de49304500916d5cc88b082"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"834b804141d021bc304a5ef62c98e871280cf467","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class ServerPasswordController(wsgi.Controller):"},{"line_number":26,"context_line":"    \"\"\"The Server Password API controller for the OpenStack API.\"\"\""},{"line_number":27,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":28,"context_line":"        self.compute_api \u003d compute.API(*args, **kwargs)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @wsgi.expected_errors(404)"},{"line_number":31,"context_line":"    def index(self, req, server_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_497d737d","line":28,"updated":"2019-06-10 14:23:41.000000000","message":"missed this one","commit_id":"256678b0024e22c20de49304500916d5cc88b082"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1c203bd81f9fc90d0b92600fb7f2b0aa42121042","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class ServerPasswordController(wsgi.Controller):"},{"line_number":26,"context_line":"    \"\"\"The Server Password API controller for the OpenStack API.\"\"\""},{"line_number":27,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":28,"context_line":"        self.compute_api \u003d compute.API(*args, **kwargs)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @wsgi.expected_errors(404)"},{"line_number":31,"context_line":"    def index(self, req, server_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fb8cfa7_69d8771d","line":28,"in_reply_to":"9fb8cfa7_690077ac","updated":"2019-06-10 14:37:21.000000000","message":"Done","commit_id":"256678b0024e22c20de49304500916d5cc88b082"}]}