)]}'
{"gate/post_test_hook.sh":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b3211c6c9d531e3f245f983d99428b9ddf8f1f55","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    # NOTE(danms): Run this a few times to make sure that we end"},{"line_number":7,"context_line":"    # up with nothing more to archive"},{"line_number":8,"context_line":"    for i in `seq 30`; do"},{"line_number":9,"context_line":"        $MANAGE $* db archive_deleted_rows --verbose --max-rows 1000 --before \u0027now - 1 day\u0027"},{"line_number":10,"context_line":"        RET\u003d$?"},{"line_number":11,"context_line":"        if [[ $RET -gt 1 ]]; then"},{"line_number":12,"context_line":"            echo Archiving failed with result $RET"}],"source_content_type":"text/x-sh","patch_set":1,"id":"bfb3d3c7_277e34af","line":9,"range":{"start_line":9,"start_character":78,"end_line":9,"end_character":91},"updated":"2019-05-24 12:01:18.000000000","message":"It does not mean what we expect it to mean\n\n\u003e\u003e\u003e parser.parse(\u0027now - 1 day\u0027, fuzzy\u003dTrue)\ndatetime.datetime(2019, 5, 1, 0, 0)","commit_id":"bdc016bf491ddb6acc496999908c0ee5b2f18e01"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"da1de2b42d1e360e388f11c80c754abeb72d7cb2","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    # NOTE(danms): Run this a few times to make sure that we end"},{"line_number":7,"context_line":"    # up with nothing more to archive"},{"line_number":8,"context_line":"    for i in `seq 30`; do"},{"line_number":9,"context_line":"        $MANAGE $* db archive_deleted_rows --verbose --max-rows 1000 --before \u0027now - 1 day\u0027"},{"line_number":10,"context_line":"        RET\u003d$?"},{"line_number":11,"context_line":"        if [[ $RET -gt 1 ]]; then"},{"line_number":12,"context_line":"            echo Archiving failed with result $RET"}],"source_content_type":"text/x-sh","patch_set":1,"id":"bfb3d3c7_72a4e8a6","line":9,"range":{"start_line":9,"start_character":78,"end_line":9,"end_character":91},"in_reply_to":"bfb3d3c7_277e34af","updated":"2019-05-24 12:46:22.000000000","message":"I think this achieves the desired effect:\n\n yesterday\u003d$(date -d \u0027now - 1 day\u0027)\n $MANAGE ... --before \"$yesterday\"\n\nWere we expecting the util to do relative parsing like this?","commit_id":"bdc016bf491ddb6acc496999908c0ee5b2f18e01"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"20425a6128b94d220fd374206cc088691475f335","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    # NOTE(danms): Run this a few times to make sure that we end"},{"line_number":7,"context_line":"    # up with nothing more to archive"},{"line_number":8,"context_line":"    for i in `seq 30`; do"},{"line_number":9,"context_line":"        $MANAGE $* db archive_deleted_rows --verbose --max-rows 1000 --before $(date -d yesterday)"},{"line_number":10,"context_line":"        RET\u003d$?"},{"line_number":11,"context_line":"        if [[ $RET -gt 1 ]]; then"},{"line_number":12,"context_line":"            echo Archiving failed with result $RET"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bfb3d3c7_df803c49","line":9,"range":{"start_line":9,"start_character":78,"end_line":9,"end_character":98},"updated":"2019-05-24 13:54:20.000000000","message":"I think you need double quotes around this.","commit_id":"39718a264851f97140f3280dc9fe65eba0af7b1e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"084f6e1103dd95ba59c300429433863b073ae8cd","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    # NOTE(danms): Run this a few times to make sure that we end"},{"line_number":7,"context_line":"    # up with nothing more to archive"},{"line_number":8,"context_line":"    for i in `seq 30`; do"},{"line_number":9,"context_line":"        $MANAGE $* db archive_deleted_rows --verbose --max-rows 1000 --before \"$(date -d yesterday)\""},{"line_number":10,"context_line":"        RET\u003d$?"},{"line_number":11,"context_line":"        if [[ $RET -gt 1 ]]; then"},{"line_number":12,"context_line":"            echo Archiving failed with result $RET"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bfb3d3c7_7f6ef02f","line":9,"range":{"start_line":9,"start_character":53,"end_line":9,"end_character":63},"updated":"2019-05-24 14:09:54.000000000","message":"Is this right? The docs say --max_rows:\n\nhttps://docs.openstack.org/nova/latest/cli/nova-manage.html\n\nas does the code:\n\nhttps://github.com/openstack/nova/blob/976d1b89c2b754729903291050e01c9bf49704b9/nova/cmd/manage.py#L485","commit_id":"b0d5fff32f9093e90ddc45b57fe67190434259ca"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"975f3dc9fbbd51112dc4efb9915107bd4d4466db","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    # NOTE(danms): Run this a few times to make sure that we end"},{"line_number":7,"context_line":"    # up with nothing more to archive"},{"line_number":8,"context_line":"    for i in `seq 30`; do"},{"line_number":9,"context_line":"        $MANAGE $* db archive_deleted_rows --verbose --max-rows 1000 --before \"$(date -d yesterday)\""},{"line_number":10,"context_line":"        RET\u003d$?"},{"line_number":11,"context_line":"        if [[ $RET -gt 1 ]]; then"},{"line_number":12,"context_line":"            echo Archiving failed with result $RET"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bfb3d3c7_df3d9cdd","line":9,"range":{"start_line":9,"start_character":53,"end_line":9,"end_character":63},"in_reply_to":"bfb3d3c7_7f6ef02f","updated":"2019-05-24 14:20:49.000000000","message":"Oh sorry, I changed it because I was going to go with just --before, but then realized that the max is also honored simultaneously, so I put it back in and fat-fingered it.","commit_id":"b0d5fff32f9093e90ddc45b57fe67190434259ca"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"864b0e29631b21fae633a3a34121f875379004bb","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    # NOTE(danms): Run this a few times to make sure that we end"},{"line_number":7,"context_line":"    # up with nothing more to archive"},{"line_number":8,"context_line":"    for i in `seq 30`; do"},{"line_number":9,"context_line":"        $MANAGE $* db archive_deleted_rows --verbose --max-rows 1000 --before \"$(date -d yesterday)\""},{"line_number":10,"context_line":"        RET\u003d$?"},{"line_number":11,"context_line":"        if [[ $RET -gt 1 ]]; then"},{"line_number":12,"context_line":"            echo Archiving failed with result $RET"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bfb3d3c7_e259e734","line":9,"range":{"start_line":9,"start_character":53,"end_line":9,"end_character":63},"in_reply_to":"bfb3d3c7_df3d9cdd","updated":"2019-05-24 14:28:47.000000000","message":"No problem, I always have to look at the docs to make sure it\u0027s --max_rows rather than --max-rows because the underscore is weird in an option. We could/should probably fix that some day with an alias option.","commit_id":"b0d5fff32f9093e90ddc45b57fe67190434259ca"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fd91d0b3a83972905278ec474362c32be8c79d47","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# take precedence."},{"line_number":40,"context_line":"conf\u003d\"--config-file $NOVA_CONF --config-file $cell_conf\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"archive_deleted_rows $conf"},{"line_number":43,"context_line":"purge_db"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"set -e"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bfb3d3c7_1f9c940d","line":42,"updated":"2019-05-24 14:14:30.000000000","message":"Could be a separate change, either before or after this, because we\u0027ll probably want to backport it but we should probably be running the archive with a set -e because --max-rows is failing:\n\nnova-manage: error: unrecognized arguments: --max-rows\n\nbut not failing the job.","commit_id":"b0d5fff32f9093e90ddc45b57fe67190434259ca"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"966048d9cd43aef7372f9638ad7d773cc29bb5d3","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    # NOTE(danms): Run this a few times to make sure that we end"},{"line_number":7,"context_line":"    # up with nothing more to archive"},{"line_number":8,"context_line":"    for i in `seq 30`; do"},{"line_number":9,"context_line":"        $MANAGE $* db archive_deleted_rows --verbose --max_rows 1000 --before \"$(date -d yesterday)\""},{"line_number":10,"context_line":"        RET\u003d$?"},{"line_number":11,"context_line":"        if [[ $RET -gt 1 ]]; then"},{"line_number":12,"context_line":"            echo Archiving failed with result $RET"}],"source_content_type":"text/x-sh","patch_set":4,"id":"bfb3d3c7_099d3ebb","line":9,"range":{"start_line":9,"start_character":89,"end_line":9,"end_character":98},"updated":"2019-05-24 19:16:07.000000000","message":"I think you want this to be tomorrow or something because right now you\u0027re trying to remove things deleted in the past which in a gate run isn\u0027t going to fly:\n\nhttp://logs.openstack.org/02/661002/4/check/nova-next/39819ea/logs/devstack-gate-post_test_hook.txt.gz#_2019-05-24_18_14_18_805\n\n2019-05-24 18:14:18.805 | + /opt/stack/new/nova/gate/post_test_hook.sh:archive_deleted_rows:L9:   /usr/local/bin/nova-manage --config-file /etc/nova/nova.conf --config-file /etc/nova/nova_cell1.conf db archive_deleted_rows --verbose --max_rows 1000 --before \u0027Thu May 23 18:14:18 UTC 2019\u0027\n2019-05-24 18:14:23.953 | Nothing was archived.","commit_id":"1b1464a2ebc08198d5165e19d19025c13b953447"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1ca5e33ea7e30880e703e849391dddb37c1747f3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"MANAGE\u003d\"/usr/local/bin/nova-manage\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"function archive_deleted_rows {"},{"line_number":6,"context_line":"    # NOTE(danms): Run this a few times to make sure that we end"},{"line_number":7,"context_line":"    # up with nothing more to archive"},{"line_number":8,"context_line":"    if $MANAGE $* (db archive_deleted_rows --verbose --before \"$(date -d yesterday)\" 2\u003e\u00261 | grep \u0027Nothing was archived\u0027; then"},{"line_number":9,"context_line":"        echo \"Archiving yesterday data should have done nothing\""},{"line_number":10,"context_line":"        return 1"}],"source_content_type":"text/x-sh","patch_set":5,"id":"bfb3d3c7_648dffd1","line":7,"range":{"start_line":6,"start_character":4,"end_line":7,"end_character":37},"updated":"2019-05-24 21:16:38.000000000","message":"nit: this should still probably be on top of the for loop","commit_id":"cdd5a43745ecf630ad65fc51c9a7d0008def18e3"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"14bf47d7bdbad3b7c5bccbc20bc5d1425ce81511","unresolved":false,"context_lines":[{"line_number":5,"context_line":"function archive_deleted_rows {"},{"line_number":6,"context_line":"    # NOTE(danms): Run this a few times to make sure that we end"},{"line_number":7,"context_line":"    # up with nothing more to archive"},{"line_number":8,"context_line":"    if $MANAGE $* (db archive_deleted_rows --verbose --before \"$(date -d yesterday)\" 2\u003e\u00261 | grep \u0027Nothing was archived\u0027; then"},{"line_number":9,"context_line":"        echo \"Archiving yesterday data should have done nothing\""},{"line_number":10,"context_line":"        return 1"},{"line_number":11,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"bfb3d3c7_adde7b6a","line":8,"range":{"start_line":8,"start_character":18,"end_line":8,"end_character":19},"updated":"2019-05-24 23:21:54.000000000","message":"http://logs.openstack.org/02/661002/5/check/nova-next/843b914/job-output.txt.gz#_2019-05-24_21_48_20_817219","commit_id":"cdd5a43745ecf630ad65fc51c9a7d0008def18e3"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7d89e89f82d6eec5503076ba75c2db5447f77bef","unresolved":false,"context_lines":[{"line_number":5,"context_line":"function archive_deleted_rows {"},{"line_number":6,"context_line":"    # NOTE(danms): Run this a few times to make sure that we end"},{"line_number":7,"context_line":"    # up with nothing more to archive"},{"line_number":8,"context_line":"    if $MANAGE $* db archive_deleted_rows --verbose --before \"$(date -d yesterday)\" 2\u003e\u00261 | grep \u0027Nothing was archived\u0027; then"},{"line_number":9,"context_line":"        echo \"Archiving yesterday data should have done nothing\""},{"line_number":10,"context_line":"        return 1"},{"line_number":11,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9fb8cfa7_e1561707","line":8,"range":{"start_line":8,"start_character":6,"end_line":8,"end_character":7},"updated":"2019-06-04 22:14:05.000000000","message":"Missing ! here","commit_id":"a7d60470ff9f8e16ff2bd368eb37adf5f63be387"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"581014ab9a12d0df3c49ce1e03ebcb7d60b05ebd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"function archive_deleted_rows {"},{"line_number":6,"context_line":"    # NOTE(danms): Run this a few times to make sure that we end"},{"line_number":7,"context_line":"    # up with nothing more to archive"},{"line_number":8,"context_line":"    if $MANAGE $* db archive_deleted_rows --verbose --before \"$(date -d yesterday)\" 2\u003e\u00261 | grep \u0027Nothing was archived\u0027; then"},{"line_number":9,"context_line":"        echo \"Archiving yesterday data should have done nothing\""},{"line_number":10,"context_line":"        return 1"},{"line_number":11,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9fb8cfa7_b87600a4","line":8,"range":{"start_line":8,"start_character":6,"end_line":8,"end_character":7},"in_reply_to":"9fb8cfa7_01756b95","updated":"2019-06-05 14:40:57.000000000","message":"Yep, thanks. I\u0027m taking the minimal-effort approach to fixing this, in case you hadn\u0027t noticed. Your re-review is appreciated, but is also making me feel inadequate and lazy. Feel free to ignore until I ping you that it\u0027s working :)","commit_id":"a7d60470ff9f8e16ff2bd368eb37adf5f63be387"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2b3bce28d5552959d2af9af11d4529be057ffb0d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"function archive_deleted_rows {"},{"line_number":6,"context_line":"    # NOTE(danms): Run this a few times to make sure that we end"},{"line_number":7,"context_line":"    # up with nothing more to archive"},{"line_number":8,"context_line":"    if $MANAGE $* db archive_deleted_rows --verbose --before \"$(date -d yesterday)\" 2\u003e\u00261 | grep \u0027Nothing was archived\u0027; then"},{"line_number":9,"context_line":"        echo \"Archiving yesterday data should have done nothing\""},{"line_number":10,"context_line":"        return 1"},{"line_number":11,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9fb8cfa7_01756b95","line":8,"range":{"start_line":8,"start_character":6,"end_line":8,"end_character":7},"in_reply_to":"9fb8cfa7_e1561707","updated":"2019-06-04 22:14:35.000000000","message":"http://logs.openstack.org/02/661002/6/check/nova-next/b72295e/job-output.txt.gz#_2019-06-04_20_46_57_772173","commit_id":"a7d60470ff9f8e16ff2bd368eb37adf5f63be387"}]}