)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"b3164c7eb1fe39a23dbbd468e853f8d4d91e69a1","unresolved":false,"context_lines":[{"line_number":9641,"context_line":"            feature_names \u003d [f.name for f in cpu.features]"},{"line_number":9642,"context_line":"        return libvirt_utils.cpu_features_to_traits(feature_names)"},{"line_number":9643,"context_line":""},{"line_number":9644,"context_line":"    def _get_guest_baseline_cpu_features(self, xml_str):"},{"line_number":9645,"context_line":"        \"\"\"Calls libvirt\u0027s baselineCPU API to compute the biggest set of"},{"line_number":9646,"context_line":"        CPU features which is compatible with the given host CPU."},{"line_number":9647,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_e93d278f","line":9644,"range":{"start_line":9644,"start_character":8,"end_line":9644,"end_character":40},"updated":"2019-05-28 15:40:12.000000000","message":"Yes, thanks for breaking it out into a smaller method.","commit_id":"b832652475df84a7ee2a9777059f5059ce5c904c"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"b3164c7eb1fe39a23dbbd468e853f8d4d91e69a1","unresolved":false,"context_lines":[{"line_number":9649,"context_line":"        :return: An XML string of the computed CPU, or None on error"},{"line_number":9650,"context_line":"        \"\"\""},{"line_number":9651,"context_line":"        LOG.debug(\"Libvirt baseline CPU %s\", xml_str)"},{"line_number":9652,"context_line":"        # TODO(lei-zh): baselineCPU is not supported on all platforms."},{"line_number":9653,"context_line":"        # There is some work going on in the libvirt community to replace the"},{"line_number":9654,"context_line":"        # baseline call. Consider using the new apis when they are ready. See"},{"line_number":9655,"context_line":"        # https://www.redhat.com/archives/libvir-list/2018-May/msg01204.html."},{"line_number":9656,"context_line":"        try:"},{"line_number":9657,"context_line":"            if hasattr(libvirt, \u0027VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES\u0027):"},{"line_number":9658,"context_line":"                return self._host.get_connection().baselineCPU("}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_29681f85","line":9655,"range":{"start_line":9652,"start_character":8,"end_line":9655,"end_character":75},"updated":"2019-05-28 15:40:12.000000000","message":"Note to self: This should be addressed as part of the last work item here: \n\nhttps://opendev.org/openstack/nova-specs/commit/70811da221035044e27 (\"Add \"CPU selection with hypervisor consideration\" spec\")","commit_id":"b832652475df84a7ee2a9777059f5059ce5c904c"}]}