)]}'
{"nova/tests/functional/regressions/test_bug_1830747.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"23f586ad149ff3aacc272f8732cdeb914553cc00","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        # Stub out the ComputeTaskAPI.resize_instance method to not pass the"},{"line_number":118,"context_line":"        # request spec from compute to conductor during a reschedule."},{"line_number":119,"context_line":"        # This simulates the pre-Stein reschedule behavior."},{"line_number":120,"context_line":"        original_resize_instance \u003d conductor_api.ComputeTaskAPI.resize_instance"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        def stub_resize_instance(_self, context, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_cd1912d7","line":119,"updated":"2019-05-31 08:36:18.000000000","message":"+1 Hackish but necessary.","commit_id":"22eccfbb6fb8cd21342a9c85ad791909cdbcce4c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4c64c3270a91b214f3716b4fb190b9f62b7dcda5","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        # Stub out the ComputeTaskAPI.resize_instance method to not pass the"},{"line_number":118,"context_line":"        # request spec from compute to conductor during a reschedule."},{"line_number":119,"context_line":"        # This simulates the pre-Stein reschedule behavior."},{"line_number":120,"context_line":"        original_resize_instance \u003d conductor_api.ComputeTaskAPI.resize_instance"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        def stub_resize_instance(_self, context, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_e35c1e1a","line":119,"in_reply_to":"bfb3d3c7_cd1912d7","updated":"2019-05-31 14:53:37.000000000","message":"Yup, I couldn\u0027t think of a way to recreate without that after stein. I think when I get to backporting this to Rocky and older I will remove this so it\u0027s a bit more clear.","commit_id":"22eccfbb6fb8cd21342a9c85ad791909cdbcce4c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2ea9cf3a4711f6a3af96352eb2084ddec2f6e7ac","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            # which we can determine from the filter_properties retry dict."},{"line_number":127,"context_line":"            filter_properties \u003d scheduler_hint[\u0027filter_properties\u0027]"},{"line_number":128,"context_line":"            if filter_properties.get(\u0027retry\u0027, {}).get(\u0027exc\u0027):"},{"line_number":129,"context_line":"                kwargs[\u0027request_spec\u0027] \u003d None"},{"line_number":130,"context_line":"            return original_resize_instance("},{"line_number":131,"context_line":"                _self, context, instance, extra_instance_updates,"},{"line_number":132,"context_line":"                scheduler_hint, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_a7a70a50","line":129,"updated":"2019-05-31 16:19:31.000000000","message":"The most right thing to do would be to delete request_spec from kwargs, right? Not any different in mechanics, but if you\u0027re going to replicate the actual calling convention...","commit_id":"22eccfbb6fb8cd21342a9c85ad791909cdbcce4c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"097ac1a6ab1728aeb5fdb229674a89e2331ca752","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            # which we can determine from the filter_properties retry dict."},{"line_number":127,"context_line":"            filter_properties \u003d scheduler_hint[\u0027filter_properties\u0027]"},{"line_number":128,"context_line":"            if filter_properties.get(\u0027retry\u0027, {}).get(\u0027exc\u0027):"},{"line_number":129,"context_line":"                kwargs[\u0027request_spec\u0027] \u003d None"},{"line_number":130,"context_line":"            return original_resize_instance("},{"line_number":131,"context_line":"                _self, context, instance, extra_instance_updates,"},{"line_number":132,"context_line":"                scheduler_hint, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_f079362f","line":129,"in_reply_to":"9fb8cfa7_a7a70a50","updated":"2019-05-31 18:50:56.000000000","message":"For the pre-stein behavior where compute doesn\u0027t pass the request_spec back to conductor, yeah you\u0027re right. I can change that.","commit_id":"22eccfbb6fb8cd21342a9c85ad791909cdbcce4c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9f8d1b8b415b789eae277edbf71d80962096866d","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            # which we can determine from the filter_properties retry dict."},{"line_number":127,"context_line":"            filter_properties \u003d scheduler_hint[\u0027filter_properties\u0027]"},{"line_number":128,"context_line":"            if filter_properties.get(\u0027retry\u0027, {}).get(\u0027exc\u0027):"},{"line_number":129,"context_line":"                kwargs[\u0027request_spec\u0027] \u003d None"},{"line_number":130,"context_line":"            return original_resize_instance("},{"line_number":131,"context_line":"                _self, context, instance, extra_instance_updates,"},{"line_number":132,"context_line":"                scheduler_hint, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_d0b0b28e","line":129,"in_reply_to":"9fb8cfa7_f079362f","updated":"2019-05-31 19:17:43.000000000","message":"Done","commit_id":"22eccfbb6fb8cd21342a9c85ad791909cdbcce4c"}]}
