)]}'
{"nova/api/openstack/compute/contrib/flavorextraspecs.py":[{"author":{"_account_id":9645,"name":"lizheming","email":"lizheming.li@huawei.com","username":"lizheming"},"change_message_id":"1016311859c38ef6293b5913a26cd464009f7c34","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            db.flavor_extra_specs_update_or_create(context,"},{"line_number":76,"context_line":"                                                              flavor_id,"},{"line_number":77,"context_line":"                                                              specs)"},{"line_number":78,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":79,"context_line":"            msg \u003d _(\"Concurrent transaction has been committed, try again\")"},{"line_number":80,"context_line":"            raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":81,"context_line":"        except exception.FlavorNotFound as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Ffcc%3D","line":78,"updated":"2014-01-13 11:20:53.000000000","message":"DBDuplicateEntry have raise?\r\nhttps://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py:4508\r\nit only rasie not raise  DBDuplicateEntry","commit_id":"6b81f69dcb1e7587d3822cf7bbde1da2e733decd"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"b4090bd30e3e0e24b50ccfda25d19f85dc77fe6a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            db.flavor_extra_specs_update_or_create(context,"},{"line_number":76,"context_line":"                                                              flavor_id,"},{"line_number":77,"context_line":"                                                              specs)"},{"line_number":78,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":79,"context_line":"            msg \u003d _(\"Concurrent transaction has been committed, try again\")"},{"line_number":80,"context_line":"            raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":81,"context_line":"        except exception.FlavorNotFound as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FexE%3D","line":78,"in_reply_to":"AAAAUH%2F%2Ffcc%3D","updated":"2014-01-13 13:31:00.000000000","message":"@Zeming, IMHO, raise will raise DBDuplicateEntry, right? Or may be I was wrong.\n\nDid some test as following:\n\njay@jay1:~$ cat t.py \ndef test():\n    try:\n        float(\u0027abc\u0027)\n    except (ValueError, TypeError):\n        print \"111111111111\"\n        raise\n    except Exception as e:\n        raise\n \ntry:\n    test()\nexcept (ValueError, TypeError):\n    print \"OOOOOOOOO\"\nexcept Exception as e:\n    print \"xxx\"\njay@jay1:~$ python t.py \n111111111111\nOOOOOOOOO","commit_id":"6b81f69dcb1e7587d3822cf7bbde1da2e733decd"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"0092e8691c3952813fb8f01b99dce0de5403f91a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                                                              flavor_id,"},{"line_number":81,"context_line":"                                                              specs)"},{"line_number":82,"context_line":"        except exception.FlavorExtraSpecUpdateCreateFailed as e:"},{"line_number":83,"context_line":"            raise exc.HTTPConflict(explanation\u003de.format_message())"},{"line_number":84,"context_line":"        except exception.FlavorNotFound as e:"},{"line_number":85,"context_line":"            raise exc.HTTPNotFound(explanation\u003de.format_message())"},{"line_number":86,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAU3%2F%2F5r4%3D","line":83,"updated":"2014-02-24 06:55:07.000000000","message":"not sure HTTPConflict is correct here...\nI referred to servers.py create functions\n\nlooks to me if it failed to create an instance, \nexc.HTTPBadRequest will be raised","commit_id":"7a5715827484a4485170321215b42cceeb0cdab2"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"79af7e3f6f44e27163fbd152e3e2523052ee9df6","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                                                              flavor_id,"},{"line_number":81,"context_line":"                                                              specs)"},{"line_number":82,"context_line":"        except exception.FlavorExtraSpecUpdateCreateFailed as e:"},{"line_number":83,"context_line":"            raise exc.HTTPConflict(explanation\u003de.format_message())"},{"line_number":84,"context_line":"        except exception.FlavorNotFound as e:"},{"line_number":85,"context_line":"            raise exc.HTTPNotFound(explanation\u003de.format_message())"},{"line_number":86,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2FvsU%3D","line":83,"in_reply_to":"AAAAU3%2F%2F5r4%3D","updated":"2014-03-14 03:08:05.000000000","message":"After a second thought, it might be better that we still use HTTPConflict, as the exception was thrown out because of db_exc.DBDuplicateEntry","commit_id":"7a5715827484a4485170321215b42cceeb0cdab2"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"7675741e71d4722d6c93a192f4755797d3ab1831","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                                                              flavor_id,"},{"line_number":81,"context_line":"                                                              specs)"},{"line_number":82,"context_line":"        except exception.FlavorExtraSpecUpdateCreateFailed as e:"},{"line_number":83,"context_line":"            raise exc.HTTPConflict(explanation\u003de.format_message())"},{"line_number":84,"context_line":"        except exception.FlavorNotFound as e:"},{"line_number":85,"context_line":"            raise exc.HTTPNotFound(explanation\u003de.format_message())"},{"line_number":86,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2FvwA%3D","line":83,"in_reply_to":"AAAAU3%2F%2F5r4%3D","updated":"2014-03-14 03:00:23.000000000","message":"Done","commit_id":"7a5715827484a4485170321215b42cceeb0cdab2"}],"nova/api/openstack/compute/plugins/v3/flavors_extraspecs.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e0cb6516465de238faa1bdd233fd3bf147e83fa7","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        try:"},{"line_number":101,"context_line":"            db.flavor_extra_specs_update_or_create(context, flavor_id,"},{"line_number":102,"context_line":"                                                          body)"},{"line_number":103,"context_line":"        except exception.FlavorIdExists as e:"},{"line_number":104,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003de.format_message())"},{"line_number":105,"context_line":"        except exception.FlavorNotFound as e:"},{"line_number":106,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.format_message())"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FSLI%3D","line":103,"updated":"2014-02-14 08:21:44.000000000","message":"I feel FlavorIdExists exception is invalid because this method is for updating flavor_extraspecs. The flavor *should* exist already.","commit_id":"27474a6ca4c51e151504ea9948d25717f8731ae9"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"0d6a5fb9a5ecfa10c50064049fa96829f2b89e7b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        try:"},{"line_number":101,"context_line":"            db.flavor_extra_specs_update_or_create(context, flavor_id,"},{"line_number":102,"context_line":"                                                          body)"},{"line_number":103,"context_line":"        except exception.FlavorIdExists as e:"},{"line_number":104,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003de.format_message())"},{"line_number":105,"context_line":"        except exception.FlavorNotFound as e:"},{"line_number":106,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.format_message())"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAU3%2F%2F%2FIA%3D","line":103,"in_reply_to":"AAAAUX%2F%2FSLI%3D","updated":"2014-02-23 01:50:59.000000000","message":"OK, will create a new exception instead. Thanks.","commit_id":"27474a6ca4c51e151504ea9948d25717f8731ae9"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"43d6add9c0be696836f0cb2de2a8cb114a11ba54","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            db.flavor_extra_specs_update_or_create(context, flavor_id,"},{"line_number":69,"context_line":"                                                          specs)"},{"line_number":70,"context_line":"        except exception.FlavorExtraSpecUpdateCreateFailed as e:"},{"line_number":71,"context_line":"            msg \u003d _(\"Concurrent transaction has been committed, try again\")"},{"line_number":72,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003de.format_message())"},{"line_number":73,"context_line":"        except exception.FlavorNotFound as e:"},{"line_number":74,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.format_message())"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVn%2F%2B908%3D","line":71,"updated":"2014-03-11 00:43:36.000000000","message":"This msg is not used, so better to remove it.","commit_id":"7a5715827484a4485170321215b42cceeb0cdab2"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"7675741e71d4722d6c93a192f4755797d3ab1831","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            db.flavor_extra_specs_update_or_create(context, flavor_id,"},{"line_number":69,"context_line":"                                                          specs)"},{"line_number":70,"context_line":"        except exception.FlavorExtraSpecUpdateCreateFailed as e:"},{"line_number":71,"context_line":"            msg \u003d _(\"Concurrent transaction has been committed, try again\")"},{"line_number":72,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003de.format_message())"},{"line_number":73,"context_line":"        except exception.FlavorNotFound as e:"},{"line_number":74,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.format_message())"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2FvwQ%3D","line":71,"in_reply_to":"AAAAVn%2F%2B908%3D","updated":"2014-03-14 03:00:23.000000000","message":"Done","commit_id":"7a5715827484a4485170321215b42cceeb0cdab2"}],"nova/tests/api/openstack/compute/plugins/v3/test_flavors_extra_specs.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"1d2b5887223c9e77b4a0f5739e5e07e0e7d7dceb","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def test_create_flavor_db_duplicate(self):"},{"line_number":168,"context_line":"        def fake_instance_type_extra_specs_update_or_create(*args, **kwargs):"},{"line_number":169,"context_line":"            raise exception.FlavorExtraSpecUpdateCreateFailed(id\u003d1, retries\u003d5)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        self.stubs.Set(nova.db,"},{"line_number":172,"context_line":"                       \u0027flavor_extra_specs_update_or_create\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FSNk%3D","line":169,"updated":"2014-01-15 14:00:10.000000000","message":"So yeah - this is not ideal - but won\u0027t block on it.","commit_id":"9c1bba3e381be1f9c92f92bf1e90561eaeebb894"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"c62cbd9f097e383948aba150407c292eeaf1e4fb","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def test_create_flavor_db_duplicate(self):"},{"line_number":168,"context_line":"        def fake_instance_type_extra_specs_update_or_create(*args, **kwargs):"},{"line_number":169,"context_line":"            raise exception.FlavorExtraSpecUpdateCreateFailed(id\u003d1, retries\u003d5)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        self.stubs.Set(nova.db,"},{"line_number":172,"context_line":"                       \u0027flavor_extra_specs_update_or_create\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FSKU%3D","line":169,"in_reply_to":"AAAAUH%2F%2FSNk%3D","updated":"2014-01-15 14:28:16.000000000","message":"Done","commit_id":"9c1bba3e381be1f9c92f92bf1e90561eaeebb894"}]}