)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"d2502128c3da89d3e250310f6620277a29748c7e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the neutron API there were calls to \u0027raise\u0027. These should be"},{"line_number":10,"context_line":"replaced with excutils.save_and_reraise_exception. The reason"},{"line_number":11,"context_line":"for this is that with eventlet tghis could actually throw an"},{"line_number":12,"context_line":"error and not raise the exception that we are expecting."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I946126c2fb5aa229f917f8cb36ecb23aab528e14"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2FZpE%3D","line":11,"updated":"2014-01-14 06:00:59.000000000","message":"this","commit_id":"057ae0713ccb595febec10152df80dabb035c3b4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e657410ba9b5355a1a855e564d24bd8ffa1e3454","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the neutron API there were calls to \u0027raise\u0027. These should be"},{"line_number":10,"context_line":"replaced with excutils.save_and_reraise_exception. The reason"},{"line_number":11,"context_line":"for this is that with eventlet tghis could actually throw an"},{"line_number":12,"context_line":"error and not raise the exception that we are expecting."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I946126c2fb5aa229f917f8cb36ecb23aab528e14"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2FX7Q%3D","line":11,"in_reply_to":"AAAAUH%2F%2FZpE%3D","updated":"2014-01-14 14:15:40.000000000","message":"Done","commit_id":"057ae0713ccb595febec10152df80dabb035c3b4"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"e0407f98b9485c89afcd7232245450627d8a6cf9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In the neutron API there were calls to \u0027raise\u0027. These should be"},{"line_number":10,"context_line":"replaced with excutils.save_and_reraise_exception. The reason"},{"line_number":11,"context_line":"for this is that with eventlet tghis could actually throw an"},{"line_number":12,"context_line":"error and not raise the exception that we are expecting."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I946126c2fb5aa229f917f8cb36ecb23aab528e14"},{"line_number":15,"context_line":"Closes-bug: #1268309"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2FY2s%3D","line":12,"updated":"2014-01-14 11:31:51.000000000","message":"\u003e The reason for this is that with eventlet tghis could actually throw an error and not raise the exception.\n\nI am not sure what you mean by this. IIUC Raising exceptions like this is fine unless you attempt to do something that could cause a yield (like log it).\n\nSo either change this to say - we are now logging exceptions so we need to use save_and_reraise, or don\u0027t log it in which case you don\u0027t need this.\n\nOr - option number 3 - explain why doing a raise will mess with eventlet\u0027s way of propagating exceptions (since neither the bug nor this commit message attempt to explain it - just state it as a fact, and google came up short for me at least)","commit_id":"057ae0713ccb595febec10152df80dabb035c3b4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e657410ba9b5355a1a855e564d24bd8ffa1e3454","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In the neutron API there were calls to \u0027raise\u0027. These should be"},{"line_number":10,"context_line":"replaced with excutils.save_and_reraise_exception. The reason"},{"line_number":11,"context_line":"for this is that with eventlet tghis could actually throw an"},{"line_number":12,"context_line":"error and not raise the exception that we are expecting."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I946126c2fb5aa229f917f8cb36ecb23aab528e14"},{"line_number":15,"context_line":"Closes-bug: #1268309"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2FX6s%3D","line":12,"in_reply_to":"AAAAUH%2F%2FY2s%3D","updated":"2014-01-14 14:15:40.000000000","message":"Done","commit_id":"057ae0713ccb595febec10152df80dabb035c3b4"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"e0ac76685623e6253063f2f1eb154c260223cf77","unresolved":false,"context_lines":[{"line_number":548,"context_line":"                        else:"},{"line_number":549,"context_line":"                            with excutils.save_and_reraise_exception():"},{"line_number":550,"context_line":"                                LOG.exception(_(\"Failed to access port %s\"),"},{"line_number":551,"context_line":"                                              port_id)"},{"line_number":552,"context_line":"                    if not port:"},{"line_number":553,"context_line":"                        raise exception.PortNotFound(port_id\u003dport_id)"},{"line_number":554,"context_line":"                    if port.get(\u0027device_id\u0027, None):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FZpU%3D","line":551,"updated":"2014-01-14 06:00:33.000000000","message":"should we include instance here as well?","commit_id":"057ae0713ccb595febec10152df80dabb035c3b4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e657410ba9b5355a1a855e564d24bd8ffa1e3454","unresolved":false,"context_lines":[{"line_number":548,"context_line":"                        else:"},{"line_number":549,"context_line":"                            with excutils.save_and_reraise_exception():"},{"line_number":550,"context_line":"                                LOG.exception(_(\"Failed to access port %s\"),"},{"line_number":551,"context_line":"                                              port_id)"},{"line_number":552,"context_line":"                    if not port:"},{"line_number":553,"context_line":"                        raise exception.PortNotFound(port_id\u003dport_id)"},{"line_number":554,"context_line":"                    if port.get(\u0027device_id\u0027, None):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FX5w%3D","line":551,"in_reply_to":"AAAAUH%2F%2FZpU%3D","updated":"2014-01-14 14:15:40.000000000","message":"this method does not have instance so i guess not","commit_id":"057ae0713ccb595febec10152df80dabb035c3b4"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"e0ac76685623e6253063f2f1eb154c260223cf77","unresolved":false,"context_lines":[{"line_number":738,"context_line":"                raise exception.FloatingIpNotFound(id\u003did)"},{"line_number":739,"context_line":"            else:"},{"line_number":740,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":741,"context_line":"                    LOG.exception(_(\u0027Unable to access floating IP %s\u0027), id)"},{"line_number":742,"context_line":"        pool_dict \u003d self._setup_net_dict(client,"},{"line_number":743,"context_line":"                                         fip[\u0027floating_network_id\u0027])"},{"line_number":744,"context_line":"        port_dict \u003d self._setup_port_dict(client, fip[\u0027port_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FZpQ%3D","line":741,"updated":"2014-01-14 06:00:33.000000000","message":"ditto","commit_id":"057ae0713ccb595febec10152df80dabb035c3b4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e657410ba9b5355a1a855e564d24bd8ffa1e3454","unresolved":false,"context_lines":[{"line_number":738,"context_line":"                raise exception.FloatingIpNotFound(id\u003did)"},{"line_number":739,"context_line":"            else:"},{"line_number":740,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":741,"context_line":"                    LOG.exception(_(\u0027Unable to access floating IP %s\u0027), id)"},{"line_number":742,"context_line":"        pool_dict \u003d self._setup_net_dict(client,"},{"line_number":743,"context_line":"                                         fip[\u0027floating_network_id\u0027])"},{"line_number":744,"context_line":"        port_dict \u003d self._setup_port_dict(client, fip[\u0027port_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FX5I%3D","line":741,"in_reply_to":"AAAAUH%2F%2FZpQ%3D","updated":"2014-01-14 14:15:40.000000000","message":"same here","commit_id":"057ae0713ccb595febec10152df80dabb035c3b4"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"29e12d7f64b913da88d840d6e249956b14bd7fc2","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                raise exception.PortLimitExceeded()"},{"line_number":179,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":180,"context_line":"                LOG.exception(_(\u0027Neutron error creating port on network %s\u0027),"},{"line_number":181,"context_line":"                              network_id, instance\u003dinstance)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def allocate_for_instance(self, context, instance, **kwargs):"},{"line_number":184,"context_line":"        \"\"\"Allocate network resources for the instance."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FSV8%3D","line":181,"updated":"2014-01-15 13:30:12.000000000","message":"It looks like this is the only place where you\u0027re fixing a bug.  The other three are adding new log messages.  The commit message implies you\u0027re only fixing a bug.\n\nI would either remove the new messages and only have this one change, or update the commit message to better reflect the scope of the change.","commit_id":"4fd5c3eca8c67006f91e123084675188a6c3bf52"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"e044cfdacf8b8d88d549a52ea024c130d0f26387","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                raise exception.PortLimitExceeded()"},{"line_number":179,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":180,"context_line":"                LOG.exception(_(\u0027Neutron error creating port on network %s\u0027),"},{"line_number":181,"context_line":"                              network_id, instance\u003dinstance)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def allocate_for_instance(self, context, instance, **kwargs):"},{"line_number":184,"context_line":"        \"\"\"Allocate network resources for the instance."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FSOA%3D","line":181,"in_reply_to":"AAAAUH%2F%2FSV8%3D","updated":"2014-01-15 13:58:26.000000000","message":"Ah yes - this one was originally a bug - I missed that... sorry :(","commit_id":"4fd5c3eca8c67006f91e123084675188a6c3bf52"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d997a8160af3abe5cb1c4b3ac0ea0c4daff314b2","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                raise exception.PortLimitExceeded()"},{"line_number":179,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":180,"context_line":"                LOG.exception(_(\u0027Neutron error creating port on network %s\u0027),"},{"line_number":181,"context_line":"                              network_id, instance\u003dinstance)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def allocate_for_instance(self, context, instance, **kwargs):"},{"line_number":184,"context_line":"        \"\"\"Allocate network resources for the instance."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FRzM%3D","line":181,"in_reply_to":"AAAAUH%2F%2FSV8%3D","updated":"2014-01-15 15:15:20.000000000","message":"Done","commit_id":"4fd5c3eca8c67006f91e123084675188a6c3bf52"}]}