)]}'
{"id":"openstack%2Fnova~662333","triplet_id":"openstack%2Fnova~stable%2Frocky~Icd7fcb87a09c35a13e4e14235feb30a289d22778","project":"openstack/nova","branch":"stable/rocky","topic":"bug/1775418","hashtags":[],"change_id":"Icd7fcb87a09c35a13e4e14235feb30a289d22778","subject":"Block swap volume on volumes with \u003e1 rw attachment","status":"MERGED","created":"2019-05-30 21:14:22.000000000","updated":"2019-06-03 09:28:23.000000000","submitted":"2019-06-03 09:28:23.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"662333-1559554103371-0e238d65","meta_rev_id":"590aff4389830e821ca032681f082cb95b972eef","_number":662333,"virtual_id_number":662333,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-05-30 21:47:12.000000000","_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-05-30 23:17:15.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-05-31 11:48:59.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-06-03 09:28:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2019-06-03 07:28:04.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-03 07:28:04.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-30 21:47:12.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-05-30 23:17:15.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-05-31 11:48:59.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-06-03 07:28:04.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-06-03 09:28:22.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cfb4795e912621c627cb6d44c3ca1a76a9865a61","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-30 21:14:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e1c87e8c38763a0884921d263de8ffe066833725","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-30 21:23:46.000000000","message":"Patch Set 1: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"349c9c582ff5047483dfc13f7f15b77faacddf87","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-30 21:25:30.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"81099642549fd97810b219dab0d39f930edf4a5e","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-05-30 21:47:12.000000000","message":"Patch Set 2:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/33/662333/2/check/nova-out-of-tree-pvm/3e0434d : FAILURE in 20m 20s\n- nova-in-tree-pvm http://184.172.12.213/33/662333/2/check/nova-in-tree-pvm/f17c387 : FAILURE in 20m 56s","accounts_in_message":[],"_revision_number":2},{"id":"128cbc53e873a53c73e397b69563765459d188bc","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-05-30 23:17:15.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/662333/2 : FAILURE in 1h 50m 58s","accounts_in_message":[],"_revision_number":2},{"id":"4cdcc80957c79f5a0044362dc3fdc3eab81f7f52","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-31 01:11:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/33/662333/2/check/openstack-tox-pep8/e629218/ : SUCCESS in 10m 40s\n- openstack-tox-py27 http://logs.openstack.org/33/662333/2/check/openstack-tox-py27/41840c7/ : SUCCESS in 14m 07s\n- openstack-tox-py35 http://logs.openstack.org/33/662333/2/check/openstack-tox-py35/033d7e6/ : SUCCESS in 12m 34s\n- build-openstack-sphinx-docs http://logs.openstack.org/33/662333/2/check/build-openstack-sphinx-docs/c5f3b64/html/ : SUCCESS in 6m 48s\n- tempest-full http://logs.openstack.org/33/662333/2/check/tempest-full/06a32a1/ : SUCCESS in 1h 43m 51s\n- neutron-grenade http://logs.openstack.org/33/662333/2/check/neutron-grenade/c0affe8/ : SUCCESS in 56m 15s\n- tempest-full-py3 http://logs.openstack.org/33/662333/2/check/tempest-full-py3/3860e9e/ : SUCCESS in 1h 37m 30s\n- build-openstack-releasenotes http://logs.openstack.org/33/662333/2/check/build-openstack-releasenotes/5ce3758/html/ : SUCCESS in 47m 06s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/33/662333/2/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/2dc638e/ : SUCCESS in 41m 53s (non-voting)\n- nova-cells-v1 http://logs.openstack.org/33/662333/2/check/nova-cells-v1/788c6e3/ : SUCCESS in 57m 15s\n- nova-grenade-live-migration http://logs.openstack.org/33/662333/2/check/nova-grenade-live-migration/46a6a36/ : SUCCESS in 1h 06m 22s (non-voting)\n- nova-live-migration http://logs.openstack.org/33/662333/2/check/nova-live-migration/c79f826/ : SUCCESS in 46m 04s\n- nova-multiattach http://logs.openstack.org/33/662333/2/check/nova-multiattach/d21fadd/ : SUCCESS in 1h 17m 06s\n- nova-next http://logs.openstack.org/33/662333/2/check/nova-next/8cbfb92/ : SUCCESS in 1h 33m 21s\n- tempest-slow http://logs.openstack.org/33/662333/2/check/tempest-slow/982d340/ : SUCCESS in 2h 11m 39s\n- nova-tox-functional http://logs.openstack.org/33/662333/2/check/nova-tox-functional/62746f2/ : SUCCESS in 17m 10s\n- nova-tox-functional-py35 http://logs.openstack.org/33/662333/2/check/nova-tox-functional-py35/80b4eab/ : SUCCESS in 19m 56s\n- openstack-tox-lower-constraints http://logs.openstack.org/33/662333/2/check/openstack-tox-lower-constraints/1ca7dfa/ : SUCCESS in 12m 15s\n- neutron-grenade-multinode http://logs.openstack.org/33/662333/2/check/neutron-grenade-multinode/c764444/ : SUCCESS in 1h 07m 06s\n- devstack-plugin-ceph-tempest http://logs.openstack.org/33/662333/2/check/devstack-plugin-ceph-tempest/289dcab/ : SUCCESS in 1h 08m 57s (non-voting)\n- tempest-multinode-full http://logs.openstack.org/33/662333/2/check/tempest-multinode-full/26e1afa/ : SUCCESS in 1h 34m 25s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"3fcb4caac8d15452d46d036fde0030f41b076e58","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-05-31 11:48:59.000000000","message":"Patch Set 2:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/33/662333/2/check/tempest-dsvm-full-xenial/c1c9ec0/ : FAILURE in 17m 12s\n- tempest-dsvm-full-xenial-py3 https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/33/662333/2/check/tempest-dsvm-full-xenial-py3/da05f1b/ : FAILURE in 20m 06s (non-voting)\n- grenade-dsvm-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/33/662333/2/check/grenade-dsvm-xenial/6b092b9/ : SUCCESS in 1h 03m 21s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"ce1f52298bc258b3f7a94e7a313c2b4568d87174","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-06-03 07:28:04.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLGTM, test conflict noted and merged into stein. Approving as this is from another Nova stable core.","accounts_in_message":[],"_revision_number":2},{"id":"06a657234307f46c3b5a3e368f8ac97cb3330d62","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-03 07:28:29.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"26156ba4faaeb40bde412fa2c7bc99851f3d0cf5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-03 09:28:22.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/33/662333/2/gate/openstack-tox-pep8/c594777/ : SUCCESS in 8m 54s\n- openstack-tox-py27 http://logs.openstack.org/33/662333/2/gate/openstack-tox-py27/49c46aa/ : SUCCESS in 11m 01s\n- openstack-tox-py35 http://logs.openstack.org/33/662333/2/gate/openstack-tox-py35/895bac9/ : SUCCESS in 12m 57s\n- build-openstack-sphinx-docs http://logs.openstack.org/33/662333/2/gate/build-openstack-sphinx-docs/09d9d2f/html/ : SUCCESS in 6m 50s\n- tempest-full http://logs.openstack.org/33/662333/2/gate/tempest-full/1633ff8/ : SUCCESS in 1h 28m 10s\n- neutron-grenade http://logs.openstack.org/33/662333/2/gate/neutron-grenade/d3bf5da/ : SUCCESS in 56m 04s\n- tempest-full-py3 http://logs.openstack.org/33/662333/2/gate/tempest-full-py3/6940fa6/ : SUCCESS in 1h 14m 54s\n- build-openstack-releasenotes http://logs.openstack.org/33/662333/2/gate/build-openstack-releasenotes/b567e24/html/ : SUCCESS in 41m 09s\n- nova-cells-v1 http://logs.openstack.org/33/662333/2/gate/nova-cells-v1/43988f0/ : SUCCESS in 51m 11s\n- nova-live-migration http://logs.openstack.org/33/662333/2/gate/nova-live-migration/8d7ef3f/ : SUCCESS in 44m 53s\n- nova-multiattach http://logs.openstack.org/33/662333/2/gate/nova-multiattach/d5eae23/ : SUCCESS in 1h 04m 04s\n- nova-next http://logs.openstack.org/33/662333/2/gate/nova-next/4872907/ : SUCCESS in 1h 40m 32s\n- tempest-slow http://logs.openstack.org/33/662333/2/gate/tempest-slow/152b493/ : SUCCESS in 1h 53m 13s\n- nova-tox-functional http://logs.openstack.org/33/662333/2/gate/nova-tox-functional/26c037b/ : SUCCESS in 19m 32s\n- nova-tox-functional-py35 http://logs.openstack.org/33/662333/2/gate/nova-tox-functional-py35/14751e0/ : SUCCESS in 16m 37s\n- openstack-tox-lower-constraints http://logs.openstack.org/33/662333/2/gate/openstack-tox-lower-constraints/9479845/ : SUCCESS in 13m 33s","accounts_in_message":[],"_revision_number":2},{"id":"8afedcf8df53e2833331a9c3f0bf0a22cba955de","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-03 09:28:23.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c19d602f9be536ee8412bac0f0951a995424f25e","revisions":{"4beb4829894b8d192c461ce5341413aaa5c9aed1":{"kind":"REWORK","_number":1,"created":"2019-05-30 21:14:22.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/33/662333/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/33/662333/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/662333/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/662333/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/662333/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/33/662333/1"}}},"commit":{"parents":[{"commit":"69dd48d7777e84d1e0512ab2f470649771cb9020","subject":"Merge \"Fix retry of instance_update_and_get_original\" into stable/rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/69dd48d7777e84d1e0512ab2f470649771cb9020"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2018-06-06 14:32:37.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-30 21:13:11.000000000","tz":-240},"subject":"Block swap volume on volumes with \u003e1 rw attachment","message":"Block swap volume on volumes with \u003e1 rw attachment\n\nIf we\u0027re swapping from a multiattach volume that has more than one\nread/write attachment, another server on the secondary attachment could\nbe writing to the volume which is not getting copied into the volume to\nwhich we\u0027re swapping, so we could have data loss during the swap.\n\nThis change does volume read/write attachment counting for the volume\nwe\u0027re swapping from and if there is more than one read/write attachment\non the volume, the swap volume operation fails with a 400 BadRequest\nerror.\n\nConflicts:\n      nova/tests/unit/compute/test_compute_api.py\n\nNOTE(mriedem): The conflict is due to Rocky change\nI7d5bddc0aa1833cda5f4bcebe5e03bdd447f641a changing the\ndecorators on the _test_snapshot_and_backup method.\n\nDepends-On: https://review.openstack.org/573025/\nCloses-Bug: #1775418\nChange-Id: Icd7fcb87a09c35a13e4e14235feb30a289d22778\n(cherry picked from commit 5a1d159d142997bb4288d4bf86d4e144334905cd)\n(cherry picked from commit 9b21d1067a071ab17758068dfca5cd2ebd29d868)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4beb4829894b8d192c461ce5341413aaa5c9aed1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4beb4829894b8d192c461ce5341413aaa5c9aed1"}]},"branch":"refs/heads/stable/rocky"},"c19d602f9be536ee8412bac0f0951a995424f25e":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-05-30 21:25:30.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/33/662333/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/33/662333/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/662333/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/662333/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/33/662333/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/33/662333/2"}}},"commit":{"parents":[{"commit":"69dd48d7777e84d1e0512ab2f470649771cb9020","subject":"Merge \"Fix retry of instance_update_and_get_original\" into stable/rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/69dd48d7777e84d1e0512ab2f470649771cb9020"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2018-06-06 14:32:37.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-30 21:25:06.000000000","tz":-240},"subject":"Block swap volume on volumes with \u003e1 rw attachment","message":"Block swap volume on volumes with \u003e1 rw attachment\n\nIf we\u0027re swapping from a multiattach volume that has more than one\nread/write attachment, another server on the secondary attachment could\nbe writing to the volume which is not getting copied into the volume to\nwhich we\u0027re swapping, so we could have data loss during the swap.\n\nThis change does volume read/write attachment counting for the volume\nwe\u0027re swapping from and if there is more than one read/write attachment\non the volume, the swap volume operation fails with a 400 BadRequest\nerror.\n\nConflicts:\n      nova/tests/unit/compute/test_compute_api.py\n\nNOTE(mriedem): The conflict is due to Stein change\nI7d5bddc0aa1833cda5f4bcebe5e03bdd447f641a changing the\ndecorators on the _test_snapshot_and_backup method.\n\nDepends-On: https://review.openstack.org/573025/\nCloses-Bug: #1775418\nChange-Id: Icd7fcb87a09c35a13e4e14235feb30a289d22778\n(cherry picked from commit 5a1d159d142997bb4288d4bf86d4e144334905cd)\n(cherry picked from commit 9b21d1067a071ab17758068dfca5cd2ebd29d868)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c19d602f9be536ee8412bac0f0951a995424f25e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c19d602f9be536ee8412bac0f0951a995424f25e"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}