)]}'
{"id":"openstack%2Fnova~662340","triplet_id":"openstack%2Fnova~stable%2Fqueens~Icd7fcb87a09c35a13e4e14235feb30a289d22778","project":"openstack/nova","branch":"stable/queens","topic":"bug/1775418","hashtags":[],"change_id":"Icd7fcb87a09c35a13e4e14235feb30a289d22778","subject":"Block swap volume on volumes with \u003e1 rw attachment","status":"MERGED","created":"2019-05-30 21:30:45.000000000","updated":"2019-06-03 11:29:02.000000000","submitted":"2019-06-03 11:29:02.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"662340-1559561342725-4f1731f4","meta_rev_id":"1b8a78996f8e7e419b9f77b44136e10198b6d6fb","_number":662340,"virtual_id_number":662340,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-05-30 22:11:28.000000000","_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-05-30 22:12:44.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-05-31 11:57:02.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2019-06-03 11:29:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2019-06-03 09:32:02.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-03 09:32:02.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-30 22:11:28.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-05-30 22:12:44.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-05-31 11:57:02.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-06-03 09:32:02.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-06-03 11:29:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d93ae324084628734b89717e646c479fb9a95dc7","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-30 21:30:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"aec82d7d8ff0246e96ca2022b7ee117b95d30674","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-05-30 22:11:28.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova-out-of-tree-pvm http://184.172.12.213/40/662340/1/check/nova-out-of-tree-pvm/2665a69 : SUCCESS in 39m 25s\n- nova-in-tree-pvm http://184.172.12.213/40/662340/1/check/nova-in-tree-pvm/7d191de : SUCCESS in 40m 01s","accounts_in_message":[],"_revision_number":1},{"id":"36cd26663051b24759e411b2e2930bf6c8dcd627","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-05-30 22:12:44.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/662340/1 : FAILURE in 41m 06s","accounts_in_message":[],"_revision_number":1},{"id":"3a02f5e13148bf10ef4c309e256dfbe0a68bc394","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-31 01:08:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/40/662340/1/check/openstack-tox-pep8/4417a6b/ : SUCCESS in 9m 15s\n- openstack-tox-py27 http://logs.openstack.org/40/662340/1/check/openstack-tox-py27/d36479b/ : SUCCESS in 11m 11s\n- openstack-tox-py35 http://logs.openstack.org/40/662340/1/check/openstack-tox-py35/8f915f4/ : SUCCESS in 14m 22s\n- build-openstack-sphinx-docs http://logs.openstack.org/40/662340/1/check/build-openstack-sphinx-docs/f8ad7fd/html/ : SUCCESS in 5m 43s\n- tempest-full http://logs.openstack.org/40/662340/1/check/tempest-full/e32b582/ : SUCCESS in 1h 46m 56s\n- neutron-grenade http://logs.openstack.org/40/662340/1/check/neutron-grenade/bf4fbd3/ : SUCCESS in 59m 01s\n- tempest-full-py3 http://logs.openstack.org/40/662340/1/check/tempest-full-py3/6f926b9/ : SUCCESS in 1h 16m 40s\n- build-openstack-releasenotes http://logs.openstack.org/40/662340/1/check/build-openstack-releasenotes/f3421bc/html/ : SUCCESS in 31m 54s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/40/662340/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/a5e541d/ : SUCCESS in 52m 32s (non-voting)\n- nova-cells-v1 http://logs.openstack.org/40/662340/1/check/nova-cells-v1/ee404e6/ : SUCCESS in 43m 12s\n- nova-grenade-live-migration http://logs.openstack.org/40/662340/1/check/nova-grenade-live-migration/34d5d86/ : SUCCESS in 57m 24s (non-voting)\n- nova-live-migration http://logs.openstack.org/40/662340/1/check/nova-live-migration/77847bb/ : SUCCESS in 44m 24s\n- nova-multiattach http://logs.openstack.org/40/662340/1/check/nova-multiattach/cfaec4d/ : SUCCESS in 1h 02m 06s\n- nova-next http://logs.openstack.org/40/662340/1/check/nova-next/909ad4b/ : SUCCESS in 1h 32m 30s\n- tempest-slow http://logs.openstack.org/40/662340/1/check/tempest-slow/815925c/ : SUCCESS in 1h 45m 19s\n- nova-tox-functional http://logs.openstack.org/40/662340/1/check/nova-tox-functional/e24fdc9/ : SUCCESS in 21m 20s\n- nova-tox-functional-py35 http://logs.openstack.org/40/662340/1/check/nova-tox-functional-py35/cc2973e/ : SUCCESS in 18m 50s\n- neutron-grenade-multinode http://logs.openstack.org/40/662340/1/check/neutron-grenade-multinode/ffb4319/ : SUCCESS in 1h 07m 21s\n- devstack-plugin-ceph-tempest http://logs.openstack.org/40/662340/1/check/devstack-plugin-ceph-tempest/96c4652/ : SUCCESS in 1h 10m 03s (non-voting)\n- tempest-multinode-full http://logs.openstack.org/40/662340/1/check/tempest-multinode-full/c9d36e7/ : SUCCESS in 1h 33m 47s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8a02151c643fe7a1e3eaca387a646407981df7a4","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-05-31 11:57:02.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/40/662340/1/check/tempest-dsvm-full-xenial/3b03380/ : SUCCESS in 1h 09m 41s\n- tempest-dsvm-full-xenial-py3 https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/40/662340/1/check/tempest-dsvm-full-xenial-py3/45a9735/ : FAILURE in 1h 07m 09s (non-voting)\n- grenade-dsvm-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/40/662340/1/check/grenade-dsvm-xenial/ffcd9d9/ : FAILURE in 1h 05m 17s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2710a01c0405d095efb0a145fb04d2d70634dcc6","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-06-03 09:32:02.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nLGTM, conflict noted and merged into Rocky. Approving as this is from another Nova stable core.","accounts_in_message":[],"_revision_number":1},{"id":"0d84bd279d432c613cf292229a7ce9f147846f44","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-03 09:32:21.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"c1e3ccbaddef58a657aaab69ae12196da280de79","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-03 11:29:02.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"b214ef3e851a47be7f5509af2e0cf57363299410","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-03 11:29:02.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/40/662340/1/gate/openstack-tox-pep8/0a1f74a/ : SUCCESS in 9m 04s\n- openstack-tox-py27 http://logs.openstack.org/40/662340/1/gate/openstack-tox-py27/fa9368b/ : SUCCESS in 13m 17s\n- openstack-tox-py35 http://logs.openstack.org/40/662340/1/gate/openstack-tox-py35/89be9b2/ : SUCCESS in 13m 09s\n- build-openstack-sphinx-docs http://logs.openstack.org/40/662340/1/gate/build-openstack-sphinx-docs/253d366/html/ : SUCCESS in 6m 28s\n- tempest-full http://logs.openstack.org/40/662340/1/gate/tempest-full/6fc5b78/ : SUCCESS in 1h 35m 24s\n- neutron-grenade http://logs.openstack.org/40/662340/1/gate/neutron-grenade/585049f/ : SUCCESS in 53m 36s\n- tempest-full-py3 http://logs.openstack.org/40/662340/1/gate/tempest-full-py3/a0d133b/ : SUCCESS in 1h 14m 59s\n- build-openstack-releasenotes http://logs.openstack.org/40/662340/1/gate/build-openstack-releasenotes/48c689a/html/ : SUCCESS in 31m 51s\n- nova-cells-v1 http://logs.openstack.org/40/662340/1/gate/nova-cells-v1/a32d512/ : SUCCESS in 47m 00s\n- nova-live-migration http://logs.openstack.org/40/662340/1/gate/nova-live-migration/2d02b1e/ : SUCCESS in 45m 19s\n- nova-multiattach http://logs.openstack.org/40/662340/1/gate/nova-multiattach/c954cd5/ : SUCCESS in 1h 00m 43s\n- nova-next http://logs.openstack.org/40/662340/1/gate/nova-next/0ce1d3a/ : SUCCESS in 1h 17m 08s\n- tempest-slow http://logs.openstack.org/40/662340/1/gate/tempest-slow/2f94638/ : SUCCESS in 1h 53m 19s\n- nova-tox-functional http://logs.openstack.org/40/662340/1/gate/nova-tox-functional/1b8563c/ : SUCCESS in 22m 07s\n- nova-tox-functional-py35 http://logs.openstack.org/40/662340/1/gate/nova-tox-functional-py35/1b87a62/ : SUCCESS in 20m 07s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"58a140487c8127da727fa7e4fb56892f8c162536","revisions":{"58a140487c8127da727fa7e4fb56892f8c162536":{"kind":"REWORK","_number":1,"created":"2019-05-30 21:30:45.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/40/662340/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/40/662340/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/662340/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/662340/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/662340/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/40/662340/1"}}},"commit":{"parents":[{"commit":"944b24f462f8785a5c039efb74eec5310ef7729e","subject":"Add functional confirm_migration_error test","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/944b24f462f8785a5c039efb74eec5310ef7729e"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2018-06-06 14:32:37.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-30 21:29:53.000000000","tz":-240},"subject":"Block swap volume on volumes with \u003e1 rw attachment","message":"Block swap volume on volumes with \u003e1 rw attachment\n\nIf we\u0027re swapping from a multiattach volume that has more than one\nread/write attachment, another server on the secondary attachment could\nbe writing to the volume which is not getting copied into the volume to\nwhich we\u0027re swapping, so we could have data loss during the swap.\n\nThis change does volume read/write attachment counting for the volume\nwe\u0027re swapping from and if there is more than one read/write attachment\non the volume, the swap volume operation fails with a 400 BadRequest\nerror.\n\nConflicts:\n      api-ref/source/os-volume-attachments.inc\n\nNOTE(mriedem): The conflict is due to not having change\nI5fc4d0ba3bb1c49dfaba2b2eed056441509cb9da in Queens. Also, the\nuuidsentinel has to be imported in the test_volumes module because\nchange I9acc2e4d6c57ea0f45ba161116993d9f1a0e1e9f is not in Queens.\n\nDepends-On: https://review.openstack.org/573025/\nCloses-Bug: #1775418\nChange-Id: Icd7fcb87a09c35a13e4e14235feb30a289d22778\n(cherry picked from commit 5a1d159d142997bb4288d4bf86d4e144334905cd)\n(cherry picked from commit 9b21d1067a071ab17758068dfca5cd2ebd29d868)\n(cherry picked from commit c19d602f9be536ee8412bac0f0951a995424f25e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/58a140487c8127da727fa7e4fb56892f8c162536"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/58a140487c8127da727fa7e4fb56892f8c162536"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}