)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"72a63305b454ef2cc46860ed84cdbfa31610141f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass extra_specs to flavor in vif tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In real life extra_specs is always present, even if empty."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Although it doesn\u0027t cause test failures right now, it is fixed as part"},{"line_number":12,"context_line":"of prepartion for blueprint: amd-sev-libvirt-support , where extra_specs"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_82a3c24f","line":9,"range":{"start_line":9,"start_character":28,"end_line":9,"end_character":57},"updated":"2019-06-03 10:54:26.000000000","message":"I don\u0027t think it is always present, e.g.\n\nhttps://opendev.org/openstack/nova/src/commit/1459e8edb9681537b263bd6fccfb7b9cbe12d923/nova/api/openstack/compute/flavor_manage.py#L44\n\nhttps://opendev.org/openstack/nova/src/commit/1459e8edb9681537b263bd6fccfb7b9cbe12d923/nova/compute/flavors.py#L123","commit_id":"d54ce5837093700ea7458a1b5c682b1287c6e256"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"72a63305b454ef2cc46860ed84cdbfa31610141f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass extra_specs to flavor in vif tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In real life extra_specs is always present, even if empty."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Although it doesn\u0027t cause test failures right now, it is fixed as part"},{"line_number":12,"context_line":"of prepartion for blueprint: amd-sev-libvirt-support , where extra_specs"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_22da16e9","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":12},"updated":"2019-06-03 10:54:26.000000000","message":"I think \"outside the test environment\" would be clearer, if that\u0027s what you mean here?","commit_id":"d54ce5837093700ea7458a1b5c682b1287c6e256"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"72a63305b454ef2cc46860ed84cdbfa31610141f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In real life extra_specs is always present, even if empty."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Although it doesn\u0027t cause test failures right now, it is fixed as part"},{"line_number":12,"context_line":"of prepartion for blueprint: amd-sev-libvirt-support , where extra_specs"},{"line_number":13,"context_line":"are used to check the traits"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_e2aabe17","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":49},"updated":"2019-06-03 10:54:26.000000000","message":"If it doesn\u0027t cause failures in the examples I listed above, why would it cause test failures?","commit_id":"d54ce5837093700ea7458a1b5c682b1287c6e256"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"72a63305b454ef2cc46860ed84cdbfa31610141f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In real life extra_specs is always present, even if empty."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Although it doesn\u0027t cause test failures right now, it is fixed as part"},{"line_number":12,"context_line":"of prepartion for blueprint: amd-sev-libvirt-support , where extra_specs"},{"line_number":13,"context_line":"are used to check the traits"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8ca6f0f37a18f81d024286a0e158353ed25fa2b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_c2c21aea","line":12,"range":{"start_line":12,"start_character":14,"end_line":12,"end_character":54},"updated":"2019-06-03 10:54:26.000000000","message":"\"for the amd-sev-libvirt-support blueprint,\"\n\nNo need to trigger the magic string here, since you already have it below.","commit_id":"d54ce5837093700ea7458a1b5c682b1287c6e256"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"72a63305b454ef2cc46860ed84cdbfa31610141f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In real life extra_specs is always present, even if empty."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Although it doesn\u0027t cause test failures right now, it is fixed as part"},{"line_number":12,"context_line":"of prepartion for blueprint: amd-sev-libvirt-support , where extra_specs"},{"line_number":13,"context_line":"are used to check the traits"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8ca6f0f37a18f81d024286a0e158353ed25fa2b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_4285caac","line":12,"range":{"start_line":12,"start_character":3,"end_line":12,"end_character":13},"updated":"2019-06-03 10:54:26.000000000","message":"\"preparation\"","commit_id":"d54ce5837093700ea7458a1b5c682b1287c6e256"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"72a63305b454ef2cc46860ed84cdbfa31610141f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In real life extra_specs is always present, even if empty."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Although it doesn\u0027t cause test failures right now, it is fixed as part"},{"line_number":12,"context_line":"of prepartion for blueprint: amd-sev-libvirt-support , where extra_specs"},{"line_number":13,"context_line":"are used to check the traits"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8ca6f0f37a18f81d024286a0e158353ed25fa2b5"},{"line_number":16,"context_line":"blueprint: amd-sev-libvirt-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_22b1b690","line":13,"range":{"start_line":12,"start_character":61,"end_line":13,"end_character":28},"updated":"2019-06-03 10:54:26.000000000","message":"Any chance you could give a bit more detail on this, to help us reviewers understand what\u0027s coming next?","commit_id":"d54ce5837093700ea7458a1b5c682b1287c6e256"}]}