)]}'
{"id":"openstack%2Fnova~662774","triplet_id":"openstack%2Fnova~stable%2Fqueens~I05700c97f756edb7470be7273d5c9c3d76d63e29","project":"openstack/nova","branch":"stable/queens","topic":"bug/1830747","hashtags":[],"change_id":"I05700c97f756edb7470be7273d5c9c3d76d63e29","subject":"Add regression recreate test for bug 1830747","status":"MERGED","created":"2019-06-03 14:39:12.000000000","updated":"2019-07-01 20:34:29.000000000","submitted":"2019-07-01 20:34:29.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"662774-1562013269834-30d87466","meta_rev_id":"1b9f79a82a6a665ac547f71c0322173ae3c855ec","_number":662774,"virtual_id_number":662774,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-06-03 20:25:17.000000000","_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-06-03 21:30:56.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2019-07-01 20:34:29.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":2,"date":"2019-07-01 18:44:07.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":1,"date":"2019-07-01 18:44:07.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-03 20:25:17.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-06-03 21:30:56.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-07-01 18:44:07.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-07-01 20:34:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0cf0493c1a7d4e0212e14bce6cb481c9a767d2a5","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-03 14:39:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d35ea4ad080ef85b5ebd10e0005b5cf7c6bb6d32","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-06-03 15:24:40.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/662774/1 : FAILURE in 44m 23s","accounts_in_message":[],"_revision_number":1},{"id":"18cedc996a990b47f18b2d9cb9ea60e4ab9785d9","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-06-03 15:25:16.000000000","message":"Patch Set 1:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/74/662774/1/check/nova-out-of-tree-pvm/44f2396 : FAILURE in 45m 26s\n- nova-in-tree-pvm http://184.172.12.213/74/662774/1/check/nova-in-tree-pvm/7d57966 : FAILURE in 44m 26s","accounts_in_message":[],"_revision_number":1},{"id":"3e0dc0535b9734e11a208af3c925c940d9a374d9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-03 16:35:33.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/74/662774/1/check/openstack-tox-pep8/6e7c980/ : SUCCESS in 8m 30s\n- openstack-tox-py27 http://logs.openstack.org/74/662774/1/check/openstack-tox-py27/5ecb9f1/ : SUCCESS in 16m 35s\n- openstack-tox-py35 http://logs.openstack.org/74/662774/1/check/openstack-tox-py35/db5528b/ : SUCCESS in 14m 16s\n- build-openstack-sphinx-docs http://logs.openstack.org/74/662774/1/check/build-openstack-sphinx-docs/744811b/html/ : SUCCESS in 6m 31s\n- nova-tox-functional http://logs.openstack.org/74/662774/1/check/nova-tox-functional/4756ab0/ : FAILURE in 18m 30s\n- nova-tox-functional-py35 http://logs.openstack.org/74/662774/1/check/nova-tox-functional-py35/a87df10/ : FAILURE in 19m 14s","accounts_in_message":[],"_revision_number":1},{"id":"d80370c3a2a328e3714a3b5dac9eeae0c82f0102","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-03 19:39:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"86148c53c36f06f842869d5c277ecb88cbbe7ddf","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-06-03 20:25:17.000000000","message":"Patch Set 2:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/74/662774/2/check/nova-out-of-tree-pvm/34fbaee : FAILURE in 45m 10s\n- nova-in-tree-pvm http://184.172.12.213/74/662774/2/check/nova-in-tree-pvm/6169542 : FAILURE in 44m 44s","accounts_in_message":[],"_revision_number":2},{"id":"f78a1330110533a39951e25c7a08f3e6fc620ab1","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-06-03 21:30:56.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/662774/2 : FAILURE in 45m 19s","accounts_in_message":[],"_revision_number":2},{"id":"e36c5f7595c0f243ca7f4b7dff52658f62ef460d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-03 22:44:32.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/74/662774/2/check/openstack-tox-pep8/de1df5f/ : SUCCESS in 8m 53s\n- openstack-tox-py27 http://logs.openstack.org/74/662774/2/check/openstack-tox-py27/adaae11/ : SUCCESS in 14m 50s\n- openstack-tox-py35 http://logs.openstack.org/74/662774/2/check/openstack-tox-py35/706adf4/ : SUCCESS in 12m 45s\n- build-openstack-sphinx-docs http://logs.openstack.org/74/662774/2/check/build-openstack-sphinx-docs/92928ba/html/ : SUCCESS in 6m 17s\n- nova-tox-functional http://logs.openstack.org/74/662774/2/check/nova-tox-functional/77f8d62/ : SUCCESS in 20m 47s\n- nova-tox-functional-py35 http://logs.openstack.org/74/662774/2/check/nova-tox-functional-py35/3e30054/ : SUCCESS in 18m 48s","accounts_in_message":[],"_revision_number":2},{"id":"3678fbdbbee6d618f67a888cddf3f389e6a5dbfb","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-07-01 18:44:07.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLGTM, changes from master NOTEd, reproduces the issue fixed by the above bugfix.","accounts_in_message":[],"_revision_number":2},{"id":"6968bc3f5ebe741ca70b20b4cdaf98eed4adfb5c","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-07-01 18:44:37.000000000","message":"Patch Set 2:\n\naaaaaand obviously I\u0027m approving as this was submitted by another Nova stable core.","accounts_in_message":[],"_revision_number":2},{"id":"61c72b23eb949178095cfac3bb511ae59682006a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-01 18:48:18.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"9fda8988c9cc849caf79e1865ce4f19894eb445c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-01 20:34:29.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"b5656b52abe9372b5dbd7685de5642e1c103098b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-01 20:34:29.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/74/662774/2/gate/openstack-tox-pep8/bc769de/ : SUCCESS in 9m 43s\n- openstack-tox-py27 http://logs.openstack.org/74/662774/2/gate/openstack-tox-py27/78d0955/ : SUCCESS in 12m 28s\n- openstack-tox-py35 http://logs.openstack.org/74/662774/2/gate/openstack-tox-py35/83c5d71/ : SUCCESS in 13m 22s\n- build-openstack-sphinx-docs http://logs.openstack.org/74/662774/2/gate/build-openstack-sphinx-docs/e6bdef3/html/ : SUCCESS in 7m 25s\n- nova-tox-functional http://logs.openstack.org/74/662774/2/gate/nova-tox-functional/91fad75/ : SUCCESS in 20m 31s\n- nova-tox-functional-py35 http://logs.openstack.org/74/662774/2/gate/nova-tox-functional-py35/74aaf45/ : SUCCESS in 21m 04s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"581df2c98676b6734e8195ab56c9e0dba74789a5","revisions":{"6538ff1e67a2c1f6fb4bd94af7efdefefbeca1f1":{"kind":"REWORK","_number":1,"created":"2019-06-03 14:39:12.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/74/662774/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/74/662774/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/74/662774/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/74/662774/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/74/662774/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/74/662774/1"}}},"commit":{"parents":[{"commit":"58a140487c8127da727fa7e4fb56892f8c162536","subject":"Block swap volume on volumes with \u003e1 rw attachment","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/58a140487c8127da727fa7e4fb56892f8c162536"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-28 17:59:20.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-06-03 14:38:36.000000000","tz":-240},"subject":"Add regression recreate test for bug 1830747","message":"Add regression recreate test for bug 1830747\n\nBefore change I4244f7dd8fe74565180f73684678027067b4506e in Stein, when\na cold migration would reschedule to conductor it would not send the\nRequestSpec, only the filter_properties. The filter_properties contain\na primitive version of the instance group information from the RequestSpec\nfor things like the group members, hosts and policies, but not the uuid.\nWhen conductor is trying to reschedule the cold migration without a\nRequestSpec, it builds a RequestSpec from the components it has, like the\nfilter_properties. This results in a RequestSpec with an instance_group\nfield set but with no uuid field in the RequestSpec.instance_group.\nThat RequestSpec gets persisted and then because of change\nIe70c77db753711e1449e99534d3b83669871943f, later attempts to load the\nRequestSpec from the database will fail because of the missing\nRequestSpec.instance_group.uuid.\n\nThe test added here recreates the pre-Stein scenario which could still\nbe a problem (on master) for any corrupted RequestSpecs for older\ninstances.\n\nChange-Id: I05700c97f756edb7470be7273d5c9c3d76d63e29\nRelated-Bug: #1830747\n(cherry picked from commit c96c7c5e13bde39944a9dde7da7fe418b311ca2d)\n(cherry picked from commit 8478a754802e29dffbb65ef363ee189162f0adea)\n(cherry picked from commit a0a187c9bb9bef149e193027a6eedc09ba10ce1f)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6538ff1e67a2c1f6fb4bd94af7efdefefbeca1f1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6538ff1e67a2c1f6fb4bd94af7efdefefbeca1f1"}]},"branch":"refs/heads/stable/queens"},"581df2c98676b6734e8195ab56c9e0dba74789a5":{"kind":"REWORK","_number":2,"created":"2019-06-03 19:39:27.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/74/662774/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/74/662774/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/74/662774/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/74/662774/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/74/662774/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/74/662774/2"}}},"commit":{"parents":[{"commit":"58a140487c8127da727fa7e4fb56892f8c162536","subject":"Block swap volume on volumes with \u003e1 rw attachment","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/58a140487c8127da727fa7e4fb56892f8c162536"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-28 17:59:20.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-06-03 19:37:59.000000000","tz":-240},"subject":"Add regression recreate test for bug 1830747","message":"Add regression recreate test for bug 1830747\n\nBefore change I4244f7dd8fe74565180f73684678027067b4506e in Stein, when\na cold migration would reschedule to conductor it would not send the\nRequestSpec, only the filter_properties. The filter_properties contain\na primitive version of the instance group information from the RequestSpec\nfor things like the group members, hosts and policies, but not the uuid.\nWhen conductor is trying to reschedule the cold migration without a\nRequestSpec, it builds a RequestSpec from the components it has, like the\nfilter_properties. This results in a RequestSpec with an instance_group\nfield set but with no uuid field in the RequestSpec.instance_group.\nThat RequestSpec gets persisted and then because of change\nIe70c77db753711e1449e99534d3b83669871943f, later attempts to load the\nRequestSpec from the database will fail because of the missing\nRequestSpec.instance_group.uuid.\n\nThe test added here recreates the pre-Stein scenario which could still\nbe a problem (on master) for any corrupted RequestSpecs for older\ninstances.\n\nNOTE(mriedem): In this version we have to request a specific port\nto avoid a NetworkAmbiguous failure when creating the server.\n\nChange-Id: I05700c97f756edb7470be7273d5c9c3d76d63e29\nRelated-Bug: #1830747\n(cherry picked from commit c96c7c5e13bde39944a9dde7da7fe418b311ca2d)\n(cherry picked from commit 8478a754802e29dffbb65ef363ee189162f0adea)\n(cherry picked from commit a0a187c9bb9bef149e193027a6eedc09ba10ce1f)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/581df2c98676b6734e8195ab56c9e0dba74789a5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/581df2c98676b6734e8195ab56c9e0dba74789a5"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}