)]}'
{"nova/policies/servers.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d7d52cac8bdf1219703ad8cbc5ccc5743161003c","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    # should do that by default."},{"line_number":100,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":101,"context_line":"        SERVERS % \u0027show:host_status\u0027,"},{"line_number":102,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"Show a server with additional host status information."},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_a6ab4e1b","line":102,"updated":"2020-04-14 09:55:12.000000000","message":"System admin for this","commit_id":"931575bfa3d75dc894fda651806eb87dd25c803e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dd9304408daaca48793e972bdbe65960bb3f572a","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    # should do that by default."},{"line_number":100,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":101,"context_line":"        SERVERS % \u0027show:host_status\u0027,"},{"line_number":102,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"Show a server with additional host status information."},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_3cd1f855","line":102,"in_reply_to":"3f4c43b2_a6ab4e1b","updated":"2020-04-15 02:02:03.000000000","message":"yeah done in https://review.opendev.org/#/c/719730/1","commit_id":"931575bfa3d75dc894fda651806eb87dd25c803e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d7d52cac8bdf1219703ad8cbc5ccc5743161003c","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        ]),"},{"line_number":133,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":134,"context_line":"            SERVERS % \u0027show:host_status:unknown-only\u0027,"},{"line_number":135,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":136,"context_line":"        \"\"\""},{"line_number":137,"context_line":"Show a server with additional host status information, only if host status is"},{"line_number":138,"context_line":"UNKNOWN."}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_266d7e04","line":135,"updated":"2020-04-14 09:55:12.000000000","message":"As above, but I would make all these scopes project and system, so folks can loosen it","commit_id":"931575bfa3d75dc894fda651806eb87dd25c803e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d7d52cac8bdf1219703ad8cbc5ccc5743161003c","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        # which is PROJECT_MEMBER so making this as SYSTEM_ADMIN"},{"line_number":174,"context_line":"        # does not make sense as system scoped role cannot"},{"line_number":175,"context_line":"        # pass the \u0027create\u0027 policy. opinion ?"},{"line_number":176,"context_line":"        check_str\u003dbase.RULE_ADMIN_API,"},{"line_number":177,"context_line":"        description\u003d\"\"\""},{"line_number":178,"context_line":"Create a server on the specified host and/or node."},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_4621aab4","line":176,"updated":"2020-04-14 09:55:12.000000000","message":"It’s a problem... I think we need to do project admin and add a todo about fixing this so system admin can become the default, I.e. allow project-Id to be passed by system admin in new micro version, similar to key pair fix","commit_id":"931575bfa3d75dc894fda651806eb87dd25c803e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dd9304408daaca48793e972bdbe65960bb3f572a","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        # which is PROJECT_MEMBER so making this as SYSTEM_ADMIN"},{"line_number":174,"context_line":"        # does not make sense as system scoped role cannot"},{"line_number":175,"context_line":"        # pass the \u0027create\u0027 policy. opinion ?"},{"line_number":176,"context_line":"        check_str\u003dbase.RULE_ADMIN_API,"},{"line_number":177,"context_line":"        description\u003d\"\"\""},{"line_number":178,"context_line":"Create a server on the specified host and/or node."},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_1ce99c19","line":176,"in_reply_to":"3f4c43b2_4621aab4","updated":"2020-04-15 02:02:03.000000000","message":"this proposal looks good to me. \n\nDone in https://review.opendev.org/#/c/720116/1","commit_id":"931575bfa3d75dc894fda651806eb87dd25c803e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d7d52cac8bdf1219703ad8cbc5ccc5743161003c","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                \u0027path\u0027: \u0027/servers\u0027"},{"line_number":188,"context_line":"            }"},{"line_number":189,"context_line":"        ],"},{"line_number":190,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027]),"},{"line_number":191,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":192,"context_line":"        REQUESTED_DESTINATION,"},{"line_number":193,"context_line":"        base.RULE_ADMIN_API,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_862bb292","line":190,"updated":"2020-04-14 09:55:12.000000000","message":"Correct!","commit_id":"931575bfa3d75dc894fda651806eb87dd25c803e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d7d52cac8bdf1219703ad8cbc5ccc5743161003c","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027]),"},{"line_number":191,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":192,"context_line":"        REQUESTED_DESTINATION,"},{"line_number":193,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":194,"context_line":"        \"\"\""},{"line_number":195,"context_line":"Create a server on the requested compute service host and/or"},{"line_number":196,"context_line":"hypervisor_hostname."}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_c61e5a6f","line":193,"updated":"2020-04-14 09:55:12.000000000","message":"As above","commit_id":"931575bfa3d75dc894fda651806eb87dd25c803e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dd9304408daaca48793e972bdbe65960bb3f572a","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027]),"},{"line_number":191,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":192,"context_line":"        REQUESTED_DESTINATION,"},{"line_number":193,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":194,"context_line":"        \"\"\""},{"line_number":195,"context_line":"Create a server on the requested compute service host and/or"},{"line_number":196,"context_line":"hypervisor_hostname."}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_5cf3240b","line":193,"in_reply_to":"3f4c43b2_c61e5a6f","updated":"2020-04-15 02:02:03.000000000","message":"done in separate patch not to overload this one.\n- https://review.opendev.org/#/c/720116/1","commit_id":"931575bfa3d75dc894fda651806eb87dd25c803e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d7d52cac8bdf1219703ad8cbc5ccc5743161003c","unresolved":false,"context_lines":[{"line_number":276,"context_line":"            # Attach a network or port to an existing server."},{"line_number":277,"context_line":"            {"},{"line_number":278,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"},{"line_number":279,"context_line":"                \u0027path\u0027: \u0027/servers/{server_id}/os-interface\u0027"},{"line_number":280,"context_line":"            }"},{"line_number":281,"context_line":"        ]),"},{"line_number":282,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_c9030d0d","line":279,"updated":"2020-04-14 09:55:12.000000000","message":"Note system admin can do this today","commit_id":"931575bfa3d75dc894fda651806eb87dd25c803e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dd9304408daaca48793e972bdbe65960bb3f572a","unresolved":false,"context_lines":[{"line_number":276,"context_line":"            # Attach a network or port to an existing server."},{"line_number":277,"context_line":"            {"},{"line_number":278,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"},{"line_number":279,"context_line":"                \u0027path\u0027: \u0027/servers/{server_id}/os-interface\u0027"},{"line_number":280,"context_line":"            }"},{"line_number":281,"context_line":"        ]),"},{"line_number":282,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_9cdc8c75","line":279,"in_reply_to":"3f4c43b2_c9030d0d","updated":"2020-04-15 02:02:03.000000000","message":"done - https://review.opendev.org/#/c/720116/1","commit_id":"931575bfa3d75dc894fda651806eb87dd25c803e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d7d52cac8bdf1219703ad8cbc5ccc5743161003c","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027]),"},{"line_number":348,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":349,"context_line":"        CROSS_CELL_RESIZE,"},{"line_number":350,"context_line":"        base.RULE_NOBODY,"},{"line_number":351,"context_line":"        \"Resize a server across cells. By default, this is disabled for all \""},{"line_number":352,"context_line":"        \"users and recommended to be tested in a deployment for admin users \""},{"line_number":353,"context_line":"        \"before opening it up to non-admin users. Resizing within a cell is \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_6912b95a","line":350,"updated":"2020-04-14 09:55:12.000000000","message":"Need to allow system admin or project member as admin option here","commit_id":"931575bfa3d75dc894fda651806eb87dd25c803e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dd9304408daaca48793e972bdbe65960bb3f572a","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027project\u0027]),"},{"line_number":348,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":349,"context_line":"        CROSS_CELL_RESIZE,"},{"line_number":350,"context_line":"        base.RULE_NOBODY,"},{"line_number":351,"context_line":"        \"Resize a server across cells. By default, this is disabled for all \""},{"line_number":352,"context_line":"        \"users and recommended to be tested in a deployment for admin users \""},{"line_number":353,"context_line":"        \"before opening it up to non-admin users. Resizing within a cell is \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_bce34833","line":350,"in_reply_to":"3f4c43b2_6912b95a","updated":"2020-04-15 02:02:03.000000000","message":"added scope for both and kept default as it is - https://review.opendev.org/#/c/720116/1","commit_id":"931575bfa3d75dc894fda651806eb87dd25c803e"}]}