)]}'
{"nova/api/openstack/compute/admin_actions.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3cfa4fbbcb86b1e5ee29c711cea46aa103ae1762","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def _reset_network(self, req, id, body):"},{"line_number":41,"context_line":"        \"\"\"Permit admins to reset networking on a server.\"\"\""},{"line_number":42,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":43,"context_line":"        context.can(aa_policies.POLICY_ROOT % \u0027reset_network\u0027, {})"},{"line_number":44,"context_line":"        instance \u003d common.get_instance(self.compute_api, context, id)"},{"line_number":45,"context_line":"        try:"},{"line_number":46,"context_line":"            self.compute_api.reset_network(context, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_0a04bf14","line":43,"range":{"start_line":43,"start_character":61,"end_line":43,"end_character":66},"updated":"2019-07-05 11:35:57.000000000","message":"these are admin APIs and policy default are admin role. passing {} seems ok to me as after new defaults and scope it would not have any target\u0027s data in check_str.","commit_id":"665e5f2391742f783279f309649980cc580372b0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0441de6ae6749ee24e87cf7beefcc63247cd5e42","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def _reset_network(self, req, id, body):"},{"line_number":41,"context_line":"        \"\"\"Permit admins to reset networking on a server.\"\"\""},{"line_number":42,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":43,"context_line":"        context.can(aa_policies.POLICY_ROOT % \u0027reset_network\u0027, {})"},{"line_number":44,"context_line":"        instance \u003d common.get_instance(self.compute_api, context, id)"},{"line_number":45,"context_line":"        try:"},{"line_number":46,"context_line":"            self.compute_api.reset_network(context, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_6fb4fa1d","line":43,"range":{"start_line":43,"start_character":61,"end_line":43,"end_character":66},"in_reply_to":"3fa7e38b_adee9efb","updated":"2020-01-21 17:27:44.000000000","message":"no, scope cannot be configured. they can configure only check_str.\n\nDB level project scope things should be removed too but I have kept that separate from this BP. Once we finish this then, I will work on that part but yes at the end we should cleanup those bits too.","commit_id":"665e5f2391742f783279f309649980cc580372b0"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"cd808040ab2a5134b0f581ed8e3288a0f5327438","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def _reset_network(self, req, id, body):"},{"line_number":41,"context_line":"        \"\"\"Permit admins to reset networking on a server.\"\"\""},{"line_number":42,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":43,"context_line":"        context.can(aa_policies.POLICY_ROOT % \u0027reset_network\u0027, {})"},{"line_number":44,"context_line":"        instance \u003d common.get_instance(self.compute_api, context, id)"},{"line_number":45,"context_line":"        try:"},{"line_number":46,"context_line":"            self.compute_api.reset_network(context, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_adee9efb","line":43,"range":{"start_line":43,"start_character":61,"end_line":43,"end_character":66},"in_reply_to":"7faddb67_0a04bf14","updated":"2020-01-19 06:53:10.000000000","message":"But the scope is configurable, right? If the operator change the scope to project scope, then we need the real target.\n\nAnother question, I found we still have db level project scope check, is that something we plan to remove?","commit_id":"665e5f2391742f783279f309649980cc580372b0"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"e632b7f269b3a79c9c0861dafd8183d9e0c1bb4e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def _reset_network(self, req, id, body):"},{"line_number":41,"context_line":"        \"\"\"Permit admins to reset networking on a server.\"\"\""},{"line_number":42,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":43,"context_line":"        context.can(aa_policies.POLICY_ROOT % \u0027reset_network\u0027, {})"},{"line_number":44,"context_line":"        instance \u003d common.get_instance(self.compute_api, context, id)"},{"line_number":45,"context_line":"        try:"},{"line_number":46,"context_line":"            self.compute_api.reset_network(context, instance)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_7d3ae697","line":43,"range":{"start_line":43,"start_character":63,"end_line":43,"end_character":65},"updated":"2020-01-14 08:28:37.000000000","message":"nit: target\u003d{}","commit_id":"2b4edfea99dfe599f685e9c26fab7db346c8538c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2949f0ed80c56c3bde63626a622718e2282363ca","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def _reset_network(self, req, id, body):"},{"line_number":41,"context_line":"        \"\"\"Permit admins to reset networking on a server.\"\"\""},{"line_number":42,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":43,"context_line":"        context.can(aa_policies.POLICY_ROOT % \u0027reset_network\u0027, {})"},{"line_number":44,"context_line":"        instance \u003d common.get_instance(self.compute_api, context, id)"},{"line_number":45,"context_line":"        try:"},{"line_number":46,"context_line":"            self.compute_api.reset_network(context, instance)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_be20429c","line":43,"range":{"start_line":43,"start_character":63,"end_line":43,"end_character":65},"in_reply_to":"3fa7e38b_7d3ae697","updated":"2020-01-14 23:22:57.000000000","message":"I used target in all other patches but forget this. I will update this if end up respin.","commit_id":"2b4edfea99dfe599f685e9c26fab7db346c8538c"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"e632b7f269b3a79c9c0861dafd8183d9e0c1bb4e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def _inject_network_info(self, req, id, body):"},{"line_number":54,"context_line":"        \"\"\"Permit admins to inject network info into a server.\"\"\""},{"line_number":55,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":56,"context_line":"        context.can(aa_policies.POLICY_ROOT % \u0027inject_network_info\u0027, {})"},{"line_number":57,"context_line":"        instance \u003d common.get_instance(self.compute_api, context, id)"},{"line_number":58,"context_line":"        try:"},{"line_number":59,"context_line":"            self.compute_api.inject_network_info(context, instance)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_9d3fa285","line":56,"range":{"start_line":56,"start_character":69,"end_line":56,"end_character":71},"updated":"2020-01-14 08:28:37.000000000","message":"ditto","commit_id":"2b4edfea99dfe599f685e9c26fab7db346c8538c"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"e632b7f269b3a79c9c0861dafd8183d9e0c1bb4e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def _reset_state(self, req, id, body):"},{"line_number":68,"context_line":"        \"\"\"Permit admins to reset the state of a server.\"\"\""},{"line_number":69,"context_line":"        context \u003d req.environ[\"nova.context\"]"},{"line_number":70,"context_line":"        context.can(aa_policies.POLICY_ROOT % \u0027reset_state\u0027, {})"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        # Identify the desired state from the body"},{"line_number":73,"context_line":"        state \u003d state_map[body[\"os-resetState\"][\"state\"]]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_3d446e1a","line":70,"range":{"start_line":70,"start_character":61,"end_line":70,"end_character":63},"updated":"2020-01-14 08:28:37.000000000","message":"ditto","commit_id":"2b4edfea99dfe599f685e9c26fab7db346c8538c"}]}