)]}'
{"nova/tests/functional/libvirt/test_numa_servers.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"21c8abc7d04661a41741443802956af08594b5d9","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # Start services"},{"line_number":67,"context_line":"        self.computes \u003d {}"},{"line_number":68,"context_line":"        for host in [\u0027test_compute0\u0027, \u0027test_compute1\u0027]:"},{"line_number":69,"context_line":"            host_info \u003d host_infos.pop(0)"},{"line_number":70,"context_line":"            fake_connection \u003d self._get_connection(host_info\u003dhost_info)"},{"line_number":71,"context_line":"            fake_connection.getHostname \u003d lambda: host"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_1577dcd6","line":68,"range":{"start_line":68,"start_character":20,"end_line":68,"end_character":54},"updated":"2019-06-05 10:50:10.000000000","message":"this should be passed as a hosts kwarg","commit_id":"7ad056177733de6bbeb8cea209ac00e2888b8b52"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9f2a18633fdc5644d1100180cf261e35b1a82e66","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # Start services"},{"line_number":67,"context_line":"        self.computes \u003d {}"},{"line_number":68,"context_line":"        for host in [\u0027test_compute0\u0027, \u0027test_compute1\u0027]:"},{"line_number":69,"context_line":"            host_info \u003d host_infos.pop(0)"},{"line_number":70,"context_line":"            fake_connection \u003d self._get_connection(host_info\u003dhost_info)"},{"line_number":71,"context_line":"            fake_connection.getHostname \u003d lambda: host"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_1e25b9c2","line":68,"range":{"start_line":68,"start_character":20,"end_line":68,"end_character":54},"in_reply_to":"9fb8cfa7_1577dcd6","updated":"2019-06-05 13:19:13.000000000","message":"Why? All existing instances of this only create two hosts so YAGNI?","commit_id":"7ad056177733de6bbeb8cea209ac00e2888b8b52"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8bcf2480f5860966d395ca2935946568507a74de","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Start services"},{"line_number":68,"context_line":"        self.computes \u003d {}"},{"line_number":69,"context_line":"        for host_name in host_infos:"},{"line_number":70,"context_line":"            host_info \u003d host_infos[host_name]"},{"line_number":71,"context_line":"            fake_connection \u003d self._get_connection(host_info\u003dhost_info)"},{"line_number":72,"context_line":"            fake_connection.getHostname \u003d lambda: host_name"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_528bd86c","line":70,"range":{"start_line":69,"start_character":12,"end_line":70,"end_character":45},"updated":"2019-06-10 16:08:33.000000000","message":"or \n\n for host_name, host_info in host_infos.items():","commit_id":"895461d1f187442388cbf332ce4e5c3af0f3da43"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"f41a26ae3c89f668707e5d29adbdabcb6eabbded","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"            # Once that\u0027s done, we need to do some tweaks to each individual"},{"line_number":77,"context_line":"            # compute \"service\" to make sure they return unique objects"},{"line_number":78,"context_line":"            compute.driver._host.get_connection \u003d lambda: fake_connection"},{"line_number":79,"context_line":"            self.computes[host_name] \u003d compute"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"            # and save the UUIDs for the corresponding resource providers"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_288e03d1","line":78,"updated":"2019-10-25 17:03:22.000000000","message":"This is going to run into the issue I describe at https://review.opendev.org/#/c/686832/6/nova/tests/functional/libvirt/base.py@157","commit_id":"ab62ad59f88a74e9a8f7919356b3bf545969108a"}]}