)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a8f663cadee85569679172af88e0bb45922242b0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"[1] Iaaeae9281301f14f4ae9b43f4a06de58b699fd68"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I77730837f803f5a741ffe4af1a06468d9fe903ba"},{"line_number":19,"context_line":"Closes-Bug: #1831723"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_ee0272b4","line":19,"updated":"2019-06-05 16:10:14.000000000","message":"The bug says, \"sometime aound liberty/mitaka we decided\nthat was a bad user experence for endusers as they did not recive what they asked for and started to convert all confict into a hard error.\" but I would like to see references to back that up because we have nothing documenting this as far as I know (I would expect something in the contributor docs) since this seems to come up every time a new extra spec and matching image property is added (which takes precedence? what if they conflict?).","commit_id":"fdfb4d9d19b10cb2d6fc63d6308047fbeb538f5a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4cb10dcc28e3b0f32c2aca0468d2351e4a70c4f9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"[1] Iaaeae9281301f14f4ae9b43f4a06de58b699fd68"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I77730837f803f5a741ffe4af1a06468d9fe903ba"},{"line_number":19,"context_line":"Closes-Bug: #1831723"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_62c1b380","line":19,"in_reply_to":"9fb8cfa7_ee0272b4","updated":"2019-06-05 19:33:21.000000000","message":"FTR it makes sense to me to do *something* here, as the user (via the image) shouldn\u0027t be able to override the admin (via the flavor). In this case it probably matters very little, but we should be consistent.","commit_id":"fdfb4d9d19b10cb2d6fc63d6308047fbeb538f5a"}],"nova/exception.py":[{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"5658a4edc4c8963e236da3fedf37825a103cbd35","unresolved":false,"context_lines":[{"line_number":2458,"context_line":"                \"moved.\")"},{"line_number":2459,"context_line":""},{"line_number":2460,"context_line":""},{"line_number":2461,"context_line":"class FlavorImageConflict(NovaException):"},{"line_number":2462,"context_line":"    msg_fmt \u003d _(\"Conflicting values for %(setting)s found in the flavor \""},{"line_number":2463,"context_line":"                \"(%(flavor_val)s) and the image (%(image_val)s).\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_79ea05ad","line":2461,"updated":"2019-06-17 18:16:17.000000000","message":"This is now added in https://review.opendev.org/#/c/664420/8/nova/exception.py","commit_id":"c27c773ea2441084bc417041e3a44fa2befae584"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fb1e0be466ec395a197cd9626e6df40530749f4b","unresolved":false,"context_lines":[{"line_number":5196,"context_line":"                    flavor_val\u003dflavor_says_hide, image_val\u003dimage_says_hide)"},{"line_number":5197,"context_line":""},{"line_number":5198,"context_line":"        hide_hypervisor_id \u003d (image_says_hide or"},{"line_number":5199,"context_line":"                              strutils.bool_from_string(flavor_says_hide))"},{"line_number":5200,"context_line":""},{"line_number":5201,"context_line":"        if virt_type \u003d\u003d \"xen\":"},{"line_number":5202,"context_line":"            # PAE only makes sense in X86"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_8f7ab485","line":5199,"updated":"2020-05-11 13:58:08.000000000","message":"I\u0027d be tempted to do this inside the nova.virt.hardware module, because a) that\u0027s where we do a lot of image metadata-flavor extra spec validation work already and b) it\u0027s called from the API which mean\u0027s we\u0027d get an error much earlier in the boot process. However, this isn\u0027t a hw-prefixed extra spec (yet [1]) so I don\u0027t know if that\u0027s ideal. As such, this is probably good enough for now and perhaps someday when we have yet another module to do intra-extra spec dependencies, we could move all this, plus the hardware.py validation stuff, to that. \n\n[1] https://review.opendev.org/#/c/722187/","commit_id":"d1cd7f368924f9ba0b9079c4ead9b9bf8b02aa01"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1799654c08249284294d94c0fce47de07fd89b50","unresolved":false,"context_lines":[{"line_number":5196,"context_line":"                    flavor_val\u003dflavor_says_hide, image_val\u003dimage_says_hide)"},{"line_number":5197,"context_line":""},{"line_number":5198,"context_line":"        hide_hypervisor_id \u003d (image_says_hide or"},{"line_number":5199,"context_line":"                              strutils.bool_from_string(flavor_says_hide))"},{"line_number":5200,"context_line":""},{"line_number":5201,"context_line":"        if virt_type \u003d\u003d \"xen\":"},{"line_number":5202,"context_line":"            # PAE only makes sense in X86"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_92881b72","line":5199,"in_reply_to":"ff570b3c_8f7ab485","updated":"2020-05-11 14:38:08.000000000","message":"well since it should be prefixed with hw:\n\ni agree that hardware.py is proably wehre this should be done.\n\nbut also i think we shoudl hold off merging this until \nhttps://review.opendev.org/#/c/722187/ is merged\nsince this need to take into account the namespaced version too.\n\n\ncan we rebased this on https://review.opendev.org/#/c/722187/\nand updated it. if we want we could have a third patch to refacor the logic into the hardware.py module.","commit_id":"d1cd7f368924f9ba0b9079c4ead9b9bf8b02aa01"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f6bd1a77820734ff0074d444cd3ae62bfc5329e2","unresolved":false,"context_lines":[{"line_number":5196,"context_line":"                    flavor_val\u003dflavor_says_hide, image_val\u003dimage_says_hide)"},{"line_number":5197,"context_line":""},{"line_number":5198,"context_line":"        hide_hypervisor_id \u003d (image_says_hide or"},{"line_number":5199,"context_line":"                              strutils.bool_from_string(flavor_says_hide))"},{"line_number":5200,"context_line":""},{"line_number":5201,"context_line":"        if virt_type \u003d\u003d \"xen\":"},{"line_number":5202,"context_line":"            # PAE only makes sense in X86"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_8791e59c","line":5199,"in_reply_to":"ff570b3c_92881b72","updated":"2020-05-12 10:33:39.000000000","message":"If you\u0027d like, yeah. Could we do it in a follow-up though, unless you think you\u0027ll have time in the next few weeks. I\u0027d rather get something in than wait for the perfect solution :)","commit_id":"d1cd7f368924f9ba0b9079c4ead9b9bf8b02aa01"}]}