)]}'
{"nova/tests/virt/xenapi/test_xenapi.py":[{"author":{"_account_id":6904,"name":"Guillaume Thouvenin","email":"gthouvenin@mirantis.com","username":"guillaume-thouvenin"},"change_message_id":"1c5971ddb0af6a85c90b838c32088d13d58c6528","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        expected \u003d {"},{"line_number":448,"context_line":"            \u0027state\u0027: \u0027running\u0027,"},{"line_number":449,"context_line":"            \u0027driver\u0027: \u0027xenapi\u0027,"},{"line_number":450,"context_line":"            \u0027num_vcpus\u0027: 4,"},{"line_number":451,"context_line":"            \u0027num_vnics\u0027: 1,"},{"line_number":452,"context_line":"            \u0027num_disks\u0027: 1,"},{"line_number":453,"context_line":"            \u0027memory_details\u0027: {\u0027maximum\u0027: 8192},"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2B15c%3D","line":450,"updated":"2014-01-21 14:40:21.000000000","message":"it will failed here ;)","commit_id":"2a52f7365fa7426167171750e24988cf36aeb8a4"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"886a6c91f0d3552f9adae0faa988dbe39e7ccf35","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        expected \u003d {"},{"line_number":448,"context_line":"            \u0027state\u0027: \u0027running\u0027,"},{"line_number":449,"context_line":"            \u0027driver\u0027: \u0027xenapi\u0027,"},{"line_number":450,"context_line":"            \u0027num_vcpus\u0027: 4,"},{"line_number":451,"context_line":"            \u0027num_vnics\u0027: 1,"},{"line_number":452,"context_line":"            \u0027num_disks\u0027: 1,"},{"line_number":453,"context_line":"            \u0027memory_details\u0027: {\u0027maximum\u0027: 8192},"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2B12M%3D","line":450,"in_reply_to":"AAAAUH%2F%2B15c%3D","updated":"2014-01-21 14:47:24.000000000","message":"D\u0027oh! I had made the change, but forgot to git commit -a --amend!","commit_id":"2a52f7365fa7426167171750e24988cf36aeb8a4"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b62dafb1fdaac743c4af84e70c7c2f9af94e31b7","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        self.stubs.Set(vm_utils, \u0027_get_rrd\u0027, fake_get_rrd)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        driver_private_data \u003d {"},{"line_number":433,"context_line":"            \u0027vbd_xvdb_write\u0027: \u00270.0\u0027,"},{"line_number":434,"context_line":"            \u0027memory_target\u0027: \u00274294967296.0000\u0027,"},{"line_number":435,"context_line":"            \u0027memory_internal_free\u0027: \u00271415564.0000\u0027,"},{"line_number":436,"context_line":"            \u0027memory\u0027: \u00274294967296.0000\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BENQ%3D","line":433,"updated":"2014-01-30 14:38:25.000000000","message":"I don\u0027t like the cut and paste, maybe just have a constant in the fake driver?","commit_id":"65030f18d60750f55095853d3f7555355aba7e2e"}],"nova/virt/xenapi/fake.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e9ec548895897dfbd495d058fc3a963d93313c8b","unresolved":false,"context_lines":[{"line_number":242,"context_line":"def after_VM_create(vm_ref, vm_rec):"},{"line_number":243,"context_line":"    \"\"\"Create read-only fields in the VM record.\"\"\""},{"line_number":244,"context_line":"    LOG.debug(vm_ref)"},{"line_number":245,"context_line":"    LOG.debug(vm_rec)"},{"line_number":246,"context_line":"    vm_rec.setdefault(\u0027is_control_domain\u0027, False)"},{"line_number":247,"context_line":"    vm_rec.setdefault(\u0027memory_static_max\u0027, str(8 * unit.Gi))"},{"line_number":248,"context_line":"    vm_rec.setdefault(\u0027memory_dynamic_max\u0027, str(8 * unit.Gi))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FZuo%3D","line":245,"updated":"2014-01-14 05:09:37.000000000","message":"Did you mean to leave this in? I guess it could be handy.","commit_id":"ff23fc00375afa6138a293ec36f3e9c749470bda"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"f7b7b35fed2bfc41b8a3ba9f8c980337711be17e","unresolved":false,"context_lines":[{"line_number":242,"context_line":"def after_VM_create(vm_ref, vm_rec):"},{"line_number":243,"context_line":"    \"\"\"Create read-only fields in the VM record.\"\"\""},{"line_number":244,"context_line":"    LOG.debug(vm_ref)"},{"line_number":245,"context_line":"    LOG.debug(vm_rec)"},{"line_number":246,"context_line":"    vm_rec.setdefault(\u0027is_control_domain\u0027, False)"},{"line_number":247,"context_line":"    vm_rec.setdefault(\u0027memory_static_max\u0027, str(8 * unit.Gi))"},{"line_number":248,"context_line":"    vm_rec.setdefault(\u0027memory_dynamic_max\u0027, str(8 * unit.Gi))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FZBg%3D","line":245,"in_reply_to":"AAAAUH%2F%2FZuo%3D","updated":"2014-01-14 09:37:00.000000000","message":"No... Sorry.  Removed.","commit_id":"ff23fc00375afa6138a293ec36f3e9c749470bda"}],"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f538450124c53166da4390a36e8754040c4bb0e6","unresolved":false,"context_lines":[{"line_number":1795,"context_line":"    diags[\u0027memory_details\u0027] \u003d {"},{"line_number":1796,"context_line":"        \u0027maximum\u0027: long(vm_rec[\u0027memory_dynamic_max\u0027]) / unit.Mi}"},{"line_number":1797,"context_line":""},{"line_number":1798,"context_line":"    diags[\u0027raw_data\u0027] \u003d compile_diagnostics(vm_rec)"},{"line_number":1799,"context_line":""},{"line_number":1800,"context_line":"    return diags"},{"line_number":1801,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2B22k%3D","line":1798,"updated":"2014-01-21 11:36:04.000000000","message":"can you please change raw_data to driver_private_data","commit_id":"41fc9d086018b145901a9e6b92da793d17758629"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"8ff9c38b5880a379df36cc2ff962eb33cece3667","unresolved":false,"context_lines":[{"line_number":1795,"context_line":"    diags[\u0027memory_details\u0027] \u003d {"},{"line_number":1796,"context_line":"        \u0027maximum\u0027: long(vm_rec[\u0027memory_dynamic_max\u0027]) / unit.Mi}"},{"line_number":1797,"context_line":""},{"line_number":1798,"context_line":"    diags[\u0027raw_data\u0027] \u003d compile_diagnostics(vm_rec)"},{"line_number":1799,"context_line":""},{"line_number":1800,"context_line":"    return diags"},{"line_number":1801,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2B2ts%3D","line":1798,"in_reply_to":"AAAAUH%2F%2B22k%3D","updated":"2014-01-21 11:56:33.000000000","message":"Done","commit_id":"41fc9d086018b145901a9e6b92da793d17758629"},{"author":{"_account_id":6904,"name":"Guillaume Thouvenin","email":"gthouvenin@mirantis.com","username":"guillaume-thouvenin"},"change_message_id":"afdf74543420bc34a678b10e30af7be0a025ff7b","unresolved":false,"context_lines":[{"line_number":1788,"context_line":"    power_state_int \u003d XENAPI_POWER_STATE[vm_rec[\u0027power_state\u0027]]"},{"line_number":1789,"context_line":"    diags[\u0027state\u0027] \u003d power_state._STATE_MAP[power_state_int]"},{"line_number":1790,"context_line":""},{"line_number":1791,"context_line":"    diags[\u0027num_vcpus\u0027] \u003d long(vm_rec[\u0027VCPUs_max\u0027])"},{"line_number":1792,"context_line":"    diags[\u0027num_vnics\u0027] \u003d len(vm_rec[\u0027VIFs\u0027])"},{"line_number":1793,"context_line":"    diags[\u0027num_disks\u0027] \u003d len(vm_rec[\u0027VBDs\u0027])"},{"line_number":1794,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2B2HA%3D","line":1791,"updated":"2014-01-21 14:11:44.000000000","message":"I\u0027m not sure here but I see on \"Nova VM Diagnostics\" page in the Proposal that the key is \"num_cpus\" for the number of vCPUS. So is \"num_vcpus\" ok?","commit_id":"2effea6c0689c38352eb85236849e11e76e12482"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"1bf51cebf95244baa03b4611234ab5c301c5641a","unresolved":false,"context_lines":[{"line_number":1788,"context_line":"    power_state_int \u003d XENAPI_POWER_STATE[vm_rec[\u0027power_state\u0027]]"},{"line_number":1789,"context_line":"    diags[\u0027state\u0027] \u003d power_state._STATE_MAP[power_state_int]"},{"line_number":1790,"context_line":""},{"line_number":1791,"context_line":"    diags[\u0027num_vcpus\u0027] \u003d long(vm_rec[\u0027VCPUs_max\u0027])"},{"line_number":1792,"context_line":"    diags[\u0027num_vnics\u0027] \u003d len(vm_rec[\u0027VIFs\u0027])"},{"line_number":1793,"context_line":"    diags[\u0027num_disks\u0027] \u003d len(vm_rec[\u0027VBDs\u0027])"},{"line_number":1794,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2B2DA%3D","line":1791,"in_reply_to":"AAAAUH%2F%2B2HA%3D","updated":"2014-01-21 14:20:30.000000000","message":"Good spot.\n\nFixed.","commit_id":"2effea6c0689c38352eb85236849e11e76e12482"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"ec7ddf34e404f842bb9fef282563acd3d5e9c614","unresolved":false,"context_lines":[{"line_number":1798,"context_line":""},{"line_number":1799,"context_line":"    diags[\u0027driver_private_data\u0027] \u003d compile_diagnostics(vm_rec)"},{"line_number":1800,"context_line":""},{"line_number":1801,"context_line":"    return diags"},{"line_number":1802,"context_line":""},{"line_number":1803,"context_line":""},{"line_number":1804,"context_line":"def compile_diagnostics(vm_rec):"}],"source_content_type":"text/x-python","patch_set":22,"id":"baada198_e150ee5f","line":1801,"updated":"2014-07-15 11:09:49.000000000","message":"This needs completely re-writing to use the Diagnostics object model now.","commit_id":"cb78c8570d01fba39c097ed0995195f11e14425c"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"b222836f8a7553c1403fd82bbe213d8559cb005a","unresolved":false,"context_lines":[{"line_number":1798,"context_line":""},{"line_number":1799,"context_line":"    diags[\u0027driver_private_data\u0027] \u003d compile_diagnostics(vm_rec)"},{"line_number":1800,"context_line":""},{"line_number":1801,"context_line":"    return diags"},{"line_number":1802,"context_line":""},{"line_number":1803,"context_line":""},{"line_number":1804,"context_line":"def compile_diagnostics(vm_rec):"}],"source_content_type":"text/x-python","patch_set":22,"id":"baada198_a1e8b6b3","line":1801,"updated":"2014-07-15 11:03:31.000000000","message":"Why isn\u0027t config_drive in this list of returned diagnostics like it is for say the vmware implementation?","commit_id":"cb78c8570d01fba39c097ed0995195f11e14425c"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"9f292fbd1773cd678680949c6bf024be1c6592a1","unresolved":false,"context_lines":[{"line_number":1798,"context_line":""},{"line_number":1799,"context_line":"    diags[\u0027driver_private_data\u0027] \u003d compile_diagnostics(vm_rec)"},{"line_number":1800,"context_line":""},{"line_number":1801,"context_line":"    return diags"},{"line_number":1802,"context_line":""},{"line_number":1803,"context_line":""},{"line_number":1804,"context_line":"def compile_diagnostics(vm_rec):"}],"source_content_type":"text/x-python","patch_set":22,"id":"baada198_9497638f","line":1801,"in_reply_to":"baada198_a1e8b6b3","updated":"2014-07-15 14:49:16.000000000","message":"Done","commit_id":"cb78c8570d01fba39c097ed0995195f11e14425c"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"9f292fbd1773cd678680949c6bf024be1c6592a1","unresolved":false,"context_lines":[{"line_number":1798,"context_line":""},{"line_number":1799,"context_line":"    diags[\u0027driver_private_data\u0027] \u003d compile_diagnostics(vm_rec)"},{"line_number":1800,"context_line":""},{"line_number":1801,"context_line":"    return diags"},{"line_number":1802,"context_line":""},{"line_number":1803,"context_line":""},{"line_number":1804,"context_line":"def compile_diagnostics(vm_rec):"}],"source_content_type":"text/x-python","patch_set":22,"id":"baada198_b492a79c","line":1801,"in_reply_to":"baada198_e150ee5f","updated":"2014-07-15 14:49:16.000000000","message":"Done","commit_id":"cb78c8570d01fba39c097ed0995195f11e14425c"}]}