)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"aa0f8de3177bf94045604044d720498e3382c138","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] libvirt: Update the default number of PCIe root ports to 32"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With the \u0027pc\u0027 (or \u0027i440fx\u0027) machine type, each of the 31 slots (from"},{"line_number":10,"context_line":"0x01 to 0x1f) on the \u0027pci-root\u0027 controller is hotplug-capable.  So by"},{"line_number":11,"context_line":"default \u0027pc\u0027 lets you hotplug upto 31 devices (*despite*, Nova\u0027s default"},{"line_number":12,"context_line":"`[libvirt]/num_pcie_ports` set to \"0\")."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"However, for the \u0027q35\u0027 machine type, the current default of \"0\" devices,"},{"line_number":15,"context_line":"for \u0027num_pcie_ports\u0027 means, Nova defaults to libvirt\u0027s \"1\".  I.e. when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_6fa010a7","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":39},"updated":"2020-03-22 15:25:19.000000000","message":"You are mixing things.\n\n\u0027i440fx\u0027 is PCI machine and ignores num_pcie_ports completely as this is setting for PCIe machines like \u0027aarch64/virt\u0027 or \u0027x86/q35\u0027.","commit_id":"981b64ea583970afacdcbd2701e84f2e9926d600"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"aa0f8de3177bf94045604044d720498e3382c138","unresolved":false,"context_lines":[{"line_number":11,"context_line":"default \u0027pc\u0027 lets you hotplug upto 31 devices (*despite*, Nova\u0027s default"},{"line_number":12,"context_line":"`[libvirt]/num_pcie_ports` set to \"0\")."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"However, for the \u0027q35\u0027 machine type, the current default of \"0\" devices,"},{"line_number":15,"context_line":"for \u0027num_pcie_ports\u0027 means, Nova defaults to libvirt\u0027s \"1\".  I.e. when"},{"line_number":16,"context_line":"using \u0027q35\u0027 machine type, libvirt creates only _one_ spare PCIe root"},{"line_number":17,"context_line":"port, which is not sufficient if you want to hotplug devices."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This is a regression in compared to the behaviour we see with the \u0027pc\u0027"},{"line_number":20,"context_line":"machine type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_cf903c52","line":17,"range":{"start_line":14,"start_character":0,"end_line":17,"end_character":61},"updated":"2020-03-22 15:25:19.000000000","message":"if you set 0 then you mean \u0027I trust libvirt to add whatever is needed\u0027 which usually means enough slots for whatever is in XML given to libvirt + 1-2 free slots.","commit_id":"981b64ea583970afacdcbd2701e84f2e9926d600"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"aa0f8de3177bf94045604044d720498e3382c138","unresolved":false,"context_lines":[{"line_number":22,"context_line":"In other words, when using Q35 machine type, if you want to be able to"},{"line_number":23,"context_line":"hotplug devices, we must explicitly create PCIe root ports."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"After consulting the QEMU and libvirt folks, increase the number (32) of"},{"line_number":26,"context_line":"PCIe root ports out of the box, so that there is no regression w.r.t"},{"line_number":27,"context_line":"hotplug for \u0027q35\u0027 machine type when compared to \u0027pc\u0027."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    - - -"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_ef7c2022","line":27,"range":{"start_line":25,"start_character":0,"end_line":27,"end_character":53},"updated":"2020-03-22 15:25:19.000000000","message":"And break AArch64.\n\nWhen I added \u0027num_pcie_ports\u0027 variable I did checks on \u0027x86/q35 +bios\u0027, \u0027x86/q35+uefi\u0027 and \u0027aarch64/virt\u0027 systems. 28 was what was bootable on AArch64 at that time.","commit_id":"981b64ea583970afacdcbd2701e84f2e9926d600"}],"nova/conf/libvirt.py":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"d95331db8061f9d10eb920bfb71e0875b0a00e56","unresolved":false,"context_lines":[{"line_number":793,"context_line":"Intel CMT, because it is broken by design."},{"line_number":794,"context_line":"\"\"\"),"},{"line_number":795,"context_line":"    cfg.IntOpt(\u0027num_pcie_ports\u0027,"},{"line_number":796,"context_line":"               default\u003d32,"},{"line_number":797,"context_line":"               min\u003d0,"},{"line_number":798,"context_line":"               max\u003d32,"},{"line_number":799,"context_line":"               help\u003d \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_8e315fef","line":796,"range":{"start_line":796,"start_character":23,"end_line":796,"end_character":25},"updated":"2019-06-07 13:31:53.000000000","message":"This 32 is wrong for AArch64.  Based on today\u0027s investigation the default number of ports for different architectures.\n\nFrom this morning\u0027s testing on real AArch64 hardware (thanks to libvirt developer, Andrea Bolognani):\n\n* With 32 root ports: it doesn\u0027t boot all the way through -- it just hangs before GRUB and never ends up in the shell\n* With the magic number 28 root ports: doesn\u0027t boot\n* With 24 root ports: the guest booted all the way through\n\nI will update here, once the dust settles, as the QEMU / libvirt folks are still testing.","commit_id":"981b64ea583970afacdcbd2701e84f2e9926d600"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"78723296ebe192ece63e87eb6ef2e71a49a6b6cb","unresolved":false,"context_lines":[{"line_number":2242,"context_line":"        self.flags(virt_type\u003d\"kvm\","},{"line_number":2243,"context_line":"                   group\u003d\u0027libvirt\u0027)"},{"line_number":2244,"context_line":""},{"line_number":2245,"context_line":"        TEST_AMOUNT_OF_PCIE_SLOTS \u003d 32"},{"line_number":2246,"context_line":"        CONF.set_override(\"num_pcie_ports\", TEST_AMOUNT_OF_PCIE_SLOTS,"},{"line_number":2247,"context_line":"                group\u003d\u0027libvirt\u0027)"},{"line_number":2248,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_3e7e666b","line":2245,"range":{"start_line":2245,"start_character":36,"end_line":2245,"end_character":38},"updated":"2019-06-06 11:54:02.000000000","message":"this should not be 32\nyou are testing seting it to a non default value\nso i would leave it at 8","commit_id":"981b64ea583970afacdcbd2701e84f2e9926d600"}]}