)]}'
{"id":"openstack%2Fnova~663616","triplet_id":"openstack%2Fnova~stable%2Fstein~Iaaeae9281301f14f4ae9b43f4a06de58b699fd68","project":"openstack/nova","branch":"stable/stein","topic":"bug/1779845","hashtags":[],"change_id":"Iaaeae9281301f14f4ae9b43f4a06de58b699fd68","subject":"Hide hypervisor id on windows guests","status":"ABANDONED","created":"2019-06-06 11:57:35.000000000","updated":"2022-11-11 18:38:09.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"965728ac78d233c6bbccc7036ab825c4778b63bd","_number":663616,"virtual_id_number":663616,"owner":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2019-06-06 18:38:28.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2019-06-06 13:28:59.000000000","_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},{"date":"2019-09-18 14:40:55.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":27961,"name":"Konstantinos Samaras-Tsakiris","email":"konstantinos.samaras-tsakiris@cern.ch","username":"kosamara"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"date":"2019-06-06 13:42:04.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"date":"2019-06-07 04:30:00.000000000","_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"date":"2019-06-06 14:46:52.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":-1,"date":"2019-09-18 13:37:38.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":27961,"name":"Konstantinos Samaras-Tsakiris","email":"konstantinos.samaras-tsakiris@cern.ch","username":"kosamara"},{"value":1,"date":"2020-06-10 16:31:07.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"date":"2019-06-06 11:57:35.000000000","_account_id":27961,"name":"Konstantinos Samaras-Tsakiris","email":"konstantinos.samaras-tsakiris@cern.ch","username":"kosamara"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"date":"2020-07-21 12:49:00.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":27961,"name":"Konstantinos Samaras-Tsakiris","email":"konstantinos.samaras-tsakiris@cern.ch","username":"kosamara"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":27961,"name":"Konstantinos Samaras-Tsakiris","email":"konstantinos.samaras-tsakiris@cern.ch","username":"kosamara"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-06 11:57:35.000000000","updated_by":{"_account_id":27961,"name":"Konstantinos Samaras-Tsakiris","email":"konstantinos.samaras-tsakiris@cern.ch","username":"kosamara"},"reviewer":{"_account_id":27961,"name":"Konstantinos Samaras-Tsakiris","email":"konstantinos.samaras-tsakiris@cern.ch","username":"kosamara"},"state":"REVIEWER"},{"updated":"2019-06-06 13:42:04.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-06-06 14:46:52.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-06-06 18:38:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-06-07 04:30:00.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-09-18 13:37:38.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2019-09-18 14:40:55.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2020-06-10 16:31:07.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2020-07-21 12:49:00.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"}],"messages":[{"id":"4cbeba0de0053484064a4a852043689205858353","author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"date":"2019-06-06 11:57:35.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"873f2cc749401ca5bf3a06d7027cb67932c5517b","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-06 13:15:13.000000000","message":"Topic changed from bug/1779845-stable/stein to bug/1779845","accounts_in_message":[],"_revision_number":1},{"id":"6c661964dc4e60c9252de6c367fda0842dca2081","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-06 13:15:36.000000000","message":"Patch Set 1:\n\nAs discussed in the change on master I\u0027m not sure we really want to backport this since it\u0027s quasi-feature(ish).","accounts_in_message":[],"_revision_number":1},{"id":"fe8d8fbd669417a426360d51dc600c4539b63513","author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"date":"2019-06-06 13:28:59.000000000","message":"Patch Set 1:\n\nI\u0027m not sure, that this is a feature. We\u0027ve always treated this more like critical bug, because our customers weren\u0027t able to use GTX1080 GPUs properly in the windows instances. We use this fix in production since at least Pike.","accounts_in_message":[],"_revision_number":1},{"id":"a13e358bb4d5b25f784be828c3637aecf86dab0c","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-06-06 13:42:04.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/16/663616/1/check/tempest-dsvm-full-xenial/6f86734/ : SUCCESS in 1h 17m 12s\n- tempest-dsvm-full-xenial-py3 https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/16/663616/1/check/tempest-dsvm-full-xenial-py3/677261a/ : SUCCESS in 1h 43m 44s (non-voting)\n- grenade-dsvm-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/16/663616/1/check/grenade-dsvm-xenial/220a5eb/ : SUCCESS in 1h 09m 34s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4616abe880071726b07a66b31bbc012b43047323","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-06-06 14:46:52.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/663616/1 : FAILURE in 2h 20m 17s","accounts_in_message":[],"_revision_number":1},{"id":"1fddae416f511e62b85d8db53966ef8dc91ab201","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-06 18:38:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/16/663616/1/check/grenade-py3/6aefc70/ : SUCCESS in 56m 42s\n- tempest-full-py3 http://logs.openstack.org/16/663616/1/check/tempest-full-py3/0b833f5/ : SUCCESS in 1h 31m 40s\n- openstack-tox-cover http://logs.openstack.org/16/663616/1/check/openstack-tox-cover/4898fcd/cover/ : SUCCESS in 14m 10s\n- openstack-tox-lower-constraints http://logs.openstack.org/16/663616/1/check/openstack-tox-lower-constraints/b94710b/ : SUCCESS in 14m 15s\n- openstack-tox-pep8 http://logs.openstack.org/16/663616/1/check/openstack-tox-pep8/2ab6977/ : SUCCESS in 9m 23s\n- openstack-tox-py27 http://logs.openstack.org/16/663616/1/check/openstack-tox-py27/d3c69d7/ : SUCCESS in 12m 13s\n- openstack-tox-py35 http://logs.openstack.org/16/663616/1/check/openstack-tox-py35/6bb8bb2/ : SUCCESS in 13m 32s\n- openstack-tox-py36 http://logs.openstack.org/16/663616/1/check/openstack-tox-py36/6eb4003/ : SUCCESS in 11m 39s\n- openstack-tox-py37 http://logs.openstack.org/16/663616/1/check/openstack-tox-py37/4eb2b4f/ : SUCCESS in 11m 51s\n- openstack-tox-docs http://logs.openstack.org/16/663616/1/check/openstack-tox-docs/544b524/html/ : SUCCESS in 6m 45s\n- build-openstack-releasenotes http://logs.openstack.org/16/663616/1/check/build-openstack-releasenotes/33f6009/html/ : SUCCESS in 26m 10s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/16/663616/1/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/6f20505/ : SUCCESS in 44m 19s (non-voting)\n- devstack-plugin-ceph-tempest http://logs.openstack.org/16/663616/1/check/devstack-plugin-ceph-tempest/96d23e8/ : FAILURE in 1h 15m 55s (non-voting)\n- neutron-grenade-multinode http://logs.openstack.org/16/663616/1/check/neutron-grenade-multinode/43d2ac3/ : SUCCESS in 1h 07m 47s\n- nova-grenade-live-migration http://logs.openstack.org/16/663616/1/check/nova-grenade-live-migration/b8138ad/ : SUCCESS in 1h 03m 01s\n- nova-live-migration http://logs.openstack.org/16/663616/1/check/nova-live-migration/232c1c9/ : SUCCESS in 50m 36s\n- nova-lvm http://logs.openstack.org/16/663616/1/check/nova-lvm/cf19842/ : SUCCESS in 1h 04m 22s (non-voting)\n- nova-next http://logs.openstack.org/16/663616/1/check/nova-next/e802f00/ : SUCCESS in 1h 25m 50s\n- nova-tox-functional http://logs.openstack.org/16/663616/1/check/nova-tox-functional/7ddeeff/ : SUCCESS in 22m 30s\n- nova-tox-functional-py35 http://logs.openstack.org/16/663616/1/check/nova-tox-functional-py35/00a5385/ : SUCCESS in 20m 51s\n- tempest-multinode-full http://logs.openstack.org/16/663616/1/check/tempest-multinode-full/cc4f724/ : SUCCESS in 1h 54m 15s (non-voting)\n- tempest-slow-py3 http://logs.openstack.org/16/663616/1/check/tempest-slow-py3/59f56eb/ : SUCCESS in 2h 10m 55s","accounts_in_message":[],"_revision_number":1},{"id":"53b3eb4f6b3606dda9b62966b4c9ac4ea87140a9","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2019-06-07 04:30:00.000000000","message":"Patch Set 1:\n\nTesting succeeded on ubuntu-xenial-s390x. For rechecking only on the ubuntu-xenail-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/663616/1/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/4190251 : SUCCESS in 1h 43m 27s","accounts_in_message":[],"_revision_number":1},{"id":"0cc1c35bddd1227c7e4c9ad38b3d6ff683e491e8","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-07 13:43:15.000000000","message":"Patch Set 1:\n\n\u003e We use this fix in production since at least Pike.\n\nSure, and so is CERN and OVH, which means I\u0027m not sure we need to backport it. I\u0027m on the fence about backporting it, obviously. I sort of feel like if people really need this they can backport it downstream as needed, but the good news for them (you) is that there is light at the end of the tunnel because you can stop carrying the patch once you get to Train.\n\nMaybe others on the stable core team feel differently. I\u0027ll abstain for awhile.","accounts_in_message":[],"_revision_number":1},{"id":"be029b8d15bc4d8efc3c1ea79d54e315ea5fada3","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-08-01 11:01:46.000000000","message":"Patch Set 1: Code-Review+2\n\nI appreciate where Matt is coming from regarding this change but I\u0027m personally more inclined to call this a pure bugfix and merge it into stable.","accounts_in_message":[],"_revision_number":1},{"id":"293445582f9980d2b9e203e460bafe2c147e3c26","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-09-18 13:37:38.000000000","message":"Patch Set 1: Code-Review-1\n\nDespite having a bug attached, this seems like a feature (it even includes a knob) so I\u0027m not sure how this is appropriate for stable. If we couldn\u0027t backport a simple feature to fix SPECTRE, I can\u0027t see how this is viable.","accounts_in_message":[],"_revision_number":1},{"id":"3b6dc17e13bea64a0c384ebb008f7b339e0ac283","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-09-18 14:40:55.000000000","message":"Patch Set 1:\n\nTo be clear, I don\u0027t think this adds any new config (despite the libvirt/config module change, that\u0027s just to update the domain xml), it just makes the existing thing also work for windows guests when using kvm. As such I didn\u0027t -1/-2 but still think people that need this can just pull the patch as necessary and eventually re-align with upstream when they upgrade to train.","accounts_in_message":[],"_revision_number":1},{"id":"51bcd9b5fb2f1258dd7c70defe269c0006f7497e","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-11-26 09:32:12.000000000","message":"Removed reviewer Lee Yarwood with the following votes:\n\n* Code-Review+2 by Lee Yarwood \u003clyarwood@redhat.com\u003e\n","accounts_in_message":[],"_revision_number":1},{"id":"e33569bc1b3f1dfcfd5c32128e017b3d77cf00a8","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-06-10 16:31:07.000000000","message":"Patch Set 1: Code-Review+1\n\nI get the contention around this, but I\u0027d be firmly on the side of this being a bugfix. If we were backporting the change that added the flavor extra spec or were adding support for this spec to another driver, it would not be backportable, however, nowhere in the blueprints did we state that this feature should work only for libvirt guests. It was a clear oversight that leads to confusing behavior for the end-user and should be closed.","accounts_in_message":[],"_revision_number":1},{"id":"dff4b3c5cd5ff5a357d1b1c66ce3993dc4bf4a56","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-06-11 14:51:06.000000000","message":"Patch Set 1:\n\nI\u0027m still -1.9 on this, FWIW. This changes guest XML and guest-visible behavior on a release that is super deep into stable and maintenance mode at this point. This is not a regression, it\u0027s a feature, and stein should be receiving basically nothing but super critical fixes and security errata at this point.","accounts_in_message":[],"_revision_number":1},{"id":"965728ac78d233c6bbccc7036ab825c4778b63bd","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2022-11-11 18:38:09.000000000","message":"Abandoned\n\nThis branch transitioned to End of Life for this project, open patches needs to be closed to be able to delete the branch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"dde1e727909b6b0cefea3bc60fad086b58044329","revisions":{"dde1e727909b6b0cefea3bc60fad086b58044329":{"kind":"REWORK","_number":1,"created":"2019-06-06 11:57:35.000000000","uploader":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"ref":"refs/changes/16/663616/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/16/663616/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/16/663616/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/16/663616/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/16/663616/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/16/663616/1"}}},"commit":{"parents":[{"commit":"105e6238dd536ac869276c38b5c76fefeb729b40","subject":"Merge \"Workaround missing RequestSpec.instance_group.uuid\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/105e6238dd536ac869276c38b5c76fefeb729b40"}]}],"author":{"name":"Konstantinos Samaras-Tsakiris","email":"konstantinos.samaras-tsakiris@cern.ch","date":"2018-07-03 12:28:55.000000000","tz":0},"committer":{"name":"Vlad Gusev","email":"vlad.esten@gmail.com","date":"2019-06-06 11:57:35.000000000","tz":0},"subject":"Hide hypervisor id on windows guests","message":"Hide hypervisor id on windows guests\n\nBlueprints hide-hypervisor-id-flavor-extra-spec [1] and\nadd-kvm-hidden-feature [2] allow hiding KVM\u0027s signature for guests,\nwhich is necessary for Nvidia drivers to work in VMs with passthrough\nGPUs.  While this works well for linux guests on KVM, it doesn\u0027t work\nfor Windows guests.\n\nFor them, KVM emulates some HyperV features. With the\ncurrent implementation, KVM\u0027s signature is hidden, but HyperV\u0027s is not,\nand Nvidia drivers don\u0027t work in Windows VMs.\n\nThis change generates an extra element in the libvirt xml for Windows\nguests on KVM which obfuscates HyperV\u0027s signature too, controlled by the\nexisting image and flavor parameters (img_hide_hypervisor_id and\nhide_hypervisor_id correspondingly). The extra xml element is\n  \u003cvendor_id state\u003d\u0027on\u0027 value\u003d\u00271234567890ab\u0027/\u003e\nin features/hyperv.\n\n[1] https://blueprints.launchpad.net/nova/+spec/hide-hypervisor-id-flavor-extra-spec\n[2] https://blueprints.launchpad.net/nova/+spec/add-kvm-hidden-feature\n\nChange-Id: Iaaeae9281301f14f4ae9b43f4a06de58b699fd68\nCloses-Bug: 1779845\n(cherry picked from commit ca543438e183b2bd97a08ef781ddeab8303354ed)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/dde1e727909b6b0cefea3bc60fad086b58044329"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/dde1e727909b6b0cefea3bc60fad086b58044329"}]},"parents_data":[{"branch_name":"refs/heads/stable/stein","commit_id":"105e6238dd536ac869276c38b5c76fefeb729b40","is_merged_in_target_branch":false}],"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}