)]}'
{"nova/virt/baremetal/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2a4f155117c222133c4da3375665bb144f107de3","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        return self.volume_driver.get_volume_connector(instance)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    def attach_volume(self, context, connection_info, instance, mountpoint,"},{"line_number":419,"context_line":"                      disk_bus\u003dNone, device_type\u003dNone, encryption\u003dNone):"},{"line_number":420,"context_line":"        return self.volume_driver.attach_volume(connection_info,"},{"line_number":421,"context_line":"                                                instance, mountpoint)"},{"line_number":422,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUX%2F%2FEv0%3D","line":419,"updated":"2014-02-17 09:56:45.000000000","message":"out of interest - why did you add these before encryption?","commit_id":"a9e40e3a61de0f433b25e63051c2f13984930e92"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"fad79d258e28413aadfb34a2f93d72ee540d0dec","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        return self.volume_driver.get_volume_connector(instance)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    def attach_volume(self, context, connection_info, instance, mountpoint,"},{"line_number":419,"context_line":"                      disk_bus\u003dNone, device_type\u003dNone, encryption\u003dNone):"},{"line_number":420,"context_line":"        return self.volume_driver.attach_volume(connection_info,"},{"line_number":421,"context_line":"                                                instance, mountpoint)"},{"line_number":422,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUX%2F%2FB%2Bw%3D","line":419,"in_reply_to":"AAAAUX%2F%2FEv0%3D","updated":"2014-02-17 16:16:23.000000000","message":"No good reason I guess - seemed more natural that encryption will be left out more often than the other two..","commit_id":"a9e40e3a61de0f433b25e63051c2f13984930e92"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2a4f155117c222133c4da3375665bb144f107de3","unresolved":false,"context_lines":[{"line_number":614,"context_line":"                                             mountpoint)"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    def detach_volume(self, connection_info, instance, mountpoint,"},{"line_number":617,"context_line":"                      encryption\u003dNone):"},{"line_number":618,"context_line":"        \"\"\"Detach volume storage to VM instance.\"\"\""},{"line_number":619,"context_line":"        _volumeops \u003d self._get_volumeops_for_compute_node(instance[\u0027node\u0027])"},{"line_number":620,"context_line":"        return _volumeops.detach_volume(connection_info,"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUX%2F%2FEu4%3D","line":617,"updated":"2014-02-17 09:56:45.000000000","message":"you need to update here","commit_id":"a9e40e3a61de0f433b25e63051c2f13984930e92"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"fad79d258e28413aadfb34a2f93d72ee540d0dec","unresolved":false,"context_lines":[{"line_number":614,"context_line":"                                             mountpoint)"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    def detach_volume(self, connection_info, instance, mountpoint,"},{"line_number":617,"context_line":"                      encryption\u003dNone):"},{"line_number":618,"context_line":"        \"\"\"Detach volume storage to VM instance.\"\"\""},{"line_number":619,"context_line":"        _volumeops \u003d self._get_volumeops_for_compute_node(instance[\u0027node\u0027])"},{"line_number":620,"context_line":"        return _volumeops.detach_volume(connection_info,"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUX%2F%2FCEA%3D","line":617,"in_reply_to":"AAAAUX%2F%2FEu4%3D","updated":"2014-02-17 16:16:23.000000000","message":"Actually the other detach was not needed - only attach is changed in this patch, but yeah - thanks for catching that smth is fishy :)","commit_id":"a9e40e3a61de0f433b25e63051c2f13984930e92"}]}