)]}'
{"id":"openstack%2Fnova~664041","triplet_id":"openstack%2Fnova~master~I950d07eb533e0d43466c58e36b314aaaf8560251","project":"openstack/nova","branch":"master","topic":"in-non-tuple","hashtags":[],"change_id":"I950d07eb533e0d43466c58e36b314aaaf8560251","subject":"Hacking N363: `in (not_a_tuple)`","status":"MERGED","created":"2019-06-07 19:20:20.000000000","updated":"2019-06-14 22:07:58.000000000","submitted":"2019-06-14 22:07:58.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"664041-1560550078286-1e9fde82","meta_rev_id":"5642bf508cb9bb11302b5fe10f11b942dc3cc0ec","_number":664041,"virtual_id_number":664041,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-06-07 21:34:46.000000000","_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-06-08 02:02:36.000000000","_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-06-08 14:08:12.000000000","_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-06-08 01:21:36.000000000","_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-06-07 22:34:37.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"date":"2019-06-08 02:14:05.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":2,"date":"2019-06-14 22:07:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-06-08 03:37:27.000000000","_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"date":"2019-06-08 03:54:42.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-06-14 17:05:26.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":0,"date":"2019-06-07 21:10:06.000000000","_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2019-06-14 17:12:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-10 06:53:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2019-06-10 20:44:42.000000000","_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-14 17:12:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-07 19:26:33.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-06-07 21:10:06.000000000","updated_by":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-06-07 21:34:46.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-06-07 22:34:37.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-06-08 01:21:36.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-06-08 02:02:36.000000000","updated_by":{"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-06-08 02:14:05.000000000","updated_by":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"reviewer":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"state":"REVIEWER"},{"updated":"2019-06-08 03:37:27.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-06-08 03:54:42.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-06-08 14:08:12.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-06-10 06:53:02.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2019-06-10 20:44:42.000000000","updated_by":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"reviewer":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"state":"REVIEWER"},{"updated":"2019-06-14 17:12:30.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2019-06-14 22:07:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"bcb9f57f74808b6b253c9d7db64d3757d78d9920","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-07 19:20:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4455e113dc7075425a9e4b84c0bc9126496a7b95","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2019-06-07 19:20:47.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b47b19b302521ac877b61795374ec845c360da03","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-07 19:27:02.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"888cf3df8de4b9fb20b044d3a0f970373ad66eaf","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-07 19:44:02.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d3ca563d4fec905810f4882493ef54b7c8db61c5","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2019-06-07 19:44:29.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"937e644d7da5e189a0887be30c6c5866983e107a","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-07 20:05:21.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c57343ce1f6c27f97ffe328071439f7429c403a9","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-07 21:09:39.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"d6a4bbdfb2e2c2c0ca19aed296d4c139e9235470","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2019-06-07 21:10:06.000000000","message":"Patch Set 3:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"5123cb2ad3e5b5beb4c5bf7ee21645ae9642dc95","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-06-07 21:34:46.000000000","message":"Patch Set 3:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/41/664041/3/check/nova-out-of-tree-pvm/38b386d : FAILURE in 21m 49s\n- nova-in-tree-pvm http://184.172.12.213/41/664041/3/check/nova-in-tree-pvm/98f3d87 : FAILURE in 20m 43s","accounts_in_message":[],"_revision_number":3},{"id":"17a8be60ff6c427c983d4342e9821efa1acaef53","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-06-07 22:34:37.000000000","message":"Patch Set 3:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/41/664041/3/check/tempest-dsvm-full-xenial/f3a6e4e/ : SUCCESS in 1h 21m 52s\n- tempest-dsvm-full-xenial-py3 https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/41/664041/3/check/tempest-dsvm-full-xenial-py3/a2d9f5e/ : SUCCESS in 1h 24m 01s (non-voting)\n- grenade-dsvm-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/41/664041/3/check/grenade-dsvm-xenial/a2f4ca7/ : SUCCESS in 1h 10m 25s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"f876fc430c019a0c943f7a96a0618119b6c6e5d7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-08 01:21:00.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/41/664041/3/check/grenade-py3/a19465e/ : SUCCESS in 1h 04m 55s\n- tempest-full-py3 http://logs.openstack.org/41/664041/3/check/tempest-full-py3/e414858/ : SUCCESS in 1h 42m 42s\n- openstack-tox-cover http://logs.openstack.org/41/664041/3/check/openstack-tox-cover/6f799be/cover/ : SUCCESS in 13m 39s\n- openstack-tox-lower-constraints http://logs.openstack.org/41/664041/3/check/openstack-tox-lower-constraints/47a01df/ : SUCCESS in 14m 34s\n- openstack-tox-pep8 http://logs.openstack.org/41/664041/3/check/openstack-tox-pep8/a73a220/ : SUCCESS in 10m 29s\n- openstack-tox-py27 http://logs.openstack.org/41/664041/3/check/openstack-tox-py27/e02e40a/ : SUCCESS in 11m 44s\n- openstack-tox-py36 http://logs.openstack.org/41/664041/3/check/openstack-tox-py36/63ee862/ : SUCCESS in 21m 26s\n- openstack-tox-py37 http://logs.openstack.org/41/664041/3/check/openstack-tox-py37/22b0324/ : SUCCESS in 14m 16s\n- openstack-tox-docs http://logs.openstack.org/41/664041/3/check/openstack-tox-docs/f3063e7/html/ : SUCCESS in 6m 11s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/41/664041/3/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/880f60a/ : SUCCESS in 50m 24s (non-voting)\n- devstack-plugin-ceph-tempest http://logs.openstack.org/41/664041/3/check/devstack-plugin-ceph-tempest/dd43bc9/ : SUCCESS in 1h 15m 25s (non-voting)\n- neutron-grenade-multinode http://logs.openstack.org/41/664041/3/check/neutron-grenade-multinode/aad272e/ : SUCCESS in 1h 05m 24s\n- nova-grenade-live-migration http://logs.openstack.org/41/664041/3/check/nova-grenade-live-migration/b171fb4/ : SUCCESS in 1h 08m 19s\n- nova-live-migration http://logs.openstack.org/41/664041/3/check/nova-live-migration/ac4999a/ : SUCCESS in 51m 30s\n- nova-lvm http://logs.openstack.org/41/664041/3/check/nova-lvm/897b5a7/ : SUCCESS in 1h 10m 29s (non-voting)\n- nova-multi-cell http://logs.openstack.org/41/664041/3/check/nova-multi-cell/4a2e0e1/ : SUCCESS in 1h 23m 57s (non-voting)\n- nova-next http://logs.openstack.org/41/664041/3/check/nova-next/e40f4b3/ : SUCCESS in 1h 34m 13s\n- nova-tox-functional http://logs.openstack.org/41/664041/3/check/nova-tox-functional/ca82e8c/ : SUCCESS in 19m 10s\n- nova-tox-functional-py36 http://logs.openstack.org/41/664041/3/check/nova-tox-functional-py36/fbbeaad/ : SUCCESS in 16m 03s\n- tempest-slow-py3 http://logs.openstack.org/41/664041/3/check/tempest-slow-py3/6462983/ : SUCCESS in 2h 14m 36s","accounts_in_message":[],"_revision_number":3},{"id":"78626302c7d2d376341a669f53662d5771f17392","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2019-06-08 01:21:36.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_VxFlexOS_NOVA http://publiclogs.emc.com/41/664041/3/check/EMC_VxFlexOS_NOVA/6d235be/EMC_VxFlexOS_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC VxFlexOS CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_VxFlexOS_CI","accounts_in_message":[],"_revision_number":3},{"id":"0201ff102ae4d200b72fd20b722ca1b1243de5b0","author":{"_account_id":16898,"name":"Virtuozzo CI","email":"virtuozzo6-ci@virtuozzo.com","username":"virtuozzo6-ci","tags":["SERVICE_USER"]},"date":"2019-06-08 02:02:36.000000000","message":"Patch Set 3:\n\nBuild failed\n\n- check-dsvm-tempest-vz7-exe-minimal http://openstack-3rd-party-virtuozzo-ci-logs.virtuozzo.com/41/664041/3/check/check-dsvm-tempest-vz7-exe-minimal/619a9a4 : FAILURE in 10m 25s\n- check-dsvm-tempest-vz7-exe-multinode http://openstack-3rd-party-virtuozzo-ci-logs.virtuozzo.com/41/664041/3/check/check-dsvm-tempest-vz7-exe-multinode/d1be3eb : FAILURE in 12m 13s\n\nFor information, see https://wiki.openstack.org/wiki/ThirdPartySystems/Virtuozzo_CI Make the comment \u0027run-Virtuozzo CI\u0027 to recheck","accounts_in_message":[],"_revision_number":3},{"id":"c9f9e34713ff3bf98927db66d564f629e2ff4dd3","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2019-06-08 02:14:05.000000000","message":"Patch Set 3:\n\nTesting completed on the zVM Driver CI system check-nova pipeline.  To recheck only the zVM driver plugins, submit a comment with only zvm: recheck in the comment. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-32708 : SUCCESS in 1h 52m 40s","accounts_in_message":[],"_revision_number":3},{"id":"54536f8e116ce0b7b80d9492739730db846569f5","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2019-06-08 03:37:27.000000000","message":"Patch Set 3:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/41/664041/3/check-vote/ext-nova-zuul/12e3e19 : SUCCESS in 1h 03m 23s","accounts_in_message":[],"_revision_number":3},{"id":"c7ba84caeaa98c71e6e82c3a1a484bd44a9a56a7","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-06-08 03:54:42.000000000","message":"Patch Set 3:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/664041/3 : FAILURE in 2h 11m 08s","accounts_in_message":[],"_revision_number":3},{"id":"5a03f9074bfab2d2bc61f6c9730bd553da7d3ad0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-08 07:13:17.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/41/664041/2/check/grenade-py3/3e9a410/ : SUCCESS in 52m 05s\n- tempest-full-py3 http://logs.openstack.org/41/664041/2/check/tempest-full-py3/cf4fb15/ : SUCCESS in 1h 47m 49s\n- openstack-tox-cover http://logs.openstack.org/41/664041/2/check/openstack-tox-cover/917d936/cover/ : SUCCESS in 14m 20s\n- openstack-tox-lower-constraints http://logs.openstack.org/41/664041/2/check/openstack-tox-lower-constraints/b77c5c1/ : SUCCESS in 15m 40s\n- openstack-tox-pep8 http://logs.openstack.org/41/664041/2/check/openstack-tox-pep8/ae37fcf/ : SUCCESS in 9m 27s\n- openstack-tox-py27 http://logs.openstack.org/41/664041/2/check/openstack-tox-py27/edc28c1/ : SUCCESS in 13m 45s\n- openstack-tox-py36 http://logs.openstack.org/41/664041/2/check/openstack-tox-py36/ce5d20d/ : SUCCESS in 11m 59s\n- openstack-tox-py37 http://logs.openstack.org/41/664041/2/check/openstack-tox-py37/b6a41ec/ : SUCCESS in 11m 38s\n- openstack-tox-docs http://logs.openstack.org/41/664041/2/check/openstack-tox-docs/c0fe876/html/ : SUCCESS in 6m 22s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/41/664041/2/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/c7fa619/ : SUCCESS in 50m 23s (non-voting)\n- devstack-plugin-ceph-tempest http://logs.openstack.org/41/664041/2/check/devstack-plugin-ceph-tempest/7b8c47b/ : SUCCESS in 1h 33m 41s (non-voting)\n- neutron-grenade-multinode http://logs.openstack.org/41/664041/2/check/neutron-grenade-multinode/86611e2/ : SUCCESS in 1h 14m 54s\n- nova-grenade-live-migration http://logs.openstack.org/41/664041/2/check/nova-grenade-live-migration/f1fa256/ : SUCCESS in 58m 57s\n- nova-live-migration http://logs.openstack.org/41/664041/2/check/nova-live-migration/0669c27/ : SUCCESS in 47m 52s\n- nova-lvm http://logs.openstack.org/41/664041/2/check/nova-lvm/cd2634c/ : SUCCESS in 1h 03m 39s (non-voting)\n- nova-multi-cell http://logs.openstack.org/41/664041/2/check/nova-multi-cell/ca86dc4/ : SUCCESS in 1h 41m 16s (non-voting)\n- nova-next http://logs.openstack.org/41/664041/2/check/nova-next/62e9912/ : SUCCESS in 1h 22m 38s\n- nova-tox-functional http://logs.openstack.org/41/664041/2/check/nova-tox-functional/ad11ab0/ : SUCCESS in 24m 27s\n- nova-tox-functional-py36 http://logs.openstack.org/41/664041/2/check/nova-tox-functional-py36/d579877/ : SUCCESS in 17m 22s\n- tempest-slow-py3 http://logs.openstack.org/41/664041/2/check/tempest-slow-py3/8643727/ : SUCCESS in 2h 17m 28s","accounts_in_message":[],"_revision_number":2},{"id":"1fb8d84472f25f75f52f30ab79c1cb0ea699eda2","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2019-06-08 14:08:12.000000000","message":"Patch Set 3:\n\nTesting failed ubuntu-xenial-s390x. For rechecking only on the ubuntu-xenial-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/664041/3/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/60c08f5 : FAILURE in 40m 46s","accounts_in_message":[],"_revision_number":3},{"id":"7365aea8a54e1bf4596f828e7d3ac7197c22642c","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-06-10 06:53:02.000000000","message":"Patch Set 3: Code-Review+1\n\nlgtm","accounts_in_message":[],"_revision_number":3},{"id":"01c0c27248a4eeb5b1dd32b0f08960b1012fdf47","author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"date":"2019-06-10 20:44:42.000000000","message":"Patch Set 3: Code-Review+2\n\nNice additional check, LGTM","accounts_in_message":[],"_revision_number":3},{"id":"771008ffd7c76472ba29580970e753f586959748","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-06-14 16:39:47.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"d00f4ebedd87646a0471e5ee51c1bd39ded8dfdd","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-06-14 16:40:03.000000000","message":"Patch Set 3:\n\nSoft -1 but we should just remove dead code when we see it","accounts_in_message":[],"_revision_number":3},{"id":"3f2534e199a46a2286d4cbc7c3ac00dc24c3afce","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-14 17:05:26.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"79fb66fdd90951ef7d737a6e9edcd539fd2be461","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-06-14 17:12:30.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nFollow-up takes care of my issue so +2","accounts_in_message":[],"_revision_number":3},{"id":"0ff8b6f017dea63356a6831e9a19b12ac12f8484","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-14 17:13:23.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"e22a428796b0a88481fcc365cf241a4bf984161c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-14 22:07:57.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 http://logs.openstack.org/41/664041/3/gate/grenade-py3/2c75320/ : SUCCESS in 1h 08m 03s\n- tempest-full-py3 http://logs.openstack.org/41/664041/3/gate/tempest-full-py3/9385165/ : SUCCESS in 1h 31m 05s\n- openstack-tox-lower-constraints http://logs.openstack.org/41/664041/3/gate/openstack-tox-lower-constraints/af51bd0/ : SUCCESS in 15m 00s\n- openstack-tox-pep8 http://logs.openstack.org/41/664041/3/gate/openstack-tox-pep8/e2d2717/ : SUCCESS in 10m 07s\n- openstack-tox-py27 http://logs.openstack.org/41/664041/3/gate/openstack-tox-py27/5dc7744/ : SUCCESS in 11m 54s\n- openstack-tox-py36 http://logs.openstack.org/41/664041/3/gate/openstack-tox-py36/0d50f6c/ : SUCCESS in 11m 27s\n- openstack-tox-py37 http://logs.openstack.org/41/664041/3/gate/openstack-tox-py37/548bbe5/ : SUCCESS in 13m 30s\n- openstack-tox-docs http://logs.openstack.org/41/664041/3/gate/openstack-tox-docs/2f15aa1/html/ : SUCCESS in 6m 17s\n- nova-grenade-live-migration http://logs.openstack.org/41/664041/3/gate/nova-grenade-live-migration/35b6ac5/ : SUCCESS in 1h 12m 22s\n- nova-live-migration http://logs.openstack.org/41/664041/3/gate/nova-live-migration/de23e1f/ : SUCCESS in 48m 57s\n- nova-tox-functional http://logs.openstack.org/41/664041/3/gate/nova-tox-functional/83c2f64/ : SUCCESS in 19m 10s\n- nova-tox-functional-py36 http://logs.openstack.org/41/664041/3/gate/nova-tox-functional-py36/8417130/ : SUCCESS in 18m 09s\n- nova-next http://logs.openstack.org/41/664041/3/gate/nova-next/45f87ee/ : SUCCESS in 1h 25m 15s\n- tempest-slow-py3 http://logs.openstack.org/41/664041/3/gate/tempest-slow-py3/edd2618/ : SUCCESS in 2h 18m 25s","accounts_in_message":[],"_revision_number":3},{"id":"ca9e89d99a7e7f475b28f3728876ff327c2e0dce","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-14 22:07:58.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"8899f8b5b5dfc84e8e0481a5587d0285c6835ec5","revisions":{"cfdae797ecef4ac1298e3a09d922d37ee6d1f68b":{"kind":"REWORK","_number":1,"created":"2019-06-07 19:20:20.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/41/664041/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/41/664041/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/664041/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/664041/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/664041/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/41/664041/1"}}},"commit":{"parents":[{"commit":"729bf14892631644167b0df1da89107c34c0657f","subject":"Merge \"Robustify attachment tracking in CinderFixtureNewAttachFlow\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/729bf14892631644167b0df1da89107c34c0657f"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-06-07 19:17:31.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-06-07 19:17:31.000000000","tz":-300},"subject":"WIP: Fix some bogus `in (not_a_tuple)` uses","message":"WIP: Fix some bogus `in (not_a_tuple)` uses\n\nA couple of places in the libvirt driver had conditionals including:\n\n if something in (element):\n\nwhich was clearly intended to be\n\n if something in (element,):\n\n(I.e. `in $tuple`, not `in element` with redundant parens)\n\nFix \u0027em.\n\nWIP: Clearly these aren\u0027t working as expected, so unit tests are either\nmissing or wrong. Fix those too.\n\nChange-Id: I950d07eb533e0d43466c58e36b314aaaf8560251\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cfdae797ecef4ac1298e3a09d922d37ee6d1f68b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cfdae797ecef4ac1298e3a09d922d37ee6d1f68b"}]},"branch":"refs/heads/master"},"99fc9ce93444fc70e4db593c9d676fb9cafaac2e":{"kind":"REWORK","_number":2,"created":"2019-06-07 19:44:02.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/41/664041/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/41/664041/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/664041/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/664041/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/664041/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/41/664041/2"}}},"commit":{"parents":[{"commit":"729bf14892631644167b0df1da89107c34c0657f","subject":"Merge \"Robustify attachment tracking in CinderFixtureNewAttachFlow\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/729bf14892631644167b0df1da89107c34c0657f"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-06-07 19:17:31.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-06-07 19:35:37.000000000","tz":-300},"subject":"Fix some bogus `in (not_a_tuple)` uses","message":"Fix some bogus `in (not_a_tuple)` uses\n\nA few places in the code had conditionals including:\n\n if something in (element):\n\nwhich was clearly intended to be\n\n if something in (element,):\n\n(I.e. `in $tuple`, not `in element` with redundant parens) or just\n\n if something \u003d\u003d element:\n\nFix \u0027em.\n\nNOTE: These weren\u0027t actually latent bugs because\n\n \u0027foo\u0027 in (\u0027foo\u0027)\n\nwhich is the same as\n\n \u0027foo\u0027 in \u0027foo\u0027\n\nreturns True. In order to be a bug, the left operand would have to be\nable to be a substring of the right:\n\n \u0027foo\u0027 in (\u0027foobar\u0027)  # True\n \u0027foo\u0027 in (\u0027foobar\u0027,) # False\n\n...which I don\u0027t think is possible in any of the scenarios found.\n\nNOTE: I considered writing a hacking rule for this, but it was going to\nbe tough to hit things like:\n\nnova/db/sqlalchemy/api.py:374:    return \"DELETE FROM %s WHERE %s in (SELECT T1.%s FROM (%s) as T1)\" % (\nnova/db/sqlalchemy/migrate_repo/versions/359_add_service_uuid.py:31:    if uuid_index_name not in (i[\u0027name\u0027] for i in indexes):\nnova/quota.py:461:                    val for val in (quotas.get(key), project_quotas.get(key))\nnova/tests/functional/test_servers_provider_tree.py:326:        for uuid in (all_uuids - agg_uuids):\nnova/tests/unit/api/openstack/compute/test_hypervisors.py:124:        if not marker_found and marker in (str(hyper.id), hyper.uuid):\nnova/tests/unit/test_hacking.py:894:        for filename in (good_filenames + bad_filenames):\n\nChange-Id: I950d07eb533e0d43466c58e36b314aaaf8560251\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/99fc9ce93444fc70e4db593c9d676fb9cafaac2e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/99fc9ce93444fc70e4db593c9d676fb9cafaac2e"}]},"branch":"refs/heads/master"},"8899f8b5b5dfc84e8e0481a5587d0285c6835ec5":{"kind":"REWORK","_number":3,"created":"2019-06-07 21:09:39.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/41/664041/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/41/664041/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/664041/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/664041/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/41/664041/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/41/664041/3"}}},"commit":{"parents":[{"commit":"729bf14892631644167b0df1da89107c34c0657f","subject":"Merge \"Robustify attachment tracking in CinderFixtureNewAttachFlow\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/729bf14892631644167b0df1da89107c34c0657f"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-06-07 19:17:31.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-06-07 21:08:12.000000000","tz":-300},"subject":"Hacking N363: `in (not_a_tuple)`","message":"Hacking N363: `in (not_a_tuple)`\n\nA few places in the code had conditionals including:\n\n if something in (element):\n\nwhich was clearly intended to be\n\n if something in (element,):\n\n(I.e. `in $tuple`, not `in element` with redundant parens) or just\n\n if something \u003d\u003d element:\n\nFix those [1] and introduce hacking rule N363 to disallow this kind of\nthing in the future.\n\n[1] NOTE: These weren\u0027t actually latent bugs because\n\n \u0027foo\u0027 in (\u0027foo\u0027)\n\nwhich is the same as\n\n \u0027foo\u0027 in \u0027foo\u0027\n\nreturns True. In order to be a bug, the left operand would have to be\nable to be a substring of the right:\n\n \u0027foo\u0027 in (\u0027foobar\u0027)  # True\n \u0027foo\u0027 in (\u0027foobar\u0027,) # False\n\n...which I don\u0027t think is possible in any of the scenarios found.\n\nChange-Id: I950d07eb533e0d43466c58e36b314aaaf8560251\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8899f8b5b5dfc84e8e0481a5587d0285c6835ec5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8899f8b5b5dfc84e8e0481a5587d0285c6835ec5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}