)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8a939642eabc59dedce990925c6063141fafc7a4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: Cleanup of \u0027_test_resize\u0027 helper test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is way too complicated for it\u0027s own good so clean things up:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- Remove the \u0027test_migrate_request_spec_not_found\u0027 which was checking"},{"line_number":12,"context_line":"  the behavior of the \u0027RequestSpec.get_by_instance_uuid\u0027 function when a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_4f06d31f","line":9,"range":{"start_line":9,"start_character":32,"end_line":9,"end_character":36},"updated":"2019-06-10 16:05:11.000000000","message":"its","commit_id":"b1ac9fa90a2efc937c9178a09e4fa8efe74e8df9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3a5dfb80d4d798c6901282f2848d6456ee74b613","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: Cleanup of \u0027_test_resize\u0027 helper test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is way too complicated for it\u0027s own good so clean things up:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- Remove the \u0027test_migrate_request_spec_not_found\u0027 which was checking"},{"line_number":12,"context_line":"  the behavior of the \u0027RequestSpec.get_by_instance_uuid\u0027 function when a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_5280b8c0","line":9,"range":{"start_line":9,"start_character":32,"end_line":9,"end_character":36},"in_reply_to":"9fb8cfa7_4f06d31f","updated":"2019-06-10 16:26:15.000000000","message":"goddangit","commit_id":"b1ac9fa90a2efc937c9178a09e4fa8efe74e8df9"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8a939642eabc59dedce990925c6063141fafc7a4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is way too complicated for it\u0027s own good so clean things up:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- Remove the \u0027test_migrate_request_spec_not_found\u0027 which was checking"},{"line_number":12,"context_line":"  the behavior of the \u0027RequestSpec.get_by_instance_uuid\u0027 function when a"},{"line_number":13,"context_line":"  \u0027RequestSpec\u0027 isn\u0027t found. This might be useful if we were attempting"},{"line_number":14,"context_line":"  to handle this exception but we\u0027re not"},{"line_number":15,"context_line":"- Remove a useless \u0027if\u0027 statement that was already covered by internal"},{"line_number":16,"context_line":"  \u0027if\u0027 statements"},{"line_number":17,"context_line":"- Rename the \u0027flavor_id_passed\u0027 parameter to \u0027is_resize\u0027 to better"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_8fc4cb60","line":14,"range":{"start_line":11,"start_character":0,"end_line":14,"end_character":40},"updated":"2019-06-10 16:05:11.000000000","message":"I don\u0027t agree with this part of the change. We\u0027re testing that RequestSpecNotFound raises through, which is significant.","commit_id":"b1ac9fa90a2efc937c9178a09e4fa8efe74e8df9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3a5dfb80d4d798c6901282f2848d6456ee74b613","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is way too complicated for it\u0027s own good so clean things up:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- Remove the \u0027test_migrate_request_spec_not_found\u0027 which was checking"},{"line_number":12,"context_line":"  the behavior of the \u0027RequestSpec.get_by_instance_uuid\u0027 function when a"},{"line_number":13,"context_line":"  \u0027RequestSpec\u0027 isn\u0027t found. This might be useful if we were attempting"},{"line_number":14,"context_line":"  to handle this exception but we\u0027re not"},{"line_number":15,"context_line":"- Remove a useless \u0027if\u0027 statement that was already covered by internal"},{"line_number":16,"context_line":"  \u0027if\u0027 statements"},{"line_number":17,"context_line":"- Rename the \u0027flavor_id_passed\u0027 parameter to \u0027is_resize\u0027 to better"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_521bd8ce","line":14,"range":{"start_line":11,"start_character":0,"end_line":14,"end_character":40},"in_reply_to":"9fb8cfa7_8fc4cb60","updated":"2019-06-10 16:26:15.000000000","message":"I really don\u0027t think it is. The key point is this bit:\n\n  This might be useful if we were attempting to handle this\n  exception but we\u0027re not.\n\nIf we were transforming this exception, we should have a test. If we were raising the exception, we should have a test. If we\u0027re doing nothing with an exception though, I don\u0027t think there\u0027s a test needed. We don\u0027t have tests for database access errors or `SystemError` or the fact that `Instance.get_flavor` returns None, to name but a few, so we shouldn\u0027t have this test either. It\u0027s a bad test (\"Bad test! Bad!\")","commit_id":"b1ac9fa90a2efc937c9178a09e4fa8efe74e8df9"}],"nova/tests/unit/compute/test_compute_api.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c17838e24c70624bec327ae7441b24e78ab0ab6b","unresolved":false,"context_lines":[{"line_number":2042,"context_line":"            mock_get_flavor.assert_called_once_with(\u0027new-flavor-id\u0027,"},{"line_number":2043,"context_line":"                                                    read_deleted\u003d\u0027no\u0027)"},{"line_number":2044,"context_line":""},{"line_number":2045,"context_line":"        if not (flavor_id_passed and same_flavor):"},{"line_number":2046,"context_line":"            if flavor_id_passed:"},{"line_number":2047,"context_line":"                mock_upsize.assert_called_once_with("},{"line_number":2048,"context_line":"                    test.MatchType(objects.Flavor),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_495493ff","side":"PARENT","line":2045,"updated":"2019-06-10 14:40:04.000000000","message":"This would trigger if we\u0027d requested a resize to the same flavor This is unnecessary since we have if_statements to guard against these individually...","commit_id":"3fb753bb85bcb6f1b6013ca037da7498ce742ef4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c17838e24c70624bec327ae7441b24e78ab0ab6b","unresolved":false,"context_lines":[{"line_number":2043,"context_line":"                                                    read_deleted\u003d\u0027no\u0027)"},{"line_number":2044,"context_line":""},{"line_number":2045,"context_line":"        if not (flavor_id_passed and same_flavor):"},{"line_number":2046,"context_line":"            if flavor_id_passed:"},{"line_number":2047,"context_line":"                mock_upsize.assert_called_once_with("},{"line_number":2048,"context_line":"                    test.MatchType(objects.Flavor),"},{"line_number":2049,"context_line":"                    test.MatchType(objects.Flavor))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_e9546700","side":"PARENT","line":2046,"updated":"2019-06-10 14:40:04.000000000","message":"like here","commit_id":"3fb753bb85bcb6f1b6013ca037da7498ce742ef4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c17838e24c70624bec327ae7441b24e78ab0ab6b","unresolved":false,"context_lines":[{"line_number":2049,"context_line":"                    test.MatchType(objects.Flavor))"},{"line_number":2050,"context_line":"                image_meta \u003d utils.get_image_from_system_metadata("},{"line_number":2051,"context_line":"                    fake_inst.system_metadata)"},{"line_number":2052,"context_line":"                if not same_flavor:"},{"line_number":2053,"context_line":"                    mock_validate.assert_called_once_with("},{"line_number":2054,"context_line":"                        self.context, image_meta, new_flavor, root_bdm\u003dNone,"},{"line_number":2055,"context_line":"                        validate_pci\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_095a1b29","side":"PARENT","line":2052,"updated":"2019-06-10 14:40:04.000000000","message":"and here","commit_id":"3fb753bb85bcb6f1b6013ca037da7498ce742ef4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c17838e24c70624bec327ae7441b24e78ab0ab6b","unresolved":false,"context_lines":[{"line_number":2076,"context_line":"            mock_get_by_instance_uuid.assert_called_once_with(self.context,"},{"line_number":2077,"context_line":"                                                              fake_inst.uuid)"},{"line_number":2078,"context_line":""},{"line_number":2079,"context_line":"            if flavor_id_passed:"},{"line_number":2080,"context_line":"                mock_record.assert_called_once_with(self.context, fake_inst,"},{"line_number":2081,"context_line":"                                                    \u0027resize\u0027)"},{"line_number":2082,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_29783f8e","side":"PARENT","line":2079,"updated":"2019-06-10 14:40:04.000000000","message":"and here","commit_id":"3fb753bb85bcb6f1b6013ca037da7498ce742ef4"}]}