)]}'
{"nova/pci/stats.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"8d6444c8eb2c0d2fcf14527640b2d2c8b65da548","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        # requested, so we need to return if we\u0027ve demanded a NUMA affinity of"},{"line_number":269,"context_line":"        # LEGACY. Similarly, we will also return if we have enough devices to"},{"line_number":270,"context_line":"        # satisfy this somewhat strict policy."},{"line_number":271,"context_line":"        if requested_policy \u003d\u003d fields.PCINUMAAffinityPolicy.LEGACY or sum("},{"line_number":272,"context_line":"                pool[\u0027count\u0027] for pool in filtered_pools) \u003e\u003d requested_count:"},{"line_number":273,"context_line":"            return filtered_pools"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        # if we\u0027ve got here, we\u0027re using the PREFERRED policy and weren\u0027t able"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_9090faef","side":"PARENT","line":272,"range":{"start_line":271,"start_character":70,"end_line":272,"end_character":77},"updated":"2019-06-17 05:41:37.000000000","message":"If the requested_policy is Preferred at here, then we will run the check on the right side of \u0027or\u0027, then if we have enough PCI devices in the pools  on the numa nodes which the instance is running on, then we return those pools.\n\nSo this is preferred policy expecting?\n\n\n@ZhouZhou,\n\nYou case in the bug report is as below:\nit will causes vm build failed when cpu located in numa1 and pci located in numa0 in compute node.\n\nBut the legacy policy only choice the numa node with pci device, or the pci device doesn\u0027t have numa info.\n\nhttp://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/share-pci-between-numa-nodes.html\n\"\nThe legacy value will mean that nova will boot instances with PCI device if either:\n\n* The PCI device is associated with at least one NUMA nodes on which the instance will be booted\n\n* There is no information about PCI-NUMA affinity available\n\"\n\nSo your case doesn\u0027t match the legacy policy. If you use the prefered policy, then it should be match your case.","commit_id":"1e088b3b270b04382c3c3cd5cd623261abbbc67d"},{"author":{"_account_id":27295,"name":"Li Zhouzhou","email":"lizhouzhou_yewu@cmss.chinamobile.com","username":"LiZhouzhou"},"change_message_id":"d6280f8b194dec25455923fc27d77d941e5d5b8a","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        # requested, so we need to return if we\u0027ve demanded a NUMA affinity of"},{"line_number":269,"context_line":"        # LEGACY. Similarly, we will also return if we have enough devices to"},{"line_number":270,"context_line":"        # satisfy this somewhat strict policy."},{"line_number":271,"context_line":"        if requested_policy \u003d\u003d fields.PCINUMAAffinityPolicy.LEGACY or sum("},{"line_number":272,"context_line":"                pool[\u0027count\u0027] for pool in filtered_pools) \u003e\u003d requested_count:"},{"line_number":273,"context_line":"            return filtered_pools"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        # if we\u0027ve got here, we\u0027re using the PREFERRED policy and weren\u0027t able"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_9bd81b1f","side":"PARENT","line":272,"range":{"start_line":271,"start_character":70,"end_line":272,"end_character":77},"in_reply_to":"9fb8cfa7_9090faef","updated":"2019-06-17 06:54:15.000000000","message":"I have misunderstood this definition, thx.","commit_id":"1e088b3b270b04382c3c3cd5cd623261abbbc67d"}]}