)]}'
{"nova/context.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a5774121e7d60b7c0519b740d9c6714537e3a05c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            kwargs[\u0027project_id\u0027] \u003d project_id"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        if kwargs.pop(\u0027instance_lock_checked\u0027, None) is not None:"},{"line_number":112,"context_line":"            # TODO(mriedem): Let this be a hard failure in 19.0.0 (S)."},{"line_number":113,"context_line":"            warnings.warn(\"The \u0027instance_lock_checked\u0027 kwarg to \""},{"line_number":114,"context_line":"                          \"nova.context.RequestContext is no longer used and \""},{"line_number":115,"context_line":"                          \"will be removed in a future version.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_b4976e48","side":"PARENT","line":112,"updated":"2019-06-12 19:15:20.000000000","message":"I was going to say maybe we should just remove the check entirely and let it go through, but the parent __init__ uses only named kwargs so it would fail if we passed it through - which is what would fail now as well...except I think with a TypeError instead of a ValueError. So maybe we should just remove the explicit check and if someone is passing it let them blow up with the TypeError from the parent class __init__?","commit_id":"f298973520420710a617e4d79e853f2416b29786"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bbfc22cdb6dd2f11693eed777b6ce4d5e425f03e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            kwargs[\u0027project_id\u0027] \u003d project_id"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        if kwargs.pop(\u0027instance_lock_checked\u0027, None) is not None:"},{"line_number":112,"context_line":"            # TODO(mriedem): Let this be a hard failure in 19.0.0 (S)."},{"line_number":113,"context_line":"            warnings.warn(\"The \u0027instance_lock_checked\u0027 kwarg to \""},{"line_number":114,"context_line":"                          \"nova.context.RequestContext is no longer used and \""},{"line_number":115,"context_line":"                          \"will be removed in a future version.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_d47b0225","side":"PARENT","line":112,"in_reply_to":"9fb8cfa7_b4976e48","updated":"2019-06-12 19:16:34.000000000","message":"wfm","commit_id":"f298973520420710a617e4d79e853f2416b29786"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f95b49485a875ec3ce3db67b8ddc076800ed6c70","unresolved":false,"context_lines":[{"line_number":96,"context_line":"           :param overwrite: Set to False to ensure that the greenthread local"},{"line_number":97,"context_line":"                copy of the index is not overwritten."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"           :param instance_lock_checked: This is not used and will be removed"},{"line_number":100,"context_line":"                in a future release."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"           :param user_auth_plugin: The auth plugin for the current request\u0027s"},{"line_number":103,"context_line":"                authentication data."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_2b76af3f","line":100,"range":{"start_line":99,"start_character":0,"end_line":100,"end_character":36},"updated":"2019-06-13 13:58:25.000000000","message":"This comment should be removed.","commit_id":"4c4a3f175f8cad07187609fe12679f3c48b750df"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7154b1cf4cad7e19704586c827a482280c18c147","unresolved":false,"context_lines":[{"line_number":96,"context_line":"           :param overwrite: Set to False to ensure that the greenthread local"},{"line_number":97,"context_line":"                copy of the index is not overwritten."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"           :param instance_lock_checked: This is not used and will be removed"},{"line_number":100,"context_line":"                in a future release."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"           :param user_auth_plugin: The auth plugin for the current request\u0027s"},{"line_number":103,"context_line":"                authentication data."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_fde858b3","line":100,"range":{"start_line":99,"start_character":0,"end_line":100,"end_character":36},"in_reply_to":"9fb8cfa7_2b76af3f","updated":"2019-06-13 15:36:22.000000000","message":"Good eye, Takashi, thanks. Done.","commit_id":"4c4a3f175f8cad07187609fe12679f3c48b750df"}]}