)]}'
{"nova/api/openstack/compute/schemas/v3/create_backup.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"db09461902243407f50c2798cfee198680517a7a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":20,"context_line":"            \u0027properties\u0027: {"},{"line_number":21,"context_line":"                \u0027name\u0027: {"},{"line_number":22,"context_line":"                    \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 1, \u0027maxLength\u0027: 255,"},{"line_number":23,"context_line":"                    \u0027pattern\u0027: \u0027^[a-zA-Z0-9 _-]+$\u0027"},{"line_number":24,"context_line":"                },"},{"line_number":25,"context_line":"                \u0027backup_type\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2B%2FX8%3D","line":22,"updated":"2014-01-20 01:09:13.000000000","message":"So this type of definition comes up quite a bit for names to be stored in the db. Do you think its worth having a predefined type for this?","commit_id":"3ebdd0e382017a9b81ecb59ce93a4501e130fb18"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"912d75058bb2b308bb638d17c6430fff40246e9b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":20,"context_line":"            \u0027properties\u0027: {"},{"line_number":21,"context_line":"                \u0027name\u0027: {"},{"line_number":22,"context_line":"                    \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 1, \u0027maxLength\u0027: 255,"},{"line_number":23,"context_line":"                    \u0027pattern\u0027: \u0027^[a-zA-Z0-9 _-]+$\u0027"},{"line_number":24,"context_line":"                },"},{"line_number":25,"context_line":"                \u0027backup_type\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2B%2Bfs%3D","line":22,"in_reply_to":"AAAAUH%2F%2B%2B%2Bs%3D","updated":"2014-01-20 07:49:34.000000000","message":"I have posted https://review.openstack.org/#/c/67781/ for the above \u0027name\u0027 parameter validation.","commit_id":"3ebdd0e382017a9b81ecb59ce93a4501e130fb18"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8cd96a828787467d6ac153a5133d087cfdc8915d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":20,"context_line":"            \u0027properties\u0027: {"},{"line_number":21,"context_line":"                \u0027name\u0027: {"},{"line_number":22,"context_line":"                    \u0027type\u0027: \u0027string\u0027, \u0027minLength\u0027: 1, \u0027maxLength\u0027: 255,"},{"line_number":23,"context_line":"                    \u0027pattern\u0027: \u0027^[a-zA-Z0-9 _-]+$\u0027"},{"line_number":24,"context_line":"                },"},{"line_number":25,"context_line":"                \u0027backup_type\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2B%2B%2Bs%3D","line":22,"in_reply_to":"AAAAUH%2F%2B%2FX8%3D","updated":"2014-01-20 04:47:35.000000000","message":"Great idea!\nNow Nova v3 API contains some \u0027name\u0027 parameters such as keypair, server, flavor, aggregate and so on. I also think the best way is that their names are validated with the same validation way, that would make API more consistent.\n\nNow each validation ways is different like the following because of porting it from v2 API:\n\n keypair name: length: 1-255, pattern: \u0027^[a-zA-Z0-9 _-]+$\u0027\n flavor name: length: 1-255, pattern: \u0027^[a-zA-Z0-9. _-]*[a-zA-Z0-9_-]+[a-zA-Z0-9. _-]*$\u0027\n backup name: nothing. (This patch defines it from keypair\u0027s)\n server name: length: 1-255, pattern: nothing\n aggregate: length: 1-255, pattern: nothing\n [..]\n\nI will create another patch which defines a \u0027name\u0027 type for sharing it between their APIs.","commit_id":"3ebdd0e382017a9b81ecb59ce93a4501e130fb18"}]}