)]}'
{"id":"openstack%2Fnova~665147","triplet_id":"openstack%2Fnova~stable%2Fstein~Ia597594e0469c0e83d7ad22b0678390aaebaffe7","project":"openstack/nova","branch":"stable/stein","topic":"bug/1804062","hashtags":[],"change_id":"Ia597594e0469c0e83d7ad22b0678390aaebaffe7","subject":"Fix double word hacking test","status":"MERGED","created":"2019-06-13 14:21:43.000000000","updated":"2019-06-14 22:22:22.000000000","submitted":"2019-06-14 22:22:21.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"665147-1560550942123-44d5107d","meta_rev_id":"a2fa2ff87b8a2910fd8963a1800e4e8a16e536f2","_number":665147,"virtual_id_number":665147,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-06-14 14:41:56.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"value":2,"date":"2019-06-14 22:22:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"recommended":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":1,"date":"2019-06-13 15:39:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2019-06-13 19:20:07.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-06-13 19:26:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":1,"date":"2019-06-14 14:13:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"date":"2019-06-14 12:03:30.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2019-06-13 19:26:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-13 15:39:04.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-06-13 19:20:07.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-06-13 19:26:02.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2019-06-14 12:03:30.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-06-14 14:13:31.000000000","updated_by":{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},"reviewer":{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},"state":"REVIEWER"},{"updated":"2019-06-14 14:41:56.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-06-14 22:22:21.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"96f044cfe9053618eb94d7c8ad6f2240b45396c6","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-06-13 14:21:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8bd7eae6cbf07ca42da41057298be3c98608fcce","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-13 15:39:04.000000000","message":"Patch Set 1: Code-Review+1\n\nGood","accounts_in_message":[],"_revision_number":1},{"id":"2efecdd31bc2f97d7bf77633241917a5c6dfb9ce","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-06-13 19:00:41.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/665147/1 : SUCCESS in 2h 22m 36s","accounts_in_message":[],"_revision_number":1},{"id":"c6262e06a7d88b76e6cc75d2fc32b5a3200542a3","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-13 19:20:07.000000000","message":"Patch Set 1: Code-Review+2\n\nLooks good to me, conflicts are noted.","accounts_in_message":[],"_revision_number":1},{"id":"79cc0d3880684c3f90e37cd50de4e5414bd516eb","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-06-13 19:26:02.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"6ed933632f55eafb5bde6069b1fe2eba416f01e2","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-13 19:39:11.000000000","message":"Patch Set 1:\n\nI\u0027m not sure why but tempest jobs are running on this patch and they shouldn\u0027t be...unrelated problem but something worth investigating since it slows down merging fixes like this.","accounts_in_message":[],"_revision_number":1},{"id":"499de545f32887e8227cdf550ae4ba225a465998","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-13 23:59:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/47/665147/1/check/openstack-tox-cover/7f3608b/cover/ : SUCCESS in 22m 07s\n- openstack-tox-lower-constraints http://logs.openstack.org/47/665147/1/check/openstack-tox-lower-constraints/f3da89a/ : SUCCESS in 11m 18s\n- openstack-tox-pep8 http://logs.openstack.org/47/665147/1/check/openstack-tox-pep8/867ac6a/ : SUCCESS in 9m 44s\n- openstack-tox-py27 http://logs.openstack.org/47/665147/1/check/openstack-tox-py27/23e8695/ : SUCCESS in 11m 49s\n- openstack-tox-py35 http://logs.openstack.org/47/665147/1/check/openstack-tox-py35/4e75188/ : SUCCESS in 14m 47s\n- openstack-tox-py36 http://logs.openstack.org/47/665147/1/check/openstack-tox-py36/e22e14c/ : SUCCESS in 13m 36s\n- openstack-tox-py37 http://logs.openstack.org/47/665147/1/check/openstack-tox-py37/216ed7c/ : SUCCESS in 12m 27s\n- openstack-tox-docs http://logs.openstack.org/47/665147/1/check/openstack-tox-docs/2e993d4/html/ : SUCCESS in 6m 42s\n- nova-tox-functional http://logs.openstack.org/47/665147/1/check/nova-tox-functional/c92fa93/ : SUCCESS in 21m 57s\n- nova-tox-functional-py35 http://logs.openstack.org/47/665147/1/check/nova-tox-functional-py35/7f670f6/ : SUCCESS in 19m 36s","accounts_in_message":[],"_revision_number":1},{"id":"ca99d6bca5fb2be76ef7073fcf69d28979d310c2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-14 00:00:13.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"600691d352ebb77d5836f434239c620aa7b02cae","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-14 00:35:59.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints http://logs.openstack.org/47/665147/1/gate/openstack-tox-lower-constraints/4412a96/ : SUCCESS in 11m 49s\n- openstack-tox-pep8 http://logs.openstack.org/47/665147/1/gate/openstack-tox-pep8/f95eefc/ : SUCCESS in 9m 59s\n- openstack-tox-py27 http://logs.openstack.org/47/665147/1/gate/openstack-tox-py27/1e9bf84/ : SUCCESS in 15m 55s\n- openstack-tox-py35 http://logs.openstack.org/47/665147/1/gate/openstack-tox-py35/099d8ec/ : SUCCESS in 15m 12s\n- openstack-tox-py36 http://logs.openstack.org/47/665147/1/gate/openstack-tox-py36/45db64d/ : FAILURE in 34m 45s\n- openstack-tox-py37 http://logs.openstack.org/47/665147/1/gate/openstack-tox-py37/ec3f17d/ : SUCCESS in 22m 09s\n- openstack-tox-docs http://logs.openstack.org/47/665147/1/gate/openstack-tox-docs/1abcebb/html/ : SUCCESS in 6m 12s\n- nova-tox-functional http://logs.openstack.org/47/665147/1/gate/nova-tox-functional/c9bac19/ : SUCCESS in 21m 18s\n- nova-tox-functional-py35 http://logs.openstack.org/47/665147/1/gate/nova-tox-functional-py35/da7945b/ : SUCCESS in 19m 46s","accounts_in_message":[],"_revision_number":1},{"id":"9fadd348dff94d019fd4588e4bded66c1b189eb0","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-06-14 06:04:50.000000000","message":"Patch Set 1:\n\nrecheck bug 1823251","accounts_in_message":[],"_revision_number":1},{"id":"2d4e7c6dd16675aa5a730240ca10615d2690d9cf","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-06-14 09:19:19.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/665147/1 : SUCCESS in 2h 24m 49s","accounts_in_message":[],"_revision_number":1},{"id":"f82a8b4187f253e6ab960bfd050fcaeb6b0e01d8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-14 10:42:37.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/47/665147/1/check/openstack-tox-cover/9ed70b2/cover/ : SUCCESS in 17m 02s\n- openstack-tox-lower-constraints http://logs.openstack.org/47/665147/1/check/openstack-tox-lower-constraints/4c5cc35/ : SUCCESS in 11m 14s\n- openstack-tox-pep8 http://logs.openstack.org/47/665147/1/check/openstack-tox-pep8/a1bb672/ : SUCCESS in 9m 19s\n- openstack-tox-py27 http://logs.openstack.org/47/665147/1/check/openstack-tox-py27/b989748/ : FAILURE in 33m 45s\n- openstack-tox-py35 http://logs.openstack.org/47/665147/1/check/openstack-tox-py35/3364628/ : SUCCESS in 12m 36s\n- openstack-tox-py36 http://logs.openstack.org/47/665147/1/check/openstack-tox-py36/0fac086/ : SUCCESS in 12m 30s\n- openstack-tox-py37 http://logs.openstack.org/47/665147/1/check/openstack-tox-py37/22af63a/ : SUCCESS in 12m 52s\n- openstack-tox-docs http://logs.openstack.org/47/665147/1/check/openstack-tox-docs/1baba07/html/ : SUCCESS in 9m 11s\n- nova-tox-functional http://logs.openstack.org/47/665147/1/check/nova-tox-functional/c4f63ef/ : SUCCESS in 19m 02s\n- nova-tox-functional-py35 http://logs.openstack.org/47/665147/1/check/nova-tox-functional-py35/33f98af/ : SUCCESS in 23m 34s","accounts_in_message":[],"_revision_number":1},{"id":"e1472dfadfad0324bcf792a0747a7b4de346f74d","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-06-14 12:03:30.000000000","message":"Patch Set 1:\n\nrecheck bug 1823251","accounts_in_message":[],"_revision_number":1},{"id":"15753b862748555a3193efa65d65d512fcb0c8ed","author":{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},"date":"2019-06-14 14:13:31.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"8540662362bb852dcb01e64f28ee92a24d75c0c4","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-06-14 14:41:56.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/665147/1 : FAILURE in 2h 37m 45s","accounts_in_message":[],"_revision_number":1},{"id":"4dd1f62281bec5ca2696b9e6bd7e9210ac6febaa","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-14 20:54:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/47/665147/1/check/openstack-tox-cover/c241689/cover/ : SUCCESS in 23m 46s\n- openstack-tox-lower-constraints http://logs.openstack.org/47/665147/1/check/openstack-tox-lower-constraints/419edfe/ : SUCCESS in 11m 40s\n- openstack-tox-pep8 http://logs.openstack.org/47/665147/1/check/openstack-tox-pep8/30cfb1d/ : SUCCESS in 9m 36s\n- openstack-tox-py27 http://logs.openstack.org/47/665147/1/check/openstack-tox-py27/4f62c90/ : SUCCESS in 13m 56s\n- openstack-tox-py35 http://logs.openstack.org/47/665147/1/check/openstack-tox-py35/8426f65/ : SUCCESS in 14m 27s\n- openstack-tox-py36 http://logs.openstack.org/47/665147/1/check/openstack-tox-py36/8f77186/ : SUCCESS in 12m 00s\n- openstack-tox-py37 http://logs.openstack.org/47/665147/1/check/openstack-tox-py37/ddc578a/ : SUCCESS in 11m 44s\n- openstack-tox-docs http://logs.openstack.org/47/665147/1/check/openstack-tox-docs/63ee2ed/html/ : SUCCESS in 6m 04s\n- nova-tox-functional http://logs.openstack.org/47/665147/1/check/nova-tox-functional/b42fbd2/ : SUCCESS in 22m 20s\n- nova-tox-functional-py35 http://logs.openstack.org/47/665147/1/check/nova-tox-functional-py35/17b6793/ : SUCCESS in 18m 19s","accounts_in_message":[],"_revision_number":1},{"id":"0e1405b5322459d0f0be8d7a94400779889927c2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-14 20:55:28.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"19381c9d5424f4d1f88647bb3e2bbf07cd349b1c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-14 22:22:21.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/47/665147/1/gate/openstack-tox-lower-constraints/467f212/ : SUCCESS in 11m 13s\n- openstack-tox-pep8 http://logs.openstack.org/47/665147/1/gate/openstack-tox-pep8/539f33c/ : SUCCESS in 10m 34s\n- openstack-tox-py27 http://logs.openstack.org/47/665147/1/gate/openstack-tox-py27/3d46bbf/ : SUCCESS in 11m 46s\n- openstack-tox-py35 http://logs.openstack.org/47/665147/1/gate/openstack-tox-py35/9c89fd2/ : SUCCESS in 12m 55s\n- openstack-tox-py36 http://logs.openstack.org/47/665147/1/gate/openstack-tox-py36/6e037e9/ : SUCCESS in 12m 45s\n- openstack-tox-py37 http://logs.openstack.org/47/665147/1/gate/openstack-tox-py37/78012ff/ : SUCCESS in 11m 41s\n- openstack-tox-docs http://logs.openstack.org/47/665147/1/gate/openstack-tox-docs/b8cd202/html/ : SUCCESS in 6m 19s\n- nova-tox-functional http://logs.openstack.org/47/665147/1/gate/nova-tox-functional/8712e2a/ : SUCCESS in 20m 19s\n- nova-tox-functional-py35 http://logs.openstack.org/47/665147/1/gate/nova-tox-functional-py35/ad413c8/ : SUCCESS in 20m 06s","accounts_in_message":[],"_revision_number":1},{"id":"f88a6ee8e1328d14e0a1f37762eb6d8f8f9bd847","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-14 22:22:22.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0cb6106b83c33bded9e6cdec7737964c36be8de5","revisions":{"0cb6106b83c33bded9e6cdec7737964c36be8de5":{"kind":"REWORK","_number":1,"created":"2019-06-13 14:21:43.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/47/665147/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/47/665147/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/47/665147/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/47/665147/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/47/665147/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/47/665147/1"}}},"commit":{"parents":[{"commit":"105e6238dd536ac869276c38b5c76fefeb729b40","subject":"Merge \"Workaround missing RequestSpec.instance_group.uuid\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/105e6238dd536ac869276c38b5c76fefeb729b40"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-06-12 14:10:59.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-06-13 14:21:25.000000000","tz":60},"subject":"Fix double word hacking test","message":"Fix double word hacking test\n\nAt present, \u0027pycodestyle\u0027 feeds the following string into the \u0027tokenizer\u0027\nlibrary:\n\n    [\"\u0027This is the the best comment\u0027\"]\n\n(note the added quotes because this isn\u0027t valid Python otherwise)\n\nOn previous versions of Python, this tokenizer would parse the string like so:\n\n  (3, \"\u0027This is the the best comment\u0027\", (1, 0), (1, 30), \"\u0027This is the the best comment\u0027\")\n  (0, \u0027\u0027, (2, 0), (2, 0), \u0027\u0027)\n\nwhere (3 \u003d \u0027STRING\u0027, 0 \u003d \u0027ENDMARKER\u0027)\n\nHowever, with the fix [1] backported to recent versions of Python, this now\nresolves to:\n\n  (3, \"\u0027This is the the best comment\u0027\", (1, 0), (1, 30), \"\u0027This is the the best comment\u0027\")\n  (4, \u0027\u0027, (1, 30), (1, 31), \u0027\u0027)\n  (0, \u0027\u0027, (2, 0), (2, 0), \u0027\u0027)\n\nwhere (3 \u003d \u0027STRING\u0027, 4 \u003d \u0027NEWLINE\u0027, 0 \u003d \u0027ENDMARKER\u0027)\n\nTypically, \u0027pycodestyle\u0027 will run physical line checks on each line as it\nparses the token:\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2036\n\nFor the former case above, the line doesn\u0027t include a newline which\nmeans we never parse a \u0027NEWLINE\u0027 token with a logical line (the fifth\nelement of the token tuple) corresponding to our full line. This means\nwe don\u0027t here but that wasn\u0027t an issue previously since there\u0027s a\nfallthrough case that handled tokens remaining at the end of the parse:\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2114-L2116\n\nUnfortunately, because we now have an additional newline character to\nparse, one that\u0027s on a separate line to our test string no less, we run\nlogical checks on it:\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2105-L2107\n\nThis is an issue since the logical check wipes stored tokens meaning\nwe\u0027ve nothing to check when we get to the fallthrough case:\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2012\n\nThis fixes changes things so that a newline is included (and also adds\nquotes so it\u0027s valid Python, but that\u0027s mostly unrelated). This means we\nend up with the following instead:\n\n  [\"\u0027This is the the best comment\u0027\\n\"]\n\nOn both Python without the bugfix and with it, this parses as:\n\n  (3, \"\u0027This is the the best comment\u0027\", (1, 0), (1, 30), \"\u0027This is the the best comment\u0027\\n\")\n  (4, \u0027\\n\u0027, (1, 30), (1, 31), \"\u0027This is the the best comment\u0027\\n\")\n  (0, \u0027\u0027, (2, 0), (2, 0), \u0027\u0027)\n\nwhere (3 \u003d \u0027STRING\u0027, 4 \u003d \u0027NEWLINE\u0027, 0 \u003d \u0027ENDMARKER\u0027)\n\nWhich triggers things in \u0027pycodestyle\u0027 correctly.\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2044-L2046\n\nThis isn\u0027t _really_ a fix since there\u0027s clearly still a bug in either\n\u0027pycodestyle\u0027 or Python (I think the latter, since it\u0027s adding a newline\nto a file that explicitly doesn\u0027t have one), but the chances of us\nhitting this bug in practice are rather low - you\u0027d need to make a\nmistake on the very last line of a file without a newline at the end\nwhich is something Vim, for example, won\u0027t even let you do without\nsetting special flags - and therefore it can be reasonably ignored.\n\nConflicts:\n\tnova/tests/unit/test_hacking.py\n\nNOTE(stephenfin): Conflicts are because we don\u0027t have change\nI35c654bd39f343417e0a1124263ff31dcd0b05c9 (\"Bump to hacking 1.1.0\") or\nchange I8826c3fb89690805baae6b9b7b48985abb8d62d3 (\"Skip\ntest_check_doubled_words hacking check UT\") on this branch.\n\n[1] https://bugs.python.org/issue33899\n\nChange-Id: Ia597594e0469c0e83d7ad22b0678390aaebaffe7\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\nCloses-Bug: #1804062\n(cherry picked from f545a25cc443c41dcd9bdd028064c28b53f56037)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0cb6106b83c33bded9e6cdec7737964c36be8de5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0cb6106b83c33bded9e6cdec7737964c36be8de5"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}