)]}'
{"nova/tests/db/test_db_api.py":[{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"8bd7b23f4b2ee79836b140ee2fdf26ca0fe8d6b1","unresolved":false,"context_lines":[{"line_number":7114,"context_line":"                          v2[\u0027address\u0027])"},{"line_number":7115,"context_line":""},{"line_number":7116,"context_line":""},{"line_number":7117,"context_line":"class RetryOnDeadlockTestCase(test.TestCase):"},{"line_number":7118,"context_line":"    def test_without_deadlock(self):"},{"line_number":7119,"context_line":"        @sqlalchemy_api._retry_on_deadlock"},{"line_number":7120,"context_line":"        def call_api(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FYs4%3D","line":7117,"updated":"2014-01-14 10:57:41.000000000","message":"tiny nitpick: Deadlock is a single word so ...DeadLock... is incorrectly camelcased.","commit_id":"28fe24ccd6ddac20915c57fb2bfb3983c1456956"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"9e693e1dc1cf1a816919d0cc033505e5e6f04c54","unresolved":false,"context_lines":[{"line_number":7114,"context_line":"                          v2[\u0027address\u0027])"},{"line_number":7115,"context_line":""},{"line_number":7116,"context_line":""},{"line_number":7117,"context_line":"class RetryOnDeadlockTestCase(test.TestCase):"},{"line_number":7118,"context_line":"    def test_without_deadlock(self):"},{"line_number":7119,"context_line":"        @sqlalchemy_api._retry_on_deadlock"},{"line_number":7120,"context_line":"        def call_api(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FYo8%3D","line":7117,"in_reply_to":"AAAAUH%2F%2FYqc%3D","updated":"2014-01-14 11:11:31.000000000","message":":)  Sorry I just copied my comment from the other patch without noticing.","commit_id":"28fe24ccd6ddac20915c57fb2bfb3983c1456956"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"58d34fa5d578b5c5a7b4178b3552c5309f0e7ff5","unresolved":false,"context_lines":[{"line_number":7114,"context_line":"                          v2[\u0027address\u0027])"},{"line_number":7115,"context_line":""},{"line_number":7116,"context_line":""},{"line_number":7117,"context_line":"class RetryOnDeadlockTestCase(test.TestCase):"},{"line_number":7118,"context_line":"    def test_without_deadlock(self):"},{"line_number":7119,"context_line":"        @sqlalchemy_api._retry_on_deadlock"},{"line_number":7120,"context_line":"        def call_api(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FYqc%3D","line":7117,"in_reply_to":"AAAAUH%2F%2FYs4%3D","updated":"2014-01-14 11:03:13.000000000","message":"I have updated the name before you comment ;)","commit_id":"28fe24ccd6ddac20915c57fb2bfb3983c1456956"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a93ccc649b3e58b354a605fc7846812171d49c9a","unresolved":false,"context_lines":[{"line_number":7115,"context_line":""},{"line_number":7116,"context_line":""},{"line_number":7117,"context_line":"class RetryOnDeadlockTestCase(test.TestCase):"},{"line_number":7118,"context_line":"    def test_without_deadlock(self):"},{"line_number":7119,"context_line":"        @sqlalchemy_api._retry_on_deadlock"},{"line_number":7120,"context_line":"        def call_api(*args, **kwargs):"},{"line_number":7121,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Bim4%3D","line":7118,"updated":"2014-01-24 15:54:00.000000000","message":"Doesn\u0027t the second test basically do this check but also that it\u0027s handling the deadlock in the loop, so you really only need the one test here?","commit_id":"1751bd764178fea9031b4ea05b0a453a46135ec2"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d9e4c629a704051e4c55162c40affc0e0a1b0d9b","unresolved":false,"context_lines":[{"line_number":7115,"context_line":""},{"line_number":7116,"context_line":""},{"line_number":7117,"context_line":"class RetryOnDeadlockTestCase(test.TestCase):"},{"line_number":7118,"context_line":"    def test_without_deadlock(self):"},{"line_number":7119,"context_line":"        @sqlalchemy_api._retry_on_deadlock"},{"line_number":7120,"context_line":"        def call_api(*args, **kwargs):"},{"line_number":7121,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Bijw%3D","line":7118,"in_reply_to":"AAAAUH%2F%2Bim4%3D","updated":"2014-01-24 16:03:35.000000000","message":"Actually I think is always good to have a simple test to prove the comportment works as we expect. Like that when we add new feature to this method (ex: https://review.openstack.org/#/c/66188/) we are sure it works always well.\n\nDoes it make sense?","commit_id":"1751bd764178fea9031b4ea05b0a453a46135ec2"}]}