)]}'
{"nova/api/openstack/compute/contrib/os_tenant_networks.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a43fa7b6feafba3a015cfc6da4557b26506643d1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                    default\u003dFalse,"},{"line_number":39,"context_line":"                    help\u003d(\u0027Enables or disables quota checking for tenant \u0027"},{"line_number":40,"context_line":"                          \u0027networks\u0027)),"},{"line_number":41,"context_line":"        cfg.BoolOpt(\u0027use_neutron_default_nets\u0027,"},{"line_number":42,"context_line":"                         default\u003dFalse,"},{"line_number":43,"context_line":"                         help\u003d(\u0027Control for checking for default networks\u0027)),"},{"line_number":44,"context_line":"        cfg.StrOpt(\u0027neutron_default_tenant_id\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F948Y%3D","line":41,"updated":"2014-02-02 08:27:04.000000000","message":"I am not exactly sure how this should behave in an upgrade process. I am not sure if there is deprecated support for changing the type of a variable. If not, maybe that is something worth adding (not sure if it is possible)","commit_id":"0cc5e8dc1149937f1d2376113cc69258bb8f075b"},{"author":{"_account_id":6509,"name":"Roman Bogorodskiy","email":"rbogorodskiy@mirantis.com","username":"novel"},"change_message_id":"15ca07602b5ce8ed9d492f304bb85f5927c08c6a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                    default\u003dFalse,"},{"line_number":39,"context_line":"                    help\u003d(\u0027Enables or disables quota checking for tenant \u0027"},{"line_number":40,"context_line":"                          \u0027networks\u0027)),"},{"line_number":41,"context_line":"        cfg.BoolOpt(\u0027use_neutron_default_nets\u0027,"},{"line_number":42,"context_line":"                         default\u003dFalse,"},{"line_number":43,"context_line":"                         help\u003d(\u0027Control for checking for default networks\u0027)),"},{"line_number":44,"context_line":"        cfg.StrOpt(\u0027neutron_default_tenant_id\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F9ikQ%3D","line":41,"in_reply_to":"AAAAUH%2F93%2B8%3D","updated":"2014-02-06 07:04:55.000000000","message":"The sad thing is that affects only people with incorrect configurations. People who want to enable this option and using the only right value \u0027True\u0027 will not be affected.\n\nHowever, people who intend to enable this option, but do in a wrong way (e.g. 1, or \u0027true\u0027), will end up this option disabled and system configured incorrectly.\n\nI don\u0027t know what is worse -- having a system working in a different way than it was intended or having it unexpectedly working as expected (sorry for a pun).","commit_id":"0cc5e8dc1149937f1d2376113cc69258bb8f075b"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"1940fd83072c037841d04cd7d0c8763aff2e8a7d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                    default\u003dFalse,"},{"line_number":39,"context_line":"                    help\u003d(\u0027Enables or disables quota checking for tenant \u0027"},{"line_number":40,"context_line":"                          \u0027networks\u0027)),"},{"line_number":41,"context_line":"        cfg.BoolOpt(\u0027use_neutron_default_nets\u0027,"},{"line_number":42,"context_line":"                         default\u003dFalse,"},{"line_number":43,"context_line":"                         help\u003d(\u0027Control for checking for default networks\u0027)),"},{"line_number":44,"context_line":"        cfg.StrOpt(\u0027neutron_default_tenant_id\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F94Bg%3D","line":41,"in_reply_to":"AAAAUH%2F948Y%3D","updated":"2014-02-02 20:19:13.000000000","message":"I agree with Gary in that I worry about existing configurations that set this value breaking. I don\u0027t see any deprecation option for the type of a flag, so I like the idea of changing the name of the flag and having a deprecated flag which is removed in a release or two.","commit_id":"0cc5e8dc1149937f1d2376113cc69258bb8f075b"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"21c4a223b65a133d97cad47ae12114098ea3aad1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                    default\u003dFalse,"},{"line_number":39,"context_line":"                    help\u003d(\u0027Enables or disables quota checking for tenant \u0027"},{"line_number":40,"context_line":"                          \u0027networks\u0027)),"},{"line_number":41,"context_line":"        cfg.BoolOpt(\u0027use_neutron_default_nets\u0027,"},{"line_number":42,"context_line":"                         default\u003dFalse,"},{"line_number":43,"context_line":"                         help\u003d(\u0027Control for checking for default networks\u0027)),"},{"line_number":44,"context_line":"        cfg.StrOpt(\u0027neutron_default_tenant_id\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F93%2B8%3D","line":41,"in_reply_to":"AAAAUH%2F94Bg%3D","updated":"2014-02-02 20:37:32.000000000","message":"An alternative - write a little bit of code to check whether the value given is a valid bool; if it\u0027s not manually emit a deprecation warning,.. then a cycle later we can change the type.","commit_id":"0cc5e8dc1149937f1d2376113cc69258bb8f075b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"bdd5371dcd80e5dd92b50727f0921b3335f0e2d4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                    default\u003dFalse,"},{"line_number":39,"context_line":"                    help\u003d(\u0027Enables or disables quota checking for tenant \u0027"},{"line_number":40,"context_line":"                          \u0027networks\u0027)),"},{"line_number":41,"context_line":"        cfg.BoolOpt(\u0027use_neutron_default_nets\u0027,"},{"line_number":42,"context_line":"                         default\u003dFalse,"},{"line_number":43,"context_line":"                         help\u003d(\u0027Control for checking for default networks\u0027)),"},{"line_number":44,"context_line":"        cfg.StrOpt(\u0027neutron_default_tenant_id\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F9VeM%3D","line":41,"in_reply_to":"AAAAUH%2F9ikQ%3D","updated":"2014-02-07 16:40:49.000000000","message":"I understand that it is a problem. Maybe you can use the following:\nstrutils.bool_from_string(value)\nwhere the value is from the \u0027use_neutron_default_nets\u0027","commit_id":"0cc5e8dc1149937f1d2376113cc69258bb8f075b"}]}