)]}'
{".pre-commit-config.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8cb4c70b71dbc7a272187d1d671b26a814fd40fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9fb8cfa7_ef239e54","line":17,"updated":"2019-06-15 16:31:55.000000000","message":"these would also be nice to add but i can add a follow up commit for that\nhttps://github.com/SeanMooney/gerio/blob/master/.pre-commit-config.yaml#L14-L20","commit_id":"7b1283ef988256736cb38800cbea53d29750ea8f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7e4dd3fc93de6ef2dce31c29286b6160662bf856","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"repos:"},{"line_number":3,"context_line":"  - repo: https://github.com/pre-commit/pre-commit-hooks"},{"line_number":4,"context_line":"    rev: v2.2.3"},{"line_number":5,"context_line":"    hooks:"},{"line_number":6,"context_line":"      - id: trailing-whitespace"},{"line_number":7,"context_line":"      - id: mixed-line-ending"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_59a9418e","line":4,"updated":"2019-06-17 18:16:13.000000000","message":"So I guess this is pulled from source and not meant to be confused with https://pypi.org/project/pre-commit/ and thus won\u0027t go through our upper-constraints system in case there are backward incompatible releases.","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5caf388fd5c1d7eb1de5720f8ece46658cc0650d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"repos:"},{"line_number":3,"context_line":"  - repo: https://github.com/pre-commit/pre-commit-hooks"},{"line_number":4,"context_line":"    rev: v2.2.3"},{"line_number":5,"context_line":"    hooks:"},{"line_number":6,"context_line":"      - id: trailing-whitespace"},{"line_number":7,"context_line":"      - id: mixed-line-ending"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_fc3023eb","line":4,"in_reply_to":"9fb8cfa7_59a9418e","updated":"2019-06-17 18:51:39.000000000","message":"https://pypi.org/project/pre-commit/ is the python cli\nstored in https://github.com/pre-commit/pre-commit\n\nhttps://github.com/pre-commit/pre-commit-hooks is the 1st party set of standard libary hooks that they support.\n\nhttps://pre-commit.com/hooks.html","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32261edca2e506f2358e5446f9f0cd0118515b0c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"repos:"},{"line_number":3,"context_line":"  - repo: https://github.com/pre-commit/pre-commit-hooks"},{"line_number":4,"context_line":"    rev: v2.2.3"},{"line_number":5,"context_line":"    hooks:"},{"line_number":6,"context_line":"      - id: trailing-whitespace"},{"line_number":7,"context_line":"      - id: mixed-line-ending"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_8c876c10","line":4,"in_reply_to":"9fb8cfa7_fc3023eb","updated":"2019-06-18 13:08:43.000000000","message":"What Sean says. This is essentially a linter too and shouldn\u0027t be tracked via upper-constraints [1]\n\n[1] https://opendev.org/openstack/requirements/src/branch/master/blacklist.txt","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"aaad1362722389db465194378d9ece2744e19269","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      - id: mixed-line-ending"},{"line_number":8,"context_line":"      - id: check-byte-order-marker"},{"line_number":9,"context_line":"      - id: check-executables-have-shebangs"},{"line_number":10,"context_line":"      - id: check-merge-conflict"},{"line_number":11,"context_line":"      - id: debug-statements"},{"line_number":12,"context_line":"      - id: flake8"},{"line_number":13,"context_line":"        additional_dependencies:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_497098dd","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":32},"updated":"2019-06-17 14:43:58.000000000","message":"Is this only block files with merge conflict markers in them? I hope it does not try to figure out if my patch is in merge conflict with the HEAD of the target branch as sometimes I need to push update to reviews that are in merge conflict   solving the merge in a later patch set.\n\n// later OK it is just the former. which is good.\nhttps://github.com/pre-commit/pre-commit-hooks/blob/master/pre_commit_hooks/check_merge_conflict.py","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32261edca2e506f2358e5446f9f0cd0118515b0c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      - id: mixed-line-ending"},{"line_number":8,"context_line":"      - id: check-byte-order-marker"},{"line_number":9,"context_line":"      - id: check-executables-have-shebangs"},{"line_number":10,"context_line":"      - id: check-merge-conflict"},{"line_number":11,"context_line":"      - id: debug-statements"},{"line_number":12,"context_line":"      - id: flake8"},{"line_number":13,"context_line":"        additional_dependencies:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_2c7c401f","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":32},"in_reply_to":"9fb8cfa7_497098dd","updated":"2019-06-18 13:08:43.000000000","message":"Yeah, it\u0027s just looking for markers","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"aaad1362722389db465194378d9ece2744e19269","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      - id: check-executables-have-shebangs"},{"line_number":10,"context_line":"      - id: check-merge-conflict"},{"line_number":11,"context_line":"      - id: debug-statements"},{"line_number":12,"context_line":"      - id: flake8"},{"line_number":13,"context_line":"        additional_dependencies:"},{"line_number":14,"context_line":"          - hacking\u003e\u003d1.1.0,\u003c1.2.0"},{"line_number":15,"context_line":"      - id: check-yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_c902480c","line":12,"range":{"start_line":12,"start_character":12,"end_line":12,"end_character":18},"updated":"2019-06-17 14:43:58.000000000","message":"Would it run flake8 with a different config than tox -e pep8 does as tox.ini has some changes?","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32261edca2e506f2358e5446f9f0cd0118515b0c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      - id: check-executables-have-shebangs"},{"line_number":10,"context_line":"      - id: check-merge-conflict"},{"line_number":11,"context_line":"      - id: debug-statements"},{"line_number":12,"context_line":"      - id: flake8"},{"line_number":13,"context_line":"        additional_dependencies:"},{"line_number":14,"context_line":"          - hacking\u003e\u003d1.1.0,\u003c1.2.0"},{"line_number":15,"context_line":"      - id: check-yaml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_ac8d902b","line":12,"range":{"start_line":12,"start_character":12,"end_line":12,"end_character":18},"in_reply_to":"9fb8cfa7_c902480c","updated":"2019-06-18 13:08:43.000000000","message":"No, flake8 will read the settings from \u0027tox.ini\u0027 [1] so we\u0027ll see the same behavior here\n\n[1] https://flake8.pycqa.org/en/latest/user/configuration.html#configuration-locations","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5caf388fd5c1d7eb1de5720f8ece46658cc0650d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fb8cfa7_bc870b62","line":17,"updated":"2019-06-17 18:51:39.000000000","message":"i personally would like to also have these to\nprevent commiting with tabs or windows line endings.\n\n-   repo: git://github.com/Lucas-C/pre-commit-hooks\n    sha: v1.1.6\n    hooks:\n    -   id: forbid-crlf\n    -   id: remove-crlf\n    -   id: forbid-tabs\n    -   id: remove-tabs","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ca159431e82977c4eac9287385a699893111e34a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7faddb67_6e3dc3db","line":17,"in_reply_to":"7faddb67_820fc735","updated":"2019-07-15 13:58:12.000000000","message":"It does mean that we don\u0027t get the advantage of shared knowledge between developers though. You\u0027d need to manually check the template/sample file to see if anything new has been added. I think it better to just compromise and to this end, I\u0027m just going to add the checks that Sean suggests because something, even if it\u0027s not quite what I\u0027d like, is miles better than nothing.","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c0f85e35acc50936a50a65c38320744d9a256e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fb8cfa7_21bbcfe5","line":17,"in_reply_to":"9fb8cfa7_00c01350","updated":"2019-06-19 14:54:48.000000000","message":"\u003e Doesn\u0027t this framework allow for a user-level config file where\n \u003e Sean or whoever can add their pet rules? Either something outside\n \u003e of the git repos, or an additional file that we can .gitignore?\n \u003e \n \u003e [Later] Boo, it doesn\u0027t look like it.\n \u003e \n \u003e So maybe we should consider adding .pre-commit-config.yaml to\n \u003e .gitignore and renaming this to .pre-commit-config.yaml.sample or\n \u003e something. Yes, it adds an extra step to the default setup (copy\n \u003e the file in your local clone) but then it\u0027s customizable.\n\nI\u0027d be concerned that this would be another barrier to entry for using this. I want it to be something that happens automatically without you even need to think about it to maximize the amount of people that will use it. Also YAGNI/KISS.\n\nIf the lack of tab autocorrect is a serious blocker, I\u0027d be okay dragging it in to get this in use.","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3b5bab6e6759d4278e4fea1db7f5fdacc20c625d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7faddb67_820fc735","line":17,"in_reply_to":"9fb8cfa7_21d2ef35","updated":"2019-07-12 16:46:04.000000000","message":"I feel like this discussion motivates making this customizable by individual developers.\n\nIf I already have to run two commands to enable this, running three (cp .pre-commit-config.yaml.sample .pre-commit-config.yaml) is not a significant extra burden. It\u0027s not like I have to do it every time I want to use it or whatever.","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9697c0fbbebf434b80ae3fd3968a30fe0e89a77e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fb8cfa7_6c93135e","line":17,"in_reply_to":"9fb8cfa7_66a1f495","updated":"2019-06-18 15:05:35.000000000","message":"What I\u0027m objecting to is automatically fixing it. It\u0027s more likely that authors will be editing existing files, rather than creating entirely new ones. As such, consider if the author had done something like this:\n\n    def test(x):\n        if x:\n    \\tprint(x)\n\nThat might look okay in their editor, because tabs were 8 spaces. However, the plugin assumes tabs \u003d a fixed number of spaces so fixing things would result in incorrect syntax:\n\n    def test(x):\n        if x:\n        print(x)\n\nI\u0027d rather not attempt to guess this and simply rely on flake8 catching these issues for us.","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c485265292360f68c37bc5d8f7c668b3062236a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fb8cfa7_d20c163d","line":17,"in_reply_to":"9fb8cfa7_6c93135e","updated":"2019-06-18 16:27:10.000000000","message":":( ok sthe auto fixing is what i was must looking forward too\ni guess ill go look at modifying pre-commit to see if i can have it check for additional user config or something.\n\nor maybe i can locally install that without needing it in the config.\n\nbut for the recored we should not have any python code with a \nraw \\t in the codebase and we should be use 4 space indentation in all the code.","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f98ec89bcafdda3875855e542db3b72d2d086485","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fb8cfa7_66a1f495","line":17,"in_reply_to":"9fb8cfa7_8cea0caa","updated":"2019-06-18 13:43:08.000000000","message":"we do not allow people to commit with tabs\nand we always use 4 spaces in nova.\n\nwhy would we not fix that.\nhow this works is it auto fixes it and fails the commit so that you have to manually git add them before you can proceed. so you will have the opportunity to review the fix.\n\nim glad the rest are covered however.","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32261edca2e506f2358e5446f9f0cd0118515b0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fb8cfa7_8cea0caa","line":17,"in_reply_to":"9fb8cfa7_bc870b62","updated":"2019-06-18 13:08:43.000000000","message":"\u003e -   id: forbid-crlf\n\nThis is handled by the \u0027mixed-line-ending\u0027 plugin.\n\n \u003e -   id: remove-crlf\n\nI\u0027ve passed the [\u0027--fix\u0027, \u0027lf\u0027] arguments to the \u0027mixed-line-ending\u0027 plugi so that should take care of this.\n\n \u003e -   id: forbid-tabs\n\nflake8 does this for us (W191 indentation contains tabs).\n\n \u003e -   id: remove-tabs\n\nI don\u0027t really want to do this since there\u0027s a chance there\u0027s mixed tabs and spaces and we don\u0027t know if the user was seeing a tab as 4 or 8 spaces.","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c0f85e35acc50936a50a65c38320744d9a256e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fb8cfa7_21d2ef35","line":17,"in_reply_to":"9fb8cfa7_d20c163d","updated":"2019-06-19 14:54:48.000000000","message":"\u003e but for the recored we should not have any python code with a\n \u003e raw \\t in the codebase and we should be use 4 space indentation in\n \u003e all the code.\n\nAgreed, but I think highlighting things rather than automatically fixing them is the correct thing to do in this instance. The author\u0027s editor is clearly misconfigured so...go fix it? :)","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c9c7cbccd5dbba6c2e02148310121774184f30d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fb8cfa7_00c01350","line":17,"in_reply_to":"9fb8cfa7_d20c163d","updated":"2019-06-18 23:14:32.000000000","message":"Doesn\u0027t this framework allow for a user-level config file where Sean or whoever can add their pet rules? Either something outside of the git repos, or an additional file that we can .gitignore?\n\n[Later] Boo, it doesn\u0027t look like it.\n\nSo maybe we should consider adding .pre-commit-config.yaml to .gitignore and renaming this to .pre-commit-config.yaml.sample or something. Yes, it adds an extra step to the default setup (copy the file in your local clone) but then it\u0027s customizable.","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"54eabbc9e23cef3033816dded46eaccaa107604b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"          - hacking\u003e\u003d1.1.0,\u003c1.2.0"},{"line_number":16,"context_line":"      - id: check-yaml"},{"line_number":17,"context_line":"        files: .*\\.(yaml|yml)$"},{"line_number":18,"context_line":"  - repo: https://github.com/Lucas-C/pre-commit-hooks"},{"line_number":19,"context_line":"    rev: v1.1.6"},{"line_number":20,"context_line":"    hooks:"},{"line_number":21,"context_line":"      - id: remove-tabs"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_1071c576","line":18,"updated":"2019-08-01 12:09:58.000000000","message":"I\u0027m concerned with the use of random github repos in jobs that otherwise should be simple and rocksolid. This introduces the cloning of a repo over the internet in every linter gate job - which increases the likelyhood of spurious failures.\n\nGiven the cost of gate resets, I think we should be very careful about such things.\n\nFor the primary set of hooks, which pre-commit\u0027s design seems built around cloning - if openstack projects are looking at starting to use this tool for real, we could add github.com/pre-commit/pre-commit-hooks to zuul so that the cloners can clone it and then add it to required-projects of the linters jobs. We\u0027d also need to add a pre playbook, I\u0027m guessing, that would edit this file if it found it in a repo to replace https://github.com/pre-commit/pre-commit-hooks with /home/zuul/src/github.com/pre-commit/pre-commit-hooks ... but since that\u0027s a thing that is likely to be in every project using pre-commit, it\u0027s maybe a worthwhile investment.\n\nHowever, I\u0027d argue that a similar investment for a repo that contains a hook for removing tabs, which is a trivial editor setting for every code editor out there, is not.","commit_id":"f1c44b9160e879f84fdbb3e87a23f9b943dec770"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"bb7f1b328a5ea9fb2afeb8f0990e66aa6d195581","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"repos:"},{"line_number":3,"context_line":"  - repo: https://github.com/pre-commit/pre-commit-hooks"},{"line_number":4,"context_line":"    rev: v2.2.3"},{"line_number":5,"context_line":"    hooks:"},{"line_number":6,"context_line":"      - id: trailing-whitespace"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_cdd93d83","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":56},"updated":"2019-08-02 15:32:24.000000000","message":"Add .git at the end or it may fail with older git versions. We already encountered this in few places.","commit_id":"ab92aa105141a37bf161b9df9d84991e3e62a676"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4fa7dba4b5a28194b30f3f2188e7f6214a798836","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"repos:"},{"line_number":3,"context_line":"  - repo: https://github.com/pre-commit/pre-commit-hooks"},{"line_number":4,"context_line":"    rev: v2.2.3"},{"line_number":5,"context_line":"    hooks:"},{"line_number":6,"context_line":"      - id: trailing-whitespace"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_b8d3ba5f","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":56},"in_reply_to":"7faddb67_cdd93d83","updated":"2019-08-06 11:17:06.000000000","message":"that used to be true yes but even centos ships a git new enoguht to not have issues with this. i think this can be updated in a follow up commit but i dont think we support and distor that ship a git that is old enough to have this problem with train.","commit_id":"ab92aa105141a37bf161b9df9d84991e3e62a676"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"bb7f1b328a5ea9fb2afeb8f0990e66aa6d195581","unresolved":false,"context_lines":[{"line_number":15,"context_line":"          - hacking\u003e\u003d1.1.0,\u003c1.2.0"},{"line_number":16,"context_line":"      - id: check-yaml"},{"line_number":17,"context_line":"        files: .*\\.(yaml|yml)$"},{"line_number":18,"context_line":"  - repo: https://github.com/Lucas-C/pre-commit-hooks"},{"line_number":19,"context_line":"    rev: v1.1.6"},{"line_number":20,"context_line":"    hooks:"},{"line_number":21,"context_line":"      - id: remove-tabs"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_0df435f0","line":18,"range":{"start_line":18,"start_character":10,"end_line":18,"end_character":53},"updated":"2019-08-02 15:32:24.000000000","message":"This is personal repository on github. Adding a dependency on it is a too big risk for a questionable benefit.\n\nI would prefer to see this out and a PR to add remove-tabs to core pre-commit-hooks -- CC me, I will help with review and get it released faster.","commit_id":"ab92aa105141a37bf161b9df9d84991e3e62a676"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4fa7dba4b5a28194b30f3f2188e7f6214a798836","unresolved":false,"context_lines":[{"line_number":15,"context_line":"          - hacking\u003e\u003d1.1.0,\u003c1.2.0"},{"line_number":16,"context_line":"      - id: check-yaml"},{"line_number":17,"context_line":"        files: .*\\.(yaml|yml)$"},{"line_number":18,"context_line":"  - repo: https://github.com/Lucas-C/pre-commit-hooks"},{"line_number":19,"context_line":"    rev: v1.1.6"},{"line_number":20,"context_line":"    hooks:"},{"line_number":21,"context_line":"      - id: remove-tabs"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_f8bcd206","line":18,"range":{"start_line":18,"start_character":10,"end_line":18,"end_character":53},"in_reply_to":"7faddb67_0df435f0","updated":"2019-08-06 11:17:06.000000000","message":"i dont think its a big risk as 1 this is an optional dependency since pre-commit will be totally optional for people to use. as not in the follow up your PR to move it to pre-commit-hooks has been rejected and this is the usage model recommended by the core team.","commit_id":"ab92aa105141a37bf161b9df9d84991e3e62a676"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"71bd46c4d6bd0bb624678a89b6ba654b6fbf7c21","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      - id: debug-statements"},{"line_number":13,"context_line":"      - id: flake8"},{"line_number":14,"context_line":"        additional_dependencies:"},{"line_number":15,"context_line":"          - hacking\u003e\u003d1.1.0,\u003c1.2.0"},{"line_number":16,"context_line":"      - id: check-yaml"},{"line_number":17,"context_line":"        files: .*\\.(yaml|yml)$"},{"line_number":18,"context_line":"  - repo: https://github.com/Lucas-C/pre-commit-hooks"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_f40768c8","line":15,"updated":"2019-12-05 10:17:55.000000000","message":"good good.\nI was a bit afraid of having a linter more pythonesque.","commit_id":"5f8dd65f6cfcb7f33e72b9371f325801835c9c83"}],"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7e4dd3fc93de6ef2dce31c29286b6160662bf856","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This nifty tool provides a extensible way to configure pre-commit hooks"},{"line_number":10,"context_line":"to do everything from running linters to spellchecking [1] and has"},{"line_number":11,"context_line":"already been adopted by a few OpenStack projects [2]. Let\u0027s start using"},{"line_number":12,"context_line":"it as a faster, more automatic alternative to the \u0027fast8\u0027 tox target and"},{"line_number":13,"context_line":"iterate on it as we find more things to use it for. The \u0027fast8\u0027 target"},{"line_number":14,"context_line":"is deprecated."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_79b9a5e7","line":11,"range":{"start_line":11,"start_character":26,"end_line":11,"end_character":29},"updated":"2019-06-17 18:16:13.000000000","message":"A few hundred TripleO projects, OK.","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7e4dd3fc93de6ef2dce31c29286b6160662bf856","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to do everything from running linters to spellchecking [1] and has"},{"line_number":11,"context_line":"already been adopted by a few OpenStack projects [2]. Let\u0027s start using"},{"line_number":12,"context_line":"it as a faster, more automatic alternative to the \u0027fast8\u0027 tox target and"},{"line_number":13,"context_line":"iterate on it as we find more things to use it for. The \u0027fast8\u0027 target"},{"line_number":14,"context_line":"is deprecated."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Note that the \u0027check-executables-have-shebangs\u0027 actually failed and"},{"line_number":17,"context_line":"highlighted that the \u0027contributor/development-environment.rst\u0027 document"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_19cae94e","line":14,"range":{"start_line":13,"start_character":52,"end_line":14,"end_character":14},"updated":"2019-06-17 18:16:13.000000000","message":"Do we really need to deprecate this? Since you have to set some stuff up on your system to make the pre-commit stuff work, I probably won\u0027t use it unless forced and will still use fast8 before pushing changes up for review.","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2f94ec41dbbe6d228484d83c06e4cd38bfed7880","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to do everything from running linters to spellchecking [1] and has"},{"line_number":11,"context_line":"already been adopted by a few OpenStack projects [2]. Let\u0027s start using"},{"line_number":12,"context_line":"it as a faster, more automatic alternative to the \u0027fast8\u0027 tox target and"},{"line_number":13,"context_line":"iterate on it as we find more things to use it for. The \u0027fast8\u0027 target"},{"line_number":14,"context_line":"is deprecated."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Note that the \u0027check-executables-have-shebangs\u0027 actually failed and"},{"line_number":17,"context_line":"highlighted that the \u0027contributor/development-environment.rst\u0027 document"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_3ce23b03","line":14,"range":{"start_line":13,"start_character":52,"end_line":14,"end_character":14},"in_reply_to":"9fb8cfa7_1902e93f","updated":"2019-06-17 19:02:35.000000000","message":"we also can run the pre-commit hooks via tox\n\nhttps://github.com/pre-commit/pre-commit-hooks/blob/master/tox.ini#L17-L20\n\nfor those that dont want to install it system wide.","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5caf388fd5c1d7eb1de5720f8ece46658cc0650d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to do everything from running linters to spellchecking [1] and has"},{"line_number":11,"context_line":"already been adopted by a few OpenStack projects [2]. Let\u0027s start using"},{"line_number":12,"context_line":"it as a faster, more automatic alternative to the \u0027fast8\u0027 tox target and"},{"line_number":13,"context_line":"iterate on it as we find more things to use it for. The \u0027fast8\u0027 target"},{"line_number":14,"context_line":"is deprecated."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Note that the \u0027check-executables-have-shebangs\u0027 actually failed and"},{"line_number":17,"context_line":"highlighted that the \u0027contributor/development-environment.rst\u0027 document"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_1902e93f","line":14,"range":{"start_line":13,"start_character":52,"end_line":14,"end_character":14},"in_reply_to":"9fb8cfa7_19cae94e","updated":"2019-06-17 18:51:39.000000000","message":"we dont have too. \nwe dont need to update it often so it does not really hurt to keep it.","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"32261edca2e506f2358e5446f9f0cd0118515b0c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to do everything from running linters to spellchecking [1] and has"},{"line_number":11,"context_line":"already been adopted by a few OpenStack projects [2]. Let\u0027s start using"},{"line_number":12,"context_line":"it as a faster, more automatic alternative to the \u0027fast8\u0027 tox target and"},{"line_number":13,"context_line":"iterate on it as we find more things to use it for. The \u0027fast8\u0027 target"},{"line_number":14,"context_line":"is deprecated."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Note that the \u0027check-executables-have-shebangs\u0027 actually failed and"},{"line_number":17,"context_line":"highlighted that the \u0027contributor/development-environment.rst\u0027 document"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_cca484bc","line":14,"range":{"start_line":13,"start_character":52,"end_line":14,"end_character":14},"in_reply_to":"9fb8cfa7_3ce23b03","updated":"2019-06-18 13:08:43.000000000","message":"I mostly deprecated it so I could prompt people to use it and highlight the fact that it exists. It\u0027s faster and automatic, so other than installing things once, I\u0027m not sure why you wouldn\u0027t use it. I can kick that can down the road though and replace the deprecation warning with a simple \"have you considered pre-commit\" message instead","commit_id":"bf4c2de747981d8ce3570ec5cff4e7421fe9940a"}],"tools/flake8wrap.sh":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"71bd46c4d6bd0bb624678a89b6ba654b6fbf7c21","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    files\u003d$(git diff --name-only HEAD~1 | tr \u0027\\n\u0027 \u0027 \u0027)"},{"line_number":15,"context_line":"    echo \"Running flake8 on ${files}\""},{"line_number":16,"context_line":"    echo \"\""},{"line_number":17,"context_line":"    echo \"Consider using the \u0027pre-commit\u0027 tool instead.\""},{"line_number":18,"context_line":"    echo \"\""},{"line_number":19,"context_line":"    echo \"    pip install --user pre-commit\""},{"line_number":20,"context_line":"    echo \"    pre-commit install --allow-missing-config\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"3fa7e38b_d42b4c30","line":17,"updated":"2019-12-05 10:17:55.000000000","message":"good, we\u0027re not *deprecating it*","commit_id":"5f8dd65f6cfcb7f33e72b9371f325801835c9c83"}]}