)]}'
{"doc/source/user/filter-scheduler.rst":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8e8c7f136aa6bc72f88abaf4b51726ea5a519af0","unresolved":false,"context_lines":[{"line_number":195,"context_line":"* |NUMATopologyFilter| - filters hosts based on the NUMA topology requested by the"},{"line_number":196,"context_line":"  instance, if any."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Now we can focus on these standard filter classes in some detail. We\u0027ll skip the"},{"line_number":199,"context_line":"simplest ones, such as |AllHostsFilter| and |NumInstancesFilter|"},{"line_number":200,"context_line":"because their functionality is relatively simple and can be understood from the"},{"line_number":201,"context_line":"code. For example class |NumInstancesFilter| has the next realization:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_a0a93524","line":198,"range":{"start_line":198,"start_character":66,"end_line":198,"end_character":76},"updated":"2019-06-16 15:26:41.000000000","message":"This seems like a weird thing to say, considering we\u0027re then, um, *not* skipping it. Perhaps worth a reword:\n\n\"Simple filters such as |AllHostsFilter| and |NumInstancesFilter| are relatively simple and can be understood from the code. For example, |NumInstancesFilter| has the following implementation::\"","commit_id":"dcb9a857ac3162f0efc3a88c4485d8d4b9b4f24c"},{"author":{"_account_id":22321,"name":"Yang,Tao","email":"magictao@gmail.com","username":"yan97ao"},"change_message_id":"a03133cb584a973d47ee364741fc572d17823cda","unresolved":false,"context_lines":[{"line_number":195,"context_line":"* |NUMATopologyFilter| - filters hosts based on the NUMA topology requested by the"},{"line_number":196,"context_line":"  instance, if any."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Now we can focus on these standard filter classes in some detail. We\u0027ll skip the"},{"line_number":199,"context_line":"simplest ones, such as |AllHostsFilter| and |NumInstancesFilter|"},{"line_number":200,"context_line":"because their functionality is relatively simple and can be understood from the"},{"line_number":201,"context_line":"code. For example class |NumInstancesFilter| has the next realization:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_604edd97","line":198,"range":{"start_line":198,"start_character":66,"end_line":198,"end_character":76},"in_reply_to":"9fb8cfa7_a0a93524","updated":"2019-06-16 15:44:05.000000000","message":"done","commit_id":"dcb9a857ac3162f0efc3a88c4485d8d4b9b4f24c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8e8c7f136aa6bc72f88abaf4b51726ea5a519af0","unresolved":false,"context_lines":[{"line_number":198,"context_line":"Now we can focus on these standard filter classes in some detail. We\u0027ll skip the"},{"line_number":199,"context_line":"simplest ones, such as |AllHostsFilter| and |NumInstancesFilter|"},{"line_number":200,"context_line":"because their functionality is relatively simple and can be understood from the"},{"line_number":201,"context_line":"code. For example class |NumInstancesFilter| has the next realization:"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"::"},{"line_number":204,"context_line":"    class NumInstancesFilter(filters.BaseHostFilter):"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_e0b3ad96","line":201,"range":{"start_line":201,"start_character":53,"end_line":201,"end_character":69},"updated":"2019-06-16 15:26:41.000000000","message":"following implementation?","commit_id":"dcb9a857ac3162f0efc3a88c4485d8d4b9b4f24c"},{"author":{"_account_id":22321,"name":"Yang,Tao","email":"magictao@gmail.com","username":"yan97ao"},"change_message_id":"a03133cb584a973d47ee364741fc572d17823cda","unresolved":false,"context_lines":[{"line_number":198,"context_line":"Now we can focus on these standard filter classes in some detail. We\u0027ll skip the"},{"line_number":199,"context_line":"simplest ones, such as |AllHostsFilter| and |NumInstancesFilter|"},{"line_number":200,"context_line":"because their functionality is relatively simple and can be understood from the"},{"line_number":201,"context_line":"code. For example class |NumInstancesFilter| has the next realization:"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"::"},{"line_number":204,"context_line":"    class NumInstancesFilter(filters.BaseHostFilter):"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_80519138","line":201,"range":{"start_line":201,"start_character":53,"end_line":201,"end_character":69},"in_reply_to":"9fb8cfa7_e0b3ad96","updated":"2019-06-16 15:44:05.000000000","message":"done","commit_id":"dcb9a857ac3162f0efc3a88c4485d8d4b9b4f24c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8e8c7f136aa6bc72f88abaf4b51726ea5a519af0","unresolved":false,"context_lines":[{"line_number":198,"context_line":"Now we can focus on these standard filter classes in some detail. We\u0027ll skip the"},{"line_number":199,"context_line":"simplest ones, such as |AllHostsFilter| and |NumInstancesFilter|"},{"line_number":200,"context_line":"because their functionality is relatively simple and can be understood from the"},{"line_number":201,"context_line":"code. For example class |NumInstancesFilter| has the next realization:"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"::"},{"line_number":204,"context_line":"    class NumInstancesFilter(filters.BaseHostFilter):"},{"line_number":205,"context_line":"        \"\"\"Filter out hosts with too many instances.\"\"\""},{"line_number":206,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_c0a4694d","line":203,"range":{"start_line":201,"start_character":69,"end_line":203,"end_character":2},"updated":"2019-06-16 15:26:41.000000000","message":"nit, could consolidate to just :: at the end of L201","commit_id":"dcb9a857ac3162f0efc3a88c4485d8d4b9b4f24c"},{"author":{"_account_id":22321,"name":"Yang,Tao","email":"magictao@gmail.com","username":"yan97ao"},"change_message_id":"a03133cb584a973d47ee364741fc572d17823cda","unresolved":false,"context_lines":[{"line_number":198,"context_line":"Now we can focus on these standard filter classes in some detail. We\u0027ll skip the"},{"line_number":199,"context_line":"simplest ones, such as |AllHostsFilter| and |NumInstancesFilter|"},{"line_number":200,"context_line":"because their functionality is relatively simple and can be understood from the"},{"line_number":201,"context_line":"code. For example class |NumInstancesFilter| has the next realization:"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"::"},{"line_number":204,"context_line":"    class NumInstancesFilter(filters.BaseHostFilter):"},{"line_number":205,"context_line":"        \"\"\"Filter out hosts with too many instances.\"\"\""},{"line_number":206,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_20446573","line":203,"range":{"start_line":201,"start_character":69,"end_line":203,"end_character":2},"in_reply_to":"9fb8cfa7_c0a4694d","updated":"2019-06-16 15:44:05.000000000","message":"done","commit_id":"dcb9a857ac3162f0efc3a88c4485d8d4b9b4f24c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8e8c7f136aa6bc72f88abaf4b51726ea5a519af0","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            return passes"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"Here :oslo.config:option:`filter-scheduler.max_instances_per_host` means the"},{"line_number":217,"context_line":"maximum number of instances that be active on a host. (it is ``50`` by default)."},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"The |AvailabilityZoneFilter| looks at the availability zone of compute node"},{"line_number":220,"context_line":"and availability zone from the properties of the request. Each compute service"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_60657d1d","line":217,"range":{"start_line":217,"start_character":53,"end_line":217,"end_character":80},"updated":"2019-06-16 15:26:41.000000000","message":"This isn\u0027t necessary, since you\u0027re linking to the option which shows the default right there.","commit_id":"dcb9a857ac3162f0efc3a88c4485d8d4b9b4f24c"},{"author":{"_account_id":22321,"name":"Yang,Tao","email":"magictao@gmail.com","username":"yan97ao"},"change_message_id":"a03133cb584a973d47ee364741fc572d17823cda","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            return passes"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"Here :oslo.config:option:`filter-scheduler.max_instances_per_host` means the"},{"line_number":217,"context_line":"maximum number of instances that be active on a host. (it is ``50`` by default)."},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"The |AvailabilityZoneFilter| looks at the availability zone of compute node"},{"line_number":220,"context_line":"and availability zone from the properties of the request. Each compute service"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_40471978","line":217,"range":{"start_line":217,"start_character":53,"end_line":217,"end_character":80},"in_reply_to":"9fb8cfa7_60657d1d","updated":"2019-06-16 15:44:05.000000000","message":"removed","commit_id":"dcb9a857ac3162f0efc3a88c4485d8d4b9b4f24c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5aa679de7568b00a85c53e0e0be8ad0a0c307265","unresolved":false,"context_lines":[{"line_number":196,"context_line":"  instance, if any."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Now we can focus on these standard filter classes in some detail. Simple filters"},{"line_number":199,"context_line":"such as |AllHostsFilter| and |NumInstancesFilter| are relatively simple and can be"},{"line_number":200,"context_line":"understood from the code. For example, |NumInstancesFilter| has the following implementation::"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    class NumInstancesFilter(filters.BaseHostFilter):"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fb8cfa7_801f516a","line":199,"range":{"start_line":199,"start_character":50,"end_line":199,"end_character":75},"updated":"2019-06-16 16:06:44.000000000","message":"strike (my fault, I didn\u0027t notice the redundancy with \u0027Simple\u0027 on L198)","commit_id":"91b181e9a8aa705235679e356b8dce205e47d400"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"338b826b786bfe4f9f94e7d20f039334dd9dbe11","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            passes \u003d num_instances \u003c max_instances"},{"line_number":212,"context_line":"            return passes"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"Here :oslo.config:option:`filter-scheduler.max_instances_per_host` means the"},{"line_number":215,"context_line":"maximum number of instances that be active on a host."},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"The |AvailabilityZoneFilter| looks at the availability zone of compute node"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fb8cfa7_c000e904","line":214,"range":{"start_line":214,"start_character":26,"end_line":214,"end_character":42},"updated":"2019-06-16 16:08:05.000000000","message":"filter_scheduler (this is your build failure)","commit_id":"91b181e9a8aa705235679e356b8dce205e47d400"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"63ec65a7744ee83f82a49666379842cce66c5dae","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Now we can focus on these standard filter classes in some detail. Some filters"},{"line_number":199,"context_line":"such as |AllHostsFilter| and |NumInstancesFilter| are relatively simple and can be"},{"line_number":200,"context_line":"understood from the code. For example, |NumInstancesFilter| has the following implementation::"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    class NumInstancesFilter(filters.BaseHostFilter):"},{"line_number":203,"context_line":"        \"\"\"Filter out hosts with too many instances.\"\"\""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_a2ee0689","line":200,"range":{"start_line":200,"start_character":92,"end_line":200,"end_character":94},"updated":"2019-06-17 21:20:44.000000000","message":"nit: I\u0027d make this a python code block instead:\n\n.. code-block:: python","commit_id":"b129511050e3bcedd0079041ecdb8d156baa67eb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"63ec65a7744ee83f82a49666379842cce66c5dae","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            return passes"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"Here :oslo.config:option:`filter_scheduler.max_instances_per_host` means the"},{"line_number":215,"context_line":"maximum number of instances that be active on a host."},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"The |AvailabilityZoneFilter| looks at the availability zone of compute node"},{"line_number":218,"context_line":"and availability zone from the properties of the request. Each compute service"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_02e03296","line":215,"range":{"start_line":215,"start_character":28,"end_line":215,"end_character":53},"updated":"2019-06-17 21:20:44.000000000","message":"I would remove \"active\" from this as I\u0027m not sure it\u0027s taking into account the status of the servers. There is also a typo (\"that can be\"), so I\u0027d probably just word this as \"that can be on a host.\"\n\n(later)\n\nOK I see this is copied from the config option description:\n\nhttp://logs.openstack.org/46/665546/5/check/openstack-tox-docs/4ed093c/html/configuration/config.html#filter_scheduler.max_instances_per_host\n\nI\u0027ll post a follow up to this change.","commit_id":"b129511050e3bcedd0079041ecdb8d156baa67eb"}]}