)]}'
{"id":"openstack%2Fnova~665790","triplet_id":"openstack%2Fnova~stable%2Fqueens~Ia597594e0469c0e83d7ad22b0678390aaebaffe7","project":"openstack/nova","branch":"stable/queens","topic":"bug/1804062","hashtags":[],"change_id":"Ia597594e0469c0e83d7ad22b0678390aaebaffe7","subject":"Fix double word hacking test","status":"MERGED","created":"2019-06-17 23:19:07.000000000","updated":"2019-08-10 01:20:41.000000000","submitted":"2019-08-10 01:20:41.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"665790-1565400041190-c4f9ddb8","meta_rev_id":"2911116570d942b382aefeca8cb4110bafcb4d86","_number":665790,"virtual_id_number":665790,"owner":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-08-09 22:42:57.000000000","_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"date":"2019-08-09 16:27:22.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-08-10 01:20:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-09 15:06:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2019-08-09 14:48:25.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-09 15:06:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-17 23:19:07.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2019-08-09 14:48:25.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-08-09 15:06:40.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2019-08-09 16:27:22.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-08-09 22:42:57.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-10 01:20:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c46d4f23c40a43aad1392fc098c70b724b378b87","author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"date":"2019-06-17 23:19:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"acffc9c4bdedeef1d9ff7bc01ec5533459178e17","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-06-17 23:40:42.000000000","message":"Patch Set 1:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/90/665790/1/check/nova-out-of-tree-pvm/a3b2e7d : FAILURE in 20m 18s\n- nova-in-tree-pvm http://184.172.12.213/90/665790/1/check/nova-in-tree-pvm/087e60b : FAILURE in 20m 54s","accounts_in_message":[],"_revision_number":1},{"id":"296295ad1273d6b8dd975d8301f50252b01cc25d","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-06-18 00:02:32.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"a5a86bb76e9c41b097374861514888f99ce06a10","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-06-18 00:06:49.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/665790/1 : FAILURE in 43m 02s","accounts_in_message":[],"_revision_number":1},{"id":"6c2d3d18468dfe12d9421b5c835afd0276be8ef0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-18 01:38:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/90/665790/1/check/openstack-tox-pep8/659d6ae/ : SUCCESS in 10m 07s\n- openstack-tox-py27 http://logs.openstack.org/90/665790/1/check/openstack-tox-py27/428f0fc/ : SUCCESS in 14m 02s\n- openstack-tox-py35 http://logs.openstack.org/90/665790/1/check/openstack-tox-py35/1e7fe48/ : SUCCESS in 13m 12s\n- build-openstack-sphinx-docs http://logs.openstack.org/90/665790/1/check/build-openstack-sphinx-docs/447970a/html/ : SUCCESS in 8m 02s\n- nova-tox-functional http://logs.openstack.org/90/665790/1/check/nova-tox-functional/db69d54/ : SUCCESS in 26m 38s\n- nova-tox-functional-py35 http://logs.openstack.org/90/665790/1/check/nova-tox-functional-py35/1a153f8/ : SUCCESS in 23m 09s","accounts_in_message":[],"_revision_number":1},{"id":"cfcb5b67aad27abe68efb776f1dcb57ec351e2c2","author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"date":"2019-06-24 09:33:30.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"725216f0d6508d35e0ff095a98537cf96cb45552","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-06-24 09:54:13.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/665790/2 : FAILURE in 19m 37s","accounts_in_message":[],"_revision_number":2},{"id":"d7bc07348d6c814190516e581cf2f362fcf95f61","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-06-24 09:55:20.000000000","message":"Patch Set 2:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/90/665790/2/check/nova-out-of-tree-pvm/2d67bae : FAILURE in 20m 33s\n- nova-in-tree-pvm http://184.172.12.213/90/665790/2/check/nova-in-tree-pvm/ffab4d0 : FAILURE in 21m 07s","accounts_in_message":[],"_revision_number":2},{"id":"d93b1240a80bacbf312cd12511ecaf8f0f11df5e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-24 10:32:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/90/665790/2/check/openstack-tox-pep8/9eb862d/ : SUCCESS in 9m 04s\n- openstack-tox-py27 http://logs.openstack.org/90/665790/2/check/openstack-tox-py27/4bbce86/ : SUCCESS in 13m 13s\n- openstack-tox-py35 http://logs.openstack.org/90/665790/2/check/openstack-tox-py35/57cc571/ : SUCCESS in 13m 42s\n- build-openstack-sphinx-docs http://logs.openstack.org/90/665790/2/check/build-openstack-sphinx-docs/f2f98dc/html/ : SUCCESS in 6m 10s\n- nova-tox-functional http://logs.openstack.org/90/665790/2/check/nova-tox-functional/24142d2/ : SUCCESS in 22m 44s\n- nova-tox-functional-py35 http://logs.openstack.org/90/665790/2/check/nova-tox-functional-py35/48a825a/ : SUCCESS in 18m 16s","accounts_in_message":[],"_revision_number":2},{"id":"954e759e909be9b0f5e6e785183ec4b7903c6fee","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-01 16:18:02.000000000","message":"Patch Set 2: Workflow-1\n\nStill sorting out rocky.","accounts_in_message":[],"_revision_number":2},{"id":"6787fc4a736bb8e83dc199974d265861dd170594","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-08-09 14:46:04.000000000","message":"Patch Set 2: -Workflow","accounts_in_message":[],"_revision_number":2},{"id":"4e74e4f14c030fdbcac44a97f790c1f8d0fbba14","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-08-09 14:47:56.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"6645741d99af73d2c30da45512e75e43c53a09c1","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-08-09 14:48:25.000000000","message":"Patch Set 3: Code-Review+2\n\nI re-cherry-picked this from rocky b/c we don\u0027t need the merge conflict comment in the commit message, it\u0027s just confusing - there is no merge conflict from rocky -\u003e queens.","accounts_in_message":[],"_revision_number":3},{"id":"550b55ba52f964134bd0bd188cfd73676761c09f","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-08-09 15:06:40.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nLGTM","accounts_in_message":[],"_revision_number":3},{"id":"690152dab7d1d9bab53a6c85fcd43b45380a9edf","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-08-09 16:27:22.000000000","message":"Patch Set 3:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/665790/3 : FAILURE in 43m 40s","accounts_in_message":[],"_revision_number":3},{"id":"828ecc909bcc29cd1da176ae2116067676e90bee","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 18:33:57.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://logs.opendev.org/90/665790/3/check/openstack-tox-pep8/243f581/ : SUCCESS in 10m 00s\n- openstack-tox-py27 https://logs.opendev.org/90/665790/3/check/openstack-tox-py27/24eac92/ : SUCCESS in 13m 24s\n- openstack-tox-py35 https://logs.opendev.org/90/665790/3/check/openstack-tox-py35/cf09eae/ : SUCCESS in 12m 59s\n- build-openstack-sphinx-docs https://logs.opendev.org/90/665790/3/check/build-openstack-sphinx-docs/2763d76/html/ : SUCCESS in 8m 15s\n- nova-tox-functional https://logs.opendev.org/90/665790/3/check/nova-tox-functional/f1d0050/ : SUCCESS in 20m 36s\n- nova-tox-functional-py35 https://logs.opendev.org/90/665790/3/check/nova-tox-functional-py35/8120667/ : SUCCESS in 24m 52s","accounts_in_message":[],"_revision_number":3},{"id":"d7b9a0047d7959557c6d113c0bb8e2e470bf4498","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 18:39:40.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"93932a621c820c46c28edd89dd462ab7379a8c22","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 20:07:51.000000000","message":"Patch Set 3:\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"bae026403ff91ac864230e7ba93da80a95921985","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-08-09 22:42:57.000000000","message":"Patch Set 3:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/90/665790/3/check/nova-out-of-tree-pvm/a82e9b5 : FAILURE in 20m 19s\n- nova-in-tree-pvm http://184.172.12.213/90/665790/3/check/nova-in-tree-pvm/101bd5d : FAILURE in 20m 30s","accounts_in_message":[],"_revision_number":3},{"id":"83eefc0364a9f7179b624054a3073ccb8462454a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-10 01:20:40.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://logs.opendev.org/90/665790/3/gate/openstack-tox-pep8/04df3c0/ : SUCCESS in 10m 53s\n- openstack-tox-py27 https://logs.opendev.org/90/665790/3/gate/openstack-tox-py27/e427e54/ : SUCCESS in 16m 26s\n- openstack-tox-py35 https://logs.opendev.org/90/665790/3/gate/openstack-tox-py35/27611cc/ : SUCCESS in 13m 48s\n- build-openstack-sphinx-docs https://logs.opendev.org/90/665790/3/gate/build-openstack-sphinx-docs/77f717e/html/ : SUCCESS in 7m 54s\n- nova-tox-functional https://logs.opendev.org/90/665790/3/gate/nova-tox-functional/922e89c/ : SUCCESS in 29m 17s\n- nova-tox-functional-py35 https://logs.opendev.org/90/665790/3/gate/nova-tox-functional-py35/d2f4ccc/ : SUCCESS in 27m 52s","accounts_in_message":[],"_revision_number":3},{"id":"13987f2ac14516f87dec33c5c44f7776f562a555","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-10 01:20:41.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"dc2963d2a0002d4ddacf50b1f80c470d5de7ec61","revisions":{"59ec7d63d964752036d81f903ccc7c25982786c1":{"kind":"REWORK","_number":1,"created":"2019-06-17 23:19:07.000000000","uploader":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"ref":"refs/changes/90/665790/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/90/665790/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/90/665790/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/90/665790/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/90/665790/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/90/665790/1"}}},"commit":{"parents":[{"commit":"58a140487c8127da727fa7e4fb56892f8c162536","subject":"Block swap volume on volumes with \u003e1 rw attachment","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/58a140487c8127da727fa7e4fb56892f8c162536"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-06-12 14:10:59.000000000","tz":60},"committer":{"name":"Sam Morrison","email":"sorrison@gmail.com","date":"2019-06-17 23:18:46.000000000","tz":600},"subject":"Fix double word hacking test","message":"Fix double word hacking test\n\nAt present, \u0027pycodestyle\u0027 feeds the following string into the \u0027tokenizer\u0027\nlibrary:\n\n    [\"\u0027This is the the best comment\u0027\"]\n\n(note the added quotes because this isn\u0027t valid Python otherwise)\n\nOn previous versions of Python, this tokenizer would parse the string like so:\n\n  (3, \"\u0027This is the the best comment\u0027\", (1, 0), (1, 30), \"\u0027This is the the best comment\u0027\")\n  (0, \u0027\u0027, (2, 0), (2, 0), \u0027\u0027)\n\nwhere (3 \u003d \u0027STRING\u0027, 0 \u003d \u0027ENDMARKER\u0027)\n\nHowever, with the fix [1] backported to recent versions of Python, this now\nresolves to:\n\n  (3, \"\u0027This is the the best comment\u0027\", (1, 0), (1, 30), \"\u0027This is the the best comment\u0027\")\n  (4, \u0027\u0027, (1, 30), (1, 31), \u0027\u0027)\n  (0, \u0027\u0027, (2, 0), (2, 0), \u0027\u0027)\n\nwhere (3 \u003d \u0027STRING\u0027, 4 \u003d \u0027NEWLINE\u0027, 0 \u003d \u0027ENDMARKER\u0027)\n\nTypically, \u0027pycodestyle\u0027 will run physical line checks on each line as it\nparses the token:\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2036\n\nFor the former case above, the line doesn\u0027t include a newline which\nmeans we never parse a \u0027NEWLINE\u0027 token with a logical line (the fifth\nelement of the token tuple) corresponding to our full line. This means\nwe don\u0027t here but that wasn\u0027t an issue previously since there\u0027s a\nfallthrough case that handled tokens remaining at the end of the parse:\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2114-L2116\n\nUnfortunately, because we now have an additional newline character to\nparse, one that\u0027s on a separate line to our test string no less, we run\nlogical checks on it:\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2105-L2107\n\nThis is an issue since the logical check wipes stored tokens meaning\nwe\u0027ve nothing to check when we get to the fallthrough case:\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2012\n\nThis fixes changes things so that a newline is included (and also adds\nquotes so it\u0027s valid Python, but that\u0027s mostly unrelated). This means we\nend up with the following instead:\n\n  [\"\u0027This is the the best comment\u0027\\n\"]\n\nOn both Python without the bugfix and with it, this parses as:\n\n  (3, \"\u0027This is the the best comment\u0027\", (1, 0), (1, 30), \"\u0027This is the the best comment\u0027\\n\")\n  (4, \u0027\\n\u0027, (1, 30), (1, 31), \"\u0027This is the the best comment\u0027\\n\")\n  (0, \u0027\u0027, (2, 0), (2, 0), \u0027\u0027)\n\nwhere (3 \u003d \u0027STRING\u0027, 4 \u003d \u0027NEWLINE\u0027, 0 \u003d \u0027ENDMARKER\u0027)\n\nWhich triggers things in \u0027pycodestyle\u0027 correctly.\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2044-L2046\n\nThis isn\u0027t _really_ a fix since there\u0027s clearly still a bug in either\n\u0027pycodestyle\u0027 or Python (I think the latter, since it\u0027s adding a newline\nto a file that explicitly doesn\u0027t have one), but the chances of us\nhitting this bug in practice are rather low - you\u0027d need to make a\nmistake on the very last line of a file without a newline at the end\nwhich is something Vim, for example, won\u0027t even let you do without\nsetting special flags - and therefore it can be reasonably ignored.\n\nConflicts:\n\tnova/tests/unit/test_hacking.py\n\nNOTE(stephenfin): Conflicts are because we don\u0027t have change\nI35c654bd39f343417e0a1124263ff31dcd0b05c9 (\"Bump to hacking 1.1.0\") or\nchange I8826c3fb89690805baae6b9b7b48985abb8d62d3 (\"Skip\ntest_check_doubled_words hacking check UT\") on this branch.\n\n[1] https://bugs.python.org/issue33899\n\nChange-Id: Ia597594e0469c0e83d7ad22b0678390aaebaffe7\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\nCloses-Bug: #1804062\n(cherry picked from f545a25cc443c41dcd9bdd028064c28b53f56037)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/59ec7d63d964752036d81f903ccc7c25982786c1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/59ec7d63d964752036d81f903ccc7c25982786c1"}]},"branch":"refs/heads/stable/queens"},"f33125dbf7d6e2f2f8ad6944de7139b82903d5f0":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-06-24 09:33:30.000000000","uploader":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"ref":"refs/changes/90/665790/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/90/665790/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/90/665790/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/90/665790/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/90/665790/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/90/665790/2"}}},"commit":{"parents":[{"commit":"58a140487c8127da727fa7e4fb56892f8c162536","subject":"Block swap volume on volumes with \u003e1 rw attachment","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/58a140487c8127da727fa7e4fb56892f8c162536"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-06-12 14:10:59.000000000","tz":60},"committer":{"name":"Sam Morrison","email":"sorrison@gmail.com","date":"2019-06-24 09:33:18.000000000","tz":600},"subject":"Fix double word hacking test","message":"Fix double word hacking test\n\nAt present, \u0027pycodestyle\u0027 feeds the following string into the \u0027tokenizer\u0027\nlibrary:\n\n    [\"\u0027This is the the best comment\u0027\"]\n\n(note the added quotes because this isn\u0027t valid Python otherwise)\n\nOn previous versions of Python, this tokenizer would parse the string like so:\n\n  (3, \"\u0027This is the the best comment\u0027\", (1, 0), (1, 30), \"\u0027This is the the best comment\u0027\")\n  (0, \u0027\u0027, (2, 0), (2, 0), \u0027\u0027)\n\nwhere (3 \u003d \u0027STRING\u0027, 0 \u003d \u0027ENDMARKER\u0027)\n\nHowever, with the fix [1] backported to recent versions of Python, this now\nresolves to:\n\n  (3, \"\u0027This is the the best comment\u0027\", (1, 0), (1, 30), \"\u0027This is the the best comment\u0027\")\n  (4, \u0027\u0027, (1, 30), (1, 31), \u0027\u0027)\n  (0, \u0027\u0027, (2, 0), (2, 0), \u0027\u0027)\n\nwhere (3 \u003d \u0027STRING\u0027, 4 \u003d \u0027NEWLINE\u0027, 0 \u003d \u0027ENDMARKER\u0027)\n\nTypically, \u0027pycodestyle\u0027 will run physical line checks on each line as it\nparses the token:\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2036\n\nFor the former case above, the line doesn\u0027t include a newline which\nmeans we never parse a \u0027NEWLINE\u0027 token with a logical line (the fifth\nelement of the token tuple) corresponding to our full line. This means\nwe don\u0027t here but that wasn\u0027t an issue previously since there\u0027s a\nfallthrough case that handled tokens remaining at the end of the parse:\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2114-L2116\n\nUnfortunately, because we now have an additional newline character to\nparse, one that\u0027s on a separate line to our test string no less, we run\nlogical checks on it:\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2105-L2107\n\nThis is an issue since the logical check wipes stored tokens meaning\nwe\u0027ve nothing to check when we get to the fallthrough case:\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2012\n\nThis fixes changes things so that a newline is included (and also adds\nquotes so it\u0027s valid Python, but that\u0027s mostly unrelated). This means we\nend up with the following instead:\n\n  [\"\u0027This is the the best comment\u0027\\n\"]\n\nOn both Python without the bugfix and with it, this parses as:\n\n  (3, \"\u0027This is the the best comment\u0027\", (1, 0), (1, 30), \"\u0027This is the the best comment\u0027\\n\")\n  (4, \u0027\\n\u0027, (1, 30), (1, 31), \"\u0027This is the the best comment\u0027\\n\")\n  (0, \u0027\u0027, (2, 0), (2, 0), \u0027\u0027)\n\nwhere (3 \u003d \u0027STRING\u0027, 4 \u003d \u0027NEWLINE\u0027, 0 \u003d \u0027ENDMARKER\u0027)\n\nWhich triggers things in \u0027pycodestyle\u0027 correctly.\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2044-L2046\n\nThis isn\u0027t _really_ a fix since there\u0027s clearly still a bug in either\n\u0027pycodestyle\u0027 or Python (I think the latter, since it\u0027s adding a newline\nto a file that explicitly doesn\u0027t have one), but the chances of us\nhitting this bug in practice are rather low - you\u0027d need to make a\nmistake on the very last line of a file without a newline at the end\nwhich is something Vim, for example, won\u0027t even let you do without\nsetting special flags - and therefore it can be reasonably ignored.\n\nConflicts:\n\tnova/tests/unit/test_hacking.py\n\nNOTE(stephenfin): Conflicts are because we don\u0027t have change\nI35c654bd39f343417e0a1124263ff31dcd0b05c9 (\"Bump to hacking 1.1.0\") or\nchange I8826c3fb89690805baae6b9b7b48985abb8d62d3 (\"Skip\ntest_check_doubled_words hacking check UT\") on this branch.\n\n[1] https://bugs.python.org/issue33899\n\nChange-Id: Ia597594e0469c0e83d7ad22b0678390aaebaffe7\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\nCloses-Bug: #1804062\n(cherry picked from f545a25cc443c41dcd9bdd028064c28b53f56037)\n(cherry picked from commit 0cb6106b83c33bded9e6cdec7737964c36be8de5)\n(cherry picked from commit 825c64738bf0164b5206ef9a285fc6599f32da96)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f33125dbf7d6e2f2f8ad6944de7139b82903d5f0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f33125dbf7d6e2f2f8ad6944de7139b82903d5f0"}]},"branch":"refs/heads/stable/queens"},"dc2963d2a0002d4ddacf50b1f80c470d5de7ec61":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2019-08-09 14:47:56.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/90/665790/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/90/665790/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/90/665790/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/90/665790/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/90/665790/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/90/665790/3"}}},"commit":{"parents":[{"commit":"b81ac378d3f02003556f14dbc852b7fe6f39c595","subject":"Merge \"Stabilize unshelve notification sample tests\" into stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b81ac378d3f02003556f14dbc852b7fe6f39c595"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-06-12 14:10:59.000000000","tz":60},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-08-09 14:47:56.000000000","tz":0},"subject":"Fix double word hacking test","message":"Fix double word hacking test\n\nAt present, \u0027pycodestyle\u0027 feeds the following string into the \u0027tokenizer\u0027\nlibrary:\n\n    [\"\u0027This is the the best comment\u0027\"]\n\n(note the added quotes because this isn\u0027t valid Python otherwise)\n\nOn previous versions of Python, this tokenizer would parse the string like so:\n\n  (3, \"\u0027This is the the best comment\u0027\", (1, 0), (1, 30), \"\u0027This is the the best comment\u0027\")\n  (0, \u0027\u0027, (2, 0), (2, 0), \u0027\u0027)\n\nwhere (3 \u003d \u0027STRING\u0027, 0 \u003d \u0027ENDMARKER\u0027)\n\nHowever, with the fix [1] backported to recent versions of Python, this now\nresolves to:\n\n  (3, \"\u0027This is the the best comment\u0027\", (1, 0), (1, 30), \"\u0027This is the the best comment\u0027\")\n  (4, \u0027\u0027, (1, 30), (1, 31), \u0027\u0027)\n  (0, \u0027\u0027, (2, 0), (2, 0), \u0027\u0027)\n\nwhere (3 \u003d \u0027STRING\u0027, 4 \u003d \u0027NEWLINE\u0027, 0 \u003d \u0027ENDMARKER\u0027)\n\nTypically, \u0027pycodestyle\u0027 will run physical line checks on each line as it\nparses the token:\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2036\n\nFor the former case above, the line doesn\u0027t include a newline which\nmeans we never parse a \u0027NEWLINE\u0027 token with a logical line (the fifth\nelement of the token tuple) corresponding to our full line. This means\nwe don\u0027t here but that wasn\u0027t an issue previously since there\u0027s a\nfallthrough case that handled tokens remaining at the end of the parse:\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2114-L2116\n\nUnfortunately, because we now have an additional newline character to\nparse, one that\u0027s on a separate line to our test string no less, we run\nlogical checks on it:\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2105-L2107\n\nThis is an issue since the logical check wipes stored tokens meaning\nwe\u0027ve nothing to check when we get to the fallthrough case:\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2012\n\nThis fixes changes things so that a newline is included (and also adds\nquotes so it\u0027s valid Python, but that\u0027s mostly unrelated). This means we\nend up with the following instead:\n\n  [\"\u0027This is the the best comment\u0027\\n\"]\n\nOn both Python without the bugfix and with it, this parses as:\n\n  (3, \"\u0027This is the the best comment\u0027\", (1, 0), (1, 30), \"\u0027This is the the best comment\u0027\\n\")\n  (4, \u0027\\n\u0027, (1, 30), (1, 31), \"\u0027This is the the best comment\u0027\\n\")\n  (0, \u0027\u0027, (2, 0), (2, 0), \u0027\u0027)\n\nwhere (3 \u003d \u0027STRING\u0027, 4 \u003d \u0027NEWLINE\u0027, 0 \u003d \u0027ENDMARKER\u0027)\n\nWhich triggers things in \u0027pycodestyle\u0027 correctly.\n\n  https://github.com/PyCQA/pycodestyle/blob/2.5.0/pycodestyle.py#L2044-L2046\n\nThis isn\u0027t _really_ a fix since there\u0027s clearly still a bug in either\n\u0027pycodestyle\u0027 or Python (I think the latter, since it\u0027s adding a newline\nto a file that explicitly doesn\u0027t have one), but the chances of us\nhitting this bug in practice are rather low - you\u0027d need to make a\nmistake on the very last line of a file without a newline at the end\nwhich is something Vim, for example, won\u0027t even let you do without\nsetting special flags - and therefore it can be reasonably ignored.\n\n[1] https://bugs.python.org/issue33899\n\nChange-Id: Ia597594e0469c0e83d7ad22b0678390aaebaffe7\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\nCloses-Bug: #1804062\n(cherry picked from f545a25cc443c41dcd9bdd028064c28b53f56037)\n(cherry picked from commit 0cb6106b83c33bded9e6cdec7737964c36be8de5)\n(cherry picked from commit 4858074c89838eadeb9eaf9f39917e9fb90acd93)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/dc2963d2a0002d4ddacf50b1f80c470d5de7ec61"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/dc2963d2a0002d4ddacf50b1f80c470d5de7ec61"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}