)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"20b8f96fc9b2a26d22540a13a98f8eb8f85633f0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Finish compacting pre-Icehouse database migrations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Compacts the pre-Icehouse database migrations into a"},{"line_number":10,"context_line":"single migration (212_havana.py)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Pre-Icehouse users will now need to upgrade to Havana before"},{"line_number":13,"context_line":"running any Icehouse migrations."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2FLKc%3D","line":10,"updated":"2014-01-16 18:34:37.000000000","message":"216_havana you mean","commit_id":"b77a6a86eb873711cb5345d8020fa9cd2bd68ed5"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"1a6fd359f26426a578213f17af6ae73241b70e21","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Finish compacting pre-Icehouse database migrations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Compacts the pre-Icehouse database migrations into a"},{"line_number":10,"context_line":"single migration (212_havana.py)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Pre-Icehouse users will now need to upgrade to Havana before"},{"line_number":13,"context_line":"running any Icehouse migrations."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2FLFI%3D","line":10,"in_reply_to":"AAAAUH%2F%2FLKc%3D","updated":"2014-01-16 18:53:46.000000000","message":"Yes!","commit_id":"b77a6a86eb873711cb5345d8020fa9cd2bd68ed5"}],"nova/db/sqlalchemy/migrate_repo/versions/216_havana.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"20b8f96fc9b2a26d22540a13a98f8eb8f85633f0","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        dump_table_name \u003d \u0027dump_\u0027 + table.name"},{"line_number":130,"context_line":"        columns \u003d []"},{"line_number":131,"context_line":"        for column in table.columns:"},{"line_number":132,"context_line":"            if column.name \u003d\u003d \u0027pci_stats\u0027:"},{"line_number":133,"context_line":"                continue"},{"line_number":134,"context_line":"            else:"},{"line_number":135,"context_line":"                columns.append(column.copy())"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FLK8%3D","line":132,"updated":"2014-01-16 18:34:37.000000000","message":"Um why?? 213 adds it to the shadow table as well AFAICT?","commit_id":"b77a6a86eb873711cb5345d8020fa9cd2bd68ed5"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"a0ae767ce55873040b0c202da07dbc5702378abf","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        dump_table_name \u003d \u0027dump_\u0027 + table.name"},{"line_number":130,"context_line":"        columns \u003d []"},{"line_number":131,"context_line":"        for column in table.columns:"},{"line_number":132,"context_line":"            if column.name \u003d\u003d \u0027pci_stats\u0027:"},{"line_number":133,"context_line":"                continue"},{"line_number":134,"context_line":"            else:"},{"line_number":135,"context_line":"                columns.append(column.copy())"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BwkM%3D","line":132,"in_reply_to":"AAAAUH%2F%2FLD4%3D","updated":"2014-01-22 12:50:27.000000000","message":"Ah yes - not a shadow table - sorry - didn\u0027t read the surrounding code carefully enough. carry on :)","commit_id":"b77a6a86eb873711cb5345d8020fa9cd2bd68ed5"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"1a6fd359f26426a578213f17af6ae73241b70e21","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        dump_table_name \u003d \u0027dump_\u0027 + table.name"},{"line_number":130,"context_line":"        columns \u003d []"},{"line_number":131,"context_line":"        for column in table.columns:"},{"line_number":132,"context_line":"            if column.name \u003d\u003d \u0027pci_stats\u0027:"},{"line_number":133,"context_line":"                continue"},{"line_number":134,"context_line":"            else:"},{"line_number":135,"context_line":"                columns.append(column.copy())"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FLD4%3D","line":132,"in_reply_to":"AAAAUH%2F%2FLK8%3D","updated":"2014-01-16 18:53:46.000000000","message":"This isn\u0027t the shadow table. These dump_ tables were created as a backup mechanism to one of the earlier Havana migrations. Once we finish compacting the migrations we can in fact remove the dump_ tables entirely. See what I\u0027m doing here: https://review.openstack.org/#/c/66633/\n\nThis bit of code is required for now to ensure we have a matching schema only. These tables aren\u0027t used in any way in the current Nova schema. Since this is a bit confusing let me add a comment about why it exists in the next patchset.","commit_id":"b77a6a86eb873711cb5345d8020fa9cd2bd68ed5"}]}