)]}'
{"nova/network/linux_net.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"793aec26d8afc9938f2fd9457e63dbfa71d56d03","unresolved":false,"context_lines":[{"line_number":828,"context_line":"    try:"},{"line_number":829,"context_line":"        prefix \u003d network_ref.cidr.prefixlen"},{"line_number":830,"context_line":"    except AttributeError:"},{"line_number":831,"context_line":"        prefix \u003d network_ref[\u0027cidr\u0027].rpartition(\u0027/\u0027)[2]"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"    full_ip \u003d \u0027%s/%s\u0027 % (network_ref[\u0027dhcp_server\u0027], prefix)"},{"line_number":834,"context_line":"    new_ip_params \u003d [[full_ip, \u0027brd\u0027, network_ref[\u0027broadcast\u0027]]]"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FGrY%3D","line":831,"updated":"2014-01-17 11:57:42.000000000","message":"why not network_ref.cidr?","commit_id":"bcafa1ec633ff7194d37410142891c92053322e7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ca10b1891c666f699119e9a5a980bb3519d87695","unresolved":false,"context_lines":[{"line_number":828,"context_line":"    try:"},{"line_number":829,"context_line":"        prefix \u003d network_ref.cidr.prefixlen"},{"line_number":830,"context_line":"    except AttributeError:"},{"line_number":831,"context_line":"        prefix \u003d network_ref[\u0027cidr\u0027].rpartition(\u0027/\u0027)[2]"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"    full_ip \u003d \u0027%s/%s\u0027 % (network_ref[\u0027dhcp_server\u0027], prefix)"},{"line_number":834,"context_line":"    new_ip_params \u003d [[full_ip, \u0027brd\u0027, network_ref[\u0027broadcast\u0027]]]"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FF0E%3D","line":831,"in_reply_to":"AAAAUH%2F%2FGrY%3D","updated":"2014-01-17 14:59:48.000000000","message":"The whole point of this try..except is to handle the case where this utility function gets passed a dict instead of an object :)","commit_id":"bcafa1ec633ff7194d37410142891c92053322e7"}],"nova/network/manager.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"db02a5688fab543cfba9dc00a418b2ae4bef8223","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        for network in network_obj.NetworkList.get_by_host(ctxt, self.host):"},{"line_number":347,"context_line":"            self._setup_network_on_host(ctxt, network)"},{"line_number":348,"context_line":"            if CONF.update_dns_entries:"},{"line_number":349,"context_line":"                dev \u003d self.driver.get_dev(network)"},{"line_number":350,"context_line":"                self.driver.update_dns(ctxt, dev, network)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    @periodic_task.periodic_task"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FJpY%3D","line":349,"updated":"2014-01-16 23:23:20.000000000","message":"There are some places in linux_net that could be converted to attribute-style access since this line is getting an object.  Non-blocker, though ...","commit_id":"bcafa1ec633ff7194d37410142891c92053322e7"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"db02a5688fab543cfba9dc00a418b2ae4bef8223","unresolved":false,"context_lines":[{"line_number":347,"context_line":"            self._setup_network_on_host(ctxt, network)"},{"line_number":348,"context_line":"            if CONF.update_dns_entries:"},{"line_number":349,"context_line":"                dev \u003d self.driver.get_dev(network)"},{"line_number":350,"context_line":"                self.driver.update_dns(ctxt, dev, network)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    @periodic_task.periodic_task"},{"line_number":353,"context_line":"    def _disassociate_stale_fixed_ips(self, context):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FJpI%3D","line":350,"updated":"2014-01-16 23:23:20.000000000","message":"same on this line","commit_id":"bcafa1ec633ff7194d37410142891c92053322e7"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"db02a5688fab543cfba9dc00a418b2ae4bef8223","unresolved":false,"context_lines":[{"line_number":1629,"context_line":"        \"\"\""},{"line_number":1630,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":1631,"context_line":"        networks \u003d network_obj.NetworkList.get_by_host(ctxt, self.host)"},{"line_number":1632,"context_line":"        self.l3driver.initialize(fixed_range\u003dFalse, networks\u003dnetworks)"},{"line_number":1633,"context_line":"        super(FlatDHCPManager, self).init_host()"},{"line_number":1634,"context_line":"        self.init_host_floating_ips()"},{"line_number":1635,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FJow%3D","line":1632,"updated":"2014-01-16 23:23:20.000000000","message":"could go down this path and update network references to be object-style","commit_id":"bcafa1ec633ff7194d37410142891c92053322e7"}]}