)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6c0fd8d78ce37732dff7a5d6f6908fa110e80222","unresolved":false,"context_lines":[{"line_number":11,"context_line":"and update the instance mapping to point at the cell. If the user"},{"line_number":12,"context_line":"deletes the BuildRequest before the instance record is created in a"},{"line_number":13,"context_line":"cell, the conductor schedule_and_build_instances method cleans up the"},{"line_number":14,"context_line":"resource allocations created by scheduler and then continues to the"},{"line_number":15,"context_line":"next instance (if it\u0027s a multi-create request). The point is the instance"},{"line_number":16,"context_line":"does not get created in a cell, the BuildRequest is gone, and the"},{"line_number":17,"context_line":"instance mapping is left pointing at no cell - effectively orphaned."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_8fc65d16","line":14,"range":{"start_line":14,"start_character":29,"end_line":14,"end_character":31},"updated":"2019-06-19 20:33:24.000000000","message":"by the","commit_id":"8d543a5e8fe3bdd85f0099c4304f3bdae7cf8af2"}],"nova/conductor/manager.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"778828d638f8527b42b31afff48d5bf724b30db8","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"                # This is a placeholder in case the quota recheck fails."},{"line_number":1355,"context_line":"                instances.append(None)"},{"line_number":1356,"context_line":"                # If the build request was deleted and the instance is not"},{"line_number":1357,"context_line":"                # going to be created, there is on point in leaving an orphan"},{"line_number":1358,"context_line":"                # instance mapping so delete it."},{"line_number":1359,"context_line":"                try:"},{"line_number":1360,"context_line":"                    im \u003d objects.InstanceMapping.get_by_instance_uuid("}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_a2432b13","line":1357,"range":{"start_line":1357,"start_character":48,"end_line":1357,"end_character":50},"updated":"2019-06-20 13:32:03.000000000","message":"no","commit_id":"8d543a5e8fe3bdd85f0099c4304f3bdae7cf8af2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2226a1e94b28d4e355067dc5a4c1d677274df577","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"                # This is a placeholder in case the quota recheck fails."},{"line_number":1355,"context_line":"                instances.append(None)"},{"line_number":1356,"context_line":"                # If the build request was deleted and the instance is not"},{"line_number":1357,"context_line":"                # going to be created, there is on point in leaving an orphan"},{"line_number":1358,"context_line":"                # instance mapping so delete it."},{"line_number":1359,"context_line":"                try:"},{"line_number":1360,"context_line":"                    im \u003d objects.InstanceMapping.get_by_instance_uuid("},{"line_number":1361,"context_line":"                        context, instance.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_42aeefe7","line":1358,"range":{"start_line":1357,"start_character":39,"end_line":1358,"end_character":48},"updated":"2019-06-20 13:28:48.000000000","message":"It occurs to me the same is true about the RequestSpec. Follow up change?","commit_id":"8d543a5e8fe3bdd85f0099c4304f3bdae7cf8af2"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"778828d638f8527b42b31afff48d5bf724b30db8","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"                # This is a placeholder in case the quota recheck fails."},{"line_number":1355,"context_line":"                instances.append(None)"},{"line_number":1356,"context_line":"                # If the build request was deleted and the instance is not"},{"line_number":1357,"context_line":"                # going to be created, there is on point in leaving an orphan"},{"line_number":1358,"context_line":"                # instance mapping so delete it."},{"line_number":1359,"context_line":"                try:"},{"line_number":1360,"context_line":"                    im \u003d objects.InstanceMapping.get_by_instance_uuid("},{"line_number":1361,"context_line":"                        context, instance.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_424a6f27","line":1358,"range":{"start_line":1357,"start_character":39,"end_line":1358,"end_character":48},"in_reply_to":"9fb8cfa7_42aeefe7","updated":"2019-06-20 13:32:03.000000000","message":"sure","commit_id":"8d543a5e8fe3bdd85f0099c4304f3bdae7cf8af2"}]}