)]}'
{"nova/network/manager.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"abf6d3c7a651287494b61c01ea1c8760fea519d9","unresolved":false,"context_lines":[{"line_number":1359,"context_line":"    def _get_networks_by_uuids(self, context, network_uuids):"},{"line_number":1360,"context_line":"        networks \u003d network_obj.NetworkList.get_by_uuids("},{"line_number":1361,"context_line":"            context, network_uuids, project_only\u003d\"allow_none\")"},{"line_number":1362,"context_line":"        networks.objects.sort(key\u003dlambda x: network_uuids.index(x.uuid))"},{"line_number":1363,"context_line":"        return networks"},{"line_number":1364,"context_line":""},{"line_number":1365,"context_line":"    def get_vifs_by_instance(self, context, instance_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FRzs%3D","line":1362,"updated":"2014-01-15 15:15:12.000000000","message":"ugh - I don\u0027t like this. \n\nEither add sort to the ObjectListBase or say: \"no sort - cast to an actual list if you want that\".\n\nThis seems ugly.","commit_id":"6964c5b48d846958ee122e1cb373838f59c00e76"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ed09cee06b2e16fe4f0acc1bbc5dd0d6cf1332f1","unresolved":false,"context_lines":[{"line_number":1359,"context_line":"    def _get_networks_by_uuids(self, context, network_uuids):"},{"line_number":1360,"context_line":"        networks \u003d network_obj.NetworkList.get_by_uuids("},{"line_number":1361,"context_line":"            context, network_uuids, project_only\u003d\"allow_none\")"},{"line_number":1362,"context_line":"        networks.objects.sort(key\u003dlambda x: network_uuids.index(x.uuid))"},{"line_number":1363,"context_line":"        return networks"},{"line_number":1364,"context_line":""},{"line_number":1365,"context_line":"    def get_vifs_by_instance(self, context, instance_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FQVw%3D","line":1362,"in_reply_to":"AAAAUH%2F%2FRzs%3D","updated":"2014-01-15 20:37:19.000000000","message":"Actually I meant to do this and forgot. This was in the middle of a ton of failure, and it advanced me only slightly :)","commit_id":"6964c5b48d846958ee122e1cb373838f59c00e76"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"abf6d3c7a651287494b61c01ea1c8760fea519d9","unresolved":false,"context_lines":[{"line_number":1802,"context_line":"        #             project yet."},{"line_number":1803,"context_line":"        networks \u003d network_obj.NetworkList.get_by_uuids("},{"line_number":1804,"context_line":"            context, network_uuids, project_only\u003dTrue)"},{"line_number":1805,"context_line":"        networks.objects.sort(key\u003dlambda x: network_uuids.index(x.uuid))"},{"line_number":1806,"context_line":"        return networks"},{"line_number":1807,"context_line":""},{"line_number":1808,"context_line":"    def _get_networks_for_instance(self, context, instance_id, project_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FRzU%3D","line":1805,"updated":"2014-01-15 15:15:12.000000000","message":"Same here","commit_id":"6964c5b48d846958ee122e1cb373838f59c00e76"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"2bd9d43137b25c860bf907a3c17835f96494ba20","unresolved":false,"context_lines":[{"line_number":1359,"context_line":"    def _get_networks_by_uuids(self, context, network_uuids):"},{"line_number":1360,"context_line":"        networks \u003d network_obj.NetworkList.get_by_uuids("},{"line_number":1361,"context_line":"            context, network_uuids, project_only\u003d\"allow_none\")"},{"line_number":1362,"context_line":"        networks.sort(key\u003dlambda x: network_uuids.index(x.uuid))"},{"line_number":1363,"context_line":"        return networks"},{"line_number":1364,"context_line":""},{"line_number":1365,"context_line":"    def get_vifs_by_instance(self, context, instance_id):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2FJjk%3D","line":1362,"updated":"2014-01-16 23:51:24.000000000","message":"I think this can break an rpc call later on ...\n\nThis is returned to _get_networks_for_instance(), which returns to allocate_for_instance(), which will then pass the networks to RPCAllocateFixedIP._allocate_fixed_ips(), which finally will pass a single network object to network_rpcapi.set_network_host().","commit_id":"68783ca270606c5e0ccf1fc7880c1b331d6cf64e"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"a0f3c3fd2cee8fb42ca3e198b4cffee92e57e833","unresolved":false,"context_lines":[{"line_number":1395,"context_line":"        # NOTE(vish): This is no longer used but can\u0027t be removed until"},{"line_number":1396,"context_line":"        #             we major version the network_rpcapi to 2.0."},{"line_number":1397,"context_line":"        try:"},{"line_number":1398,"context_line":"            return network_obj.NetworkList.get_all(context)"},{"line_number":1399,"context_line":"        except exception.NoNetworksFound:"},{"line_number":1400,"context_line":"            return []"},{"line_number":1401,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2FJnc%3D","line":1398,"updated":"2014-01-16 23:26:43.000000000","message":"doesn\u0027t this break backwards compat of the rpc API?","commit_id":"68783ca270606c5e0ccf1fc7880c1b331d6cf64e"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"f31ce5ca7ee3e18ff1da0b3be285bd17dae2f044","unresolved":false,"context_lines":[{"line_number":1364,"context_line":"        networks \u003d network_obj.NetworkList.get_by_uuids("},{"line_number":1365,"context_line":"            context, network_uuids, project_only\u003d\"allow_none\")"},{"line_number":1366,"context_line":"        networks.sort(key\u003dlambda x: network_uuids.index(x.uuid))"},{"line_number":1367,"context_line":"        return networks"},{"line_number":1368,"context_line":""},{"line_number":1369,"context_line":"    def get_vifs_by_instance(self, context, instance_id):"},{"line_number":1370,"context_line":"        \"\"\"Returns the vifs associated with an instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FD40%3D","line":1367,"updated":"2014-01-17 20:18:56.000000000","message":"I think you missed my comment on this one from rev 6.\n\nIt may also apply to the other instance of this same function down below","commit_id":"ab4d760c33f6716cfa1c03cbf4960b149ca2a874"}]}