)]}'
{"nova/virt/libvirt/vif.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"92d4aab3108a2b0e24d4e10acf801fda37363a77","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        if model !\u003d network_model.VIF_MODEL_VIRTIO:"},{"line_number":173,"context_line":"            designer.set_vif_guest_frontend_config("},{"line_number":174,"context_line":"                conf, mac, model, driver, vhost_queues, rx_queue_size)"},{"line_number":175,"context_line":"            return conf"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        # Workaround libvirt bug, where it mistakenly enables vhost mode, even"},{"line_number":178,"context_line":"        # for non-KVM guests"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_352a0e2c","line":175,"updated":"2019-06-20 17:49:53.000000000","message":"I very much prefer the pattern of bailing early in a method that largely doesn\u0027t apply to most cases. So, this combined with the previous patch to do the same for direct types is goodness to me.","commit_id":"bdb1230c87b2fee32d9f5886060e2a5d6ae52c7e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3f4c57fdfbda63123452263a9ed1bd7f2c704dfd","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        if model !\u003d network_model.VIF_MODEL_VIRTIO:"},{"line_number":173,"context_line":"            designer.set_vif_guest_frontend_config("},{"line_number":174,"context_line":"                conf, mac, model, driver, vhost_queues, rx_queue_size)"},{"line_number":175,"context_line":"            return conf"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        # Workaround libvirt bug, where it mistakenly enables vhost mode, even"},{"line_number":178,"context_line":"        # for non-KVM guests"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_54402e08","line":175,"in_reply_to":"9fb8cfa7_352a0e2c","updated":"2019-07-04 11:15:03.000000000","message":"+1","commit_id":"bdb1230c87b2fee32d9f5886060e2a5d6ae52c7e"}]}
